)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"b73bb0d9d40d8feb20cfea1f2ebff260518b4d47","unresolved":false,"context_lines":[{"line_number":6139,"context_line":"        compute_utils.notify_about_instance_action("},{"line_number":6140,"context_line":"            context, instance, self.host,"},{"line_number":6141,"context_line":"            action\u003dfields.NotificationAction.LIVE_MIGRATION_PRE,"},{"line_number":6142,"context_line":"            phase\u003dfields.NotificationPhase.START, bdms\u003dbdms)"},{"line_number":6143,"context_line":""},{"line_number":6144,"context_line":"        try:"},{"line_number":6145,"context_line":"            connector \u003d self.driver.get_volume_connector(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f0e964e3","line":6142,"range":{"start_line":6142,"start_character":50,"end_line":6142,"end_character":60},"updated":"2018-10-16 01:41:10.000000000","message":"nice catch, we should change this in every call that already has bdms","commit_id":"7a2228142b8f8f015a554e2b25198ab37811a058"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"0539dc923d671e58aeb7e8185c86f0592ed95006","unresolved":false,"context_lines":[{"line_number":7429,"context_line":"        @mock.patch.object(compute_utils, \u0027add_instance_fault_from_exc\u0027)"},{"line_number":7430,"context_line":"        @mock.patch.object(vol1_bdm, \u0027save\u0027)"},{"line_number":7431,"context_line":"        @mock.patch.object(compute, \u0027_notify_about_instance_usage\u0027)"},{"line_number":7432,"context_line":"        @mock.patch(\u0027nova.compute.utils.notify_about_instance_action\u0027)"},{"line_number":7433,"context_line":"        @mock.patch.object(compute, \u0027network_api\u0027)"},{"line_number":7434,"context_line":"        @mock.patch.object(compute.driver, \u0027pre_live_migration\u0027)"},{"line_number":7435,"context_line":"        @mock.patch.object(compute, \u0027_get_instance_block_device_info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6ac3268b","line":7432,"updated":"2018-10-16 00:27:41.000000000","message":"nit: we\u0027re using patch.object with compute_utils 4 lines down, could this be made consistent?","commit_id":"7a2228142b8f8f015a554e2b25198ab37811a058"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a8d83df48167742162fd5bdcf97e29cd307506ca","unresolved":false,"context_lines":[{"line_number":7429,"context_line":"        @mock.patch.object(compute_utils, \u0027add_instance_fault_from_exc\u0027)"},{"line_number":7430,"context_line":"        @mock.patch.object(vol1_bdm, \u0027save\u0027)"},{"line_number":7431,"context_line":"        @mock.patch.object(compute, \u0027_notify_about_instance_usage\u0027)"},{"line_number":7432,"context_line":"        @mock.patch(\u0027nova.compute.utils.notify_about_instance_action\u0027)"},{"line_number":7433,"context_line":"        @mock.patch.object(compute, \u0027network_api\u0027)"},{"line_number":7434,"context_line":"        @mock.patch.object(compute.driver, \u0027pre_live_migration\u0027)"},{"line_number":7435,"context_line":"        @mock.patch.object(compute, \u0027_get_instance_block_device_info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fc6132a3","line":7432,"in_reply_to":"3f79a3b5_6ac3268b","updated":"2018-10-16 14:46:32.000000000","message":"I actually prefer mock.patch when mocking a global because I\u0027ve seen issues when too many things are mock.patch.object\u0027ing the same global/class/static method (namely in the libvirt driver tests with the Host.has_min_version stuff).","commit_id":"7a2228142b8f8f015a554e2b25198ab37811a058"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fecc3fc17657a055029ff50475ca8246882eb139","unresolved":false,"context_lines":[{"line_number":7429,"context_line":"        @mock.patch.object(compute_utils, \u0027add_instance_fault_from_exc\u0027)"},{"line_number":7430,"context_line":"        @mock.patch.object(vol1_bdm, \u0027save\u0027)"},{"line_number":7431,"context_line":"        @mock.patch.object(compute, \u0027_notify_about_instance_usage\u0027)"},{"line_number":7432,"context_line":"        @mock.patch(\u0027nova.compute.utils.notify_about_instance_action\u0027)"},{"line_number":7433,"context_line":"        @mock.patch.object(compute, \u0027network_api\u0027)"},{"line_number":7434,"context_line":"        @mock.patch.object(compute.driver, \u0027pre_live_migration\u0027)"},{"line_number":7435,"context_line":"        @mock.patch.object(compute, \u0027_get_instance_block_device_info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_87f3916d","line":7432,"in_reply_to":"3f79a3b5_95c09a2d","updated":"2018-10-22 18:09:26.000000000","message":"As in the global not having the expected mock value because another test changed it. At least that\u0027s what I think I was seeing.","commit_id":"7a2228142b8f8f015a554e2b25198ab37811a058"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"78f3a5db2fde2e71398d4653b0c4d9db394203f1","unresolved":false,"context_lines":[{"line_number":7429,"context_line":"        @mock.patch.object(compute_utils, \u0027add_instance_fault_from_exc\u0027)"},{"line_number":7430,"context_line":"        @mock.patch.object(vol1_bdm, \u0027save\u0027)"},{"line_number":7431,"context_line":"        @mock.patch.object(compute, \u0027_notify_about_instance_usage\u0027)"},{"line_number":7432,"context_line":"        @mock.patch(\u0027nova.compute.utils.notify_about_instance_action\u0027)"},{"line_number":7433,"context_line":"        @mock.patch.object(compute, \u0027network_api\u0027)"},{"line_number":7434,"context_line":"        @mock.patch.object(compute.driver, \u0027pre_live_migration\u0027)"},{"line_number":7435,"context_line":"        @mock.patch.object(compute, \u0027_get_instance_block_device_info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_95c09a2d","line":7432,"in_reply_to":"3f79a3b5_fc6132a3","updated":"2018-10-22 17:20:10.000000000","message":"What kind of issues? Just curious.","commit_id":"7a2228142b8f8f015a554e2b25198ab37811a058"}]}