)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0ba8b06e7e6e212401394281cf6d5f25ff995ff0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Also removed \u0027finish\u0027 method of InstanceActionEvent object, because"},{"line_number":14,"context_line":"event finish call depends on \u0027instance_uuid\u0027 and \u0027request_id\u0027"},{"line_number":15,"context_line":"information. None of them are accessible from current"},{"line_number":16,"context_line":"InstanceActionEvent object model."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id3100fc28aa39b259a1f04fbae28df79c931a572"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9g6c%3D","line":16,"updated":"2013-12-10 18:14:08.000000000","message":"If we keep this, it should be in a separate patch, IMHO. Remove it first if you like and then follow on with the test fixes.\n\nHowever, instead of removing it, can you just fix it so that it will be useful? Perhaps we should be passing in an action?","commit_id":"2aca83ec8de9965200598a44d39c1ea0ad6eff3a"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"0fcc150cd3ba8d05d15bfb3ad9b382f37ba6fd6e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Also removed \u0027finish\u0027 method of InstanceActionEvent object, because"},{"line_number":14,"context_line":"event finish call depends on \u0027instance_uuid\u0027 and \u0027request_id\u0027"},{"line_number":15,"context_line":"information. None of them are accessible from current"},{"line_number":16,"context_line":"InstanceActionEvent object model."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id3100fc28aa39b259a1f04fbae28df79c931a572"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9e44%3D","line":16,"in_reply_to":"AAAATn%2F9g6c%3D","updated":"2013-12-11 02:05:33.000000000","message":"Sure, I agree. Actually, I\u0027m working on another patch [1][2] to use action_instance_create / action_instance_update instead of action_instance_start / finish.\n\nSo my original thought was enable unittest for instance action object first, then add testcases for _create / _update, and then deprecate _start / finish and those testcases too.\n\nHope that explain things a little bit.\n\n[1] https://review.openstack.org/#/c/61050/\n[2] https://review.openstack.org/#/c/58321/","commit_id":"2aca83ec8de9965200598a44d39c1ea0ad6eff3a"}],"nova/tests/objects/test_instance_action.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0ba8b06e7e6e212401394281cf6d5f25ff995ff0","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_event_start(self):"},{"line_number":161,"context_line":"        self.stubs.Set(compute_utils, \u0027pack_action_event_start\u0027,"},{"line_number":162,"context_line":"                       lambda *args, **kwargs: fake_event_values)"},{"line_number":163,"context_line":"        self.mox.StubOutWithMock(db, \u0027action_event_start\u0027)"},{"line_number":164,"context_line":"        db.action_event_start("},{"line_number":165,"context_line":"            self.context, fake_event_values).AndReturn(fake_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9g6w%3D","line":162,"updated":"2013-12-10 18:14:08.000000000","message":"Please use mock or mox for this. Setting stubs to just return something like this is really not as useful.","commit_id":"2aca83ec8de9965200598a44d39c1ea0ad6eff3a"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"0fcc150cd3ba8d05d15bfb3ad9b382f37ba6fd6e","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def test_event_start(self):"},{"line_number":161,"context_line":"        self.stubs.Set(compute_utils, \u0027pack_action_event_start\u0027,"},{"line_number":162,"context_line":"                       lambda *args, **kwargs: fake_event_values)"},{"line_number":163,"context_line":"        self.mox.StubOutWithMock(db, \u0027action_event_start\u0027)"},{"line_number":164,"context_line":"        db.action_event_start("},{"line_number":165,"context_line":"            self.context, fake_event_values).AndReturn(fake_event)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9e30%3D","line":162,"in_reply_to":"AAAATn%2F9g6w%3D","updated":"2013-12-11 02:05:33.000000000","message":"The problem with pack_action_event_start is that, it will generate timestamp, which will change when you actual call instance_action.InstanceEvent.event_start (and then trigger pack_action_event_start) afterwards.\n\nSo my thought was since we\u0027re test InstanceActionEvent object only, it doesn\u0027t matter if we mock pack_action_event_start/finish.\n\nHowever, if you can suggest how to handle / ignore timestamp with mock/mox here, I\u0027d really happy to use it. Just need to figure out how.","commit_id":"2aca83ec8de9965200598a44d39c1ea0ad6eff3a"}]}