)]}'
{"nova/objects/cell_mapping.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f85b2f92ca91390c56f8b6eb3ed3165b2ebbbba9","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @staticmethod"},{"line_number":131,"context_line":"    def _format_db_url(url):"},{"line_number":132,"context_line":"        if CONF.database.connection is None:"},{"line_number":133,"context_line":"            if \u0027{\u0027 in url:"},{"line_number":134,"context_line":"                LOG.error(\u0027Cell mapping database_connection is a template, \u0027"},{"line_number":135,"context_line":"                          \u0027but [database]/connection is not set\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6bfc7770","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":35},"updated":"2018-10-16 17:08:54.000000000","message":"FWIW, I don\u0027t think this an actually ever be none since we default the connection in config:\n\nhttps://github.com/openstack/nova/blob/396156eb13521a0e7af4488a8cd4693aa65a0da2/nova/conf/database.py#L160","commit_id":"4437b16c4ac1978da9e181e95a63a8f109190f30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1e0cd5947390317fd813131b5bd5c7f364f43bb","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @staticmethod"},{"line_number":131,"context_line":"    def _format_db_url(url):"},{"line_number":132,"context_line":"        if CONF.database.connection is None:"},{"line_number":133,"context_line":"            if \u0027{\u0027 in url:"},{"line_number":134,"context_line":"                LOG.error(\u0027Cell mapping database_connection is a template, \u0027"},{"line_number":135,"context_line":"                          \u0027but [database]/connection is not set\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0b014339","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":35},"in_reply_to":"3f79a3b5_0bd863ed","updated":"2018-10-16 17:16:11.000000000","message":"Yeah I\u0027d rather be safe here, just thought about it is all.","commit_id":"4437b16c4ac1978da9e181e95a63a8f109190f30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b27934496e05181e9f737b302484e503150727d9","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    @staticmethod"},{"line_number":131,"context_line":"    def _format_db_url(url):"},{"line_number":132,"context_line":"        if CONF.database.connection is None:"},{"line_number":133,"context_line":"            if \u0027{\u0027 in url:"},{"line_number":134,"context_line":"                LOG.error(\u0027Cell mapping database_connection is a template, \u0027"},{"line_number":135,"context_line":"                          \u0027but [database]/connection is not set\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0bd863ed","line":132,"range":{"start_line":132,"start_character":11,"end_line":132,"end_character":35},"in_reply_to":"3f79a3b5_6bfc7770","updated":"2018-10-16 17:14:56.000000000","message":"Yeah, I thought about that, but I\u0027m not sure that it\u0027s not ever going to be that way (like how we stopped setting that default for placement\u0027s connection). I can obviously set it to None in the test, so I figured it was better for consistency.","commit_id":"4437b16c4ac1978da9e181e95a63a8f109190f30"}],"nova/tests/unit/objects/test_cell_mapping.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8696905dff42b45379f6c882821366387b33b2be","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    def test_non_formatted_url_with_no_base(self, mock_get):"},{"line_number":252,"context_line":"        # Make sure we just pass through the template URL if the base"},{"line_number":253,"context_line":"        # URLs are not set"},{"line_number":254,"context_line":"        url \u003d \u0027foo\u0027"},{"line_number":255,"context_line":"        self.flags(transport_url\u003dNone)"},{"line_number":256,"context_line":"        self.flags(connection\u003dNone, group\u003d\u0027database\u0027)"},{"line_number":257,"context_line":"        db_mapping \u003d get_db_mapping(transport_url\u003durl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f752a467","line":254,"range":{"start_line":254,"start_character":8,"end_line":254,"end_character":19},"updated":"2018-10-16 19:51:17.000000000","message":"Shouldn\u0027t this be None? I thought the problem was that the value is None but we aren\u0027t handling that.","commit_id":"4437b16c4ac1978da9e181e95a63a8f109190f30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c9808bbabf7daea52d430215103e81820db94c7","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    def test_non_formatted_url_with_no_base(self, mock_get):"},{"line_number":252,"context_line":"        # Make sure we just pass through the template URL if the base"},{"line_number":253,"context_line":"        # URLs are not set"},{"line_number":254,"context_line":"        url \u003d \u0027foo\u0027"},{"line_number":255,"context_line":"        self.flags(transport_url\u003dNone)"},{"line_number":256,"context_line":"        self.flags(connection\u003dNone, group\u003d\u0027database\u0027)"},{"line_number":257,"context_line":"        db_mapping \u003d get_db_mapping(transport_url\u003durl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f7d704bf","line":254,"range":{"start_line":254,"start_character":8,"end_line":254,"end_character":19},"in_reply_to":"3f79a3b5_f752a467","updated":"2018-10-16 19:52:51.000000000","message":"Nevermind that wouldn\u0027t work because the fields are not nullable.","commit_id":"4437b16c4ac1978da9e181e95a63a8f109190f30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bf2711b722da3806f721b50ffa5b8076fa0cb7a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    def test_non_formatted_url_with_no_base(self, mock_get):"},{"line_number":252,"context_line":"        # Make sure we just pass through the template URL if the base"},{"line_number":253,"context_line":"        # URLs are not set"},{"line_number":254,"context_line":"        url \u003d \u0027foo\u0027"},{"line_number":255,"context_line":"        self.flags(transport_url\u003dNone)"},{"line_number":256,"context_line":"        self.flags(connection\u003dNone, group\u003d\u0027database\u0027)"},{"line_number":257,"context_line":"        db_mapping \u003d get_db_mapping(transport_url\u003durl,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_97bed061","line":254,"range":{"start_line":254,"start_character":8,"end_line":254,"end_character":19},"in_reply_to":"3f79a3b5_f7d704bf","updated":"2018-10-16 19:55:43.000000000","message":"I guess you should assert that _format_url is not called.","commit_id":"4437b16c4ac1978da9e181e95a63a8f109190f30"}]}