)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4acfca5b990ca65821c2f07f9ec7b8b52495e9b1","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                     \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":677,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"},{"line_number":678,"context_line":"               default\u003d\u0027auto\u0027,"},{"line_number":679,"context_line":"               choices\u003d(\u0027none\u0027, \u0027os\u0027, \u0027hardware\u0027, \u0027auto\u0027),"},{"line_number":680,"context_line":"               help\u003d\"\"\""},{"line_number":681,"context_line":"The data source used to the populate the host \"serial\" UUID exposed to guest"},{"line_number":682,"context_line":"in the virtual BIOS."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b0b093de","line":679,"range":{"start_line":679,"start_character":15,"end_line":679,"end_character":58},"updated":"2018-10-18 00:58:29.000000000","message":"The new style of choices parameter should be used.\nSee https://review.openstack.org/#/c/530924/ .","commit_id":"20b0486c690d910aef882f1fdebdc6cefac76b51"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5d93f10af5c6fe96bdb4e5f6babdc972e72c70c","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                     \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":677,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"},{"line_number":678,"context_line":"               default\u003d\u0027auto\u0027,"},{"line_number":679,"context_line":"               choices\u003d(\u0027none\u0027, \u0027os\u0027, \u0027hardware\u0027, \u0027auto\u0027),"},{"line_number":680,"context_line":"               help\u003d\"\"\""},{"line_number":681,"context_line":"The data source used to the populate the host \"serial\" UUID exposed to guest"},{"line_number":682,"context_line":"in the virtual BIOS."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4964eab3","line":679,"range":{"start_line":679,"start_character":15,"end_line":679,"end_character":58},"in_reply_to":"3f79a3b5_0d004569","updated":"2018-10-18 18:45:25.000000000","message":"Done","commit_id":"20b0486c690d910aef882f1fdebdc6cefac76b51"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d509d7842fd050578363d50f22cbbfd703a0806a","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                     \u0027For example: x86_64\u003dmachinetype1,armv7l\u003dmachinetype2\u0027),"},{"line_number":677,"context_line":"    cfg.StrOpt(\u0027sysinfo_serial\u0027,"},{"line_number":678,"context_line":"               default\u003d\u0027auto\u0027,"},{"line_number":679,"context_line":"               choices\u003d(\u0027none\u0027, \u0027os\u0027, \u0027hardware\u0027, \u0027auto\u0027),"},{"line_number":680,"context_line":"               help\u003d\"\"\""},{"line_number":681,"context_line":"The data source used to the populate the host \"serial\" UUID exposed to guest"},{"line_number":682,"context_line":"in the virtual BIOS."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0d004569","line":679,"range":{"start_line":679,"start_character":15,"end_line":679,"end_character":58},"in_reply_to":"3f79a3b5_b0b093de","updated":"2018-10-18 14:25:46.000000000","message":"++","commit_id":"20b0486c690d910aef882f1fdebdc6cefac76b51"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c830783ba0bfa2a83b5d31409c870e6a5e398099","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                   (\u0027none\u0027, \u0027A serial number entry is not added to the guest \u0027"},{"line_number":681,"context_line":"                            \u0027domain xml.\u0027),"},{"line_number":682,"context_line":"                   (\u0027os\u0027, \u0027A UUID serial number is generated from the host \u0027"},{"line_number":683,"context_line":"                          \u0027\"/etc/machine-id\" file.\u0027),"},{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2022d1a7","line":683,"range":{"start_line":683,"start_character":20,"end_line":683,"end_character":26},"updated":"2018-10-19 10:28:20.000000000","message":"...and this indentation isn\u0027t needed","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"84e42ad3be1e173422f9d438f9fb5680f7574c5b","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                   (\u0027none\u0027, \u0027A serial number entry is not added to the guest \u0027"},{"line_number":681,"context_line":"                            \u0027domain xml.\u0027),"},{"line_number":682,"context_line":"                   (\u0027os\u0027, \u0027A UUID serial number is generated from the host \u0027"},{"line_number":683,"context_line":"                          \u0027\"/etc/machine-id\" file.\u0027),"},{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_04e81713","line":683,"range":{"start_line":683,"start_character":27,"end_line":683,"end_character":44},"updated":"2018-10-18 19:32:47.000000000","message":"These could be double backticks","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"112c77f63442a106861e69ed3255ee86c987eed7","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                   (\u0027none\u0027, \u0027A serial number entry is not added to the guest \u0027"},{"line_number":681,"context_line":"                            \u0027domain xml.\u0027),"},{"line_number":682,"context_line":"                   (\u0027os\u0027, \u0027A UUID serial number is generated from the host \u0027"},{"line_number":683,"context_line":"                          \u0027\"/etc/machine-id\" file.\u0027),"},{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_76640fb4","line":683,"range":{"start_line":683,"start_character":20,"end_line":683,"end_character":26},"in_reply_to":"3f79a3b5_1beaa676","updated":"2018-10-19 12:58:50.000000000","message":"Commence tearing of eyes https://github.com/openstack/nova/commit/a53a29ccf0bea32eeb5352c93280dece36e1ee28","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2eeb907b61cd3f7ed351ca423b3267dcf0f7f1a2","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                   (\u0027none\u0027, \u0027A serial number entry is not added to the guest \u0027"},{"line_number":681,"context_line":"                            \u0027domain xml.\u0027),"},{"line_number":682,"context_line":"                   (\u0027os\u0027, \u0027A UUID serial number is generated from the host \u0027"},{"line_number":683,"context_line":"                          \u0027\"/etc/machine-id\" file.\u0027),"},{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1beaa676","line":683,"range":{"start_line":683,"start_character":20,"end_line":683,"end_character":26},"in_reply_to":"3f79a3b5_2022d1a7","updated":"2018-10-19 12:30:38.000000000","message":"\u003e ...and this indentation isn\u0027t needed\n\nSo you want this to look like:\n\n(\u0027os\u0027, \u0027A UUID serial number is generated from the host \u0027\n \u0027\"/etc/machine-id\" file.\u0027),\n\nI would rather tear my eyes out.","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"84e42ad3be1e173422f9d438f9fb5680f7574c5b","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                            \u0027domain xml.\u0027),"},{"line_number":682,"context_line":"                   (\u0027os\u0027, \u0027A UUID serial number is generated from the host \u0027"},{"line_number":683,"context_line":"                          \u0027\"/etc/machine-id\" file.\u0027),"},{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in libvirtd.conf.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a4ecc328","line":684,"range":{"start_line":684,"start_character":62,"end_line":684,"end_character":70},"updated":"2018-10-18 19:32:47.000000000","message":"is reported?","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"84e42ad3be1e173422f9d438f9fb5680f7574c5b","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in libvirtd.conf.\u0027),"},{"line_number":688,"context_line":"                   (\u0027auto\u0027, \u0027Uses the \"os\" source if possible, else \u0027"},{"line_number":689,"context_line":"                            \u0027\"hardware\".\u0027),"},{"line_number":690,"context_line":"               ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c4f1bf02","line":687,"range":{"start_line":687,"start_character":36,"end_line":687,"end_character":49},"updated":"2018-10-18 19:32:47.000000000","message":"``?``","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3662d4650ac9d47dc7d5950674e0df5d923c4574","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in libvirtd.conf.\u0027),"},{"line_number":688,"context_line":"                   (\u0027auto\u0027, \u0027Uses the \"os\" source if possible, else \u0027"},{"line_number":689,"context_line":"                            \u0027\"hardware\".\u0027),"},{"line_number":690,"context_line":"               ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1c393d3f","line":687,"range":{"start_line":687,"start_character":36,"end_line":687,"end_character":49},"in_reply_to":"3f79a3b5_36753798","updated":"2018-10-19 14:06:46.000000000","message":"Sorry, I meant \"should this be in double backticks?\"\n\nMatt got it.","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"a8f669ba9b7f0c776d074831bc5e0d56aac988b5","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                   (\u0027hardware\u0027, \u0027A UUID for the host hardware reported by \u0027"},{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in libvirtd.conf.\u0027),"},{"line_number":688,"context_line":"                   (\u0027auto\u0027, \u0027Uses the \"os\" source if possible, else \u0027"},{"line_number":689,"context_line":"                            \u0027\"hardware\".\u0027),"},{"line_number":690,"context_line":"               ),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_36753798","line":687,"range":{"start_line":687,"start_character":36,"end_line":687,"end_character":49},"in_reply_to":"3f79a3b5_c4f1bf02","updated":"2018-10-19 12:51:01.000000000","message":"He\u0027s referring to this bit in /etc/libvirt/libvirtd.conf:\n\n-----------------------------------------------------------\n\n# The host_uuid_source default is \u0027smbios\u0027. If \u0027dmidecode\u0027 does not provide\n# a valid UUID a temporary UUID will be generated.\n#\n# Another option is to specify host UUID in host_uuid.\n#\n# Keep the format of the example UUID below. UUID must not have all digits\n# be the same.\n\n# NB This default all-zeros UUID will not work. Replace\n# it with the output of the \u0027uuidgen\u0027 command and then\n# uncomment this entry\n#host_uuid \u003d \"00000000-0000-0000-0000-000000000000\"\n#host_uuid_source \u003d \"smbios\"\n\n-----------------------------------------------------------","commit_id":"df1e338d17bf6cfd33c16aef6dd964f0225690f0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3662d4650ac9d47dc7d5950674e0df5d923c4574","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in ``libvirtd.conf``.\u0027),"},{"line_number":688,"context_line":"                   (\u0027auto\u0027, \u0027Uses the \"os\" source if possible, else \u0027"},{"line_number":689,"context_line":"                            \u0027\"hardware\".\u0027),"},{"line_number":690,"context_line":"               ),"},{"line_number":691,"context_line":"               help\u003d\u0027The data source used to the populate the host \"serial\" \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dc70a50c","line":688,"range":{"start_line":688,"start_character":38,"end_line":688,"end_character":42},"updated":"2018-10-19 14:06:46.000000000","message":"Looking at the output, these would make more sense as ``os`` or **os**, but this is certainly fine as is.","commit_id":"6ae39071767a2009d596cdb6d295f07ddcb604fa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"097fb8d0c505f53c7cb2d1cd25ff4f2937cdf497","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in ``libvirtd.conf``.\u0027),"},{"line_number":688,"context_line":"                   (\u0027auto\u0027, \u0027Uses the \"os\" source if possible, else \u0027"},{"line_number":689,"context_line":"                            \u0027\"hardware\".\u0027),"},{"line_number":690,"context_line":"               ),"},{"line_number":691,"context_line":"               help\u003d\u0027The data source used to the populate the host \"serial\" \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9c551422","line":688,"range":{"start_line":688,"start_character":38,"end_line":688,"end_character":42},"in_reply_to":"3f79a3b5_63a44906","updated":"2018-10-23 11:25:27.000000000","message":"``+1``","commit_id":"6ae39071767a2009d596cdb6d295f07ddcb604fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d7073bb07876bd14ad4d0834dfd073fd5885e63c","unresolved":false,"context_lines":[{"line_number":685,"context_line":"                                \u0027libvirt. This is typically from the host \u0027"},{"line_number":686,"context_line":"                                \u0027SMBIOS data, unless it has been overridden \u0027"},{"line_number":687,"context_line":"                                \u0027in ``libvirtd.conf``.\u0027),"},{"line_number":688,"context_line":"                   (\u0027auto\u0027, \u0027Uses the \"os\" source if possible, else \u0027"},{"line_number":689,"context_line":"                            \u0027\"hardware\".\u0027),"},{"line_number":690,"context_line":"               ),"},{"line_number":691,"context_line":"               help\u003d\u0027The data source used to the populate the host \"serial\" \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_63a44906","line":688,"range":{"start_line":688,"start_character":38,"end_line":688,"end_character":42},"in_reply_to":"3f79a3b5_dc70a50c","updated":"2018-10-19 19:38:15.000000000","message":"I was waiting for one of you bastards to mention it, I just wanted to bide my time for the rage-quit.","commit_id":"6ae39071767a2009d596cdb6d295f07ddcb604fa"}]}