)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d4f34a539c0fb8cf48d45b73c1abf73c0355e96c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from the CachingScheduler to the FilterScheduler."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Since the [scheduler]/driver configuration option does allow"},{"line_number":22,"context_line":"loading out-of-tree drivers and the scheduler driver interface"},{"line_number":23,"context_line":"does have the USES_ALLOCATION_CANDIDATES variable, it is"},{"line_number":24,"context_line":"possible that there are drivers being used which are also not"},{"line_number":25,"context_line":"using the placement service. The release note also explains this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_190000ff","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":27},"updated":"2018-10-25 09:10:06.000000000","message":"So in theory if somebody desperately needs the ChachingScheduler then it can be loaded as a out-of-tree driver after this patch.","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"}],"nova/test.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d4f34a539c0fb8cf48d45b73c1abf73c0355e96c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        compute.start()"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    @staticmethod"},{"line_number":433,"context_line":"    def restart_scheduler_service(scheduler):"},{"line_number":434,"context_line":"        \"\"\"Restart a scheduler service in a realistic way."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        :param scheduler: The nova-scheduler service to be restarted."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_79d2545d","line":433,"updated":"2018-10-25 09:10:06.000000000","message":"I think this is not called any more.","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b168392b0495ebfcd285dcdd91ed942ac23a083d","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        compute.start()"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    @staticmethod"},{"line_number":433,"context_line":"    def restart_scheduler_service(scheduler):"},{"line_number":434,"context_line":"        \"\"\"Restart a scheduler service in a realistic way."},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        :param scheduler: The nova-scheduler service to be restarted."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f413c258","line":433,"in_reply_to":"3f79a3b5_79d2545d","updated":"2018-10-25 14:21:31.000000000","message":"Yeah I thought about removing this as well since it doesn\u0027t really do anything now, but figured it wasn\u0027t hurting. If it\u0027s not called, I\u0027ll remove it.","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"}],"nova/tests/functional/regressions/test_bug_1671648.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"955a24efe350f99e7565401a9fb27b6f7dcdbefa","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # We need to mock the FilterScheduler to not use Placement so that"},{"line_number":162,"context_line":"        # allocations won\u0027t be created during scheduling."},{"line_number":163,"context_line":"        self.scheduler_service.manager.driver.USES_ALLOCATION_CANDIDATES \u003d \\"},{"line_number":164,"context_line":"            False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a777db3c","line":164,"updated":"2018-10-19 08:09:26.000000000","message":"Maybe we should have a FakeSchedulerWithNoAllocationCandidates ?","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"9aec02ae5dbb872ad358d088a39803a227282c02","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # We need to mock the FilterScheduler to not use Placement so that"},{"line_number":162,"context_line":"        # allocations won\u0027t be created during scheduling."},{"line_number":163,"context_line":"        self.scheduler_service.manager.driver.USES_ALLOCATION_CANDIDATES \u003d \\"},{"line_number":164,"context_line":"            False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fd888d6c","line":164,"in_reply_to":"3f79a3b5_79e9f416","updated":"2018-10-25 11:20:22.000000000","message":"Anyway, it\u0027s just a nit like I said. In case we want to have a specific FakeScheduler not calling Placement for something else, we could just have a follow-up.","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d4f34a539c0fb8cf48d45b73c1abf73c0355e96c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # We need to mock the FilterScheduler to not use Placement so that"},{"line_number":162,"context_line":"        # allocations won\u0027t be created during scheduling."},{"line_number":163,"context_line":"        self.scheduler_service.manager.driver.USES_ALLOCATION_CANDIDATES \u003d \\"},{"line_number":164,"context_line":"            False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_79e9f416","line":164,"in_reply_to":"3f79a3b5_7b25dabe","updated":"2018-10-25 09:10:06.000000000","message":"I\u0027m fine having a single line of mock instead of a new driver for test","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"375b222f3f536461ca816f079a1fbe30abde8918","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # We need to mock the FilterScheduler to not use Placement so that"},{"line_number":162,"context_line":"        # allocations won\u0027t be created during scheduling."},{"line_number":163,"context_line":"        self.scheduler_service.manager.driver.USES_ALLOCATION_CANDIDATES \u003d \\"},{"line_number":164,"context_line":"            False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7b25dabe","line":164,"in_reply_to":"3f79a3b5_a777db3c","updated":"2018-10-19 12:41:44.000000000","message":"I thought about it but then we have to have a registered entry point for that, and we already have the fake_scheduler, unless we just make that fake scheduler one that doesn\u0027t use placement (it\u0027s already broken in that its select_destinations method args are wrong since we added the alternate hosts stuff). And besides, I think we\u0027ll likely follow this up with removing the USES_ALLOCATION_CANDIDATES variable anyway, along with the compatibility code associated with it (and stuff testing that code, like this).","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"}],"nova/tests/functional/test_nova_manage.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"955a24efe350f99e7565401a9fb27b6f7dcdbefa","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            self.assertEqual("},{"line_number":417,"context_line":"                0, usage,"},{"line_number":418,"context_line":"                \u0027Compute node resource provider %s should not have %s \u0027"},{"line_number":419,"context_line":"                \u0027usage; something must be wrong in test setup.\u0027 %"},{"line_number":420,"context_line":"                (hostname, resource_class))"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        # Check that the server has no allocations."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_478e0727","line":419,"updated":"2018-10-19 08:09:26.000000000","message":"++","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"955a24efe350f99e7565401a9fb27b6f7dcdbefa","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        1.8 when consumer (project_id and user_id) were not required so the"},{"line_number":597,"context_line":"        consumer information is using sentinel values from config."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        Since the hacked scheduler used in this test class won\u0027t actually"},{"line_number":600,"context_line":"        create allocations during scheduling, we have to create the allocations"},{"line_number":601,"context_line":"        out-of-band and then run our heal routine to see they get updated with"},{"line_number":602,"context_line":"        the instance project and user information."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_07980f67","line":599,"updated":"2018-10-19 08:09:26.000000000","message":"Faked?","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"375b222f3f536461ca816f079a1fbe30abde8918","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        1.8 when consumer (project_id and user_id) were not required so the"},{"line_number":597,"context_line":"        consumer information is using sentinel values from config."},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        Since the hacked scheduler used in this test class won\u0027t actually"},{"line_number":600,"context_line":"        create allocations during scheduling, we have to create the allocations"},{"line_number":601,"context_line":"        out-of-band and then run our heal routine to see they get updated with"},{"line_number":602,"context_line":"        the instance project and user information."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_db0d0e41","line":599,"in_reply_to":"3f79a3b5_07980f67","updated":"2018-10-19 12:41:44.000000000","message":"No, hacked as in I hacked the USES_ALLOCATION_CANDIDATES value on the FilterScheduler.","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"}],"releasenotes/notes/remove-caching-scheduler-cfe0985b5a58bef4.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"955a24efe350f99e7565401a9fb27b6f7dcdbefa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    driver which sets ``USES_ALLOCATION_CANDIDATES \u003d False`` to bypass the"},{"line_number":44,"context_line":"    placement service, please communicate with the nova development team in"},{"line_number":45,"context_line":"    the openstack-dev mailing list and/or #openstack-nova freenode IRC channel"},{"line_number":46,"context_line":"    to determine what prevents you from using the ``filter_scheduler`` driver."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_c78bf71f","line":46,"updated":"2018-10-19 08:09:26.000000000","message":"++","commit_id":"25dadb94db37e0f1c6769bf586ec06c3b5ea3051"}]}