)]}'
{"nova/tests/unit/virt/libvirt/test_imagebackend.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e0b96f6842e14a54ec0383ca205afe4ed0b63051","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(2361393152, image.get_disk_size(image.path))"},{"line_number":205,"context_line":"        get_disk_size.assert_called_once_with(image.path)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _test_libvirt_info_scsi_with_unit(self, disk_unit):"},{"line_number":208,"context_line":"        # The address should be set if bus is scsi and unit is set."},{"line_number":209,"context_line":"        # Otherwise, it should not be set at all."},{"line_number":210,"context_line":"        image \u003d self.image_class(self.INSTANCE, self.NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_873d63de","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":41},"updated":"2019-03-17 19:04:43.000000000","message":"nit - Can\u0027t we just do this with one method?","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5efa1fafb6e241f409d717d9cc0e27b0ebfb392d","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(2361393152, image.get_disk_size(image.path))"},{"line_number":205,"context_line":"        get_disk_size.assert_called_once_with(image.path)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _test_libvirt_info_scsi_with_unit(self, disk_unit):"},{"line_number":208,"context_line":"        # The address should be set if bus is scsi and unit is set."},{"line_number":209,"context_line":"        # Otherwise, it should not be set at all."},{"line_number":210,"context_line":"        image \u003d self.image_class(self.INSTANCE, self.NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_5bb641fb","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":41},"in_reply_to":"5fc1f717_308594ad","updated":"2019-03-28 20:51:29.000000000","message":"Actually, I find I can\u0027t because in the child class RbdTestCase, I can\u0027t call the parent method if it\u0027s decorated with @ddt because ddt will create test methods with suffix _1_5 and _2_None and the child class method won\u0027t be able to find them:\n\n AttributeError: \u0027super\u0027 object has no attribute \u0027test_libvirt_info_scsi_with_unit\u0027\n\nSo I think I can\u0027t use one method. If you a way to do it, let me know and I\u0027ll change it.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"59a0fcda13eeb4f430d1b5ed0843214e2672c822","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(2361393152, image.get_disk_size(image.path))"},{"line_number":205,"context_line":"        get_disk_size.assert_called_once_with(image.path)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _test_libvirt_info_scsi_with_unit(self, disk_unit):"},{"line_number":208,"context_line":"        # The address should be set if bus is scsi and unit is set."},{"line_number":209,"context_line":"        # Otherwise, it should not be set at all."},{"line_number":210,"context_line":"        image \u003d self.image_class(self.INSTANCE, self.NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_e1aba272","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":41},"in_reply_to":"5fc1f717_5bb641fb","updated":"2019-04-11 15:39:41.000000000","message":"Ah understood, I had assumed ddt wasn\u0027t doing that tbh.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad0fcd92b549e56818e2f4dc1dbb39f3b59eaa9f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(2361393152, image.get_disk_size(image.path))"},{"line_number":205,"context_line":"        get_disk_size.assert_called_once_with(image.path)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def _test_libvirt_info_scsi_with_unit(self, disk_unit):"},{"line_number":208,"context_line":"        # The address should be set if bus is scsi and unit is set."},{"line_number":209,"context_line":"        # Otherwise, it should not be set at all."},{"line_number":210,"context_line":"        image \u003d self.image_class(self.INSTANCE, self.NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_308594ad","line":207,"range":{"start_line":207,"start_character":8,"end_line":207,"end_character":41},"in_reply_to":"5fc1f717_873d63de","updated":"2019-03-28 20:25:51.000000000","message":"Oh yeah, probably.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"59a0fcda13eeb4f430d1b5ed0843214e2672c822","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                  disk_unit\u003ddisk_unit)"},{"line_number":224,"context_line":"        if disk_unit:"},{"line_number":225,"context_line":"            self.assertEqual(0, disk.device_addr.controller)"},{"line_number":226,"context_line":"            self.assertEqual(5, disk.device_addr.unit)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            self.assertIsNone(disk.device_addr)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_1ecbab53","line":226,"range":{"start_line":226,"start_character":29,"end_line":226,"end_character":30},"updated":"2019-04-11 15:39:41.000000000","message":"nit - disk_unit?","commit_id":"02d96f1c9a838d49785f04e9571c0dfb25f867df"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"04e2593637f6f42259433b6e064ff2ef8733ed65","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                  disk_unit\u003ddisk_unit)"},{"line_number":224,"context_line":"        if disk_unit:"},{"line_number":225,"context_line":"            self.assertEqual(0, disk.device_addr.controller)"},{"line_number":226,"context_line":"            self.assertEqual(5, disk.device_addr.unit)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            self.assertIsNone(disk.device_addr)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_a1efda85","line":226,"range":{"start_line":226,"start_character":29,"end_line":226,"end_character":30},"in_reply_to":"3fce034c_1ecbab53","updated":"2019-04-11 15:48:20.000000000","message":"Ah, whoops. I should fix this but don\u0027t want to lose my +1s.","commit_id":"02d96f1c9a838d49785f04e9571c0dfb25f867df"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4ce3612c6679dc7ed9d8cc8ec60a37c4cd29269a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                  disk_unit\u003ddisk_unit)"},{"line_number":224,"context_line":"        if disk_unit:"},{"line_number":225,"context_line":"            self.assertEqual(0, disk.device_addr.controller)"},{"line_number":226,"context_line":"            self.assertEqual(5, disk.device_addr.unit)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            self.assertIsNone(disk.device_addr)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_c535f947","line":226,"range":{"start_line":226,"start_character":29,"end_line":226,"end_character":30},"in_reply_to":"3fce034c_32aed62e","updated":"2019-04-16 23:22:18.000000000","message":"Done: https://review.openstack.org/653168","commit_id":"02d96f1c9a838d49785f04e9571c0dfb25f867df"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5d34c3d915eda02ebc93b110675a8e35f238de9a","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                                  disk_unit\u003ddisk_unit)"},{"line_number":224,"context_line":"        if disk_unit:"},{"line_number":225,"context_line":"            self.assertEqual(0, disk.device_addr.controller)"},{"line_number":226,"context_line":"            self.assertEqual(5, disk.device_addr.unit)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            self.assertIsNone(disk.device_addr)"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_32aed62e","line":226,"range":{"start_line":226,"start_character":29,"end_line":226,"end_character":30},"in_reply_to":"3fce034c_a1efda85","updated":"2019-04-11 18:10:01.000000000","message":"fup it","commit_id":"02d96f1c9a838d49785f04e9571c0dfb25f867df"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1156741cc2431ec29a1d072388f41a36d1140220","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # up to 256 devices. So, we should only be setting the address tag"},{"line_number":161,"context_line":"        # if we intend to set the unit number. Otherwise, we will let libvirt"},{"line_number":162,"context_line":"        # handle autogeneration of the address tag."},{"line_number":163,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":164,"context_line":"        if disk_unit is not None:"},{"line_number":165,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":166,"context_line":"            # at index 0."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_34c96825","line":163,"range":{"start_line":163,"start_character":52,"end_line":163,"end_character":59},"updated":"2019-03-12 21:53:36.000000000","message":"and/or 1792077 ?","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad0fcd92b549e56818e2f4dc1dbb39f3b59eaa9f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        # up to 256 devices. So, we should only be setting the address tag"},{"line_number":161,"context_line":"        # if we intend to set the unit number. Otherwise, we will let libvirt"},{"line_number":162,"context_line":"        # handle autogeneration of the address tag."},{"line_number":163,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":164,"context_line":"        if disk_unit is not None:"},{"line_number":165,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":166,"context_line":"            # at index 0."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_509ce00c","line":163,"range":{"start_line":163,"start_character":52,"end_line":163,"end_character":59},"in_reply_to":"5fc1f717_34c96825","updated":"2019-03-28 20:25:51.000000000","message":"Yeah, I can add it.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"}],"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1156741cc2431ec29a1d072388f41a36d1140220","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        # up to 256 devices. So, we should only be setting the address tag"},{"line_number":100,"context_line":"        # if we intend to set the unit number. Otherwise, we will let libvirt"},{"line_number":101,"context_line":"        # handle autogeneration of the address tag."},{"line_number":102,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":103,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027 and \u0027unit\u0027 in disk_info:"},{"line_number":104,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":105,"context_line":"            # at index 0."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_54ce742e","line":102,"range":{"start_line":102,"start_character":52,"end_line":102,"end_character":59},"updated":"2019-03-12 21:53:36.000000000","message":"ditto","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"e0b96f6842e14a54ec0383ca205afe4ed0b63051","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # handle autogeneration of the address tag."},{"line_number":102,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":103,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027 and \u0027unit\u0027 in disk_info:"},{"line_number":104,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":105,"context_line":"            # at index 0."},{"line_number":106,"context_line":"            conf.device_addr \u003d vconfig.LibvirtConfigGuestDeviceAddressDrive()"},{"line_number":107,"context_line":"            conf.device_addr.controller \u003d 0"},{"line_number":108,"context_line":"            # In order to allow up to 256 disks handled by one"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e2b53533","line":105,"range":{"start_line":104,"start_character":12,"end_line":105,"end_character":25},"updated":"2019-03-17 19:04:43.000000000","message":"I\u0027m not entirely sure what we mean by driver here if I\u0027m honest, I assume it\u0027s the actual libvirt virt driver?","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e592bcf66e81ace0802a5d33ee501ac673b0972a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # handle autogeneration of the address tag."},{"line_number":102,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":103,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027 and \u0027unit\u0027 in disk_info:"},{"line_number":104,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":105,"context_line":"            # at index 0."},{"line_number":106,"context_line":"            conf.device_addr \u003d vconfig.LibvirtConfigGuestDeviceAddressDrive()"},{"line_number":107,"context_line":"            conf.device_addr.controller \u003d 0"},{"line_number":108,"context_line":"            # In order to allow up to 256 disks handled by one"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1bc8b952","line":105,"range":{"start_line":104,"start_character":12,"end_line":105,"end_character":25},"in_reply_to":"5fc1f717_10dc18e2","updated":"2019-03-28 20:57:35.000000000","message":"Looking at this again, I think in this context it means the LibvirtBaseVolumeDriver since that\u0027s what\u0027s creating the SCSI controller on L106-107, right?","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"5d365f4168337e1111b643bbe810cd625e5b70fb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # handle autogeneration of the address tag."},{"line_number":102,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":103,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027 and \u0027unit\u0027 in disk_info:"},{"line_number":104,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":105,"context_line":"            # at index 0."},{"line_number":106,"context_line":"            conf.device_addr \u003d vconfig.LibvirtConfigGuestDeviceAddressDrive()"},{"line_number":107,"context_line":"            conf.device_addr.controller \u003d 0"},{"line_number":108,"context_line":"            # In order to allow up to 256 disks handled by one"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_fcd2f033","line":105,"range":{"start_line":104,"start_character":12,"end_line":105,"end_character":25},"in_reply_to":"5fc1f717_1bc8b952","updated":"2019-04-05 23:59:05.000000000","message":"I agree.\n\nActually I think it\u0027s ultimately referring to the driver that will subclass LibvirtBaseVolumeDriver, but they all just call the base class function so it\u0027s kind of a moot point.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad0fcd92b549e56818e2f4dc1dbb39f3b59eaa9f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # handle autogeneration of the address tag."},{"line_number":102,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":103,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027 and \u0027unit\u0027 in disk_info:"},{"line_number":104,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":105,"context_line":"            # at index 0."},{"line_number":106,"context_line":"            conf.device_addr \u003d vconfig.LibvirtConfigGuestDeviceAddressDrive()"},{"line_number":107,"context_line":"            conf.device_addr.controller \u003d 0"},{"line_number":108,"context_line":"            # In order to allow up to 256 disks handled by one"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_10dc18e2","line":105,"range":{"start_line":104,"start_character":12,"end_line":105,"end_character":25},"in_reply_to":"5fc1f717_e2b53533","updated":"2019-03-28 20:25:51.000000000","message":"I didn\u0027t write this comment, but I assume it means the libvirt virt driver.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"59a0fcda13eeb4f430d1b5ed0843214e2672c822","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # handle autogeneration of the address tag."},{"line_number":102,"context_line":"        # See: https://bugs.launchpad.net/nova/+bug/1686116"},{"line_number":103,"context_line":"        if disk_info[\u0027bus\u0027] \u003d\u003d \u0027scsi\u0027 and \u0027unit\u0027 in disk_info:"},{"line_number":104,"context_line":"            # The driver is responsible to create the SCSI controller"},{"line_number":105,"context_line":"            # at index 0."},{"line_number":106,"context_line":"            conf.device_addr \u003d vconfig.LibvirtConfigGuestDeviceAddressDrive()"},{"line_number":107,"context_line":"            conf.device_addr.controller \u003d 0"},{"line_number":108,"context_line":"            # In order to allow up to 256 disks handled by one"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_019b4e72","line":105,"range":{"start_line":104,"start_character":12,"end_line":105,"end_character":25},"in_reply_to":"5fc1f717_fcd2f033","updated":"2019-04-11 15:39:41.000000000","message":"Ah! That makes sense now thanks.","commit_id":"6c0cddb4a6870de6aee04ed0d939136a765fef04"}]}