)]}'
{"nova/rpc.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"243d52ff89053b02baf06562595f65d9e62054f5","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        if isinstance(obj, nova.context.RequestContext):"},{"line_number":135,"context_line":"            # This matches RequestContextSerializer.serialize_context()."},{"line_number":136,"context_line":"            return obj.to_dict()"},{"line_number":137,"context_line":"        # The default fallback in jsonutils.to_primitive() is six.text_type."},{"line_number":138,"context_line":"        return six.text_type(obj)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def serialize_entity(self, context, entity):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9af6db2c","line":137,"updated":"2018-11-13 21:09:07.000000000","message":"Right as https://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L89","commit_id":"cd1dfc157b89a2aa53832ebe8a9694b7edc47f6f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b18afa92eca79315f94ddc57a602781498964038","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        if isinstance(obj, nova.context.RequestContext):"},{"line_number":135,"context_line":"            # This matches RequestContextSerializer.serialize_context()."},{"line_number":136,"context_line":"            return obj.to_dict()"},{"line_number":137,"context_line":"        # The default fallback in jsonutils.to_primitive() is six.text_type."},{"line_number":138,"context_line":"        return six.text_type(obj)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def serialize_entity(self, context, entity):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_bd40318c","line":137,"in_reply_to":"3f79a3b5_9af6db2c","updated":"2018-12-15 14:10:33.000000000","message":"Kind of icky to duplicate the default from within a library, though. It would be cleaner to make this return None and let jsonutils.to_primitive set the default.","commit_id":"cd1dfc157b89a2aa53832ebe8a9694b7edc47f6f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a9d10080762cdc5579d222fe75cdd7387be4e6ff","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        if isinstance(obj, nova.context.RequestContext):"},{"line_number":135,"context_line":"            # This matches RequestContextSerializer.serialize_context()."},{"line_number":136,"context_line":"            return obj.to_dict()"},{"line_number":137,"context_line":"        # The default fallback in jsonutils.to_primitive() is six.text_type."},{"line_number":138,"context_line":"        return six.text_type(obj)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def serialize_entity(self, context, entity):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_28d38138","line":137,"in_reply_to":"3f79a3b5_bd40318c","updated":"2018-12-15 17:16:55.000000000","message":"That won\u0027t happen I don\u0027t think. Look at the code:\n\nhttps://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L89\n\nWe\u0027re providing the fallback, so we\u0027ll get here:\n\nhttps://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L185\n\nCall *this* fallback and we just return None we\u0027ll blow up since we didn\u0027t serialize the thing.\n\nUnless I\u0027m not reading this correctly.","commit_id":"cd1dfc157b89a2aa53832ebe8a9694b7edc47f6f"}],"nova/tests/fixtures.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b18afa92eca79315f94ddc57a602781498964038","unresolved":false,"context_lines":[{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        # NOTE(mriedem): Avoid adding anything which tries to convert an"},{"line_number":835,"context_line":"        # object to a primitive which jsonutils.to_primitive() does not know"},{"line_number":836,"context_line":"        # how to handle (or isn\u0027t given a fallback callback)."},{"line_number":837,"context_line":"        warnings.filterwarnings("},{"line_number":838,"context_line":"            \u0027error\u0027,"},{"line_number":839,"context_line":"            message\u003d\"Cannot convert \u003coslo_db.sqlalchemy.enginefacade\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_7dc059f9","line":836,"range":{"start_line":836,"start_character":42,"end_line":836,"end_character":59},"updated":"2018-12-15 14:10:33.000000000","message":"snappy","commit_id":"cd1dfc157b89a2aa53832ebe8a9694b7edc47f6f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a9d10080762cdc5579d222fe75cdd7387be4e6ff","unresolved":false,"context_lines":[{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        # NOTE(mriedem): Avoid adding anything which tries to convert an"},{"line_number":835,"context_line":"        # object to a primitive which jsonutils.to_primitive() does not know"},{"line_number":836,"context_line":"        # how to handle (or isn\u0027t given a fallback callback)."},{"line_number":837,"context_line":"        warnings.filterwarnings("},{"line_number":838,"context_line":"            \u0027error\u0027,"},{"line_number":839,"context_line":"            message\u003d\"Cannot convert \u003coslo_db.sqlalchemy.enginefacade\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a811d1fb","line":836,"range":{"start_line":836,"start_character":42,"end_line":836,"end_character":59},"in_reply_to":"3f79a3b5_7dc059f9","updated":"2018-12-15 17:16:55.000000000","message":"The name of my band in high school.","commit_id":"cd1dfc157b89a2aa53832ebe8a9694b7edc47f6f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8255f8fc06a1ee09d88ba379669bff548eb0d41a","unresolved":false,"context_lines":[{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        # NOTE(mriedem): Avoid adding anything which tries to convert an"},{"line_number":835,"context_line":"        # object to a primitive which jsonutils.to_primitive() does not know"},{"line_number":836,"context_line":"        # how to handle (or isn\u0027t given a fallback callback)."},{"line_number":837,"context_line":"        warnings.filterwarnings("},{"line_number":838,"context_line":"            \u0027error\u0027,"},{"line_number":839,"context_line":"            message\u003d\"Cannot convert \u003coslo_db.sqlalchemy.enginefacade\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_511ada69","line":836,"range":{"start_line":836,"start_character":42,"end_line":836,"end_character":59},"in_reply_to":"3f79a3b5_a811d1fb","updated":"2018-12-19 17:55:01.000000000","message":"lol","commit_id":"cd1dfc157b89a2aa53832ebe8a9694b7edc47f6f"}]}