)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66aef7bd145188a3df7f8e7b41295f03de95b26e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tests for bug #1800511"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Rocky, we started including the MTU for networks all the time,"},{"line_number":10,"context_line":"however this also meant that we started specifying the MTU when"},{"line_number":11,"context_line":"doing live migrations."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_8b01d3b7","line":9,"range":{"start_line":9,"start_character":51,"end_line":9,"end_character":64},"updated":"2018-10-29 19:23:12.000000000","message":"Well, if (1) vif_type is bridge or tap and (2) if libvirt \u003e\u003d 3.3.","commit_id":"bdad0e1b75be9713e5c665f1ac96843e4df3106e"}],"nova/tests/unit/virt/libvirt/test_migration.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66aef7bd145188a3df7f8e7b41295f03de95b26e","unresolved":false,"context_lines":[{"line_number":745,"context_line":"\u003c/domain\u003e\"\"\""},{"line_number":746,"context_line":"        self._test_update_vif_xml(conf, original_xml, expected_xml)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def test_update_vif_xml_to_bridge_without_mtu(self):"},{"line_number":749,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestInterface()"},{"line_number":750,"context_line":"        conf.net_type \u003d \"bridge\""},{"line_number":751,"context_line":"        conf.source_dev \u003d \"qbra188171c-ea\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2bde7f3b","line":748,"updated":"2018-10-29 19:23:12.000000000","message":"A docstring with a description of the test would be useful, since the test here and below are 99% the same. The difference is the original xml doesn\u0027t have an mtu value, and the expected does (but shouldn\u0027t due to the bug). So would be good to note that when starting with a source xml that does not have mtu set, the resulting xml should also not have mtu set.","commit_id":"bdad0e1b75be9713e5c665f1ac96843e4df3106e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"66aef7bd145188a3df7f8e7b41295f03de95b26e","unresolved":false,"context_lines":[{"line_number":791,"context_line":"\u003c/domain\u003e\"\"\""},{"line_number":792,"context_line":"        self._test_update_vif_xml(conf, original_xml, expected_xml)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def test_update_vif_xml_to_bridge_with_mtu(self):"},{"line_number":795,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestInterface()"},{"line_number":796,"context_line":"        conf.net_type \u003d \"bridge\""},{"line_number":797,"context_line":"        conf.source_dev \u003d \"qbra188171c-ea\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ebe3a701","line":794,"updated":"2018-10-29 19:23:12.000000000","message":"Same as above - would be good to have a comment/docstring explanation of the test. In this case, the source xml starts with an mtu value set so its OK for the destination xml to also have mtu set.","commit_id":"bdad0e1b75be9713e5c665f1ac96843e4df3106e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef6c5ab01c199042604b15a0693f4d242bc62cbb","unresolved":false,"context_lines":[{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def test_update_vif_xml_to_bridge_without_mtu(self):"},{"line_number":749,"context_line":"        \"\"\"This test validates _update_vif_xml to make sure it does not add"},{"line_number":750,"context_line":"        MTU to the interface if it does not exist in the source XML.\"\"\""},{"line_number":751,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestInterface()"},{"line_number":752,"context_line":"        conf.net_type \u003d \"bridge\""},{"line_number":753,"context_line":"        conf.source_dev \u003d \"qbra188171c-ea\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f60e2a31","line":750,"range":{"start_line":750,"start_character":68,"end_line":750,"end_character":71},"updated":"2018-10-29 19:56:00.000000000","message":"pep8 is going to complain this this needs to be on a dropped new line below","commit_id":"bd245c2aab9b14951c4aeb7fbdcbb2e86e341dc1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef6c5ab01c199042604b15a0693f4d242bc62cbb","unresolved":false,"context_lines":[{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def test_update_vif_xml_to_bridge_with_mtu(self):"},{"line_number":797,"context_line":"        \"\"\"This test validates _update_vif_xml to make sure it maintains the"},{"line_number":798,"context_line":"        interface MTU if it exists in the source XML\"\"\""},{"line_number":799,"context_line":"        conf \u003d vconfig.LibvirtConfigGuestInterface()"},{"line_number":800,"context_line":"        conf.net_type \u003d \"bridge\""},{"line_number":801,"context_line":"        conf.source_dev \u003d \"qbra188171c-ea\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b6143243","line":798,"range":{"start_line":798,"start_character":52,"end_line":798,"end_character":55},"updated":"2018-10-29 19:56:00.000000000","message":"same","commit_id":"bd245c2aab9b14951c4aeb7fbdcbb2e86e341dc1"}]}