)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1f17a1edc4e63a8999ab78afb0e4cb87c1c6d82b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohammed Naser \u003cmnaser@vexxhost.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-29 19:51:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid setting MTU if none was configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is a live migration of an instance that was launched"},{"line_number":10,"context_line":"before Rocky, it would not have host_mtu defined and therefore"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0b0f032f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":40},"updated":"2018-10-29 19:34:57.000000000","message":"maybe add something about live migration in the summary line?","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"449af273228ddf04c7316df96a0c5545b6bbbbbc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohammed Naser \u003cmnaser@vexxhost.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-29 19:51:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid setting MTU if none was configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is a live migration of an instance that was launched"},{"line_number":10,"context_line":"before Rocky, it would not have host_mtu defined and therefore"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_6b30f754","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":40},"in_reply_to":"3f79a3b5_0b0f032f","updated":"2018-10-29 19:38:09.000000000","message":"And prefix with \"libvirt: \".","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"53f33e538a062e2334fa88b26e2f3edaea2272bb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoid setting MTU if none was configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is a live migration of an instance that was launched"},{"line_number":10,"context_line":"before Rocky, it would not have host_mtu defined and therefore"},{"line_number":11,"context_line":"it wouldn\u0027t have it in the XML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When live migrating, the host_mtu is added which changes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_cbc10b51","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":12},"updated":"2018-10-29 19:31:34.000000000","message":"\"change Iecc265fb25e88fa00a66f1fd38e215cad53e7669\"\n\nLet\u0027s be specific for both context and because ^ was backported to queens so it applies to queens as well.","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"53f33e538a062e2334fa88b26e2f3edaea2272bb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Avoid setting MTU if none was configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is a live migration of an instance that was launched"},{"line_number":10,"context_line":"before Rocky, it would not have host_mtu defined and therefore"},{"line_number":11,"context_line":"it wouldn\u0027t have it in the XML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When live migrating, the host_mtu is added which changes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ab892f25","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":40},"updated":"2018-10-29 19:31:34.000000000","message":"nit: I\u0027m not really sure what \"host_mtu\" is. Is that a config option somewhere? Nova pulls the mtu off the neutron network resource:\n\nhttps://review.openstack.org/#/c/553072/8/nova/virt/libvirt/vif.py@276\n\nMaybe \"host_mtu\" is some neutron config that controls the mtu on the network?","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"53f33e538a062e2334fa88b26e2f3edaea2272bb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"before Rocky, it would not have host_mtu defined and therefore"},{"line_number":11,"context_line":"it wouldn\u0027t have it in the XML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When live migrating, the host_mtu is added which changes the"},{"line_number":14,"context_line":"guest ABI, causing the live migration to fail.  This patch"},{"line_number":15,"context_line":"prevents this by avoiding setting MTU if none is configured."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_cb6fcb5e","line":13,"range":{"start_line":13,"start_character":25,"end_line":13,"end_character":33},"updated":"2018-10-29 19:31:34.000000000","message":"same - is guest/network mtu a better word?","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"53f33e538a062e2334fa88b26e2f3edaea2272bb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"it wouldn\u0027t have it in the XML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When live migrating, the host_mtu is added which changes the"},{"line_number":14,"context_line":"guest ABI, causing the live migration to fail.  This patch"},{"line_number":15,"context_line":"prevents this by avoiding setting MTU if none is configured."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug #1800511"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_8b8b1315","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":9},"updated":"2018-10-29 19:31:34.000000000","message":"Probably good to reference https://bugzilla.redhat.com/show_bug.cgi?id\u003d1449346 here.","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1f17a1edc4e63a8999ab78afb0e4cb87c1c6d82b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When live migrating, the host_mtu is added which changes the"},{"line_number":14,"context_line":"guest ABI, causing the live migration to fail.  This patch"},{"line_number":15,"context_line":"prevents this by avoiding setting MTU if none is configured."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug #1800511"},{"line_number":18,"context_line":"Change-Id: I6e2e6437a7c826dc425d8b353c38670d6eece0b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_eb28877f","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":60},"updated":"2018-10-29 19:34:57.000000000","message":"\"if none is configured\" is ambiguous.  Configured where?","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1f17a1edc4e63a8999ab78afb0e4cb87c1c6d82b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"before Rocky, it would not have host_mtu defined and therefore"},{"line_number":11,"context_line":"it wouldn\u0027t have it in the XML."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"When live migrating, the host_mtu is added which changes the"},{"line_number":14,"context_line":"guest ABI, causing the live migration to fail.  This patch"},{"line_number":15,"context_line":"prevents this by avoiding setting MTU if none is configured."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug #1800511"},{"line_number":18,"context_line":"Change-Id: I6e2e6437a7c826dc425d8b353c38670d6eece0b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ab27efb4","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":60},"updated":"2018-10-29 19:34:57.000000000","message":"maybe add something about what conditions would cause \"host_mtu\" to be added? (Libvirt version, virtio type, etc.)","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"85369182b3db685b1cd4bb1412f5aea71cf5cedc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"occurs when trying to live migrate an instance that:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- Launched before change Iecc265fb25e88fa00a66f1fd38e215cad53e7669"},{"line_number":19,"context_line":"- It has not been hard rebooted (i.e. XML has not changed since)"},{"line_number":20,"context_line":"- It\u0027s using bridge/tap networking"},{"line_number":21,"context_line":"- Migration attempted after change Iecc265fb25e88fa00a66f1fd38e215cad53e7669"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_0b7383e9","line":19,"range":{"start_line":19,"start_character":18,"end_line":19,"end_character":22},"updated":"2018-10-29 19:50:32.000000000","message":"could remove the \"hard\", I think.","commit_id":"aa7b23ab066612f48bcc95a3eaf230fbd8c9c038"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fb1dffe6844d77970227acb7b1193eb1eab5d59","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- Migration attempted after change Iecc265fb25e88fa00a66f1fd38e215cad53e7669"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"This patch prevents this by avoiding setting MTU if the running"},{"line_number":24,"context_line":"instance does not have one configured in it\u0027s domain XML."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1]: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1449346"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_b642f23a","line":24,"range":{"start_line":24,"start_character":41,"end_line":24,"end_character":45},"updated":"2018-10-29 19:57:52.000000000","message":"nit: its (I\u0027m glad I\u0027m not the only person that does this).","commit_id":"db45ef7dd3595deb8ab28afcf4b4d4782f33fe19"}],"nova/virt/libvirt/migration.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"53f33e538a062e2334fa88b26e2f3edaea2272bb","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        LOG.debug(\u0027Updating guest XML with vif config: %s\u0027, conf_xml,"},{"line_number":318,"context_line":"                  instance_uuid\u003dinstance_uuid)"},{"line_number":319,"context_line":"        dest_interface_elem \u003d etree.XML(conf_xml, parser)"},{"line_number":320,"context_line":"        # Save off the hw address, MTU presented to the guest since that can\u0027t"},{"line_number":321,"context_line":"        # change during live migration."},{"line_number":322,"context_line":"        address \u003d interface_dev.find(\u0027address\u0027)"},{"line_number":323,"context_line":"        mtu \u003d interface_dev.find(\u0027mtu\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4b917b44","line":320,"range":{"start_line":320,"start_character":33,"end_line":320,"end_character":34},"updated":"2018-10-29 19:31:34.000000000","message":"nit: \"Save off the hw address and MTU presented...\"\n\nCould also link to https://bugzilla.redhat.com/show_bug.cgi?id\u003d1449346 for the MTU thing - or link it in below where your NOTE lives.","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"d315e49ddce9f1b956380c29737468dcda8ba238","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        LOG.debug(\u0027Updating guest XML with vif config: %s\u0027, conf_xml,"},{"line_number":318,"context_line":"                  instance_uuid\u003dinstance_uuid)"},{"line_number":319,"context_line":"        dest_interface_elem \u003d etree.XML(conf_xml, parser)"},{"line_number":320,"context_line":"        # Save off the hw address, MTU presented to the guest since that can\u0027t"},{"line_number":321,"context_line":"        # change during live migration."},{"line_number":322,"context_line":"        address \u003d interface_dev.find(\u0027address\u0027)"},{"line_number":323,"context_line":"        mtu \u003d interface_dev.find(\u0027mtu\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cb402ba6","line":320,"range":{"start_line":320,"start_character":33,"end_line":320,"end_character":34},"in_reply_to":"3f79a3b5_4b917b44","updated":"2018-10-30 07:14:36.000000000","message":"Done","commit_id":"87493307a467ff75265d681d9d908589e6ac8094"}]}