)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5187db052b882c03dd489524e55d3af70473de00","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        # NOTE(mriedem): cross_cell_move defaults to False so that the"},{"line_number":777,"context_line":"        # scheduler by default selects hosts from the cell specified in the"},{"line_number":778,"context_line":"        # cell field."},{"line_number":779,"context_line":"        \u0027cross_cell_move\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":780,"context_line":"    }"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6804c4c5","line":779,"range":{"start_line":779,"start_character":9,"end_line":779,"end_character":24},"updated":"2018-11-07 14:20:40.000000000","message":"recommend calling this field allow_cross_cell_move or similar to better indicate it\u0027s a request to allow the destination to be on a different cell than the source host.","commit_id":"ea83585f3fdd95e51f0296c86ef0670cefac20bb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bdc52c7b2465580a00ac576e3afb8feceec7f4ac","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        # NOTE(mriedem): cross_cell_move defaults to False so that the"},{"line_number":777,"context_line":"        # scheduler by default selects hosts from the cell specified in the"},{"line_number":778,"context_line":"        # cell field."},{"line_number":779,"context_line":"        \u0027cross_cell_move\u0027: fields.BooleanField(default\u003dFalse),"},{"line_number":780,"context_line":"    }"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_adc35159","line":779,"range":{"start_line":779,"start_character":9,"end_line":779,"end_character":24},"in_reply_to":"3f79a3b5_6804c4c5","updated":"2018-11-30 16:44:01.000000000","message":"Done","commit_id":"ea83585f3fdd95e51f0296c86ef0670cefac20bb"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c45a999c25c94ea29c5bb7ed29b761a8c1935af8","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        if target_version \u003c (1, 3) and \u0027allow_cross_cell_move\u0027 in primitive:"},{"line_number":906,"context_line":"            del primitive[\u0027allow_cross_cell_move\u0027]"},{"line_number":907,"context_line":"        if target_version \u003c (1, 2):"},{"line_number":908,"context_line":"            if \u0027aggregates\u0027 in primitive:"},{"line_number":909,"context_line":"                del primitive[\u0027aggregates\u0027]"},{"line_number":910,"context_line":"        if target_version \u003c (1, 1):"},{"line_number":911,"context_line":"            if \u0027cell\u0027 in primitive:"}],"source_content_type":"text/x-python","patch_set":48,"id":"7faddb67_e6c83a76","line":908,"updated":"2019-08-28 13:57:47.000000000","message":"Unrelated aside: I\u0027d rather we just fixed things like this as we were going, even though they\u0027re no needed, cos local consistency","commit_id":"656f53edc1dd7f01951f76598757478cf8260b55"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c5c110cd59f09e9a1108696665fda86ae4c63990","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        if target_version \u003c (1, 3) and \u0027allow_cross_cell_move\u0027 in primitive:"},{"line_number":906,"context_line":"            del primitive[\u0027allow_cross_cell_move\u0027]"},{"line_number":907,"context_line":"        if target_version \u003c (1, 2):"},{"line_number":908,"context_line":"            if \u0027aggregates\u0027 in primitive:"},{"line_number":909,"context_line":"                del primitive[\u0027aggregates\u0027]"},{"line_number":910,"context_line":"        if target_version \u003c (1, 1):"},{"line_number":911,"context_line":"            if \u0027cell\u0027 in primitive:"}],"source_content_type":"text/x-python","patch_set":48,"id":"7faddb67_8148505c","line":908,"in_reply_to":"7faddb67_c6d89ef1","updated":"2019-08-28 14:27:43.000000000","message":"\u003e But I guess you\u0027re looking for consistency within the same method.\n\nYup, just that. It\u0027s purely a style thing","commit_id":"656f53edc1dd7f01951f76598757478cf8260b55"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6abb17f9b471bde0358aaffe16f23cf5323eb4f6","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        if target_version \u003c (1, 3) and \u0027allow_cross_cell_move\u0027 in primitive:"},{"line_number":906,"context_line":"            del primitive[\u0027allow_cross_cell_move\u0027]"},{"line_number":907,"context_line":"        if target_version \u003c (1, 2):"},{"line_number":908,"context_line":"            if \u0027aggregates\u0027 in primitive:"},{"line_number":909,"context_line":"                del primitive[\u0027aggregates\u0027]"},{"line_number":910,"context_line":"        if target_version \u003c (1, 1):"},{"line_number":911,"context_line":"            if \u0027cell\u0027 in primitive:"}],"source_content_type":"text/x-python","patch_set":48,"id":"7faddb67_c6d89ef1","line":908,"in_reply_to":"7faddb67_e6c83a76","updated":"2019-08-28 14:13:19.000000000","message":"You mean doing the \u0027in\u0027 check on the same conditional line with an \u0027and\u0027? Meh, that\u0027s just a style nit of mine. Some of these (I\u0027m pretty sure anyway) just check the version and then do a pop rather than a del without the \u0027in\u0027 check, e.g.:\n\nif target_version \u003c (1, 3):\n    primitive.pop(\u0027allow_cross_cell_move\u0027, None)\n\nBut I guess you\u0027re looking for consistency within the same method.","commit_id":"656f53edc1dd7f01951f76598757478cf8260b55"}]}