)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"641cdf88db9f962c9208fbd88fedde5ae8447676","unresolved":false,"context_lines":[{"line_number":18,"context_line":"since we want to do all we can before updating the instance in case"},{"line_number":19,"context_line":"we fail."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"There is one remaining compatibility shim for RequestSpec.from_components"},{"line_number":22,"context_line":"which is due to nova-compute not passing the RequestSpec back to the"},{"line_number":23,"context_line":"cell conductor during a resize reschedule. That will be cleaned up in"},{"line_number":24,"context_line":"a later change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_8084d7b0","line":21,"updated":"2018-12-17 17:03:23.000000000","message":"Forgot about unshelve:\n\nhttps://github.com/openstack/nova/blob/af9977c71c45aa3228a416bad9f9c5de835839fb/nova/conductor/manager.py#L797\n\nDo that separately.","commit_id":"6368aee1d6fddd7bd611e67f04c3fae166851109"}],"nova/compute/api.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8a985308022befdd7b20c92b17c90bde2a1dc69e","unresolved":false,"context_lines":[{"line_number":3625,"context_line":"        # by compute."},{"line_number":3626,"context_line":"        scheduler_hint \u003d {\u0027filter_properties\u0027: filter_properties}"},{"line_number":3627,"context_line":""},{"line_number":3628,"context_line":"        if request_spec:"},{"line_number":3629,"context_line":"            if host_name is None:"},{"line_number":3630,"context_line":"                # If \u0027host_name\u0027 is not specified,"},{"line_number":3631,"context_line":"                # clear the \u0027requested_destination\u0027 field of the RequestSpec."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_99044613","line":3628,"range":{"start_line":3628,"start_character":8,"end_line":3628,"end_character":24},"updated":"2018-12-18 06:14:55.000000000","message":"This \u0027if\u0027 can be removed.","commit_id":"4224afc5850e7969ff3df3e1218aebfffc8887f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1f3cf8fd82f12dd115340ff632b718f03f98e54","unresolved":false,"context_lines":[{"line_number":3625,"context_line":"        # by compute."},{"line_number":3626,"context_line":"        scheduler_hint \u003d {\u0027filter_properties\u0027: filter_properties}"},{"line_number":3627,"context_line":""},{"line_number":3628,"context_line":"        if request_spec:"},{"line_number":3629,"context_line":"            if host_name is None:"},{"line_number":3630,"context_line":"                # If \u0027host_name\u0027 is not specified,"},{"line_number":3631,"context_line":"                # clear the \u0027requested_destination\u0027 field of the RequestSpec."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9876750a","line":3628,"range":{"start_line":3628,"start_character":8,"end_line":3628,"end_character":24},"in_reply_to":"3f79a3b5_99044613","updated":"2018-12-18 15:24:10.000000000","message":"Nice catch.","commit_id":"4224afc5850e7969ff3df3e1218aebfffc8887f3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8a985308022befdd7b20c92b17c90bde2a1dc69e","unresolved":false,"context_lines":[{"line_number":4489,"context_line":"            # compute per service but doesn\u0027t support live migrations,"},{"line_number":4490,"context_line":"            # let\u0027s provide the first one."},{"line_number":4491,"context_line":"            target \u003d nodes[0]"},{"line_number":4492,"context_line":"            if request_spec:"},{"line_number":4493,"context_line":"                # TODO(sbauza): Hydrate a fake spec for old instances not yet"},{"line_number":4494,"context_line":"                # having a request spec attached to them (particularly true for"},{"line_number":4495,"context_line":"                # cells v1). For the moment, let\u0027s keep the same behaviour for"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_19f9161a","line":4492,"range":{"start_line":4492,"start_character":12,"end_line":4492,"end_character":28},"updated":"2018-12-18 06:14:55.000000000","message":"This \u0027if\u0027 can be removed.","commit_id":"4224afc5850e7969ff3df3e1218aebfffc8887f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1f3cf8fd82f12dd115340ff632b718f03f98e54","unresolved":false,"context_lines":[{"line_number":4489,"context_line":"            # compute per service but doesn\u0027t support live migrations,"},{"line_number":4490,"context_line":"            # let\u0027s provide the first one."},{"line_number":4491,"context_line":"            target \u003d nodes[0]"},{"line_number":4492,"context_line":"            if request_spec:"},{"line_number":4493,"context_line":"                # TODO(sbauza): Hydrate a fake spec for old instances not yet"},{"line_number":4494,"context_line":"                # having a request spec attached to them (particularly true for"},{"line_number":4495,"context_line":"                # cells v1). For the moment, let\u0027s keep the same behaviour for"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b87b31f0","line":4492,"range":{"start_line":4492,"start_character":12,"end_line":4492,"end_character":28},"in_reply_to":"3f79a3b5_19f9161a","updated":"2018-12-18 15:24:10.000000000","message":"Done","commit_id":"4224afc5850e7969ff3df3e1218aebfffc8887f3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8a985308022befdd7b20c92b17c90bde2a1dc69e","unresolved":false,"context_lines":[{"line_number":4661,"context_line":"            # compute per service but doesn\u0027t support evacuations,"},{"line_number":4662,"context_line":"            # let\u0027s provide the first one."},{"line_number":4663,"context_line":"            target \u003d nodes[0]"},{"line_number":4664,"context_line":"            if request_spec:"},{"line_number":4665,"context_line":"                # TODO(sbauza): Hydrate a fake spec for old instances not yet"},{"line_number":4666,"context_line":"                # having a request spec attached to them (particularly true for"},{"line_number":4667,"context_line":"                # cells v1). For the moment, let\u0027s keep the same behaviour for"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8704e21b","line":4664,"range":{"start_line":4664,"start_character":12,"end_line":4664,"end_character":28},"updated":"2018-12-18 06:14:55.000000000","message":"This \u0027if\u0027 can be removed","commit_id":"4224afc5850e7969ff3df3e1218aebfffc8887f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f1f3cf8fd82f12dd115340ff632b718f03f98e54","unresolved":false,"context_lines":[{"line_number":4661,"context_line":"            # compute per service but doesn\u0027t support evacuations,"},{"line_number":4662,"context_line":"            # let\u0027s provide the first one."},{"line_number":4663,"context_line":"            target \u003d nodes[0]"},{"line_number":4664,"context_line":"            if request_spec:"},{"line_number":4665,"context_line":"                # TODO(sbauza): Hydrate a fake spec for old instances not yet"},{"line_number":4666,"context_line":"                # having a request spec attached to them (particularly true for"},{"line_number":4667,"context_line":"                # cells v1). For the moment, let\u0027s keep the same behaviour for"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_58645d4e","line":4664,"range":{"start_line":4664,"start_character":12,"end_line":4664,"end_character":28},"in_reply_to":"3f79a3b5_8704e21b","updated":"2018-12-18 15:24:10.000000000","message":"Done","commit_id":"4224afc5850e7969ff3df3e1218aebfffc8887f3"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"756149956c0565150c371b8246c216b3c3370363","unresolved":false,"context_lines":[{"line_number":8979,"context_line":"        self.assertIn(\u0027Unable to find root block device mapping for \u0027"},{"line_number":8980,"context_line":"                      \u0027volume-backed instance\u0027, six.text_type(ex))"},{"line_number":8981,"context_line":""},{"line_number":8982,"context_line":"    @mock.patch(\u0027nova.objects.RequestSpec\u0027)"},{"line_number":8983,"context_line":"    def test_rebuild_with_deleted_image(self, mock_reqspec):"},{"line_number":8984,"context_line":"        # If we\u0027re given a deleted image by glance, we should not be able to"},{"line_number":8985,"context_line":"        # rebuild from it"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_d9fdcf70","line":8982,"range":{"start_line":8982,"start_character":4,"end_line":8982,"end_character":43},"updated":"2018-12-18 17:31:05.000000000","message":"Something I learned from melwitt: if you add a \u0027new\u003dmock.Mock\u0027  argument here, you don\u0027t need to pass an argument to the function. Maybe useful if you need to rework this.","commit_id":"52d515ba7dbb22433d8fceeafd3bc045aa2781ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3d3efc5e6decaebe6be2584794254b03609eef7c","unresolved":false,"context_lines":[{"line_number":8979,"context_line":"        self.assertIn(\u0027Unable to find root block device mapping for \u0027"},{"line_number":8980,"context_line":"                      \u0027volume-backed instance\u0027, six.text_type(ex))"},{"line_number":8981,"context_line":""},{"line_number":8982,"context_line":"    @mock.patch(\u0027nova.objects.RequestSpec\u0027)"},{"line_number":8983,"context_line":"    def test_rebuild_with_deleted_image(self, mock_reqspec):"},{"line_number":8984,"context_line":"        # If we\u0027re given a deleted image by glance, we should not be able to"},{"line_number":8985,"context_line":"        # rebuild from it"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_24929757","line":8982,"range":{"start_line":8982,"start_character":4,"end_line":8982,"end_character":43},"in_reply_to":"3f79a3b5_d9fdcf70","updated":"2018-12-18 20:51:24.000000000","message":"Eric has mentioned that to me forever, but meh.","commit_id":"52d515ba7dbb22433d8fceeafd3bc045aa2781ac"}]}