)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"4e86dfcd281532d28afb6d0bb13221552fd8bdb4","unresolved":false,"context_lines":[{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"    1. Create a server successfully."},{"line_number":2043,"context_line":"    2. Using the fixture, list/show servers. Depending on the microversion"},{"line_number":2044,"context_line":"       used, the API should either return minimal results or return an error."},{"line_number":2045,"context_line":""},{"line_number":2046,"context_line":"    Example usage::"},{"line_number":2047,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_31278969","line":2044,"range":{"start_line":2044,"start_character":61,"end_line":2044,"end_character":76},"updated":"2018-11-01 17:00:30.000000000","message":"by default would skip the results from down cells.","commit_id":"4dc9b75b0d44b0a0cd3253e5b673f1b8f1c01e0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3a1af7c2153408452317bfd2ff7410be7bc7222d","unresolved":false,"context_lines":[{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"    1. Create a server successfully."},{"line_number":2043,"context_line":"    2. Using the fixture, list/show servers. Depending on the microversion"},{"line_number":2044,"context_line":"       used, the API should either return minimal results or return an error."},{"line_number":2045,"context_line":""},{"line_number":2046,"context_line":"    Example usage::"},{"line_number":2047,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_943e8b24","line":2044,"range":{"start_line":2044,"start_character":61,"end_line":2044,"end_character":76},"in_reply_to":"3f79a3b5_31278969","updated":"2018-11-01 18:08:38.000000000","message":"Good point, I guess I was thinking about this option:\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#api.list_records_by_skipping_down_cells","commit_id":"4dc9b75b0d44b0a0cd3253e5b673f1b8f1c01e0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5c23881bced35044748bcbd5f86d7a9b8b36c100","unresolved":false,"context_lines":[{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"    1. Create a server successfully."},{"line_number":2043,"context_line":"    2. Using the fixture, list/show servers. Depending on the microversion"},{"line_number":2044,"context_line":"       used, the API should either return minimal results or return an error."},{"line_number":2045,"context_line":""},{"line_number":2046,"context_line":"    Example usage::"},{"line_number":2047,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e132140e","line":2044,"range":{"start_line":2044,"start_character":61,"end_line":2044,"end_character":76},"in_reply_to":"3f79a3b5_943e8b24","updated":"2018-11-08 15:51:34.000000000","message":"Done","commit_id":"4dc9b75b0d44b0a0cd3253e5b673f1b8f1c01e0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c7af1a0cb0712306000beed15e82272d54828d9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"from nova import quota as nova_quota"},{"line_number":57,"context_line":"from nova import rpc"},{"line_number":58,"context_line":"from nova import service"},{"line_number":59,"context_line":"from nova import test"},{"line_number":60,"context_line":"from nova.tests.functional.api import client"},{"line_number":61,"context_line":"from nova.tests.functional.api.openstack.placement.fixtures import placement"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_db198e76","line":59,"range":{"start_line":59,"start_character":17,"end_line":59,"end_character":21},"updated":"2018-11-16 06:49:46.000000000","message":"Apparently this causes issues so need to use some other kind of exception.","commit_id":"88059f6d09ae845577127ca4885ab80ff02f4395"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c92d9850f34898185509b39105fcf2f4d18287fd","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"                # are considered as down cells."},{"line_number":2073,"context_line":"                self.down_cell_mappings \u003d cell_mappings"},{"line_number":2074,"context_line":"            else:"},{"line_number":2075,"context_line":"                # user has passed down cell mappings, so the rest of the cells"},{"line_number":2076,"context_line":"                # should be up meaning we should return the right results."},{"line_number":2077,"context_line":"                # We assume that down cells will be a subset of the"},{"line_number":2078,"context_line":"                # cell_mappings."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_43edd021","line":2075,"updated":"2018-12-11 23:36:14.000000000","message":"This isn\u0027t tested in the unit test for the fixture at all. We should have a wrinkle for that in the test.","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"87344812c1f6d6f9acd5946531378ac2e07304ab","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"                # are considered as down cells."},{"line_number":2073,"context_line":"                self.down_cell_mappings \u003d cell_mappings"},{"line_number":2074,"context_line":"            else:"},{"line_number":2075,"context_line":"                # user has passed down cell mappings, so the rest of the cells"},{"line_number":2076,"context_line":"                # should be up meaning we should return the right results."},{"line_number":2077,"context_line":"                # We assume that down cells will be a subset of the"},{"line_number":2078,"context_line":"                # cell_mappings."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_6936a3b5","line":2075,"in_reply_to":"3f79a3b5_43edd021","updated":"2018-12-12 11:59:17.000000000","message":"ok I will add a test for this in the fixture itself,","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c92d9850f34898185509b39105fcf2f4d18287fd","unresolved":false,"context_lines":[{"line_number":2082,"context_line":"                    for cell in cell_mappings"},{"line_number":2083,"context_line":"                        if cell.uuid not in down_cell_uuids]"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"            def wrap(uuid, thing):"},{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_03a118f5","line":2085,"range":{"start_line":2085,"start_character":21,"end_line":2085,"end_character":25},"updated":"2018-12-11 23:36:14.000000000","message":"Name this arg cell_uuid.","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"88d93d2945bba270daf6c32dc3091ab5eb998a43","unresolved":false,"context_lines":[{"line_number":2082,"context_line":"                    for cell in cell_mappings"},{"line_number":2083,"context_line":"                        if cell.uuid not in down_cell_uuids]"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"            def wrap(uuid, thing):"},{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_9d3ab993","line":2085,"updated":"2018-12-07 10:12:03.000000000","message":"This level of nesting is a bit too much to my taste but I was able to follow along so I can live with it.","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c92d9850f34898185509b39105fcf2f4d18287fd","unresolved":false,"context_lines":[{"line_number":2082,"context_line":"                    for cell in cell_mappings"},{"line_number":2083,"context_line":"                        if cell.uuid not in down_cell_uuids]"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"            def wrap(uuid, thing):"},{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_a84e038f","line":2085,"in_reply_to":"3f79a3b5_9d3ab993","updated":"2018-12-11 23:36:14.000000000","message":"Yeah at least documenting this with a comment would be good (Surya added it so I\u0027m not sure what it\u0027s for).","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"87344812c1f6d6f9acd5946531378ac2e07304ab","unresolved":false,"context_lines":[{"line_number":2082,"context_line":"                    for cell in cell_mappings"},{"line_number":2083,"context_line":"                        if cell.uuid not in down_cell_uuids]"},{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"            def wrap(uuid, thing):"},{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_e9b4f320","line":2085,"in_reply_to":"3f79a3b5_a84e038f","updated":"2018-12-12 11:59:17.000000000","message":"Done","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c92d9850f34898185509b39105fcf2f4d18287fd","unresolved":false,"context_lines":[{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"            def wrap(uuid, thing):"},{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"            if fn is multi_cell_list.query_wrapper:"},{"line_number":2090,"context_line":"                ret1 \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_c8f9ff1d","line":2087,"range":{"start_line":2087,"start_character":59,"end_line":2087,"end_character":68},"updated":"2018-12-11 23:36:14.000000000","message":"This should be a RecordSortContext and what you\u0027re passing here is a RequestContext...so if this gets used it will probably blow up in weird ways. Maybe just pass a RecordSortContext with two empty lists for sort_keys/dirs? Maybe this doesn\u0027t matter because the _db_record would always be DBError here so we wouldn\u0027t actually try to sort records?","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"87344812c1f6d6f9acd5946531378ac2e07304ab","unresolved":false,"context_lines":[{"line_number":2084,"context_line":""},{"line_number":2085,"context_line":"            def wrap(uuid, thing):"},{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"            if fn is multi_cell_list.query_wrapper:"},{"line_number":2090,"context_line":"                ret1 \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_29bbcb11","line":2087,"range":{"start_line":2087,"start_character":59,"end_line":2087,"end_character":68},"in_reply_to":"3f79a3b5_c8f9ff1d","updated":"2018-12-12 11:59:17.000000000","message":"exactly why I did not bother much with the context, but I will change this to a proper way then.","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c92d9850f34898185509b39105fcf2f4d18287fd","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"            if fn is multi_cell_list.query_wrapper:"},{"line_number":2090,"context_line":"                ret1 \u003d {"},{"line_number":2091,"context_line":"                    cell_mapping.uuid: [wrap(cell_mapping.uuid,"},{"line_number":2092,"context_line":"                        db_exc.DBError())]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_882b0799","line":2089,"updated":"2018-12-11 23:36:14.000000000","message":"We really need documentation for this code and why it\u0027s needed.","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"87344812c1f6d6f9acd5946531378ac2e07304ab","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"                ctxt.cell_uuid \u003d uuid"},{"line_number":2087,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, self.ctxt, thing)"},{"line_number":2088,"context_line":""},{"line_number":2089,"context_line":"            if fn is multi_cell_list.query_wrapper:"},{"line_number":2090,"context_line":"                ret1 \u003d {"},{"line_number":2091,"context_line":"                    cell_mapping.uuid: [wrap(cell_mapping.uuid,"},{"line_number":2092,"context_line":"                        db_exc.DBError())]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f79a3b5_49b88712","line":2089,"in_reply_to":"3f79a3b5_882b0799","updated":"2018-12-12 11:59:17.000000000","message":"Done","commit_id":"20a580b81729baf7d710a986fc07d6b3bfe2e76b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9a1f840d9d654434f142bf29c69bba3c55fc5b9","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"                # wrapping since its used to calcualte the cells_timed_out and"},{"line_number":2087,"context_line":"                # cells_failed properties in the object."},{"line_number":2088,"context_line":"                ctxt.cell_uuid \u003d cell_uuid"},{"line_number":2089,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, sort_ctx, thing)"},{"line_number":2090,"context_line":""},{"line_number":2091,"context_line":"            if fn is multi_cell_list.query_wrapper:"},{"line_number":2092,"context_line":"                # If the function called through scatter-gather utility is the"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_7fd06df6","line":2089,"range":{"start_line":2089,"start_character":59,"end_line":2089,"end_character":67},"updated":"2018-12-13 19:53:03.000000000","message":"nit: confusing that this is used here but declared below, but such is python.","commit_id":"511c50ad086063d39fed0404ad5766fa72518118"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"33a96ee70eb80f0054559ae62339c2b8b44f9fc1","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"                # wrapping since its used to calcualte the cells_timed_out and"},{"line_number":2087,"context_line":"                # cells_failed properties in the object."},{"line_number":2088,"context_line":"                ctxt.cell_uuid \u003d cell_uuid"},{"line_number":2089,"context_line":"                return multi_cell_list.RecordWrapper(ctxt, sort_ctx, thing)"},{"line_number":2090,"context_line":""},{"line_number":2091,"context_line":"            if fn is multi_cell_list.query_wrapper:"},{"line_number":2092,"context_line":"                # If the function called through scatter-gather utility is the"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f79a3b5_56a30c46","line":2089,"range":{"start_line":2089,"start_character":59,"end_line":2089,"end_character":67},"in_reply_to":"3f79a3b5_7fd06df6","updated":"2018-12-14 13:04:33.000000000","message":"we could even pass that to wrap as a parameter if we want, but meh.","commit_id":"511c50ad086063d39fed0404ad5766fa72518118"}]}