)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ed0c2c2bd0859d00d13c18bf737a6fe83aec026c","unresolved":false,"context_lines":[{"line_number":2420,"context_line":"                else:"},{"line_number":2421,"context_line":"                    raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2422,"context_line":"        else:"},{"line_number":2423,"context_line":"            LOG.error(\u0027No instance_mappings record found in the API DB \u0027"},{"line_number":2424,"context_line":"                      \u0027for instance.\u0027, instance_uuid\u003dinstance_uuid)"},{"line_number":2425,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2426,"context_line":""},{"line_number":2427,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ff1a1617","line":2424,"range":{"start_line":2423,"start_character":12,"end_line":2424,"end_character":67},"updated":"2018-11-02 22:00:55.000000000","message":"I suppose this could give a hint, like \"have you run nova-manage cell_v2 map_instances?\".","commit_id":"ba2b7a355e859de76b53eb263fc92ad7455ec829"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9d1640462ccfce5a1235495cfc74c7af79ab8c24","unresolved":false,"context_lines":[{"line_number":2420,"context_line":"                else:"},{"line_number":2421,"context_line":"                    raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2422,"context_line":"        else:"},{"line_number":2423,"context_line":"            LOG.error(\u0027No instance_mappings record found in the API DB \u0027"},{"line_number":2424,"context_line":"                      \u0027for instance.\u0027, instance_uuid\u003dinstance_uuid)"},{"line_number":2425,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2426,"context_line":""},{"line_number":2427,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1f891228","line":2424,"range":{"start_line":2423,"start_character":12,"end_line":2424,"end_character":67},"in_reply_to":"3f79a3b5_7f9a8675","updated":"2018-11-02 22:04:21.000000000","message":"Well, we don\u0027t delete the instance mapping until the instance is archive/purged from the database, so the instance mapping would be around until then, but if you are trying to show details on a server that is gone and you\u0027ve archived/purged the DB, we shouldn\u0027t error in that case.","commit_id":"ba2b7a355e859de76b53eb263fc92ad7455ec829"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b235170b266581f4bbb80b84ede61304b37d1f96","unresolved":false,"context_lines":[{"line_number":2420,"context_line":"                else:"},{"line_number":2421,"context_line":"                    raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2422,"context_line":"        else:"},{"line_number":2423,"context_line":"            LOG.error(\u0027No instance_mappings record found in the API DB \u0027"},{"line_number":2424,"context_line":"                      \u0027for instance.\u0027, instance_uuid\u003dinstance_uuid)"},{"line_number":2425,"context_line":"            raise exception.InstanceNotFound(instance_id\u003dinstance_uuid)"},{"line_number":2426,"context_line":""},{"line_number":2427,"context_line":"        return instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7f9a8675","line":2424,"range":{"start_line":2423,"start_character":12,"end_line":2424,"end_character":67},"in_reply_to":"3f79a3b5_ff1a1617","updated":"2018-11-02 22:02:54.000000000","message":"Actually it\u0027s probably wrong to log an error here because it could just be a case of someone looking for an instance that does not exist, like polling for it to be gone.","commit_id":"ba2b7a355e859de76b53eb263fc92ad7455ec829"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf5826336d1de6670b135d862f3a21fb8784160e","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"        \"\"\""},{"line_number":1822,"context_line":"        deleted \u003d self._attempt_delete_of_buildrequest(context, instance)"},{"line_number":1823,"context_line":""},{"line_number":1824,"context_line":"        # After service version 15 deletion of the BuildRequest will halt the"},{"line_number":1825,"context_line":"        # build process in the conductor. In that case run the rest of this"},{"line_number":1826,"context_line":"        # method and consider the instance deleted. If we have not yet reached"},{"line_number":1827,"context_line":"        # service version 15 then just return False so the rest of the delete"},{"line_number":1828,"context_line":"        # process will proceed usually."},{"line_number":1829,"context_line":"        service_version \u003d objects.Service.get_minimum_version("},{"line_number":1830,"context_line":"            context, \u0027nova-osapi_compute\u0027)"},{"line_number":1831,"context_line":"        if service_version \u003c 15:"},{"line_number":1832,"context_line":"            return False"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":"        if deleted:"},{"line_number":1835,"context_line":"            # If we\u0027ve reached this block the successful deletion of the"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_83612f3f","line":1832,"range":{"start_line":1824,"start_character":8,"end_line":1832,"end_character":24},"updated":"2018-11-05 20:53:04.000000000","message":"This could probably also be cleaned up, but maybe in a follow up change.","commit_id":"485e4822943d9ed1231f7dfb1f486de694811065"}],"releasenotes/notes/compute-api-get-service-version-cellsv2-compat-e6451c99afc67836.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"00486c7291fa485c27117635e9982efa085ad4b6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pre-cells v2 compatibility code which was used to lookup a server without"},{"line_number":5,"context_line":"    an associated instance mapping record in the API database has been removed."},{"line_number":6,"context_line":"    As a result, ensure all existing instances been \"mapped\" to a cell before"},{"line_number":7,"context_line":"    upgrading to Stein. The ``nova-manage cell_v2 map_instances`` command is"},{"line_number":8,"context_line":"    used to map existing instances to cells. And the"},{"line_number":9,"context_line":"    ``nova-manage cell_v2 verify_instance`` command can be used to verify"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_6bca6c18","line":6,"range":{"start_line":6,"start_character":47,"end_line":6,"end_character":51},"updated":"2018-12-07 20:42:46.000000000","message":"have been","commit_id":"485e4822943d9ed1231f7dfb1f486de694811065"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b410f3285f733f9315d6d7d9ae54b83d12b8746e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    used to map existing instances to cells. And the"},{"line_number":9,"context_line":"    ``nova-manage cell_v2 verify_instance`` command can be used to verify"},{"line_number":10,"context_line":"    an instance is mapped to a cell. Details on those commands can be found"},{"line_number":11,"context_line":"    here: https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-cells-v2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_abd0842b","line":11,"updated":"2018-12-07 20:10:45.000000000","message":"So, in reality this (mapping) has been required for a while now for lots of other stuff not to be broken, right? The way this reads, we\u0027re introducing something now which isn\u0027t really how I see it. Is it worth re-wording this to just say we\u0027re dropping some no-long-valid compat code that was around for bridging the gap, but which hasn\u0027t been legit for a while? Am I being too OCD?","commit_id":"485e4822943d9ed1231f7dfb1f486de694811065"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"00486c7291fa485c27117635e9982efa085ad4b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    used to map existing instances to cells. And the"},{"line_number":9,"context_line":"    ``nova-manage cell_v2 verify_instance`` command can be used to verify"},{"line_number":10,"context_line":"    an instance is mapped to a cell. Details on those commands can be found"},{"line_number":11,"context_line":"    here: https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-cells-v2"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_8be8287e","line":11,"in_reply_to":"3f79a3b5_abd0842b","updated":"2018-12-07 20:42:46.000000000","message":"As in, we could have dropped this code in Pike when the API was cells aware via instance mappings? Yeah I could probably buy that. If anything, this is more about fixing bug 1759316 for having old data around than anything than you should hit in Stein by this point. I\u0027m OK to drop the release note if it\u0027s more confusing than it\u0027s worth.","commit_id":"485e4822943d9ed1231f7dfb1f486de694811065"}]}