)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c8bd8d3364c79690a079cb29c7cd480b4350b8d","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Inventories are still refreshed in a different code path."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"A subsequent patch will be submitted to allow manual refresh by sending"},{"line_number":16,"context_line":"SIGHUP to the compute process."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iec33e656491848b26686fbf6fb5db4a4c94b9ea8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_7c0fbfd3","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":30},"updated":"2018-11-06 15:23:44.000000000","message":"Can\u0027t we just hook this into the mutable config stuff we already have in the compute for debug and a couple of the live migration options (like live_migration_completion_timeout)?\n\nhttps://docs.openstack.org/oslo.config/latest/reference/mutable.html\n\nIn other words, I think all you have to do is set mutable\u003dTrue on the option and then SIGHUP the process and you get it for free.","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2215491651883601c7906db82d900e84d4dcb8b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Inventories are still refreshed in a different code path."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"A subsequent patch will be submitted to allow manual refresh by sending"},{"line_number":16,"context_line":"SIGHUP to the compute process."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iec33e656491848b26686fbf6fb5db4a4c94b9ea8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a50a1a1b","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":30},"in_reply_to":"3f79a3b5_7c0fbfd3","updated":"2018-11-06 17:06:21.000000000","message":"As discussed: Yes, I added mutable\u003dTrue, good call; but we do still need the ability to clear the cache explicitly.","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"}],"nova/conf/compute.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d12fb862f6119a45f6f29e31d3ef30efc83309c6","unresolved":false,"context_lines":[{"line_number":649,"context_line":"* ``shutdown_timeout``"},{"line_number":650,"context_line":"\"\"\"),"},{"line_number":651,"context_line":"    cfg.IntOpt(\u0027resource_provider_association_refresh\u0027,"},{"line_number":652,"context_line":"        default\u003d300,"},{"line_number":653,"context_line":"        min\u003d0,"},{"line_number":654,"context_line":"        help\u003d\"\"\""},{"line_number":655,"context_line":"Interval for updating nova-compute-side cache of the compute node resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3c8f0723","line":652,"range":{"start_line":652,"start_character":16,"end_line":652,"end_character":19},"updated":"2018-11-06 15:30:35.000000000","message":"Can we just make the default 0 for new installs? To Jay\u0027s point, we might not really need the aggressive caching at all, and in a \u0027normal\u0027 environment the inventory on the host shouldn\u0027t be changing that often - they can restart the service (or SIGHUP it) if it does I guess. The default should match the normal case, in other words. That would require an upgrade reno, but that seems OK.","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2215491651883601c7906db82d900e84d4dcb8b","unresolved":false,"context_lines":[{"line_number":649,"context_line":"* ``shutdown_timeout``"},{"line_number":650,"context_line":"\"\"\"),"},{"line_number":651,"context_line":"    cfg.IntOpt(\u0027resource_provider_association_refresh\u0027,"},{"line_number":652,"context_line":"        default\u003d300,"},{"line_number":653,"context_line":"        min\u003d0,"},{"line_number":654,"context_line":"        help\u003d\"\"\""},{"line_number":655,"context_line":"Interval for updating nova-compute-side cache of the compute node resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8536fee7","line":652,"range":{"start_line":652,"start_character":16,"end_line":652,"end_character":19},"in_reply_to":"3f79a3b5_3c8f0723","updated":"2018-11-06 17:06:21.000000000","message":"I think I would still rather do that in a separate patch so we can ask a couple of deployments to try this out before we commit to it being the default. If it seems to have legs, perhaps we can get rid of the option entirely at that point? In any case, that\u0027s a controversial enough thing that I would rather not muddy this patch with it if that\u0027s okay.","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d12fb862f6119a45f6f29e31d3ef30efc83309c6","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        default\u003d300,"},{"line_number":653,"context_line":"        min\u003d0,"},{"line_number":654,"context_line":"        help\u003d\"\"\""},{"line_number":655,"context_line":"Interval for updating nova-compute-side cache of the compute node resource"},{"line_number":656,"context_line":"provider\u0027s aggregates and traits info."},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"This option specifies the number of seconds between attempts to update a"},{"line_number":659,"context_line":"provider\u0027s aggregates and traits information in the local cache of the compute"},{"line_number":660,"context_line":"node."},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"A value of zero disables cache refresh completely."},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fcad0f83","line":660,"range":{"start_line":655,"start_character":0,"end_line":660,"end_character":5},"updated":"2018-11-06 15:30:35.000000000","message":"To Tetsuro\u0027s point in the release note, I\u0027m not sure how much operators would read this and understand the implications.  For example, the compute service doesn\u0027t use aggregates information yet, so they shouldn\u0027t care about that. As for traits, that might matter if they are externally setting traits on compute node resource providers in placement for scheduling decisions. IOW, we should probably try to describe the use cases this is related to rather than \"this refreshes some stuff in the compute but you don\u0027t really know how that stuff is used, or if you should care\".","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2215491651883601c7906db82d900e84d4dcb8b","unresolved":false,"context_lines":[{"line_number":652,"context_line":"        default\u003d300,"},{"line_number":653,"context_line":"        min\u003d0,"},{"line_number":654,"context_line":"        help\u003d\"\"\""},{"line_number":655,"context_line":"Interval for updating nova-compute-side cache of the compute node resource"},{"line_number":656,"context_line":"provider\u0027s aggregates and traits info."},{"line_number":657,"context_line":""},{"line_number":658,"context_line":"This option specifies the number of seconds between attempts to update a"},{"line_number":659,"context_line":"provider\u0027s aggregates and traits information in the local cache of the compute"},{"line_number":660,"context_line":"node."},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"A value of zero disables cache refresh completely."},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4541c636","line":660,"range":{"start_line":655,"start_character":0,"end_line":660,"end_character":5},"in_reply_to":"3f79a3b5_fcad0f83","updated":"2018-11-06 17:06:21.000000000","message":"I don\u0027t disagree. But IMO that would also be a separate patch. And whatever we do there would depend greatly on what we decide for the big picture here (make 0 the default? Kill the refresh entirely? Keep the inventory refresh when we kill the rest? Etc.)","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0dc12b2655dd78c4ae4dc8ac7b14e1f2fa739ae","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        set or is more than CONF.compute.resource_provider_association_refresh"},{"line_number":849,"context_line":"        seconds ago."},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        Always False if CONF.compute.resource_provider_association_refresh is"},{"line_number":852,"context_line":"        zero."},{"line_number":853,"context_line":"        \"\"\""},{"line_number":854,"context_line":"        rpar \u003d CONF.compute.resource_provider_association_refresh"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_234d8d6f","line":851,"range":{"start_line":851,"start_character":15,"end_line":851,"end_character":20},"updated":"2018-11-07 14:55:47.000000000","message":"nit: \"Always returns False\"","commit_id":"11a5fcbb6a3302c581f763776496d0833cf80ab6"}],"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ec26e90e598350d7b338de442ca3d3baf6cca302","unresolved":false,"context_lines":[{"line_number":2966,"context_line":"        mock_trait_get.reset_mock()"},{"line_number":2967,"context_line":"        mock_shr_get.reset_mock()"},{"line_number":2968,"context_line":""},{"line_number":2969,"context_line":"        with mock.patch(\u0027time.time\u0027) as mock_future:"},{"line_number":2970,"context_line":"            # A lot of time passes"},{"line_number":2971,"context_line":"            mock_future.return_value \u003d now + 10000000000000"},{"line_number":2972,"context_line":"            self.client._refresh_associations(self.context, uuid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a8697c23","line":2969,"updated":"2018-11-07 14:40:43.000000000","message":"I feel my hands tingling as time wrinkles and we approach the event horizon.","commit_id":"11a5fcbb6a3302c581f763776496d0833cf80ab6"}],"releasenotes/notes/disable-rt-cache-refresh-9f6633e585516760.yaml":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"04b28806aa17bee5f107aad8386fac7b8f381ca7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option"},{"line_number":5,"context_line":"    ``[compute]resource_provider_association_refresh`` can now"},{"line_number":6,"context_line":"    be set to zero to disable refresh entirely."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_531c3e13","line":6,"updated":"2018-11-06 06:00:08.000000000","message":"Can we include the brief background (and/or the link) that explains why we added this so that the operators who will face the same problem with CERN will catch that this helps them resolve the problem at the first sight?","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f2215491651883601c7906db82d900e84d4dcb8b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option"},{"line_number":5,"context_line":"    ``[compute]resource_provider_association_refresh`` can now"},{"line_number":6,"context_line":"    be set to zero to disable refresh entirely."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_653e42b7","line":6,"in_reply_to":"3f79a3b5_3c8aa719","updated":"2018-11-06 17:06:21.000000000","message":"Added words \u0026 link, see if you like.","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d12fb862f6119a45f6f29e31d3ef30efc83309c6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The configuration option"},{"line_number":5,"context_line":"    ``[compute]resource_provider_association_refresh`` can now"},{"line_number":6,"context_line":"    be set to zero to disable refresh entirely."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_3c8aa719","line":6,"in_reply_to":"3f79a3b5_531c3e13","updated":"2018-11-06 15:30:35.000000000","message":"Yeah we could at least reference bug 1767309 which introduced the option and the ML thread:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-November/thread.html#136251","commit_id":"fae92384a3d2d3299f7e25419b16ec7534f9233a"}]}