)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d13254f076bc670cea543d8823b91e08e535aa42","unresolved":false,"context_lines":[{"line_number":9,"context_line":"FIPS 140-2 does not allow MD5 use for most purposes and systems"},{"line_number":10,"context_line":"in \"FIPS mode\" (fips\u003d1 kernel flag) will cause software using"},{"line_number":11,"context_line":"MD5 from popular libraries to fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaaebc5a42bcb8d7a7647544150ed32a1378f510a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0d2c6992","line":12,"updated":"2018-11-06 01:12:14.000000000","message":"Thanks for the patch. Could you please report a nova bug explaining the problem [1] and add to the commit message \"Closes-Bug: \u003cbug number\u003e\" here to link it?\n\nWe\u0027d like to understand what action/steps result in which error or traceback and how this patch fixes the problem. It would also be helpful to include a brief explanation of the same in this commit message.\n\n[1] https://bugs.launchpad.net/nova/","commit_id":"4214170e96f33552a3f9257f7692b4893c1ec316"},{"author":{"_account_id":29432,"name":"Joshua Cornutt","email":"jcornutt@gmail.com","username":"01000101"},"change_message_id":"6fa8a3c867a3cc46bc8bd1fee81f3d0a1aa07df8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"FIPS 140-2 does not allow MD5 use for most purposes and systems"},{"line_number":10,"context_line":"in \"FIPS mode\" (fips\u003d1 kernel flag) will cause software using"},{"line_number":11,"context_line":"MD5 from popular libraries to fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaaebc5a42bcb8d7a7647544150ed32a1378f510a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_2dacc5e9","line":12,"in_reply_to":"3f79a3b5_0d2c6992","updated":"2018-11-06 02:05:27.000000000","message":"Thanks for the info. I\u0027ll open a bug ticket and update this accordingly.","commit_id":"4214170e96f33552a3f9257f7692b4893c1ec316"}],"nova/privsep/fs.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6e05db8ebfe18f89afbd89befee3dd2b612bddf5","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    if isinstance(base_str, six.text_type):"},{"line_number":285,"context_line":"        base_str \u003d base_str.encode(\u0027utf-8\u0027)"},{"line_number":286,"context_line":"    return hashlib.sha256(base_str).hexdigest()"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def get_file_extension_for_os_type(os_type, default_ephemeral_format,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_90c11c51","line":286,"updated":"2019-10-30 21:24:02.000000000","message":"I\u0027m wondering if this could cause backward-compatibility issues based on the code where it\u0027s used in the libvirt driver by way of the get_file_extension_for_os_type method call:\n\nhttps://github.com/openstack/nova/blob/ac0acfb8094fe8634a2eeeb9d3fe709f877137dd/nova/virt/libvirt/driver.py#L3836\n\nWould changing this cause any inability to find an existing VM\u0027s disk files not to be found or some other problem? I\u0027m going to add mdbooth to this review to verify.","commit_id":"19a48e57e43072f91ff8e19e2122ee003b0055f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"947e6e826e2176ee3858f747f53914b860fa2157","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    \"\"\""},{"line_number":284,"context_line":"    if isinstance(base_str, six.text_type):"},{"line_number":285,"context_line":"        base_str \u003d base_str.encode(\u0027utf-8\u0027)"},{"line_number":286,"context_line":"    return hashlib.sha256(base_str).hexdigest()"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"def get_file_extension_for_os_type(os_type, default_ephemeral_format,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_71e7b813","line":286,"in_reply_to":"3fa7e38b_90c11c51","updated":"2019-10-31 17:30:47.000000000","message":"Could this be configurable?","commit_id":"19a48e57e43072f91ff8e19e2122ee003b0055f6"}],"nova/utils.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6e05db8ebfe18f89afbd89befee3dd2b612bddf5","unresolved":false,"context_lines":[{"line_number":951,"context_line":""},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"def get_hash_str(base_str):"},{"line_number":954,"context_line":"    return get_sha256_str(base_str)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"def get_sha256_str(base_str):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_10abec87","line":954,"updated":"2019-10-30 21:24:02.000000000","message":"Similar question here, could there be any potential problem after an upgrade of not being able to disconnect a volume that was connected prior to the upgrade because the hash (and mountpoint) would change?\n\nhttps://github.com/openstack/nova/blob/ac0acfb8094fe8634a2eeeb9d3fe709f877137dd/nova/virt/libvirt/volume/fs.py#L75\n\nI\u0027m adding lyarwood to the review for this one.","commit_id":"19a48e57e43072f91ff8e19e2122ee003b0055f6"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"947e6e826e2176ee3858f747f53914b860fa2157","unresolved":false,"context_lines":[{"line_number":951,"context_line":""},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"def get_hash_str(base_str):"},{"line_number":954,"context_line":"    return get_sha256_str(base_str)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":""},{"line_number":957,"context_line":"def get_sha256_str(base_str):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_11d76425","line":954,"in_reply_to":"3fa7e38b_10abec87","updated":"2019-10-31 17:30:47.000000000","message":"As Matt highlights in his cover comment this is going to break any NFS, smbfs, or Quobyte volume users.","commit_id":"19a48e57e43072f91ff8e19e2122ee003b0055f6"}]}