)]}'
{"nova/cells/messaging.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"a7cc7746394856599b5878d18a84f332c1f24671","unresolved":false,"context_lines":[{"line_number":931,"context_line":"                         files_to_inject, kwargs):"},{"line_number":932,"context_line":"        self._call_compute_api_with_obj(message.ctxt, instance, \u0027rebuild\u0027,"},{"line_number":933,"context_line":"                                        image_href, admin_password,"},{"line_number":934,"context_line":"                                        files_to_inject, **kwargs)"},{"line_number":935,"context_line":""},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"class _BroadcastMessageMethods(_BaseMessageMethods):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9OT8%3D","line":934,"updated":"2013-12-13 20:28:08.000000000","message":"I\u0027d prefer to see files_to_inject\u003dfiles_to_inject because it\u0027s an optional kwarg, but I won\u0027t hold this up for that.","commit_id":"7e6c7e4e8e9a5c80f6664a6eef31423fab7768af"}],"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"12ba665325204613a060f7186505f1f6e58de35e","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"    @check_instance_state(vm_state\u003d[vm_states.ACTIVE, vm_states.STOPPED,"},{"line_number":2025,"context_line":"                                    vm_states.ERROR],"},{"line_number":2026,"context_line":"                          task_state\u003d[None])"},{"line_number":2027,"context_line":"    def rebuild(self, context, instance, image_href, admin_password, **kwargs):"},{"line_number":2028,"context_line":"        \"\"\"Rebuild the given instance with the provided attributes.\"\"\""},{"line_number":2029,"context_line":"        orig_image_ref \u003d instance[\u0027image_ref\u0027] or \u0027\u0027"},{"line_number":2030,"context_line":"        files_to_inject \u003d kwargs.pop(\u0027files_to_inject\u0027, [])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9Zds%3D","side":"PARENT","line":2027,"updated":"2013-12-11 22:43:46.000000000","message":"These original kwargs are going to need to make it to the child cell... so they can be used to re-call compute_api there.  But you have the correct approach for cells here.","commit_id":"2240dcbce41dfc45b56c299467338d14d1e20297"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"cfe8b2b237a5d44b2d287fd80ce9e7b8fdfff436","unresolved":false,"context_lines":[{"line_number":2095,"context_line":"                new_pass\u003dadmin_password, injected_files\u003dfiles_to_inject,"},{"line_number":2096,"context_line":"                image_ref\u003dimage_href, orig_image_ref\u003dorig_image_ref,"},{"line_number":2097,"context_line":"                orig_sys_metadata\u003dorig_sys_metadata, bdms\u003dbdms,"},{"line_number":2098,"context_line":"                kwargs\u003dkwargs)"},{"line_number":2099,"context_line":""},{"line_number":2100,"context_line":"    @wrap_check_policy"},{"line_number":2101,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9ZDw%3D","line":2098,"updated":"2013-12-11 23:48:49.000000000","message":"Some things were popped out of this above.  I wonder if it\u0027s worth fixing the compute API method signature to accept \u0027files_to_inject\u0027, etc as a separate kwarg.  And maybe kwargs could be better passed in as a single argument like \u0027extra_updates\u0027.","commit_id":"82981ed34efa18eab97b5f688524e710b55ab797"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9e5c87361a192bc936f95ef57311777a2a999533","unresolved":false,"context_lines":[{"line_number":2095,"context_line":"                new_pass\u003dadmin_password, injected_files\u003dfiles_to_inject,"},{"line_number":2096,"context_line":"                image_ref\u003dimage_href, orig_image_ref\u003dorig_image_ref,"},{"line_number":2097,"context_line":"                orig_sys_metadata\u003dorig_sys_metadata, bdms\u003dbdms,"},{"line_number":2098,"context_line":"                kwargs\u003dkwargs)"},{"line_number":2099,"context_line":""},{"line_number":2100,"context_line":"    @wrap_check_policy"},{"line_number":2101,"context_line":"    @check_instance_lock"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Y%2FQ%3D","line":2098,"in_reply_to":"AAAATn%2F9ZDw%3D","updated":"2013-12-12 00:04:27.000000000","message":"This is added back in cells_rpcapi","commit_id":"82981ed34efa18eab97b5f688524e710b55ab797"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e84a0f210337e66e6661a30dbc9f4afdb750218","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"            # updates will be lost. Since this problem exists in a lot"},{"line_number":2063,"context_line":"            # of other places, I think it should be addressed in a DB"},{"line_number":2064,"context_line":"            # layer overhaul."},{"line_number":2065,"context_line":"            sys_metadata \u003d self.db.instance_system_metadata_get(context,"},{"line_number":2066,"context_line":"                    instance[\u0027uuid\u0027])"},{"line_number":2067,"context_line":"            orig_sys_metadata \u003d dict(sys_metadata)"},{"line_number":2068,"context_line":"            # Remove the old keys"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9OB0%3D","line":2065,"updated":"2013-12-13 21:36:02.000000000","message":"instance.uuid","commit_id":"7e6c7e4e8e9a5c80f6664a6eef31423fab7768af"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e84a0f210337e66e6661a30dbc9f4afdb750218","unresolved":false,"context_lines":[{"line_number":821,"context_line":"    def _get_power_state(self, context, instance):"},{"line_number":822,"context_line":"        \"\"\"Retrieve the power state for the given instance.\"\"\""},{"line_number":823,"context_line":"        LOG.debug(_(\u0027Checking state\u0027), instance\u003dinstance)"},{"line_number":824,"context_line":"        try:"},{"line_number":825,"context_line":"            return self.driver.get_info(instance)[\"state\"]"},{"line_number":826,"context_line":"        except exception.NotFound:"},{"line_number":827,"context_line":"            return power_state.NOSTATE"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9OC0%3D","line":824,"updated":"2013-12-13 21:36:02.000000000","message":"Does driver.get_info support objects?  Looking at a few virt drivers they are treating the instance like a dict.  Maybe that\u0027s just something you plan on cleaning up in the virt drivers to objects blueprint?","commit_id":"7e6c7e4e8e9a5c80f6664a6eef31423fab7768af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e84a0f210337e66e6661a30dbc9f4afdb750218","unresolved":false,"context_lines":[{"line_number":2195,"context_line":"            self._notify_about_instance_usage(context, instance,"},{"line_number":2196,"context_line":"                    \"rebuild.start\", extra_usage_info\u003dextra_usage_info)"},{"line_number":2197,"context_line":""},{"line_number":2198,"context_line":"            instance.power_state \u003d self._get_power_state(context, instance)"},{"line_number":2199,"context_line":"            instance.task_state \u003d task_states.REBUILDING"},{"line_number":2200,"context_line":"            instance.save(expected_task_state\u003d[task_states.REBUILDING])"},{"line_number":2201,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9OCo%3D","line":2198,"updated":"2013-12-13 21:36:02.000000000","message":"Does _get_power_state support objects?  Does it matter?","commit_id":"7e6c7e4e8e9a5c80f6664a6eef31423fab7768af"}]}