)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d87bcd5b63594cf4ffc5ef33f6ca69b8a855488e","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"        instance.task_state \u003d task_states.NETWORKING"},{"line_number":1562,"context_line":"        instance.save(expected_task_state\u003d[None])"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"        is_vpn \u003d False"},{"line_number":1565,"context_line":"        return network_model.NetworkInfoAsyncWrapper("},{"line_number":1566,"context_line":"                self._allocate_network_async, context, instance,"},{"line_number":1567,"context_line":"                requested_networks, macs, security_groups, is_vpn,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_d3dab277","line":1564,"range":{"start_line":1564,"start_character":8,"end_line":1564,"end_character":22},"updated":"2019-02-21 22:30:01.000000000","message":"wee!","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"034012047fc3ed4e74d1ded55c051b0a0d2869e1","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"        instance.task_state \u003d task_states.NETWORKING"},{"line_number":1562,"context_line":"        instance.save(expected_task_state\u003d[None])"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"        is_vpn \u003d False"},{"line_number":1565,"context_line":"        return network_model.NetworkInfoAsyncWrapper("},{"line_number":1566,"context_line":"                self._allocate_network_async, context, instance,"},{"line_number":1567,"context_line":"                requested_networks, macs, security_groups, is_vpn,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_74761edb","line":1564,"range":{"start_line":1564,"start_character":8,"end_line":1564,"end_character":22},"in_reply_to":"9fdfeff1_d3dab277","updated":"2019-02-25 15:54:11.000000000","message":"better than just passing False as an unnamed param and not knowing what the heck it\u0027s indicating :)","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7fb4899d5ca3974a65c52cd5039c50669e663033","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"            hints \u003d filter_properties.get(\u0027scheduler_hints\u0027) or {}"},{"line_number":2094,"context_line":"        return hints"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    def _build_and_run_instance(self, context, instance, image, injected_files,"},{"line_number":2097,"context_line":"            admin_password, requested_networks, security_groups,"},{"line_number":2098,"context_line":"            block_device_mapping, node, limits, filter_properties,"},{"line_number":2099,"context_line":"            request_spec\u003dNone):"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_d3f632d9","line":2096,"range":{"start_line":2096,"start_character":8,"end_line":2096,"end_character":31},"updated":"2019-02-21 22:31:02.000000000","message":"This is another huge method. It would be nice to throw your logic that builds the dict into a private helper method and call that from within here.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"034012047fc3ed4e74d1ded55c051b0a0d2869e1","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"            hints \u003d filter_properties.get(\u0027scheduler_hints\u0027) or {}"},{"line_number":2094,"context_line":"        return hints"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    def _build_and_run_instance(self, context, instance, image, injected_files,"},{"line_number":2097,"context_line":"            admin_password, requested_networks, security_groups,"},{"line_number":2098,"context_line":"            block_device_mapping, node, limits, filter_properties,"},{"line_number":2099,"context_line":"            request_spec\u003dNone):"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_947382e7","line":2096,"range":{"start_line":2096,"start_character":8,"end_line":2096,"end_character":31},"in_reply_to":"9fdfeff1_d3f632d9","updated":"2019-02-25 15:54:11.000000000","message":"++","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"37d5298f24fce25202d555b40c1adad56bfea93d","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"            hints \u003d filter_properties.get(\u0027scheduler_hints\u0027) or {}"},{"line_number":2094,"context_line":"        return hints"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    def _build_and_run_instance(self, context, instance, image, injected_files,"},{"line_number":2097,"context_line":"            admin_password, requested_networks, security_groups,"},{"line_number":2098,"context_line":"            block_device_mapping, node, limits, filter_properties,"},{"line_number":2099,"context_line":"            request_spec\u003dNone):"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_8eccd389","line":2096,"range":{"start_line":2096,"start_character":8,"end_line":2096,"end_character":31},"in_reply_to":"9fdfeff1_d3f632d9","updated":"2019-02-25 16:59:22.000000000","message":"factored out in a fup.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d87bcd5b63594cf4ffc5ef33f6ca69b8a855488e","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2127,"context_line":""},{"line_number":2128,"context_line":"                if request_spec:"},{"line_number":2129,"context_line":"                    request_group_resource_providers_mapping \u003d {"},{"line_number":2130,"context_line":"                        group.requester_id: group.provider_uuids"},{"line_number":2131,"context_line":"                        for group in request_spec.requested_resources"},{"line_number":2132,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_33cd3eb7","line":2129,"updated":"2019-02-21 22:30:01.000000000","message":"A comment here would be good, especially with an example of what this would be, i.e. in the minimum bandwidth based scheduling case, this is a dict, keyed by port_id, to resource provider UUIDs that fulfill the port\u0027s requested resources.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"37d5298f24fce25202d555b40c1adad56bfea93d","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2127,"context_line":""},{"line_number":2128,"context_line":"                if request_spec:"},{"line_number":2129,"context_line":"                    request_group_resource_providers_mapping \u003d {"},{"line_number":2130,"context_line":"                        group.requester_id: group.provider_uuids"},{"line_number":2131,"context_line":"                        for group in request_spec.requested_resources"},{"line_number":2132,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_0ec1c354","line":2129,"in_reply_to":"9fdfeff1_33cd3eb7","updated":"2019-02-25 16:59:22.000000000","message":"Done in a fup.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"034012047fc3ed4e74d1ded55c051b0a0d2869e1","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2127,"context_line":""},{"line_number":2128,"context_line":"                if request_spec:"},{"line_number":2129,"context_line":"                    request_group_resource_providers_mapping \u003d {"},{"line_number":2130,"context_line":"                        group.requester_id: group.provider_uuids"},{"line_number":2131,"context_line":"                        for group in request_spec.requested_resources"},{"line_number":2132,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_d446ea7b","line":2129,"in_reply_to":"9fdfeff1_33cd3eb7","updated":"2019-02-25 15:54:11.000000000","message":"and add a comment that requested_resources only includes the unnumbered request group and therefore the len(group.provider_uuids) will always be exactly 1...","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9133a01b8e7662e8233520c6b118d4c741dd1463","unresolved":false,"context_lines":[{"line_number":2126,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image)"},{"line_number":2127,"context_line":""},{"line_number":2128,"context_line":"                if request_spec:"},{"line_number":2129,"context_line":"                    request_group_resource_providers_mapping \u003d {"},{"line_number":2130,"context_line":"                        group.requester_id: group.provider_uuids"},{"line_number":2131,"context_line":"                        for group in request_spec.requested_resources"},{"line_number":2132,"context_line":"                    }"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_887da61d","line":2129,"in_reply_to":"9fdfeff1_d446ea7b","updated":"2019-02-25 16:10:28.000000000","message":"You mean requested_resources only includes *numbered* request groups and therefore...\n\nThe unnumbered request group a) is not included in the request spec (yet); and b) can be satisfied by multiple providers if group_policy\u003dnone.\n\nBut looking more closely, this raises another question: Can one port request bw in more than one request group? If so, we need to be more careful about this dict; as written, the last one we come across will \"win\".\n\nPretty sure we\u0027ll have to address this for cyborg, where one device_profile can map to multiple request groups.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"}],"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07a8d2b42a9965b923c7799f1c99b3bed5d7d9ce","unresolved":false,"context_lines":[{"line_number":706,"context_line":"            local_reqspec \u003d objects.RequestSpec.from_primitives("},{"line_number":707,"context_line":"                context, request_spec, local_filter_props)"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"            # TODO(gibi): make sure that the request group - provider mapping"},{"line_number":710,"context_line":"            # is updated in the request spec during reschedule"},{"line_number":711,"context_line":"            local_reqspec.requested_resources \u003d []"},{"line_number":712,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_d3e4f210","line":709,"updated":"2019-02-21 22:34:52.000000000","message":"Note to other reviewers, this is handled in https://review.openstack.org/#/c/619529/ next in the series.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d0f7c58aff564d176e299451e75db6d2c17bbe80","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"            # TODO(gibi): make sure that the request group - provider mapping"},{"line_number":710,"context_line":"            # is updated in the request spec during reschedule"},{"line_number":711,"context_line":"            local_reqspec.requested_resources \u003d []"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            # The block_device_mapping passed from the api doesn\u0027t contain"},{"line_number":714,"context_line":"            # instance specific information"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_34bbb60f","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":50},"updated":"2019-02-25 15:34:20.000000000","message":"curious why this isn\u0027t done for us in RequestSpec.from_primitives","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"87a0f78feddf03e1aeb43d343336a567f2339e44","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"            # TODO(gibi): make sure that the request group - provider mapping"},{"line_number":710,"context_line":"            # is updated in the request spec during reschedule"},{"line_number":711,"context_line":"            local_reqspec.requested_resources \u003d []"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            # The block_device_mapping passed from the api doesn\u0027t contain"},{"line_number":714,"context_line":"            # instance specific information"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_141f926c","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":50},"in_reply_to":"9fdfeff1_34bbb60f","updated":"2019-02-25 15:50:27.000000000","message":"That\u0027s not a bad point. The field is nullable and defaults to None and if someone tried calling local_reqspec.requested_resources it would set the default to None, so I\u0027m not sure setting this to an empty list is really necessary, but it\u0027s also addressed in this series so low priority for me to change this.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"034012047fc3ed4e74d1ded55c051b0a0d2869e1","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"            # TODO(gibi): make sure that the request group - provider mapping"},{"line_number":710,"context_line":"            # is updated in the request spec during reschedule"},{"line_number":711,"context_line":"            local_reqspec.requested_resources \u003d []"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            # The block_device_mapping passed from the api doesn\u0027t contain"},{"line_number":714,"context_line":"            # instance specific information"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_e8579200","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":50},"in_reply_to":"9fdfeff1_34bbb60f","updated":"2019-02-25 15:54:11.000000000","message":"because requested_resources isn\u0027t in \"legacy dicts\". That said, I agree with you that it should probably be done there instead of here.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c307e1e6b70ce542dfdb7fe2d2bf0019743e1cf5","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"            # TODO(gibi): make sure that the request group - provider mapping"},{"line_number":710,"context_line":"            # is updated in the request spec during reschedule"},{"line_number":711,"context_line":"            local_reqspec.requested_resources \u003d []"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"            # The block_device_mapping passed from the api doesn\u0027t contain"},{"line_number":714,"context_line":"            # instance specific information"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_84c57d5e","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":50},"in_reply_to":"9fdfeff1_e8579200","updated":"2019-02-26 16:16:48.000000000","message":"As mat stated it is changed in a later patch (which is already merged now)","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"}],"nova/network/base_api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d0f7c58aff564d176e299451e75db6d2c17bbe80","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        :param attach: Boolean indicating if a port is being attached to an"},{"line_number":204,"context_line":"            existing running instance. Should be False during server create."},{"line_number":205,"context_line":"        :param resource_provider_mapping: a dict keyed by ids of the entities"},{"line_number":206,"context_line":"            (for example Neutron port) requested resources for this instance"},{"line_number":207,"context_line":"            mapped to a list of resource provider UUIDs that are fulfilling"},{"line_number":208,"context_line":"            such resource request."},{"line_number":209,"context_line":"        :returns: network info as from get_instance_nw_info() below"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_34a89676","line":206,"range":{"start_line":206,"start_character":39,"end_line":206,"end_character":48},"updated":"2019-02-25 15:34:20.000000000","message":"requesting","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c307e1e6b70ce542dfdb7fe2d2bf0019743e1cf5","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        :param attach: Boolean indicating if a port is being attached to an"},{"line_number":204,"context_line":"            existing running instance. Should be False during server create."},{"line_number":205,"context_line":"        :param resource_provider_mapping: a dict keyed by ids of the entities"},{"line_number":206,"context_line":"            (for example Neutron port) requested resources for this instance"},{"line_number":207,"context_line":"            mapped to a list of resource provider UUIDs that are fulfilling"},{"line_number":208,"context_line":"            such resource request."},{"line_number":209,"context_line":"        :returns: network info as from get_instance_nw_info() below"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_64a659c4","line":206,"range":{"start_line":206,"start_character":39,"end_line":206,"end_character":48},"in_reply_to":"9fdfeff1_34a89676","updated":"2019-02-26 16:16:48.000000000","message":"Done in the fup","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d0f7c58aff564d176e299451e75db6d2c17bbe80","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        :param resource_provider_mapping: a dict keyed by ids of the entities"},{"line_number":206,"context_line":"            (for example Neutron port) requested resources for this instance"},{"line_number":207,"context_line":"            mapped to a list of resource provider UUIDs that are fulfilling"},{"line_number":208,"context_line":"            such resource request."},{"line_number":209,"context_line":"        :returns: network info as from get_instance_nw_info() below"},{"line_number":210,"context_line":"        \"\"\""},{"line_number":211,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_74cb7e52","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":16},"updated":"2019-02-25 15:34:20.000000000","message":"\u0027the\u0027 or \u0027such a\u0027","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c307e1e6b70ce542dfdb7fe2d2bf0019743e1cf5","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        :param resource_provider_mapping: a dict keyed by ids of the entities"},{"line_number":206,"context_line":"            (for example Neutron port) requested resources for this instance"},{"line_number":207,"context_line":"            mapped to a list of resource provider UUIDs that are fulfilling"},{"line_number":208,"context_line":"            such resource request."},{"line_number":209,"context_line":"        :returns: network info as from get_instance_nw_info() below"},{"line_number":210,"context_line":"        \"\"\""},{"line_number":211,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_24acd19d","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":16},"in_reply_to":"9fdfeff1_74cb7e52","updated":"2019-02-26 16:16:48.000000000","message":"Done in the fup","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d0f7c58aff564d176e299451e75db6d2c17bbe80","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        :param bind_host_id: the host ID to attach to the ports being created."},{"line_number":1037,"context_line":"        :param attach: Boolean indicating if a port is being attached to an"},{"line_number":1038,"context_line":"            existing running instance. Should be False during server create."},{"line_number":1039,"context_line":"        :param resource_provider_mapping: a dict keyed by ids of the entities"},{"line_number":1040,"context_line":"            (for example Neutron port) requested resources for this instance"},{"line_number":1041,"context_line":"            mapped to a list of resource provider UUIDs that are fulfilling"},{"line_number":1042,"context_line":"            such resource request."}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_14e232d6","line":1039,"updated":"2019-02-25 15:34:20.000000000","message":"ditto","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c307e1e6b70ce542dfdb7fe2d2bf0019743e1cf5","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"        :param bind_host_id: the host ID to attach to the ports being created."},{"line_number":1037,"context_line":"        :param attach: Boolean indicating if a port is being attached to an"},{"line_number":1038,"context_line":"            existing running instance. Should be False during server create."},{"line_number":1039,"context_line":"        :param resource_provider_mapping: a dict keyed by ids of the entities"},{"line_number":1040,"context_line":"            (for example Neutron port) requested resources for this instance"},{"line_number":1041,"context_line":"            mapped to a list of resource provider UUIDs that are fulfilling"},{"line_number":1042,"context_line":"            such resource request."}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_e491e953","line":1039,"in_reply_to":"9fdfeff1_14e232d6","updated":"2019-02-26 16:16:48.000000000","message":"Done in the fup","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"}],"nova/tests/functional/test_compute_mgr.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d0f7c58aff564d176e299451e75db6d2c17bbe80","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 \u0027instance_type\u0027: flavor,"},{"line_number":73,"context_line":"                 \u0027image\u0027: None},"},{"line_number":74,"context_line":"                filter_properties)"},{"line_number":75,"context_line":"            request_spec.requested_resources \u003d []"},{"line_number":76,"context_line":"            self.compute.manager.build_and_run_instance("},{"line_number":77,"context_line":"                    self.context, instance, {}, request_spec,"},{"line_number":78,"context_line":"                    filter_properties, block_device_mapping\u003d[])"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_74d05ef8","line":75,"updated":"2019-02-25 15:34:20.000000000","message":"ditto","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c307e1e6b70ce542dfdb7fe2d2bf0019743e1cf5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 \u0027instance_type\u0027: flavor,"},{"line_number":73,"context_line":"                 \u0027image\u0027: None},"},{"line_number":74,"context_line":"                filter_properties)"},{"line_number":75,"context_line":"            request_spec.requested_resources \u003d []"},{"line_number":76,"context_line":"            self.compute.manager.build_and_run_instance("},{"line_number":77,"context_line":"                    self.context, instance, {}, request_spec,"},{"line_number":78,"context_line":"                    filter_properties, block_device_mapping\u003d[])"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_04ae6d80","line":75,"in_reply_to":"9fdfeff1_74d05ef8","updated":"2019-02-26 16:16:48.000000000","message":"Good point. Not needed. Removed in the fup.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d87bcd5b63594cf4ffc5ef33f6ca69b8a855488e","unresolved":false,"context_lines":[{"line_number":6606,"context_line":"                    requester_id\u003duuids.port1,"},{"line_number":6607,"context_line":"                    provider_uuids\u003d[uuids.rp1])])"},{"line_number":6608,"context_line":"        with test.nested("},{"line_number":6609,"context_line":"                mock.patch.object(self.compute.driver, \u0027spawn\u0027),"},{"line_number":6610,"context_line":"                mock.patch.object(self.compute,"},{"line_number":6611,"context_line":"                    \u0027_build_networks_for_instance\u0027, return_value\u003d[]),"},{"line_number":6612,"context_line":"                mock.patch.object(self.instance, \u0027save\u0027),"},{"line_number":6613,"context_line":"        ) as (mock_spawn, mock_networks, mock_save):"},{"line_number":6614,"context_line":"                self.compute._build_and_run_instance("},{"line_number":6615,"context_line":"                    self.context,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_736186a8","line":6612,"range":{"start_line":6609,"start_character":0,"end_line":6612,"end_character":57},"updated":"2019-02-21 22:30:01.000000000","message":"Drop the intend a tab.","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"37d5298f24fce25202d555b40c1adad56bfea93d","unresolved":false,"context_lines":[{"line_number":6606,"context_line":"                    requester_id\u003duuids.port1,"},{"line_number":6607,"context_line":"                    provider_uuids\u003d[uuids.rp1])])"},{"line_number":6608,"context_line":"        with test.nested("},{"line_number":6609,"context_line":"                mock.patch.object(self.compute.driver, \u0027spawn\u0027),"},{"line_number":6610,"context_line":"                mock.patch.object(self.compute,"},{"line_number":6611,"context_line":"                    \u0027_build_networks_for_instance\u0027, return_value\u003d[]),"},{"line_number":6612,"context_line":"                mock.patch.object(self.instance, \u0027save\u0027),"},{"line_number":6613,"context_line":"        ) as (mock_spawn, mock_networks, mock_save):"},{"line_number":6614,"context_line":"                self.compute._build_and_run_instance("},{"line_number":6615,"context_line":"                    self.context,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_6ea2cf9c","line":6612,"range":{"start_line":6609,"start_character":0,"end_line":6612,"end_character":57},"in_reply_to":"9fdfeff1_736186a8","updated":"2019-02-25 16:59:22.000000000","message":"Done in a fup","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d87bcd5b63594cf4ffc5ef33f6ca69b8a855488e","unresolved":false,"context_lines":[{"line_number":6611,"context_line":"                    \u0027_build_networks_for_instance\u0027, return_value\u003d[]),"},{"line_number":6612,"context_line":"                mock.patch.object(self.instance, \u0027save\u0027),"},{"line_number":6613,"context_line":"        ) as (mock_spawn, mock_networks, mock_save):"},{"line_number":6614,"context_line":"                self.compute._build_and_run_instance("},{"line_number":6615,"context_line":"                    self.context,"},{"line_number":6616,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":6617,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":6618,"context_line":"                    self.security_groups, self.block_device_mapping, self.node,"},{"line_number":6619,"context_line":"                    self.limits, self.filter_properties, request_spec)"},{"line_number":6620,"context_line":""},{"line_number":6621,"context_line":"        mock_networks.assert_called_once_with("},{"line_number":6622,"context_line":"            self.context, self.instance, self.requested_networks,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_13583af8","line":6619,"range":{"start_line":6614,"start_character":0,"end_line":6619,"end_character":70},"updated":"2019-02-21 22:30:01.000000000","message":"same, you went indent crazy","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"37d5298f24fce25202d555b40c1adad56bfea93d","unresolved":false,"context_lines":[{"line_number":6611,"context_line":"                    \u0027_build_networks_for_instance\u0027, return_value\u003d[]),"},{"line_number":6612,"context_line":"                mock.patch.object(self.instance, \u0027save\u0027),"},{"line_number":6613,"context_line":"        ) as (mock_spawn, mock_networks, mock_save):"},{"line_number":6614,"context_line":"                self.compute._build_and_run_instance("},{"line_number":6615,"context_line":"                    self.context,"},{"line_number":6616,"context_line":"                    self.instance, self.image, self.injected_files,"},{"line_number":6617,"context_line":"                    self.admin_pass, self.requested_networks,"},{"line_number":6618,"context_line":"                    self.security_groups, self.block_device_mapping, self.node,"},{"line_number":6619,"context_line":"                    self.limits, self.filter_properties, request_spec)"},{"line_number":6620,"context_line":""},{"line_number":6621,"context_line":"        mock_networks.assert_called_once_with("},{"line_number":6622,"context_line":"            self.context, self.instance, self.requested_networks,"}],"source_content_type":"text/x-python","patch_set":32,"id":"9fdfeff1_ce997b6d","line":6619,"range":{"start_line":6614,"start_character":0,"end_line":6619,"end_character":70},"in_reply_to":"9fdfeff1_13583af8","updated":"2019-02-25 16:59:22.000000000","message":"Done in a fup. I blame pycharm. :)","commit_id":"bea316d479750452a42295d9980d9dac5a89934e"}]}