)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"6503ae213c4dfd36bb1618e543823a52212932b5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Attach volumes using adapter type from instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pick the adapter type from the instance VM instead of from the shadow"},{"line_number":10,"context_line":"VM since attaching the volume to a different adapter type may change"},{"line_number":11,"context_line":"the boot order."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6d9c52b78f7e160b707334e98c282c7cbf1a0766"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_7d274b1f","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":15},"updated":"2018-11-13 03:39:37.000000000","message":"Is there a bug trace this?","commit_id":"891a4e1885d430a7952b2ae5351a43ff335e3616"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"bf3cdfdfa9a1222ec2fa29422bea461628112030","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Attach volumes using adapter type from instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pick the adapter type from the instance VM instead of from the shadow"},{"line_number":10,"context_line":"VM since attaching the volume to a different adapter type may change"},{"line_number":11,"context_line":"the boot order."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6d9c52b78f7e160b707334e98c282c7cbf1a0766"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_0e685f87","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":15},"in_reply_to":"3f79a3b5_7d274b1f","updated":"2018-11-13 08:50:19.000000000","message":"Not yet as the problem is not clearly reproducible. But root cause analysis indicated that this unnecessary addition of another adapter might be the reason for the side effect of reordering.","commit_id":"891a4e1885d430a7952b2ae5351a43ff335e3616"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8452e99948b493d4a9796a188bcd7bb973b86f09","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Attach volumes using adapter type from instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pick the adapter type from the instance VM instead of from the shadow"},{"line_number":10,"context_line":"VM since attaching the volume to a different adapter type may change"},{"line_number":11,"context_line":"the boot order."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6d9c52b78f7e160b707334e98c282c7cbf1a0766"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_79f94dc6","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":68},"updated":"2019-01-16 20:48:55.000000000","message":"In our testing, we find the boot order problem only when the root disk is attached using paraVirtual. There are customer use cases where we need \u0027ide\u0027 for root disk and SCSI adapters for volumes.","commit_id":"12651a85417eeb88c1682e8b8361639505da708f"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"eb19fef9a2293c11bff0c5868247c4dcc0ba9089","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Attach volumes using adapter type from instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pick the adapter type from the instance VM instead of from the shadow"},{"line_number":10,"context_line":"VM since attaching the volume to a different adapter type may change"},{"line_number":11,"context_line":"the boot order."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6d9c52b78f7e160b707334e98c282c7cbf1a0766"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfdaf3ff_311d11bd","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":68},"in_reply_to":"bfdaf3ff_79f94dc6","updated":"2019-01-17 10:16:36.000000000","message":"I see. Could you suggest any other way for addressing the boot order issue?","commit_id":"12651a85417eeb88c1682e8b8361639505da708f"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"c18609a72112c81230a9f56c672219ffb17c88a0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Attach volumes using adapter type from instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pick the adapter type from the instance VM instead of from the shadow"},{"line_number":10,"context_line":"VM since attaching the volume to a different adapter type may change"},{"line_number":11,"context_line":"the boot order."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6d9c52b78f7e160b707334e98c282c7cbf1a0766"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_0b4a8f26","line":10,"range":{"start_line":10,"start_character":57,"end_line":10,"end_character":68},"in_reply_to":"bfdaf3ff_79f94dc6","updated":"2019-09-17 15:27:59.000000000","message":"Vipin, looking back at this one: what problem do you see with the proposed change in terms of the use-case you\u0027ve described (i.e. instance root disk on IDE and volume on SCSI)?","commit_id":"12651a85417eeb88c1682e8b8361639505da708f"}],"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"88796a82d6fdc7f6b0c7fde05cda3c5bd6d414b4","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        # Get details required for adding disk device such as"},{"line_number":329,"context_line":"        # adapter_type, disk_type"},{"line_number":330,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, volume_ref)"},{"line_number":331,"context_line":"        instance_root_vmdk_info \u003d vm_util.get_vmdk_info(self._session,"},{"line_number":332,"context_line":"                                                        vm_ref,"},{"line_number":333,"context_line":"                                                        uuid\u003dinstance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_678e1127","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":63},"updated":"2018-11-08 18:57:15.000000000","message":"This line should be move to line 343 where vmdk is used just before.","commit_id":"e717006de9f81553cd5b46a4a1a86b40394462f1"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"d95268efd7171164db0fc192ba0ba1fff5a6419a","unresolved":false,"context_lines":[{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        # Get details required for adding disk device such as"},{"line_number":329,"context_line":"        # adapter_type, disk_type"},{"line_number":330,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, volume_ref)"},{"line_number":331,"context_line":"        instance_root_vmdk_info \u003d vm_util.get_vmdk_info(self._session,"},{"line_number":332,"context_line":"                                                        vm_ref,"},{"line_number":333,"context_line":"                                                        uuid\u003dinstance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_05d94b26","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":63},"in_reply_to":"3f79a3b5_678e1127","updated":"2018-11-09 14:19:31.000000000","message":"Done","commit_id":"e717006de9f81553cd5b46a4a1a86b40394462f1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6aa9a9c06fed5a663cc73fc3727d68d21750842e","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                          \u0027hotplug.\u0027) % adapter_type)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # Get details required for adding disk device such as"},{"line_number":341,"context_line":"        # adapter_type, disk_type"},{"line_number":342,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, volume_ref)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # Attach the disk to virtual machine instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0cadbde6","line":341,"range":{"start_line":341,"start_character":10,"end_line":341,"end_character":23},"updated":"2018-11-13 19:03:59.000000000","message":"That is a nice point.\nAt least, this patch makes this get_vmdk_info() unnecessary for adapter_type.\nSo it is better to remove \"adapter_type\" from the comment.","commit_id":"891a4e1885d430a7952b2ae5351a43ff335e3616"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"6503ae213c4dfd36bb1618e543823a52212932b5","unresolved":false,"context_lines":[{"line_number":337,"context_line":"                raise exception.Invalid(_(\u0027%s does not support disk \u0027"},{"line_number":338,"context_line":"                                          \u0027hotplug.\u0027) % adapter_type)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # Get details required for adding disk device such as"},{"line_number":341,"context_line":"        # adapter_type, disk_type"},{"line_number":342,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, volume_ref)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # Attach the disk to virtual machine instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fded9bb9","line":341,"range":{"start_line":340,"start_character":8,"end_line":341,"end_character":33},"updated":"2018-11-13 03:39:37.000000000","message":"Why remove these two lines here, it seems we get adapter_type in L328~L331, how about rephrase like this:\nAdd comment for get adapter_type from instance in L327.","commit_id":"891a4e1885d430a7952b2ae5351a43ff335e3616"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"da59e08abe48debd80f236560034141d4bb9e2b7","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                          \u0027hotplug.\u0027) % adapter_type)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # Get details required for adding disk device such as"},{"line_number":341,"context_line":"        # adapter_type, disk_type"},{"line_number":342,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, volume_ref)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # Attach the disk to virtual machine instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_431ffbb8","line":341,"range":{"start_line":341,"start_character":10,"end_line":341,"end_character":23},"in_reply_to":"3f79a3b5_0cadbde6","updated":"2018-11-14 09:36:28.000000000","message":"Done","commit_id":"891a4e1885d430a7952b2ae5351a43ff335e3616"},{"author":{"_account_id":29125,"name":"Ivaylo Mitev","email":"imitev@vmware.com","username":"imitev"},"change_message_id":"bf3cdfdfa9a1222ec2fa29422bea461628112030","unresolved":false,"context_lines":[{"line_number":337,"context_line":"                raise exception.Invalid(_(\u0027%s does not support disk \u0027"},{"line_number":338,"context_line":"                                          \u0027hotplug.\u0027) % adapter_type)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        # Get details required for adding disk device such as"},{"line_number":341,"context_line":"        # adapter_type, disk_type"},{"line_number":342,"context_line":"        vmdk \u003d vm_util.get_vmdk_info(self._session, volume_ref)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        # Attach the disk to virtual machine instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ceda6775","line":341,"range":{"start_line":340,"start_character":8,"end_line":341,"end_character":33},"in_reply_to":"3f79a3b5_fded9bb9","updated":"2018-11-13 08:50:19.000000000","message":"In my change I\u0027ve introduced a second call of get_vmdk_info. I think a comment for it is unnecessary but I\u0027ve respected the opinion of the previous developers and left the comment on the old code the way it was. The old code block has just been moved few lines down but the diff displays it as remove/add instead.","commit_id":"891a4e1885d430a7952b2ae5351a43ff335e3616"}]}