)]}'
{"nova/tests/unit/virt/vmwareapi/test_vif.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3d0766957fc2c3e48e6e1037b2683082bdd95312","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        fake_network_obj \u003d {\u0027type\u0027: \u0027DistributedVirtualPortgroup\u0027,"},{"line_number":373,"context_line":"                            \u0027dvpg\u0027: \u0027fake-key\u0027,"},{"line_number":374,"context_line":"                            \u0027dvsw\u0027: \u0027fake-props\u0027}"},{"line_number":375,"context_line":"        mock_network_name.side_effect \u003d [fake_network_obj]"},{"line_number":376,"context_line":"        vif_info \u003d network_model.NetworkInfo(["},{"line_number":377,"context_line":"                network_model.VIF(type\u003dnetwork_model.VIF_TYPE_DVS,"},{"line_number":378,"context_line":"                                  address\u003d\u0027DE:AD:BE:EF:00:00\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5acc7832","line":375,"updated":"2018-11-19 20:38:39.000000000","message":"Seems to me we need to add a test where the vif info has the dvs_id and pg_id. Assert that the returned network_ref contains the values from the vif info, and that get_network_with_the_name isn\u0027t called.","commit_id":"eff37148c3a45b33f122505b5b359a761394f658"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"2bddd98204177beefd11d977a5c17c74c40b023b","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        fake_network_obj \u003d {\u0027type\u0027: \u0027DistributedVirtualPortgroup\u0027,"},{"line_number":373,"context_line":"                            \u0027dvpg\u0027: \u0027fake-key\u0027,"},{"line_number":374,"context_line":"                            \u0027dvsw\u0027: \u0027fake-props\u0027}"},{"line_number":375,"context_line":"        mock_network_name.side_effect \u003d [fake_network_obj]"},{"line_number":376,"context_line":"        vif_info \u003d network_model.NetworkInfo(["},{"line_number":377,"context_line":"                network_model.VIF(type\u003dnetwork_model.VIF_TYPE_DVS,"},{"line_number":378,"context_line":"                                  address\u003d\u0027DE:AD:BE:EF:00:00\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a7dfad37","line":375,"in_reply_to":"3f79a3b5_5acc7832","updated":"2018-11-20 08:08:21.000000000","message":"Sure - I\u0027ll look into that.","commit_id":"eff37148c3a45b33f122505b5b359a761394f658"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9b17019bb9d8681d5efbeabed4fbd0a3cf8696c9","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                            \u0027dvsw\u0027: \u0027fake-props\u0027}"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        self.assertEqual(network_ref, fake_network_ref)"},{"line_number":429,"context_line":"        calls \u003d []"},{"line_number":430,"context_line":"        mock_network_name.assert_has_calls(calls)"},{"line_number":431,"context_line":"        self.assertEqual(fake_network_obj, network_ref)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f6af6e99","line":431,"range":{"start_line":429,"start_character":1,"end_line":431,"end_character":1},"updated":"2018-12-05 21:29:44.000000000","message":"This is typically done as\n\n mock_network_name.assert_not_called()","commit_id":"68e8ae35929f33e6d50cf3e52f15a54691b487c7"}]}