)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7701e4f565128cb79e60b668bf6426294a98803","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove v1 check in Cinder client version lookup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Cinder v1 API was deprecated in Juno on removed completely in"},{"line_number":10,"context_line":"Queens. We no do not support compatibility between Stein Nova and Queens"},{"line_number":11,"context_line":"Cinder, so this checking can be removed."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_f7a35d9b","line":9,"range":{"start_line":9,"start_character":41,"end_line":9,"end_character":43},"updated":"2018-11-14 13:29:04.000000000","message":"Will fix typo if an update is needed.","commit_id":"fee72b1a063bf79d9aad214ceb06eab8dcf558c2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0a2e4e13995c68df031619aa508325d679f666f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove v1 check in Cinder client version lookup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The Cinder v1 API was deprecated in Juno on removed completely in"},{"line_number":10,"context_line":"Queens. We no do not support compatibility between Stein Nova and Queens"},{"line_number":11,"context_line":"Cinder, so this checking can be removed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I947f50e921159f66b425f10e31a08a3e0840228e"},{"line_number":14,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_9af0a294","line":11,"range":{"start_line":10,"start_character":8,"end_line":11,"end_character":6},"updated":"2018-11-21 20:58:30.000000000","message":"Umm, we don\u0027t? Since when? Rackspace was a historic example of a deployment with newer nova and much older cinder. This is why we have things like microversions and such so nova, as the client, can determine which version of the cinder API it needs to talk to. And we also don\u0027t require N-1 between services as far as I know. We don\u0027t gate that way, but it should certainly be possible because of versioned APIs.","commit_id":"82c5f9b23907fbef9b4566355fba032e53d8366f"}],"nova/volume/cinder.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7432ee21f105e3de4f36e23ee3fc855cfdea7be9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        #   1. The classic (legacy) endpoint:"},{"line_number":129,"context_line":"        #       http://{host}:{optional_port}/v{2 or 3}/{project-id}"},{"line_number":130,"context_line":"        #       http://{host}:{optional_port}/v{2 or 3}"},{"line_number":131,"context_line":"        #   3. Under wsgi:"},{"line_number":132,"context_line":"        #       http://{host}:{optional_port}/volume/v{2 or 3}"},{"line_number":133,"context_line":"        for ver in [\u0027v2\u0027, \u0027v3\u0027]:"},{"line_number":134,"context_line":"            if u.path.endswith(ver) or \"/{0}/\".format(ver) in u.path:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3fad24e7","line":131,"range":{"start_line":131,"start_character":12,"end_line":131,"end_character":14},"updated":"2018-11-14 23:02:07.000000000","message":"nit: Should this be 2. instead?","commit_id":"fee72b1a063bf79d9aad214ceb06eab8dcf558c2"}]}