)]}'
{"nova/api/openstack/ips.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"87839a5e03f3d35eab0d000d7ced698d31f8275b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return self._to_xml(addresses)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def _get_networks_for_instance(context, network_api, instance):"},{"line_number":147,"context_line":"    \"\"\"Returns a prepared nw_info list for passing into the view"},{"line_number":148,"context_line":"    builders"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B%2BM%3D","line":146,"updated":"2011-09-23 17:37:44.000000000","message":"Brian, is this what you are referring to when you say:\n\n\"To build a server entity, we now have to rpc call to get the network information from the network manager. This could cause some latency in the api that we should try to avoid. Could you implement the function at the network api level?\"\n\nI\u0027m not sure I follow, if this runs in the network_api it still runs in the same greenthread on the osapi side of the RPC call correct? Is this different than calling to compute_api to get the instance?","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"63ce92705daefb4b8ba900acc5236d1746a68f9b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return self._to_xml(addresses)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def _get_networks_for_instance(context, network_api, instance):"},{"line_number":147,"context_line":"    \"\"\"Returns a prepared nw_info list for passing into the view"},{"line_number":148,"context_line":"    builders"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B9w%3D","line":146,"in_reply_to":"AAAACX%2F%2F%2B%2BM%3D","updated":"2011-09-23 17:54:07.000000000","message":"Calling the network api is fine. The problem is when the network api then calls the network manager through rpc. The compute api handles the db call, it doesn\u0027t rpc call to the manager to get the information. I would love to follow that pattern in this case, too. I\u0027m concerned about relying on an rpc call every time we want to present a server entity through the API.","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"53a9432ffafd99ddf9da3342c5757b6b3c399ff3","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return self._to_xml(addresses)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def _get_networks_for_instance(context, network_api, instance):"},{"line_number":147,"context_line":"    \"\"\"Returns a prepared nw_info list for passing into the view"},{"line_number":148,"context_line":"    builders"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B7g%3D","line":146,"in_reply_to":"AAAACX%2F%2F%2B8Q%3D","updated":"2011-09-23 20:24:13.000000000","message":"You\u0027re 100% right. I talked with Dan/Lamar and I understand a lot better now.","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"299279f95bae552f2aca9a5b755bb170abadbca7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        return self._to_xml(addresses)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"def _get_networks_for_instance(context, network_api, instance):"},{"line_number":147,"context_line":"    \"\"\"Returns a prepared nw_info list for passing into the view"},{"line_number":148,"context_line":"    builders"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B8Q%3D","line":146,"in_reply_to":"AAAACX%2F%2F%2B9w%3D","updated":"2011-09-23 19:18:15.000000000","message":"The problem is that with melange it will not be the same DB. So there is no way to avoid an RPC call of some sort.","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"}],"nova/api/openstack/views/addresses.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"87839a5e03f3d35eab0d000d7ced698d31f8275b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            if not FLAGS.use_ipv6 and ip[\u0027version\u0027] \u003d\u003d 6:"},{"line_number":41,"context_line":"                continue"},{"line_number":42,"context_line":"            yield ip"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ViewBuilderV10(ViewBuilder):"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B%2BI%3D","line":43,"updated":"2011-09-23 17:37:44.000000000","message":"\"Some of the view logic was moved out of the view builders and into controllers. I question this because it makes the view builders much less useful\"\n\nIs this what you\u0027re referring to? That it now uses a prebuilt datastructure that the view builders share?","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"63ce92705daefb4b8ba900acc5236d1746a68f9b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            if not FLAGS.use_ipv6 and ip[\u0027version\u0027] \u003d\u003d 6:"},{"line_number":41,"context_line":"                continue"},{"line_number":42,"context_line":"            yield ip"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ViewBuilderV10(ViewBuilder):"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B9Y%3D","line":43,"in_reply_to":"AAAACX%2F%2F%2B%2BI%3D","updated":"2011-09-23 17:54:07.000000000","message":"This is what I\u0027m referring to. I question what value this module now adds if the majority of the presentation logic has moved up into the controller. I understand that it now uses a \u0027prebuilt datastructure\u0027, but imho, it was already using a datastructure (albeit an ugly one).","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"299279f95bae552f2aca9a5b755bb170abadbca7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            if not FLAGS.use_ipv6 and ip[\u0027version\u0027] \u003d\u003d 6:"},{"line_number":41,"context_line":"                continue"},{"line_number":42,"context_line":"            yield ip"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ViewBuilderV10(ViewBuilder):"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F%2B8I%3D","line":43,"in_reply_to":"AAAACX%2F%2F%2B9Y%3D","updated":"2011-09-23 19:18:15.000000000","message":"Would you rather I pass the network_api layer all the way down and make the floating_ips calls here then?","commit_id":"39ecb64d155af9bf734ff3982fd01c79ca818518"}]}