)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12b1ef2835b7bf8615c6a04422e4d055947a7bda","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_78ff5667","line":1208,"range":{"start_line":1208,"start_character":10,"end_line":1208,"end_character":19},"updated":"2019-06-03 16:17:34.000000000","message":"I don\u0027t believe images_type \u003d \u0027lvm\u0027 means we\u0027re using cinder, there might not be any volumes attached to the server, it just means we\u0027re storing the local disk in lvm volumes.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31d2fe267b57c1396b014f51a87dd5b524f5be35","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._undefine_domain(instance)"},{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"},{"line_number":1212,"context_line":"                               if lvmdisk.endswith(\u0027.swap\u0027)])"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _get_volume_driver(self, connection_info):"},{"line_number":1215,"context_line":"        driver_type \u003d connection_info.get(\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_e535e3f8","line":1212,"range":{"start_line":1207,"start_character":0,"end_line":1212,"end_character":61},"updated":"2019-06-03 16:41:41.000000000","message":"I think this is a (real, but) separate issue not related to your migration issue. I think we need to delete *all* lvm volumes for the instance here.\n\nThe bug here appears to be that we don\u0027t remove LVM volumes after a resize. Would you mind moving that into a separate change, preferrably with a different bug?","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":27928,"name":"Dr. Clemens Hardewig","email":"clemens.hardewig@crandale.de","username":"bringha1"},"change_message_id":"ff03c80a3555ab1551438403f78e2b46d65fb917","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._undefine_domain(instance)"},{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"},{"line_number":1212,"context_line":"                               if lvmdisk.endswith(\u0027.swap\u0027)])"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _get_volume_driver(self, connection_info):"},{"line_number":1215,"context_line":"        driver_type \u003d connection_info.get(\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_a6b235e5","line":1212,"range":{"start_line":1207,"start_character":0,"end_line":1212,"end_character":61},"in_reply_to":"9fb8cfa7_aa79a62f","updated":"2019-06-07 16:37:44.000000000","message":"Thanks Matt; have now as suggested opened a separate Bug for the cleanup (Bug #1831657) and submitted my proposal there; tried to map the wind river patch to my current rocky master but it is really old (2016) don\u0027t know why it was abandoned;\nI tried a different approach and tox said no error ....","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":27928,"name":"Dr. Clemens Hardewig","email":"clemens.hardewig@crandale.de","username":"bringha1"},"change_message_id":"358d5ca5916fbc504dc67a55604f7f6eb60ad402","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._undefine_domain(instance)"},{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"},{"line_number":1212,"context_line":"                               if lvmdisk.endswith(\u0027.swap\u0027)])"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _get_volume_driver(self, connection_info):"},{"line_number":1215,"context_line":"        driver_type \u003d connection_info.get(\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_e4b70a86","line":1212,"range":{"start_line":1207,"start_character":0,"end_line":1212,"end_character":61},"in_reply_to":"9fb8cfa7_c230c30a","updated":"2019-06-04 18:45:37.000000000","message":"Opened a new bug for it in Bug #1831657","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a7ad53a4110cf901d352dbc6f560526e52959dda","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._undefine_domain(instance)"},{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"},{"line_number":1212,"context_line":"                               if lvmdisk.endswith(\u0027.swap\u0027)])"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _get_volume_driver(self, connection_info):"},{"line_number":1215,"context_line":"        driver_type \u003d connection_info.get(\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_c230c30a","line":1212,"range":{"start_line":1207,"start_character":0,"end_line":1212,"end_character":61},"in_reply_to":"9fb8cfa7_d1097ddd","updated":"2019-06-04 10:12:56.000000000","message":"Yep, seeing lvm volumes left behind is what I\u0027d expect from this bug. I\u0027d personally recommend treating it as a separate bug because the changes have different root causes and affect different bits of the code.\n\nYou should delete *all* lvm volumes. If your root volume is provided by cinder it will not be exposed on the compute host as LVM, although if you\u0027re using iscsi it will be a block device. Cinder is not relevant to this patch at all, regardless of the backend or connector in use.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f9bc07ec1d998a1a2fbaf734cf44610cb37d5f08","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._undefine_domain(instance)"},{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"},{"line_number":1212,"context_line":"                               if lvmdisk.endswith(\u0027.swap\u0027)])"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _get_volume_driver(self, connection_info):"},{"line_number":1215,"context_line":"        driver_type \u003d connection_info.get(\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_aa79a62f","line":1212,"range":{"start_line":1207,"start_character":0,"end_line":1212,"end_character":61},"in_reply_to":"9fb8cfa7_e4b70a86","updated":"2019-06-07 00:29:41.000000000","message":"FYI, there is an old abandoned change from cfriesen to add lvm resize support: https://review.opendev.org/#/c/337334/","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":27928,"name":"Dr. Clemens Hardewig","email":"clemens.hardewig@crandale.de","username":"bringha1"},"change_message_id":"14222cae515b4abb63043cc6ed1b6809bcf79560","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"            self._undefine_domain(instance)"},{"line_number":1205,"context_line":"            self.unplug_vifs(instance, network_info)"},{"line_number":1206,"context_line":"            self.unfilter_instance(instance, network_info)"},{"line_number":1207,"context_line":"        # (bringha) delete swap devices if lvm volumes"},{"line_number":1208,"context_line":"        # in cinder are used"},{"line_number":1209,"context_line":"        if CONF.libvirt.images_type \u003d\u003d \u0027lvm\u0027:"},{"line_number":1210,"context_line":"            lvm.remove_volumes([lvmdisk for lvmdisk"},{"line_number":1211,"context_line":"                               in self._lvm_disks(instance)"},{"line_number":1212,"context_line":"                               if lvmdisk.endswith(\u0027.swap\u0027)])"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"    def _get_volume_driver(self, connection_info):"},{"line_number":1215,"context_line":"        driver_type \u003d connection_info.get(\u0027driver_volume_type\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_d1097ddd","line":1212,"range":{"start_line":1207,"start_character":0,"end_line":1212,"end_character":61},"in_reply_to":"9fb8cfa7_e535e3f8","updated":"2019-06-04 05:53:58.000000000","message":"Can open a separate bug for it... however, when I tested the instance resize, it left me with tons of old lvm swap volumes I had to clean up manually with lvremove\n\nNot sure whether to delete all lvm volumes: if the root volume is provided by cinder with iscsi, it stays at the old node and is connected to the instance on the new node via iscsi. Imho it\u0027s not copied","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12b1ef2835b7bf8615c6a04422e4d055947a7bda","unresolved":false,"context_lines":[{"line_number":8330,"context_line":"                # the OS is shut down, and as recreating a swap disk is very"},{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_f87586fb","line":8333,"range":{"start_line":8333,"start_character":29,"end_line":8333,"end_character":63},"updated":"2019-06-03 16:17:34.000000000","message":"nit: this isn\u0027t particularly useful - right how? Please expand/explain (if the filename is different in a resize situation or for a different type of image backend for example).","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":27928,"name":"Dr. Clemens Hardewig","email":"clemens.hardewig@crandale.de","username":"bringha1"},"change_message_id":"14222cae515b4abb63043cc6ed1b6809bcf79560","unresolved":false,"context_lines":[{"line_number":8330,"context_line":"                # the OS is shut down, and as recreating a swap disk is very"},{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_71277166","line":8333,"range":{"start_line":8333,"start_character":29,"end_line":8333,"end_character":63},"in_reply_to":"9fb8cfa7_f87586fb","updated":"2019-06-04 05:53:58.000000000","message":"Will correct towards a more speaking comment - my apologies","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"92de3a5a7b51c191995ec9b4c327bd0218cac342","unresolved":false,"context_lines":[{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_4e0df18e","line":8334,"range":{"start_line":8334,"start_character":25,"end_line":8334,"end_character":27},"updated":"2019-06-03 15:59:15.000000000","message":"This is weird. The condition will now trigger if fname is e.g. \u0027disk\u0027 or \u0027swap\u0027 or \u0027w\u0027 or \u0027sk.s\u0027 or...\n\nIs that what you intended?","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31d2fe267b57c1396b014f51a87dd5b524f5be35","unresolved":false,"context_lines":[{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_c519bf88","line":8334,"updated":"2019-06-03 16:41:41.000000000","message":"Wrong way round:\n\nif \u0027disk.swap\u0027 in fname:\n   ...\n\nIdeally we\u0027d parse this out in imagebackend, because this is ugly as hell, but this would be fine for now.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12b1ef2835b7bf8615c6a04422e4d055947a7bda","unresolved":false,"context_lines":[{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_f847c6bb","line":8334,"range":{"start_line":8334,"start_character":25,"end_line":8334,"end_character":27},"in_reply_to":"9fb8cfa7_4e0df18e","updated":"2019-06-03 16:17:34.000000000","message":"Is this trying to handle a _resize suffix in the filename or something?","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":27928,"name":"Dr. Clemens Hardewig","email":"clemens.hardewig@crandale.de","username":"bringha1"},"change_message_id":"14222cae515b4abb63043cc6ed1b6809bcf79560","unresolved":false,"context_lines":[{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_b1d2c933","line":8334,"range":{"start_line":8334,"start_character":25,"end_line":8334,"end_character":27},"in_reply_to":"9fb8cfa7_5b912c52","updated":"2019-06-04 05:53:58.000000000","message":"My fault - transfer error from my productive to the development instance. correct is \nif \u0027disk.swap\u0027 in fname","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"70b9ed5d41d6fd8cdda80a6d08893c941300bacd","unresolved":false,"context_lines":[{"line_number":8331,"context_line":"                # cheap it is more efficient than copying either locally or"},{"line_number":8332,"context_line":"                # over the network. This also means we don\u0027t have to resize it."},{"line_number":8333,"context_line":"                # (bringha): get handling of swap devices right"},{"line_number":8334,"context_line":"                if fname in \u0027disk.swap\u0027:"},{"line_number":8335,"context_line":"                    continue"},{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_5b912c52","line":8334,"range":{"start_line":8334,"start_character":25,"end_line":8334,"end_character":27},"in_reply_to":"9fb8cfa7_f847c6bb","updated":"2019-06-03 16:50:21.000000000","message":"@Matt, this is just excluding based on the type of disk due to special handling earlier.\n\nThe original code assumes it\u0027s a file path, which would have a basename of \u0027disk.swap\u0027 here. However, for LVM the basename of the logical volume (a block device) is \u0027/dev/\u003cvg\u003e/\u003cinstance_uuid\u003e_disk.swap\u0027, so fname here is \u003cinstance_uuid\u003e_disk.swap. As I commented it would be much nicer to have the imagebackend parse this for us and do an \u003d\u003d comparison, but it\u0027s not worth the code motion to make that happen imho. This code needs to die anyway.\n\nNote this this code would also be problematic for rbd, but rbd disks don\u0027t get here because in libvirt they don\u0027t have a path element, and are excluded earlier by _get_instance_disk_info_from_config().","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31d2fe267b57c1396b014f51a87dd5b524f5be35","unresolved":false,"context_lines":[{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"},{"line_number":8338,"context_line":"                # (bringha) Try copy only if source path exist"},{"line_number":8339,"context_line":"                if os.path.exists(from_path):"},{"line_number":8340,"context_line":"                    libvirt_utils.copy_image(from_path, img_path, host\u003ddest,"},{"line_number":8341,"context_line":"                                             on_execute\u003don_execute,"},{"line_number":8342,"context_line":"                                             on_completion\u003don_completion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_3840fe35","line":8339,"updated":"2019-06-03 16:41:41.000000000","message":"I don\u0027t think we want this. from_path should always exist, and if it didn\u0027t that would be a legitimate error.\n\nHowever... copy_image will fail for block devices because it uses scp. This is why migrations of LVM instances have never been supported.\n\nCold migration/resize of an LVM instance with swap and ephemeral is still going to fail, because we\u0027re going to fail to copy the ephemeral disk. However, after your fix above for swap disks, I don\u0027t see why we shouldn\u0027t allow swap-only flavors to succeed. We should produce a good error if from_path is a block device, though, because we know this isn\u0027t going to work.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"a7ad53a4110cf901d352dbc6f560526e52959dda","unresolved":false,"context_lines":[{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"},{"line_number":8338,"context_line":"                # (bringha) Try copy only if source path exist"},{"line_number":8339,"context_line":"                if os.path.exists(from_path):"},{"line_number":8340,"context_line":"                    libvirt_utils.copy_image(from_path, img_path, host\u003ddest,"},{"line_number":8341,"context_line":"                                             on_execute\u003don_execute,"},{"line_number":8342,"context_line":"                                             on_completion\u003don_completion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_650fa12e","line":8339,"in_reply_to":"9fb8cfa7_318819c5","updated":"2019-06-04 10:12:56.000000000","message":"Once you fix the test on line 8334 above you won\u0027t get here for swap because you\u0027ll short circuit.\n\nHowever, as I noted above if the flavor has an ephemeral disk you will still get here, and this will still fail. We should raise some kind of informative error highlighting that cold migration/resize isn\u0027t supported with LVM when the flavor has an ephemeral disk.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":27928,"name":"Dr. Clemens Hardewig","email":"clemens.hardewig@crandale.de","username":"bringha1"},"change_message_id":"14222cae515b4abb63043cc6ed1b6809bcf79560","unresolved":false,"context_lines":[{"line_number":8336,"context_line":""},{"line_number":8337,"context_line":"                compression \u003d info[\u0027type\u0027] not in NO_COMPRESSION_TYPES"},{"line_number":8338,"context_line":"                # (bringha) Try copy only if source path exist"},{"line_number":8339,"context_line":"                if os.path.exists(from_path):"},{"line_number":8340,"context_line":"                    libvirt_utils.copy_image(from_path, img_path, host\u003ddest,"},{"line_number":8341,"context_line":"                                             on_execute\u003don_execute,"},{"line_number":8342,"context_line":"                                             on_completion\u003don_completion,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_318819c5","line":8339,"in_reply_to":"9fb8cfa7_3840fe35","updated":"2019-06-04 05:53:58.000000000","message":"OK -  what if the instance has as root partition a normal cinder volume (which is the default if iscsi is used in cinder) and no ephermal disk (see bug description which contains the xml file of the instance);instance migration and resize works fine if the swap volume story is fixed ....\n\nfrom_path in my case looks like\nfrom_path \u003d /var/lib/nova/instances/\u003cuuid\u003e_resize/\u003cuuid\u003e_disk.swap\nif the swap device is a lvm volume, then this path does not exist; somehow the copy must take place only if swap is NO lvm volume ... how to prevent this ?","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31d2fe267b57c1396b014f51a87dd5b524f5be35","unresolved":false,"context_lines":[{"line_number":8406,"context_line":"            path \u003d info[\u0027path\u0027]"},{"line_number":8407,"context_line":"            disk_name \u003d os.path.basename(path)"},{"line_number":8408,"context_line":""},{"line_number":8409,"context_line":"            # (bringha) prevent that swap device is converted to qcow2"},{"line_number":8410,"context_line":"            if (\u0027disk.swap\u0027 in disk_name):"},{"line_number":8411,"context_line":"                continue"},{"line_number":8412,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_d8d68250","line":8409,"range":{"start_line":8409,"start_character":14,"end_line":8409,"end_character":23},"updated":"2019-06-03 16:41:41.000000000","message":"We normally only add a developer name for a NOTE, which tends to be a longer form comment describing something weird. We don\u0027t add them for short descriptive comments like this we.\n\nHowever, in this case the interesting comment here is *why* we\u0027re going to unconditionally ignore swap disks: it\u0027s because we can be sure they don\u0027t exist anyway. How about something like:\n\n# Ignore swap disks because we explicitly didn\u0027t copy them in migrate_disk_and_power_off.\n\nIncidentally, this is probably fixes a bug for other imagebackends, too.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"31d2fe267b57c1396b014f51a87dd5b524f5be35","unresolved":false,"context_lines":[{"line_number":8407,"context_line":"            disk_name \u003d os.path.basename(path)"},{"line_number":8408,"context_line":""},{"line_number":8409,"context_line":"            # (bringha) prevent that swap device is converted to qcow2"},{"line_number":8410,"context_line":"            if (\u0027disk.swap\u0027 in disk_name):"},{"line_number":8411,"context_line":"                continue"},{"line_number":8412,"context_line":""},{"line_number":8413,"context_line":"            # NOTE(mdbooth): The code below looks wrong, but is actually"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_38247ec6","line":8410,"updated":"2019-06-03 16:41:41.000000000","message":"Redundant parens.","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"92de3a5a7b51c191995ec9b4c327bd0218cac342","unresolved":false,"context_lines":[{"line_number":8407,"context_line":"            disk_name \u003d os.path.basename(path)"},{"line_number":8408,"context_line":""},{"line_number":8409,"context_line":"            # (bringha) prevent that swap device is converted to qcow2"},{"line_number":8410,"context_line":"            if (\u0027disk.swap\u0027 in disk_name):"},{"line_number":8411,"context_line":"                continue"},{"line_number":8412,"context_line":""},{"line_number":8413,"context_line":"            # NOTE(mdbooth): The code below looks wrong, but is actually"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_ceaa4118","line":8410,"range":{"start_line":8410,"start_character":15,"end_line":8410,"end_character":42},"updated":"2019-06-03 15:59:15.000000000","message":"nit: parens redundant","commit_id":"61c7746b6572f57a010a96354cc39f812e51368f"}]}