)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"9d996330191b39b043894048c6ef9b0c930531a9","unresolved":false,"context_lines":[{"line_number":7435,"context_line":"                    libvirt_migrate.save_stats(instance, migration,"},{"line_number":7436,"context_line":"                                               info, remaining)"},{"line_number":7437,"context_line":""},{"line_number":7438,"context_line":"                    # NOTE(fanzhang): do not include disk transfer stats in"},{"line_number":7439,"context_line":"                    # the progress percentage calculation but log them."},{"line_number":7440,"context_line":"                    disk_remaining \u003d 100"},{"line_number":7441,"context_line":"                    if info.disk_total !\u003d 0:"},{"line_number":7442,"context_line":"                        disk_remaining \u003d round(info.disk_remaining *"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fcb932e4","line":7439,"range":{"start_line":7438,"start_character":20,"end_line":7439,"end_character":71},"updated":"2018-12-11 06:37:29.000000000","message":"May I ask why? because bov instances won\u0027t have this value?","commit_id":"4931a79d9250d05edeafe7c033ea8040a3182f91"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"d747ee5cb258d94c4471f05e51b94c75ccd26a61","unresolved":false,"context_lines":[{"line_number":7435,"context_line":"                    libvirt_migrate.save_stats(instance, migration,"},{"line_number":7436,"context_line":"                                               info, remaining)"},{"line_number":7437,"context_line":""},{"line_number":7438,"context_line":"                    # NOTE(fanzhang): do not include disk transfer stats in"},{"line_number":7439,"context_line":"                    # the progress percentage calculation but log them."},{"line_number":7440,"context_line":"                    disk_remaining \u003d 100"},{"line_number":7441,"context_line":"                    if info.disk_total !\u003d 0:"},{"line_number":7442,"context_line":"                        disk_remaining \u003d round(info.disk_remaining *"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_02fda83a","line":7439,"range":{"start_line":7438,"start_character":20,"end_line":7439,"end_character":71},"in_reply_to":"3f79a3b5_fcb932e4","updated":"2018-12-11 07:41:12.000000000","message":"See the code above, there are notes at line 7426-7429. \n\nSo what I want to do is just to log the disk transfer stats(if any) and do not change other things, like the progress percentage calculation.","commit_id":"4931a79d9250d05edeafe7c033ea8040a3182f91"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"e2ca5769076776dbe7f9d93667494fe14deda8b7","unresolved":false,"context_lines":[{"line_number":7422,"context_line":"                    libvirt_migrate.save_stats(instance, migration,"},{"line_number":7423,"context_line":"                                               info, remaining)"},{"line_number":7424,"context_line":""},{"line_number":7425,"context_line":"                    # NOTE(fanzhang): do not include disk transfer stats in"},{"line_number":7426,"context_line":"                    # the progress percentage calculation but log them."},{"line_number":7427,"context_line":"                    disk_remaining \u003d 100"},{"line_number":7428,"context_line":"                    if info.disk_total !\u003d 0:"},{"line_number":7429,"context_line":"                        disk_remaining \u003d round(info.disk_remaining *"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_b9c5f75d","line":7426,"range":{"start_line":7425,"start_character":19,"end_line":7426,"end_character":71},"updated":"2018-12-22 09:40:31.000000000","message":"should it be better if you also update the stats? as admin can see it from API","commit_id":"8e97171637a3261cdffb3538c93bbbc63fd03c46"},{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"41b6e91d97bf7c0b8a9beb61e5953d664f6b054e","unresolved":false,"context_lines":[{"line_number":7422,"context_line":"                    libvirt_migrate.save_stats(instance, migration,"},{"line_number":7423,"context_line":"                                               info, remaining)"},{"line_number":7424,"context_line":""},{"line_number":7425,"context_line":"                    # NOTE(fanzhang): do not include disk transfer stats in"},{"line_number":7426,"context_line":"                    # the progress percentage calculation but log them."},{"line_number":7427,"context_line":"                    disk_remaining \u003d 100"},{"line_number":7428,"context_line":"                    if info.disk_total !\u003d 0:"},{"line_number":7429,"context_line":"                        disk_remaining \u003d round(info.disk_remaining *"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_d9cf9355","line":7426,"range":{"start_line":7425,"start_character":19,"end_line":7426,"end_character":71},"in_reply_to":"1f769fc5_b9c5f75d","updated":"2018-12-22 10:15:23.000000000","message":"You can see the progress details via API `GET /servers/{server_id}/migrations/{migration_id}`, see [1], but it does not include progress percentage as you can see the properties of nova.objects.migration.Migration [2] do not have percentage fields.\n\nWhat I want to do is simply logging the disks transfer percentage but not to calculate the percentage with disks because of the same reason as the comments berrange left above, at line 7413 to line 7416.\n\nIf you guys agree to include disk transfer stats in the progress percentage calculation, then I am OK to do that.\n\nThanks for the reviews :)\n\n[1].https://developer.openstack.org/api-ref/compute/?expanded\u003dlive-migrate-server-os-migratelive-action-detail,show-server-diagnostics-detail,show-server-action-details-detail,show-migration-details-detail#show-migration-details\n[2].https://github.com/openstack/nova/blob/master/nova/objects/migration.py#L36-L69","commit_id":"8e97171637a3261cdffb3538c93bbbc63fd03c46"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"eed41bc71e1320fe6d25b58012c38e3a98137a84","unresolved":false,"context_lines":[{"line_number":7422,"context_line":"                    libvirt_migrate.save_stats(instance, migration,"},{"line_number":7423,"context_line":"                                               info, remaining)"},{"line_number":7424,"context_line":""},{"line_number":7425,"context_line":"                    # NOTE(fanzhang): do not include disk transfer stats in"},{"line_number":7426,"context_line":"                    # the progress percentage calculation but log them."},{"line_number":7427,"context_line":"                    disk_remaining \u003d 100"},{"line_number":7428,"context_line":"                    if info.disk_total !\u003d 0:"},{"line_number":7429,"context_line":"                        disk_remaining \u003d round(info.disk_remaining *"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f769fc5_5f87ded8","line":7426,"range":{"start_line":7425,"start_character":19,"end_line":7426,"end_character":71},"in_reply_to":"1f769fc5_d9cf9355","updated":"2018-12-24 06:27:09.000000000","message":"Thanks for the reply","commit_id":"8e97171637a3261cdffb3538c93bbbc63fd03c46"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6212146aaa214fd9b402f5fbdcfcbbadfa0839e2","unresolved":false,"context_lines":[{"line_number":8049,"context_line":"                        \"processed_memory\": info.memory_processed,"},{"line_number":8050,"context_line":"                        \"remaining_memory\": info.memory_remaining,"},{"line_number":8051,"context_line":"                        \"total_memory\": info.memory_total,"},{"line_number":8052,"context_line":"                        \"disk_remaining\": disk_remaining,"},{"line_number":8053,"context_line":"                        \"processed_disk\": info.disk_processed,"},{"line_number":8054,"context_line":"                        \"remaining_disk\": info.disk_remaining,"},{"line_number":8055,"context_line":"                        \"total_disk\": info.disk_total}, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_0a390540","line":8052,"updated":"2019-06-19 13:39:40.000000000","message":"Why do you have disk_remaining, which you calculated yourself, and then we have \"remaining_disk\" below which comes from the job info? What is the difference?","commit_id":"9570e75752e047f9960ea919edd195a749714e84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"46603442537dfb32f8c3dffceb8e7943e4325631","unresolved":false,"context_lines":[{"line_number":8049,"context_line":"                        \"processed_memory\": info.memory_processed,"},{"line_number":8050,"context_line":"                        \"remaining_memory\": info.memory_remaining,"},{"line_number":8051,"context_line":"                        \"total_memory\": info.memory_total,"},{"line_number":8052,"context_line":"                        \"disk_remaining\": disk_remaining,"},{"line_number":8053,"context_line":"                        \"processed_disk\": info.disk_processed,"},{"line_number":8054,"context_line":"                        \"remaining_disk\": info.disk_remaining,"},{"line_number":8055,"context_line":"                        \"total_disk\": info.disk_total}, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_6a4e81c2","line":8052,"in_reply_to":"9fb8cfa7_0a390540","updated":"2019-06-19 13:43:09.000000000","message":"Oh nevermind, the first is the percentage, the latter is the bytes remaining.","commit_id":"9570e75752e047f9960ea919edd195a749714e84"}]}