)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"cf10cc18487b7e9a5e9bf6288b28f05213745c98","unresolved":false,"context_lines":[{"line_number":1078,"context_line":"                LOG.debug(e.format_message(), instance\u003dinstance)"},{"line_number":1079,"context_line":"                # Make sure the async call finishes"},{"line_number":1080,"context_line":"                if network_info is not None:"},{"line_number":1081,"context_line":"                    network_info.wait(do_raise\u003dFalse)"},{"line_number":1082,"context_line":"        except Exception:"},{"line_number":1083,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":1084,"context_line":"            # try to re-schedule instance:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9BuU%3D","line":1081,"updated":"2013-12-17 15:16:35.000000000","message":"I would rather short circuit unrecoverable errors here and not retry them at all.  (ex. bad/missing image)","commit_id":"1372e9cb472546ad83567abb421bcc1dfc76a30e"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"cf10cc18487b7e9a5e9bf6288b28f05213745c98","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"            # stringify to avoid circular ref problem in json serialization:"},{"line_number":1176,"context_line":"            retry[\u0027exc\u0027] \u003d traceback.format_exception(*exc_info)"},{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"            # tell the scheduler there was an issue getting the resources"},{"line_number":1179,"context_line":"            exception_type \u003d exc_info[0]"},{"line_number":1180,"context_line":"            if exception_type \u003d\u003d exception.ComputeResourcesUnavailable:"},{"line_number":1181,"context_line":"                retry[\u0027was_resource_unavailable\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9BuI%3D","line":1178,"updated":"2013-12-17 15:16:35.000000000","message":"The type checking is somewhat awkward","commit_id":"1372e9cb472546ad83567abb421bcc1dfc76a30e"}],"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"944056900ea3fb1dba9e9b204f025f08b0f4561f","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        raise_no_vaild_host \u003d num_attempts \u003e max_attempts"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        resource_issue \u003d retry.get(\"was_resource_unavailable\", False)"},{"line_number":278,"context_line":"        if not resource_issue:"},{"line_number":279,"context_line":"            if not retry[\"seen_no_resource_error\"]:"},{"line_number":280,"context_line":"                # error next time"},{"line_number":281,"context_line":"                retry[\"seen_no_resource_error\"] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9GxE%3D","line":278,"updated":"2013-12-16 18:46:57.000000000","message":"this is too messy, but the idea is to remove the config, and just have a single retry for non-resource manager errors.","commit_id":"8296efe04cc91585802aa5580b96b31d4aa3e759"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"cf10cc18487b7e9a5e9bf6288b28f05213745c98","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        instance_uuid \u003d instance_properties.get(\u0027uuid\u0027)"},{"line_number":274,"context_line":"        self._log_compute_error(instance_uuid, retry)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        resource_issue \u003d retry.get(\"was_resource_unavailable\")"},{"line_number":277,"context_line":"        if not resource_issue:"},{"line_number":278,"context_line":"            if not retry[\"error_seen\"]:"},{"line_number":279,"context_line":"                # error next time"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9BuA%3D","line":276,"updated":"2013-12-17 15:16:35.000000000","message":"This is hard to read.  Also, one retry is a bit of a one-size-fits-all.  I think it is just as arbitrary as just trying again 3 times. :)","commit_id":"1372e9cb472546ad83567abb421bcc1dfc76a30e"}]}