)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e78e9c5661755b2bd70585537a83351ec3da594a","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"        block_device_info \u003d \\"},{"line_number":1737,"context_line":"            self._get_instance_volume_block_device_info(context, instance_id)"},{"line_number":1738,"context_line":"        instance \u003d instance_ref[\u0027name\u0027]"},{"line_number":1739,"context_line":"        self.driver.destroy(instance, network_info, block_device_info, True)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"    def periodic_tasks(self, context\u003dNone):"},{"line_number":1742,"context_line":"        \"\"\"Tasks to be run at a periodic interval.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F94Y%3D","line":1739,"updated":"2011-09-30 14:35:25.000000000","message":"I\u0027m curious why you switched from instance_ref to instance_ref[\u0027name\u0027] here. As far as I can tell, you need to use the whole dict.","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a35e1a6a9654570e528f37fd02a42fd7bc2735a8","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"        block_device_info \u003d \\"},{"line_number":1737,"context_line":"            self._get_instance_volume_block_device_info(context, instance_id)"},{"line_number":1738,"context_line":"        instance \u003d instance_ref[\u0027name\u0027]"},{"line_number":1739,"context_line":"        self.driver.destroy(instance, network_info, block_device_info, True)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"    def periodic_tasks(self, context\u003dNone):"},{"line_number":1742,"context_line":"        \"\"\"Tasks to be run at a periodic interval.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F934%3D","line":1739,"in_reply_to":"AAAACX%2F%2F94Y%3D","updated":"2011-09-30 16:17:32.000000000","message":"yes, good point.  This looks like a bad merge by me.  Fixed","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"}],"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e78e9c5661755b2bd70585537a83351ec3da594a","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    # for no device to suppress devices."},{"line_number":470,"context_line":"    no_device \u003d Column(Boolean, nullable\u003dTrue)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    # dur, it\u0027s information about the connection!"},{"line_number":473,"context_line":"    connection_info \u003d Column(Text, nullable\u003dTrue)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F94U%3D","line":472,"updated":"2011-09-30 14:35:25.000000000","message":"As hilarious as it may be, I don\u0027t see why this comment is necessary ;)","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a35e1a6a9654570e528f37fd02a42fd7bc2735a8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    # for no device to suppress devices."},{"line_number":470,"context_line":"    no_device \u003d Column(Boolean, nullable\u003dTrue)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    # dur, it\u0027s information about the connection!"},{"line_number":473,"context_line":"    connection_info \u003d Column(Text, nullable\u003dTrue)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F930%3D","line":472,"in_reply_to":"AAAACX%2F%2F94U%3D","updated":"2011-09-30 16:17:32.000000000","message":"removed","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"}],"nova/virt/driver.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e78e9c5661755b2bd70585537a83351ec3da594a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        raise NotImplementedError()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":153,"context_line":"                cleanup\u003dTrue):"},{"line_number":154,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F94M%3D","line":152,"updated":"2011-09-30 14:35:25.000000000","message":"Can you add block_device_info to the docstring?","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a35e1a6a9654570e528f37fd02a42fd7bc2735a8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        \"\"\""},{"line_number":150,"context_line":"        raise NotImplementedError()"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":153,"context_line":"                cleanup\u003dTrue):"},{"line_number":154,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F93w%3D","line":152,"in_reply_to":"AAAACX%2F%2F94M%3D","updated":"2011-09-30 16:17:32.000000000","message":"sure done","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e78e9c5661755b2bd70585537a83351ec3da594a","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # TODO(Vek): Need to pass context in for access to auth_token"},{"line_number":205,"context_line":"        raise NotImplementedError()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def attach_volume(self, connection_info, instance_name, mountpoint):"},{"line_number":208,"context_line":"        \"\"\"Attach the disk to the instance at mountpoint using info\"\"\""},{"line_number":209,"context_line":"        raise NotImplementedError()"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F94I%3D","line":207,"updated":"2011-09-30 14:35:25.000000000","message":"I\u0027m not crazy about using instance_name, why not instance_id?","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a35e1a6a9654570e528f37fd02a42fd7bc2735a8","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        # TODO(Vek): Need to pass context in for access to auth_token"},{"line_number":205,"context_line":"        raise NotImplementedError()"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def attach_volume(self, connection_info, instance_name, mountpoint):"},{"line_number":208,"context_line":"        \"\"\"Attach the disk to the instance at mountpoint using info\"\"\""},{"line_number":209,"context_line":"        raise NotImplementedError()"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F93o%3D","line":207,"in_reply_to":"AAAACX%2F%2F94I%3D","updated":"2011-09-30 16:17:32.000000000","message":"instance_name is the way that the virtualization layer refers to the instance.  It may have been preferrable to use instance_id or (probably) uuid, but everything else is using instance_name, so we would have to do an extensive change and migration.","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"}],"nova/virt/xenapi/volumeops.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e78e9c5661755b2bd70585537a83351ec3da594a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # NOTE: No Resource Pool concept so far"},{"line_number":50,"context_line":"        LOG.debug(_(\"Attach_volume: %(connection_info)s, %(instance_name)s,\""},{"line_number":51,"context_line":"                \" %(mountpoint)s\") % locals())"},{"line_number":52,"context_line":"        driver_type \u003d connection_info[\u0027driver_volume_type\u0027]"},{"line_number":53,"context_line":"        if driver_type !\u003d \u0027iscsi\u0027:"},{"line_number":54,"context_line":"            raise exception.VolumeDriverNotFound(driver_type\u003ddriver_type)"},{"line_number":55,"context_line":"        # Create the iSCSI SR, and the PDB through which hosts access SRs."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F94E%3D","line":52,"updated":"2011-09-30 14:35:25.000000000","message":"connection_info is a string in the database, but it\u0027s used as a dict here. Can you document its format somewhere?","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"a35e1a6a9654570e528f37fd02a42fd7bc2735a8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # NOTE: No Resource Pool concept so far"},{"line_number":50,"context_line":"        LOG.debug(_(\"Attach_volume: %(connection_info)s, %(instance_name)s,\""},{"line_number":51,"context_line":"                \" %(mountpoint)s\") % locals())"},{"line_number":52,"context_line":"        driver_type \u003d connection_info[\u0027driver_volume_type\u0027]"},{"line_number":53,"context_line":"        if driver_type !\u003d \u0027iscsi\u0027:"},{"line_number":54,"context_line":"            raise exception.VolumeDriverNotFound(driver_type\u003ddriver_type)"},{"line_number":55,"context_line":"        # Create the iSCSI SR, and the PDB through which hosts access SRs."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F92U%3D","line":52,"in_reply_to":"AAAACX%2F%2F94E%3D","updated":"2011-09-30 16:17:32.000000000","message":"good point I have added it to the docstring for initialize_connection in the volume manager\nand iscsi params in the driver","commit_id":"4a770aaa8e0a991c70e13689001c4560ab45a0da"}]}