)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"50a54424c608e6f121536aba0971edb4fd2fe657","unresolved":false,"context_lines":[{"line_number":5121,"context_line":"        controllers"},{"line_number":5122,"context_line":"        \"\"\""},{"line_number":5123,"context_line":""},{"line_number":5124,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5125,"context_line":""},{"line_number":5126,"context_line":"        # TODO(kchamart) In the third \u0027if\u0027 conditional below, for \u0027x86\u0027"},{"line_number":5127,"context_line":"        # arch, we\u0027re assuming: when \u0027os_mach_type\u0027 is \u0027None\u0027, you\u0027ll"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4eb65efe","line":5124,"range":{"start_line":5124,"start_character":8,"end_line":5124,"end_character":44},"updated":"2018-11-28 22:56:37.000000000","message":"Is it necessary?\nWhy isn\u0027t \u0027caps\u0027 passed as an argument of \u0027_guest_needs_pcie\u0027 method?","commit_id":"8a5c7b51cd558f5a7b3183d890a1ef5905bf643c"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"cd2111598a4648f44292d17f0fd5bff884678038","unresolved":false,"context_lines":[{"line_number":5121,"context_line":"        controllers"},{"line_number":5122,"context_line":"        \"\"\""},{"line_number":5123,"context_line":""},{"line_number":5124,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5125,"context_line":""},{"line_number":5126,"context_line":"        # TODO(kchamart) In the third \u0027if\u0027 conditional below, for \u0027x86\u0027"},{"line_number":5127,"context_line":"        # arch, we\u0027re assuming: when \u0027os_mach_type\u0027 is \u0027None\u0027, you\u0027ll"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_db0f842a","line":5124,"range":{"start_line":5124,"start_character":8,"end_line":5124,"end_character":44},"in_reply_to":"3f79a3b5_4eb65efe","updated":"2018-11-29 10:07:22.000000000","message":"Hmm, probably it\u0027s not needed -- because we\u0027re already dumping \u0027caps\u0027 in _get_guest_config(); can pass it as an argument when calling it on line-5288.\n\nThanks for the review!","commit_id":"8a5c7b51cd558f5a7b3183d890a1ef5905bf643c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"de81f560a3e5ec766be266d462a5012edccc544e","unresolved":false,"context_lines":[{"line_number":5147,"context_line":"        # but only if their amount is configured"},{"line_number":5148,"context_line":""},{"line_number":5149,"context_line":"        if not CONF.libvirt.num_pcie_ports:"},{"line_number":5150,"context_line":"            return False"},{"line_number":5151,"context_line":"        if (caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64"},{"line_number":5152,"context_line":"                and guest.os_mach_type.startswith(\u0027virt\u0027)):"},{"line_number":5153,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b91e7e0c","line":5150,"updated":"2018-11-27 15:48:42.000000000","message":"So far so good - the original if has num_pcie_ports and \u003ceverything else\u003e","commit_id":"8a5c7b51cd558f5a7b3183d890a1ef5905bf643c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"de81f560a3e5ec766be266d462a5012edccc544e","unresolved":false,"context_lines":[{"line_number":5150,"context_line":"            return False"},{"line_number":5151,"context_line":"        if (caps.host.cpu.arch \u003d\u003d fields.Architecture.AARCH64"},{"line_number":5152,"context_line":"                and guest.os_mach_type.startswith(\u0027virt\u0027)):"},{"line_number":5153,"context_line":"            return True"},{"line_number":5154,"context_line":"        if (caps.host.cpu.arch \u003d\u003d fields.Architecture.X86_64"},{"line_number":5155,"context_line":"                and guest.os_mach_type is not None"},{"line_number":5156,"context_line":"                and \u0027q35\u0027 in guest.os_mach_type):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_59e2ca00","line":5153,"updated":"2018-11-27 15:48:42.000000000","message":"Also good - the \u003ceverything else\u003e is (aarch64 and machine type virt) or \u003csomething else\u003e","commit_id":"8a5c7b51cd558f5a7b3183d890a1ef5905bf643c"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"de81f560a3e5ec766be266d462a5012edccc544e","unresolved":false,"context_lines":[{"line_number":5153,"context_line":"            return True"},{"line_number":5154,"context_line":"        if (caps.host.cpu.arch \u003d\u003d fields.Architecture.X86_64"},{"line_number":5155,"context_line":"                and guest.os_mach_type is not None"},{"line_number":5156,"context_line":"                and \u0027q35\u0027 in guest.os_mach_type):"},{"line_number":5157,"context_line":"            return True"},{"line_number":5158,"context_line":"        return False"},{"line_number":5159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d9925a49","line":5156,"updated":"2018-11-27 15:48:42.000000000","message":"Still good - \u003csomethine else\u003e is x86)64 and \u0027q35\u0027 in machine type","commit_id":"8a5c7b51cd558f5a7b3183d890a1ef5905bf643c"}]}