)]}'
{"nova/network/security_group/neutron_driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3a953101b6ab8964b3466e0cd2b25f0ad01c26fa","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            nova_group \u003d self._convert_to_nova_security_group_format(group)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            # neutron don\u0027t allow filter through project id,"},{"line_number":150,"context_line":"            # so check here to ensure no access to resource that"},{"line_number":151,"context_line":"            # belong to current project"},{"line_number":152,"context_line":"            if nova_group[\u0027project_id\u0027] !\u003d context.project_id:"},{"line_number":153,"context_line":"                raise exception.SecurityGroupNotFound("},{"line_number":154,"context_line":"                    security_group_id\u003did)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e6dc4373","line":151,"range":{"start_line":150,"start_character":30,"end_line":151,"end_character":39},"updated":"2018-11-28 08:36:18.000000000","message":"I don\u0027t quite get what you mean here, seems you added a project_id filter in line 144.","commit_id":"66afd68c0b5a3a8e05311a420a17c19b85d40a5d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3a953101b6ab8964b3466e0cd2b25f0ad01c26fa","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # neutron don\u0027t allow filter through project id,"},{"line_number":150,"context_line":"            # so check here to ensure no access to resource that"},{"line_number":151,"context_line":"            # belong to current project"},{"line_number":152,"context_line":"            if nova_group[\u0027project_id\u0027] !\u003d context.project_id:"},{"line_number":153,"context_line":"                raise exception.SecurityGroupNotFound("},{"line_number":154,"context_line":"                    security_group_id\u003did)"},{"line_number":155,"context_line":"            return nova_group"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a6cdeb92","line":152,"range":{"start_line":152,"start_character":12,"end_line":152,"end_character":62},"updated":"2018-11-28 08:36:18.000000000","message":"this was get through search_opts \u003d {\"tenant_id\": context.project_id}, so I think the result will always be false(nova_group[\u0027project_id\u0027] always \u003d context.project_id)?\n\nIs your case that you used an admin and specified a SG belong to other user? and admin can get it with SG show API but cannot access it?If that is the case, I think maybe your change in line 152 here is redundant with 144.","commit_id":"66afd68c0b5a3a8e05311a420a17c19b85d40a5d"}]}