)]}'
{"nova/tests/unit/test_cinder.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9805f933bfe4a3d1448fc251e84952a455e39f53","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.assertIn(\u0027attachments\u0027, volume)"},{"line_number":235,"context_line":"        self.assertEqual(exp_volume_attachment_2, volume[\u0027attachments\u0027])"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_create_client_with_no_service_name(self):"},{"line_number":238,"context_line":"        \"\"\"Tests that service_name is not required and not passed through"},{"line_number":239,"context_line":"        when constructing the cinder client Client object if it\u0027s not"},{"line_number":240,"context_line":"        configured."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dac93a23","line":237,"updated":"2018-12-18 22:53:57.000000000","message":"nit: ..._with_service_name test case also could be nice to be maintained for existing config which contains service_name.","commit_id":"d0ba488c1df86905082a13cc8598548244db0fd7"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ad43073cf982851e2e3754e58ff7df58f9501427","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.assertIn(\u0027attachments\u0027, volume)"},{"line_number":235,"context_line":"        self.assertEqual(exp_volume_attachment_2, volume[\u0027attachments\u0027])"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_create_client_with_no_service_name(self):"},{"line_number":238,"context_line":"        \"\"\"Tests that service_name is not required and not passed through"},{"line_number":239,"context_line":"        when constructing the cinder client Client object if it\u0027s not"},{"line_number":240,"context_line":"        configured."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b619f68b","line":237,"in_reply_to":"3f79a3b5_d0e2799b","updated":"2018-12-19 01:52:16.000000000","message":"Then, that existing tests seem to become getting old now due to changing default.","commit_id":"d0ba488c1df86905082a13cc8598548244db0fd7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f54a8149320fb637f9253c86f73e1076c9b51a47","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.assertIn(\u0027attachments\u0027, volume)"},{"line_number":235,"context_line":"        self.assertEqual(exp_volume_attachment_2, volume[\u0027attachments\u0027])"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_create_client_with_no_service_name(self):"},{"line_number":238,"context_line":"        \"\"\"Tests that service_name is not required and not passed through"},{"line_number":239,"context_line":"        when constructing the cinder client Client object if it\u0027s not"},{"line_number":240,"context_line":"        configured."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d0e2799b","line":237,"in_reply_to":"3f79a3b5_dac93a23","updated":"2018-12-19 00:29:51.000000000","message":"The existing tests handle that since catalog_info defaults to \"volumev3:cinderv3:publicURL\".","commit_id":"d0ba488c1df86905082a13cc8598548244db0fd7"}]}