)]}'
{"nova/quota.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"dec28f292986806e064c5c049034f3aedbf09a38","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    for key in defaults.keys():"},{"line_number":96,"context_line":"        if key in quota:"},{"line_number":97,"context_line":"            if defaults[key] \u003d\u003d -1:"},{"line_number":98,"context_line":"                defaults[key] \u003d None"},{"line_number":99,"context_line":"            else:"},{"line_number":100,"context_line":"                defaults[key] \u003d quota[key]"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFH%2F%2F8DM%3D","line":98,"updated":"2012-04-04 13:44:26.000000000","message":"Actually, is this check even required? \n\n[as db.sqlalchemy.api.quota_class_create/update() has already mapped the -1 threshold to None, so -1 should never be returned from quota_class_get_all_by_name()]","commit_id":"f05d2d6e6c72b7a0d34b8ce029bda433e1ca76b8"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"809028ace5a104c9af93f26bf35efc84d7434c30","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    for key in defaults.keys():"},{"line_number":96,"context_line":"        if key in quota:"},{"line_number":97,"context_line":"            if defaults[key] \u003d\u003d -1:"},{"line_number":98,"context_line":"                defaults[key] \u003d None"},{"line_number":99,"context_line":"            else:"},{"line_number":100,"context_line":"                defaults[key] \u003d quota[key]"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAFH%2F%2F8Dc%3D","line":98,"updated":"2012-04-04 13:20:26.000000000","message":"Shouldn\u0027t this be:\n\n  if quotas[key] \u003d\u003d -1:\n      defaults[key] \u003d None\n\ni.e. the purpose here is to detect a -1 in the quota_classes and over-ride the default to unlimited in that case.\n\nAnother option would be to add a method like:\n\n  @staticmethod\n  def _map_unlimited(defaults):\n      for key in defaults.keys():\n          if defaults[key] \u003d\u003d -1:\n              defaults[key] \u003d None\n\nand call that from both get_class_quotas() and _get_default_quotas(), so that the -1\u003d\u003eNone mapping occurs in just one place in nova/quotas.py.","commit_id":"f05d2d6e6c72b7a0d34b8ce029bda433e1ca76b8"}]}