)]}'
{"nova/tests/functional/regressions/test_bug_1550919.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d62cf0e6d9bf310941cf863b29621cc002817150","unresolved":false,"context_lines":[{"line_number":62,"context_line":"     \u0027flavorRef\u0027: \u0027root_only\u0027,"},{"line_number":63,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":64,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":65,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":66,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":67,"context_line":"        \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":68,"context_line":"     }],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a67aa876","line":65,"updated":"2018-11-29 16:56:56.000000000","message":"I don\u0027t think this is the right uuid to use, this should be a volume id if source_type is volume, and given our cinder fixture you\u0027d want to use this id for a bootable volume:\n\nhttps://github.com/openstack/nova/blob/8c318d0fb20fdfe0ae8e203245e4d4d6668c8a44/nova/tests/fixtures.py#L1642","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2b165918d2e0ea33828cdaae71ebb6ff2741a62d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"     \u0027flavorRef\u0027: \u0027root_only\u0027,"},{"line_number":63,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":64,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":65,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":66,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":67,"context_line":"        \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":68,"context_line":"     }],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_26c21838","line":65,"in_reply_to":"3f79a3b5_a67aa876","updated":"2018-11-29 17:11:38.000000000","message":"Presumably this would break somewhere in attach, which we completely avoid. I\u0027ll fix it.","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d62cf0e6d9bf310941cf863b29621cc002817150","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # Local eph disk only"},{"line_number":71,"context_line":"    {\u0027name\u0027: \u0027bfv_with_eph\u0027,"},{"line_number":72,"context_line":"     \u0027flavorRef\u0027: \u0027with_ephemeral\u0027,"},{"line_number":73,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":74,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":75,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":76,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_06859c53","line":73,"range":{"start_line":73,"start_character":6,"end_line":73,"end_character":29},"updated":"2018-11-29 16:56:56.000000000","message":"Do we really need the bfv with the ephemeral and swap disk scenarios? The flavors themselves will generate ephemeral/swap bdms right for an image-backed instance. I\u0027m not sure it really matters though.","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2b165918d2e0ea33828cdaae71ebb6ff2741a62d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # Local eph disk only"},{"line_number":71,"context_line":"    {\u0027name\u0027: \u0027bfv_with_eph\u0027,"},{"line_number":72,"context_line":"     \u0027flavorRef\u0027: \u0027with_ephemeral\u0027,"},{"line_number":73,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":74,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":75,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":76,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_46887424","line":73,"range":{"start_line":73,"start_character":6,"end_line":73,"end_character":29},"in_reply_to":"3f79a3b5_06859c53","updated":"2018-11-29 17:11:38.000000000","message":"We wanted to specifically test that we\u0027re noticing creation of ephemeral/swap disks. Because the next patch short-circuits the first time it finds a local disk that we created, I\u0027ve intentionally created instances with only 1 local disk. We need to use BFV to ensure there\u0027s no local root disk.","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"2bd4c00a9a8c76b4f737149b6f8b3ea2a3385639","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    # Local eph disk only"},{"line_number":71,"context_line":"    {\u0027name\u0027: \u0027bfv_with_eph\u0027,"},{"line_number":72,"context_line":"     \u0027flavorRef\u0027: \u0027with_ephemeral\u0027,"},{"line_number":73,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":74,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":75,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":76,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_867e8ce0","line":73,"range":{"start_line":73,"start_character":6,"end_line":73,"end_character":29},"in_reply_to":"3f79a3b5_46887424","updated":"2018-11-29 17:15:35.000000000","message":"Thinking about it, that\u0027s important enough to add as a comment to this test. I\u0027ll do that, too.","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d62cf0e6d9bf310941cf863b29621cc002817150","unresolved":false,"context_lines":[{"line_number":72,"context_line":"     \u0027flavorRef\u0027: \u0027with_ephemeral\u0027,"},{"line_number":73,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":74,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":75,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":76,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":77,"context_line":"        \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":78,"context_line":"     }],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8679ac82","line":75,"updated":"2018-11-29 16:56:56.000000000","message":"same","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d62cf0e6d9bf310941cf863b29621cc002817150","unresolved":false,"context_lines":[{"line_number":82,"context_line":"     \u0027flavorRef\u0027: \u0027with_swap\u0027,"},{"line_number":83,"context_line":"     \u0027block_device_mapping_v2\u0027: [{"},{"line_number":84,"context_line":"        \u0027boot_index\u0027: 0,"},{"line_number":85,"context_line":"        \u0027uuid\u0027: IMAGE_ID,"},{"line_number":86,"context_line":"        \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":87,"context_line":"        \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":88,"context_line":"     }],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_268e987b","line":85,"updated":"2018-11-29 16:56:56.000000000","message":"same","commit_id":"4eb512aa15f9f80322b2889dfdafaab1b08da7c0"}]}