)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi_vm_util.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"a2f8f84400ad1f5d4950f55bf75d0ec2302ca00f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        fake_objects.add_object(fake.ObjectContent(\"prop_list_host1\","},{"line_number":105,"context_line":"                                                   prop_list_host_2))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        ResourcePoolResourceUsage \u003d fake.DataObject()"},{"line_number":108,"context_line":"        ResourcePoolResourceUsage.maxUsage \u003d 5368709120"},{"line_number":109,"context_line":"        ResourcePoolResourceUsage.overallUsage \u003d 2147483648"},{"line_number":110,"context_line":"        session \u003d fake_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9FOY%3D","line":107,"updated":"2013-12-16 23:56:02.000000000","message":"naming convention can be changed for ResourcePoolResourceUsage, probably to underscore.","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f7e4789286913bde3d3960b1a3431c1009ee8ea9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        fake_objects.add_object(fake.ObjectContent(\"prop_list_host1\","},{"line_number":105,"context_line":"                                                   prop_list_host_2))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        ResourcePoolResourceUsage \u003d fake.DataObject()"},{"line_number":108,"context_line":"        ResourcePoolResourceUsage.maxUsage \u003d 5368709120"},{"line_number":109,"context_line":"        ResourcePoolResourceUsage.overallUsage \u003d 2147483648"},{"line_number":110,"context_line":"        session \u003d fake_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9Aws%3D","line":107,"in_reply_to":"AAAATn%2F9E9g%3D","updated":"2013-12-17 18:02:04.000000000","message":"respool_resource_usage or something similar.","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":9046,"name":"Maithem","email":"munshedm@vmware.com","username":"Maithem"},"change_message_id":"a11a1cee5403b7951cc52abd401ef07e1455e388","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        fake_objects.add_object(fake.ObjectContent(\"prop_list_host1\","},{"line_number":105,"context_line":"                                                   prop_list_host_2))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        ResourcePoolResourceUsage \u003d fake.DataObject()"},{"line_number":108,"context_line":"        ResourcePoolResourceUsage.maxUsage \u003d 5368709120"},{"line_number":109,"context_line":"        ResourcePoolResourceUsage.overallUsage \u003d 2147483648"},{"line_number":110,"context_line":"        session \u003d fake_session()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9E9g%3D","line":107,"in_reply_to":"AAAATn%2F9FOY%3D","updated":"2013-12-17 01:01:58.000000000","message":"What do you suggest?","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9563826c4047813fcabbee408b82ad70733ca968","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        session \u003d fake_session()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        def fake_call_method(*args):"},{"line_number":113,"context_line":"            if \"get_dynamic_properties\" in args:"},{"line_number":114,"context_line":"                return prop_dict"},{"line_number":115,"context_line":"            elif \"get_properties_for_a_collection_of_objects\" in args:"},{"line_number":116,"context_line":"                return fake_objects"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9L1A%3D","line":113,"updated":"2013-12-15 09:31:46.000000000","message":"why not args.get?","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":9046,"name":"Maithem","email":"munshedm@vmware.com","username":"Maithem"},"change_message_id":"ef0cbca129b96a0e027451c667067756989e1f3c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        session \u003d fake_session()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        def fake_call_method(*args):"},{"line_number":113,"context_line":"            if \"get_dynamic_properties\" in args:"},{"line_number":114,"context_line":"                return prop_dict"},{"line_number":115,"context_line":"            elif \"get_properties_for_a_collection_of_objects\" in args:"},{"line_number":116,"context_line":"                return fake_objects"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9GWQ%3D","line":113,"in_reply_to":"AAAATn%2F9L1A%3D","updated":"2013-12-16 19:57:44.000000000","message":"Because args is a tuple.","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13e8272a672bf726f4eae366a68f0d86f8677d90","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            mem_info[\u0027total\u0027] \u003d 5120"},{"line_number":129,"context_line":"            mem_info[\u0027free\u0027] \u003d 3072"},{"line_number":130,"context_line":"            expected_stats \u003d {\u0027cpu\u0027: cpu_info, \u0027mem\u0027: mem_info}"},{"line_number":131,"context_line":"            self.assertEqual(result, expected_stats)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_get_datastore_ref_and_name_with_list(self):"},{"line_number":134,"context_line":"        # Test with a regex containing whitelist of datastores"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2F46Y%3D","line":131,"updated":"2014-01-07 07:15:50.000000000","message":"This should be:self.assertEqual(expected_stats, result)","commit_id":"0a41f6349f33ab1e32fc68acb3e329fea0ff92f6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"369b2b93e3b9ac8e96bed9b5090155bd67b16811","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import collections"},{"line_number":20,"context_line":"import mock"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2F2J4%3D","line":20,"updated":"2014-01-07 18:55:22.000000000","message":"mock is a third party include. can you please have this in a spearte section","commit_id":"320b9d0e24a5fea741378e2ed413e7e475c73a92"}],"nova/virt/vmwareapi/fake.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"a2f8f84400ad1f5d4950f55bf75d0ec2302ca00f","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        hardware.memorySize \u003d unit.Gi"},{"line_number":593,"context_line":"        summary.hardware \u003d hardware"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        runtime \u003d DataObject()"},{"line_number":596,"context_line":"        if connected:"},{"line_number":597,"context_line":"            runtime.connectionState \u003d \"connected\""},{"line_number":598,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9FM4%3D","line":595,"updated":"2013-12-16 23:56:02.000000000","message":"Though the changes to fake are valid, i don\u0027t think you are using this in your test. Right ?","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"f7e4789286913bde3d3960b1a3431c1009ee8ea9","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        hardware.memorySize \u003d unit.Gi"},{"line_number":593,"context_line":"        summary.hardware \u003d hardware"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        runtime \u003d DataObject()"},{"line_number":596,"context_line":"        if connected:"},{"line_number":597,"context_line":"            runtime.connectionState \u003d \"connected\""},{"line_number":598,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9AxY%3D","line":595,"in_reply_to":"AAAATn%2F9E%2BE%3D","updated":"2013-12-17 18:02:04.000000000","message":"Got it. I asked this because runtime.connectionState was already getting set, but now I see runtime was not a DataObject. Thanks","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"},{"author":{"_account_id":9046,"name":"Maithem","email":"munshedm@vmware.com","username":"Maithem"},"change_message_id":"a11a1cee5403b7951cc52abd401ef07e1455e388","unresolved":false,"context_lines":[{"line_number":592,"context_line":"        hardware.memorySize \u003d unit.Gi"},{"line_number":593,"context_line":"        summary.hardware \u003d hardware"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        runtime \u003d DataObject()"},{"line_number":596,"context_line":"        if connected:"},{"line_number":597,"context_line":"            runtime.connectionState \u003d \"connected\""},{"line_number":598,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9E%2BE%3D","line":595,"in_reply_to":"AAAATn%2F9FM4%3D","updated":"2013-12-17 01:01:58.000000000","message":"Correct, I am not using it in my test, but since this object is being used by other tests that call the the new get cluster stats (which needs to access runtime attribute), it needs this change, otherwise it will break.","commit_id":"259a903fd56c864aa0c5df0cb14fa6cbe381d15a"}]}