)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c67850e8056ca8aa3bc14a39d38ac63ba0b6f36f","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        try:"},{"line_number":1292,"context_line":"            self._disconnect_volume(context, connection_info, instance)"},{"line_number":1293,"context_line":"        except Exception as ex:"},{"line_number":1294,"context_line":"            # TODO(mriedem): Maybe we should let this raise instead?"},{"line_number":1295,"context_line":"            LOG.error(\u0027Failed to disconnect volume %s from this host. \u0027"},{"line_number":1296,"context_line":"                      \u0027Error: %s\u0027, volume_id, six.text_type(ex),"},{"line_number":1297,"context_line":"                      instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_01e73a14","line":1294,"range":{"start_line":1294,"start_character":12,"end_line":1294,"end_character":68},"updated":"2019-02-13 08:26:37.000000000","message":"do we care about this? I mean do we have to perform some handling or it doesn\u0027t matter since we will connect it again when we pefrom migration. will it be a problem to try to connect an already connected volume?","commit_id":"1a78c9e0cfef98ee6528c2054cedb817284dfc93"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4632d7423f78106058b966bd61a8814b405356b","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        try:"},{"line_number":1292,"context_line":"            self._disconnect_volume(context, connection_info, instance)"},{"line_number":1293,"context_line":"        except Exception as ex:"},{"line_number":1294,"context_line":"            # TODO(mriedem): Maybe we should let this raise instead?"},{"line_number":1295,"context_line":"            LOG.error(\u0027Failed to disconnect volume %s from this host. \u0027"},{"line_number":1296,"context_line":"                      \u0027Error: %s\u0027, volume_id, six.text_type(ex),"},{"line_number":1297,"context_line":"                      instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_4ba0ddf4","line":1294,"range":{"start_line":1294,"start_character":12,"end_line":1294,"end_character":68},"in_reply_to":"9fdfeff1_01e73a14","updated":"2019-02-14 13:52:33.000000000","message":"I\u0027m not sure, hence the TODO. It\u0027s probably safest to log and re-raise the exception. Then prep_snapshot_based_resize_at_dest will handled it and raise MigrationPreCheckError and we\u0027ll skip this host.","commit_id":"1a78c9e0cfef98ee6528c2054cedb817284dfc93"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c57656d9afa4da2c7fcee555738f194fa9a5ffbc","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        try:"},{"line_number":1292,"context_line":"            self._disconnect_volume(context, connection_info, instance)"},{"line_number":1293,"context_line":"        except Exception as ex:"},{"line_number":1294,"context_line":"            # TODO(mriedem): Maybe we should let this raise instead?"},{"line_number":1295,"context_line":"            LOG.error(\u0027Failed to disconnect volume %s from this host. \u0027"},{"line_number":1296,"context_line":"                      \u0027Error: %s\u0027, volume_id, six.text_type(ex),"},{"line_number":1297,"context_line":"                      instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_404e7797","line":1294,"range":{"start_line":1294,"start_character":12,"end_line":1294,"end_character":68},"in_reply_to":"9fdfeff1_4ba0ddf4","updated":"2019-02-14 17:03:35.000000000","message":"Done","commit_id":"1a78c9e0cfef98ee6528c2054cedb817284dfc93"}]}