)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b646f8463e4fe2740a81b16e57bf8441c9cc324f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import nova.conf"},{"line_number":38,"context_line":"from nova import exception"},{"line_number":39,"context_line":"from nova.i18n import _"},{"line_number":40,"context_line":"from nova.network import linux_utils as linux_net_utils"},{"line_number":41,"context_line":"from nova import objects"},{"line_number":42,"context_line":"from nova.pci import utils as pci_utils"},{"line_number":43,"context_line":"import nova.privsep.linux_net"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_92bb1010","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":55},"updated":"2018-12-13 05:57:32.000000000","message":"It should be removed.","commit_id":"b88074fcc5d840de962845f09d5c206406838c8e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"37a325cd297e79c7be475961d1f89fbcd692fe6d","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"                        \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address])"},{"line_number":1671,"context_line":"            _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, dev, \u0027address\u0027, mac_address,"},{"line_number":1672,"context_line":"                     run_as_root\u003dTrue)"},{"line_number":1673,"context_line":"            nova.privsep.linux_net.set_device_mtu(dev, network.get(\u0027mtu\u0027))"},{"line_number":1674,"context_line":"            _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, dev, \u0027up\u0027, run_as_root\u003dTrue)"},{"line_number":1675,"context_line":"            if not gateway:"},{"line_number":1676,"context_line":"                # If we weren\u0027t instructed to act as a gateway then add the"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_5e9264f8","line":1673,"range":{"start_line":1673,"start_character":0,"end_line":1673,"end_character":74},"updated":"2019-01-14 17:38:06.000000000","message":"I\u0027m guessing this should be rolled into the previous change?","commit_id":"571355d40f78b6dacbaf8fd3401f96a50708febb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f3c0c9e72506af7fa716f022975978708386caa1","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"                        \u0027external-ids:attached-mac\u003d%s\u0027 % mac_address])"},{"line_number":1671,"context_line":"            _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, dev, \u0027address\u0027, mac_address,"},{"line_number":1672,"context_line":"                     run_as_root\u003dTrue)"},{"line_number":1673,"context_line":"            nova.privsep.linux_net.set_device_mtu(dev, network.get(\u0027mtu\u0027))"},{"line_number":1674,"context_line":"            _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, dev, \u0027up\u0027, run_as_root\u003dTrue)"},{"line_number":1675,"context_line":"            if not gateway:"},{"line_number":1676,"context_line":"                # If we weren\u0027t instructed to act as a gateway then add the"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_14635b1c","line":1673,"range":{"start_line":1673,"start_character":0,"end_line":1673,"end_character":74},"in_reply_to":"bfdaf3ff_5e9264f8","updated":"2019-01-14 19:42:11.000000000","message":"The previous patch is already approved, so it is nice to merge this also at this time..","commit_id":"571355d40f78b6dacbaf8fd3401f96a50708febb"}],"nova/tests/functional/api_sample_tests/api_sample_base.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9a8c28979f80a5ef6de78d91de88c341c07a8da1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        def fake_noop(*args, **kwargs):"},{"line_number":127,"context_line":"            return \u0027\u0027, \u0027\u0027"},{"line_number":128,"context_line":"        self.stub_out(\u0027nova.privsep.linux_net.add_bridge\u0027, fake_noop)"},{"line_number":129,"context_line":"        self.stub_out(\u0027nova.privsep.linux_net.set_device_mtu\u0027, fake_noop)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _setup_services(self):"},{"line_number":132,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_97f9941c","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":73},"updated":"2018-12-04 00:54:49.000000000","message":"This line should be added in the parent patch ( https://review.openstack.org/#/c/621398/ ).\nThe functional tests of the parent patch fails.","commit_id":"97262477d104bb4866d490a062ea710a55e2d8a4"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"e0c29dd993ac652cd8d461cf9f751c3f552dfc48","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        def fake_noop(*args, **kwargs):"},{"line_number":127,"context_line":"            return \u0027\u0027, \u0027\u0027"},{"line_number":128,"context_line":"        self.stub_out(\u0027nova.privsep.linux_net.add_bridge\u0027, fake_noop)"},{"line_number":129,"context_line":"        self.stub_out(\u0027nova.privsep.linux_net.set_device_mtu\u0027, fake_noop)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _setup_services(self):"},{"line_number":132,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_aef9d61b","line":129,"range":{"start_line":129,"start_character":8,"end_line":129,"end_character":73},"in_reply_to":"3f79a3b5_97f9941c","updated":"2018-12-04 07:59:47.000000000","message":"Good catch, thanks!","commit_id":"97262477d104bb4866d490a062ea710a55e2d8a4"}]}