)]}'
{"nova/network/linux_net.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b68432cb5ec7fe4de1d9b824e2a0f0e41a987bc5","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"                _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027address\u0027, interface_mac,"},{"line_number":1453,"context_line":"                         run_as_root\u003dTrue)"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"            nova.privsep.linux_net.set_device_enabled(interface)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"            # NOTE(vish): This will break if there is already an ip on the"},{"line_number":1458,"context_line":"            #             interface, so we move any ips to the bridge"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_be7350e7","line":1455,"range":{"start_line":1455,"start_character":12,"end_line":1455,"end_character":64},"updated":"2019-01-14 17:41:08.000000000","message":"This isn\u0027t the same thing. We were explicitly not checking exit codes here previously, whereas now we\u0027re checking for [0,2, 254]. That said, the exit codes don\u0027t appear to be documented in the man page so I\u0027m not sure what this should be looking for.","commit_id":"07403a490bb6d390e8e923a1d4fec1dd969e5089"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a937727f27c18b0cef3e6bacd6a03af4a00f5b5c","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"                _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027address\u0027, interface_mac,"},{"line_number":1453,"context_line":"                         run_as_root\u003dTrue)"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"            nova.privsep.linux_net.set_device_enabled(interface)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"            # NOTE(vish): This will break if there is already an ip on the"},{"line_number":1458,"context_line":"            #             interface, so we move any ips to the bridge"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_594a7e55","line":1455,"range":{"start_line":1455,"start_character":12,"end_line":1455,"end_character":64},"in_reply_to":"bfdaf3ff_be7350e7","updated":"2019-01-14 17:54:56.000000000","message":"Sean thinks it\u0027s OK (and this code might even be unused now) so let\u0027s do it.\n\n\u003cstephenfin\u003e sean-k-mooney: thoughts on https://review.openstack.org/#/c/621528/5/nova/network/linux_net.py@1455 ?\n\u003csean-k-mooney\u003e  exitcode 2 is file not found or interface not found in this case\n\u003csean-k-mooney\u003e 254 im not sure and 0 is success\n\u003csean-k-mooney\u003e what is that patch for\n\u003csean-k-mooney\u003e oh its the privesep changes im not sure if that code is used as os-vif should be used even for nova-networks\n\u003cstephenfin\u003e sean-k-mooney: Aye, could be nova-network only code\n\u003csean-k-mooney\u003e you mean unrelated to vif plugging\n\u003cstephenfin\u003e No I mean the file I\u0027m linking to seems to be nova-network only code and unrelated to the neutron/os-vif code path\n\u003cstephenfin\u003e We don\u0027t use os-vif for nova-net, do we?\n\u003csean-k-mooney\u003e yes we do\n\u003csean-k-mooney\u003e os-vif should be used for both nova-networks and neutorn in the libvirt dirver\n\u003csean-k-mooney\u003e this is the legacy linux bridge code path which i think is unused currently\n\u003csean-k-mooney\u003e in any case you are coorect that its a change in behavior but i think exit codes [0,2,254] would have been the correct set to use in this case","commit_id":"07403a490bb6d390e8e923a1d4fec1dd969e5089"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7223c56a311ba346db1e897b8c6af6c1d8e56d41","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"                _execute(\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, bridge, \u0027address\u0027, interface_mac,"},{"line_number":1453,"context_line":"                         run_as_root\u003dTrue)"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"            nova.privsep.linux_net.set_device_enabled(interface)"},{"line_number":1456,"context_line":""},{"line_number":1457,"context_line":"            # NOTE(vish): This will break if there is already an ip on the"},{"line_number":1458,"context_line":"            #             interface, so we move any ips to the bridge"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_39521a15","line":1455,"range":{"start_line":1455,"start_character":12,"end_line":1455,"end_character":64},"in_reply_to":"bfdaf3ff_be7350e7","updated":"2019-01-14 18:02:07.000000000","message":"i think this is safe as that is the set of exit code that os-vif uses for similar actions.\nif the device does not exist (e.g. because the vm has not started yet) it will have an exit code of 2 which is likely why cech_exit_code\u003dFalse was set\n\nif we were worried we could wrap it in a try block to get the old behavior","commit_id":"07403a490bb6d390e8e923a1d4fec1dd969e5089"}]}