)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40a9a7c5d2a0fa0b7faf7717289d11b49faec1bb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"* Update oslo.policy and olso.messaging to versions that work with the"},{"line_number":51,"context_line":"  tests, under Python 3."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"NOTE: There is one remaining failing test which it is not clear how to"},{"line_number":54,"context_line":"resolve. \u0027test_policy_generator_from_command_line\u0027 forks a call to"},{"line_number":55,"context_line":"\u0027oslopolicy-policy-generator --namespace nova\u0027 which fails because"},{"line_number":56,"context_line":"stevedore fails to pick up nova-based entry points when in a different"},{"line_number":57,"context_line":"process. This is because of the change to usedevelop. Presumably the"},{"line_number":58,"context_line":"test can be changed to not fork, and instead call the generator"},{"line_number":59,"context_line":"directly. Another option is to get rid of it, doesn\u0027t seem to do that"},{"line_number":60,"context_line":"much. Input desired."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[1] Id66a28f7ace6fc2adf0e1201d9de5f901234d870"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_5e068524","line":60,"range":{"start_line":53,"start_character":0,"end_line":60,"end_character":20},"updated":"2018-12-05 14:35:31.000000000","message":"As noted on IRC,  I\u0027d kill the test, personally. lbragstad added it in 6244a442784 and, while I get what it\u0027s doing, I don\u0027t think the lower-constraints thing is more of an issue. Would be good to get another opinion though.","commit_id":"fef5c06d5efb3f02704a40d63113aa745673376f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c7c833736797057377223d85cf958fdf1bb46327","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Update psycopg2 to a version that can talk with postgresql 10."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Add PyJWT, used by zVMCloudConnector"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Update zVMCloudConnector to a version that works with Python 3.5 and"},{"line_number":48,"context_line":"  beyond."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* Update oslo.policy and olso.messaging to versions that work with the"},{"line_number":51,"context_line":"  tests, under Python 3."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_25ba8adf","line":48,"range":{"start_line":45,"start_character":0,"end_line":48,"end_character":9},"updated":"2018-12-06 03:28:03.000000000","message":"thanks for the the update, the changes looks good to me","commit_id":"f7bfbb6ca4b2c6bdf87d7b83989106a328b31127"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7d4a87de1d0e01e9d9485a2b64872bcc07d6439b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"considered an acceptable choice."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"[1] http://eavesdrop.openstack.org/irclogs/%23openstack-dev/%23openstack-dev.2019-03-05.log.html#t2019-03-05T13:28:23"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Change-Id: Ic6466b0440a4fe012731a63715cf5d793b6ae4dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5fc1f717_c5fd3e6f","line":81,"updated":"2019-04-01 19:15:04.000000000","message":"Closes-Bug: #1822575","commit_id":"990c7d6926b191ade4cfa97212dd4526085f26d2"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b2bb98f0ef7f1b500a3327c6f2adc8702ad711ed","unresolved":false,"context_lines":[{"line_number":275,"context_line":"# when making the environment. Set usedevelop to false to avoid pbr installing"},{"line_number":276,"context_line":"# requirements for us so all requirements are install in one call to pip."},{"line_number":277,"context_line":"usedevelop \u003d False"},{"line_number":278,"context_line":"# We must sdist to ensure the entry-points are found."},{"line_number":279,"context_line":"skipsdist \u003d False"},{"line_number":280,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":281,"context_line":"deps \u003d"},{"line_number":282,"context_line":"  -c{toxinidir}/lower-constraints.txt"}],"source_content_type":"text/x-properties","patch_set":5,"id":"3f79a3b5_1d8469ae","line":279,"range":{"start_line":278,"start_character":0,"end_line":279,"end_character":17},"updated":"2018-12-07 15:28:31.000000000","message":"This is a global setting. I\u0027m pretty sure you can\u0027t override it on a per-environment basis:\n\n  https://tox.readthedocs.io/en/latest/config.html#tox-global-settings\n\nThat being said, we\u0027re using \u0027usedevelop\u0027 for all environment except this and \u0027bindep\u0027. Installing this way prevents sdist generation by default:\n\n  https://tox.readthedocs.io/en/latest/example/general.html#avoiding-expensive-sdist\n\nAs such, couldn\u0027t we simply define \u0027usedevelop\u0027 here and drop \u0027skipsdist\u0027 entirely (from \u0027[tox]\u0027 too)?","commit_id":"f924ff563e5b8818245985f48aef51e58945005f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"bf3079ecd6840d3d5334a5f7d3c625703225d64f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.1"},{"line_number":3,"context_line":"envlist \u003d py{27,35},functional,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_548ab61d","side":"PARENT","line":4,"updated":"2018-12-07 14:39:39.000000000","message":"The bummer about removing this is that it does (as advertised) really slow down the tox run: gathering up all the nova bits is slow locally and will be extra super slow on the i/o crippled vms in the gate. Not sure if there is an alternative, but we might want to dig.","commit_id":"4a688c3387ff81ad1c0166db7d2f2215ecf94cc6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"94c260df8b2d92c9556dee51ce5873a5560ddb06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 2.1"},{"line_number":3,"context_line":"envlist \u003d py{27,35},functional,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"basepython \u003d python3"}],"source_content_type":"text/x-properties","patch_set":6,"id":"3f79a3b5_8fe35b9f","side":"PARENT","line":4,"in_reply_to":"3f79a3b5_548ab61d","updated":"2018-12-07 15:30:32.000000000","message":"As noted here [1], I don\u0027t think this will have any effect where we\u0027re using usedevelop\n\n[1] https://review.openstack.org/#/c/622972/5/tox.ini","commit_id":"4a688c3387ff81ad1c0166db7d2f2215ecf94cc6"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7d4a87de1d0e01e9d9485a2b64872bcc07d6439b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"[testenv:lower-constraints]"},{"line_number":279,"context_line":"# We need our own install command to avoid upper constraints being considered"},{"line_number":280,"context_line":"# when making the environment. Set usedevelop to false to avoid pbr installing"},{"line_number":281,"context_line":"# requirements for us so all requirements are install in one call to pip."},{"line_number":282,"context_line":"usedevelop \u003d False"},{"line_number":283,"context_line":"install_command \u003d pip install {opts} {packages}"},{"line_number":284,"context_line":"deps \u003d"}],"source_content_type":"text/x-properties","patch_set":14,"id":"5fc1f717_2509a294","line":281,"range":{"start_line":281,"start_character":46,"end_line":281,"end_character":53},"updated":"2019-04-01 19:15:04.000000000","message":"installed","commit_id":"990c7d6926b191ade4cfa97212dd4526085f26d2"}]}