)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"13face4b461d35c3d3e90d6e7998b75762bbc5b5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":"LAST_VERSION \u003d None"},{"line_number":37,"context_line":"NO_COMPUTES_WARNING \u003d False"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _compute_host(host, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d7401a8d","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":19},"updated":"2018-12-06 19:35:37.000000000","message":"This made me think we log it at warning level, but I guess it\u0027s debug. I wonder if we should make that info level since now we\u0027d only log it once.","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f34e3bf8f136d9ffde06a9b0aea47737e51aae2a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":"LAST_VERSION \u003d None"},{"line_number":37,"context_line":"NO_COMPUTES_WARNING \u003d False"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _compute_host(host, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4f87920b","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":19},"in_reply_to":"3f79a3b5_620866d6","updated":"2018-12-06 21:46:55.000000000","message":"LOGGED_NO_COMPUTES?","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f3f330f92b4f0b12510238a31c98f01e32b9613a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":"LAST_VERSION \u003d None"},{"line_number":37,"context_line":"NO_COMPUTES_WARNING \u003d False"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _compute_host(host, instance):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_620866d6","line":37,"range":{"start_line":37,"start_character":12,"end_line":37,"end_character":19},"in_reply_to":"3f79a3b5_d7401a8d","updated":"2018-12-06 20:00:58.000000000","message":"Yeah, I was thinking the same about the leveling. However it\u0027s still a warning in the english sense. NO_COMPUTES_INFO doesn\u0027t make much sense (to me), so what is your suggestion for the name of this?","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17328c18ac0883d06fd62d6c2f1eb7fba13243ef","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":397,"context_line":"        # As a sane default, return the current version."},{"line_number":398,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":399,"context_line":"            if not NO_COMPUTES_WARNING:"},{"line_number":400,"context_line":"                # NOTE(danms): Only show this warning once"},{"line_number":401,"context_line":"                LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":402,"context_line":"                          \"service_version is 0. Please ensure a nova-compute \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1d173e44","line":399,"updated":"2018-12-11 15:55:25.000000000","message":"We should probably do the same for this:\n\nhttp://logs.openstack.org/82/623282/2/check/tempest-full/0a4f66a/controller/logs/screen-n-api.txt.gz?level\u003dWARNING#_Dec_11_06_09_01_928385\n\nhttp://logstash.openstack.org/#dashboard/file/logstash.json?query\u003dmessage%3A%5C%22The%20nova-osapi_compute%20service%20version%20is%20from%20before%20Ocata%5C%22%20AND%20tags%3A%5C%22screen-n-api.txt%5C%22\u0026from\u003d7d\n\nI\u0027m kind of surprised no one has complained about that. Maybe no one is running nova-api pointing at cell0 for [database]/connection.","commit_id":"183f6238c1d98b04fdcee0fb70212f01f4012ae4"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"87c45c2e974cb7e5a7f53da25773a98abda2d91a","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        self.assertEqual(1, len(mock_log.debug.call_args_list))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8f74cacf","line":599,"range":{"start_line":599,"start_character":28,"end_line":599,"end_character":61},"updated":"2018-12-06 22:13:35.000000000","message":"I would have thought you could have used mock_log.debug.call_count here as a more direct way.","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b9a0654a14032b4fcbe75776903bb5e17334f813","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        self.assertEqual(1, len(mock_log.debug.call_args_list))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_546cf603","line":599,"range":{"start_line":599,"start_character":28,"end_line":599,"end_character":61},"in_reply_to":"3f79a3b5_256915be","updated":"2018-12-07 14:54:20.000000000","message":"I need to reset the global flag once this test starts running in a different order (found in the next patch), so I\u0027ll change this while I fix that.","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e15327a1c396d3e97c286ce4fdb4570dbda2fe50","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        self.assertEqual(1, len(mock_log.debug.call_args_list))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8fc59b91","line":599,"range":{"start_line":599,"start_character":28,"end_line":599,"end_character":61},"in_reply_to":"3f79a3b5_546cf603","updated":"2018-12-07 15:06:56.000000000","message":"Ah yeah, dirty old globals, I should have thought of that.","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c4e6e6121aee2918eac9da6805e86712a8a27d7a","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        self.assertEqual(1, len(mock_log.debug.call_args_list))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_256915be","line":599,"range":{"start_line":599,"start_character":28,"end_line":599,"end_character":61},"in_reply_to":"3f79a3b5_8f74cacf","updated":"2018-12-06 23:52:16.000000000","message":"I should have, I just can\u0027t always remember all the various ways you can access the called-ness of mocks, so I remember the few that cover just about everything I could need :)","commit_id":"ae6e1e1002bb23116b21ffa52e93250274cedd30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"98973bbd11e2e914c1e101c1df3608500071304c","unresolved":false,"context_lines":[{"line_number":594,"context_line":"    def test_version_cap_no_computes_log_once(self, mock_minver, mock_log):"},{"line_number":595,"context_line":"        self.flags(compute\u003d\u0027auto\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.NO_COMPUTES_WARNING \u003d False"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":600,"context_line":"        self.assertEqual(1, mock_log.debug.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_90ca93a0","line":597,"range":{"start_line":597,"start_character":23,"end_line":597,"end_character":42},"updated":"2018-12-07 19:13:41.000000000","message":"Could have renamed this while updating the change but meh.","commit_id":"f4253e095574b99f5313de2923f2e42e0cb75fed"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b30a837a79d622aedbcdd83bf7e9a624b9017b61","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.NO_COMPUTES_WARNING \u003d False"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":600,"context_line":"        self.assertEqual(1, mock_log.debug.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ec2d33fb","line":599,"updated":"2018-12-07 22:33:44.000000000","message":"Regarding the unit test failure in the next patch (debug log message not called), it seems to imply that different, parallel test set NO_COMPUTES_WARNING to True before these two calls could complete. Not sure how to handle that.","commit_id":"f4253e095574b99f5313de2923f2e42e0cb75fed"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2401c320704e87ce1632cd16ab43804745934d89","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.NO_COMPUTES_WARNING \u003d False"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":600,"context_line":"        self.assertEqual(1, mock_log.debug.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2c600b0c","line":599,"in_reply_to":"3f79a3b5_ccdf17d1","updated":"2018-12-07 22:51:06.000000000","message":"I did recall that, but wasn\u0027t sure how that could prevent another parallel test from doing the same thing and setting it to True before this test gets a chance.","commit_id":"f4253e095574b99f5313de2923f2e42e0cb75fed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8abb47b4802fff8502ba57e4f132a84b9c472328","unresolved":false,"context_lines":[{"line_number":596,"context_line":"        mock_minver.return_value \u003d 0"},{"line_number":597,"context_line":"        compute_rpcapi.NO_COMPUTES_WARNING \u003d False"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":600,"context_line":"        self.assertEqual(1, mock_log.debug.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ccdf17d1","line":599,"in_reply_to":"3f79a3b5_ec2d33fb","updated":"2018-12-07 22:46:11.000000000","message":"Other unit tests that have globals like this normally get reset in test setup:\n\nhttps://github.com/openstack/nova/blob/4d8baef8dcdb63aa60f73b117d77459cb35a2b50/nova/test.py#L290\n\nThere are quite a few globals that get reset in test setup.","commit_id":"f4253e095574b99f5313de2923f2e42e0cb75fed"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"98973bbd11e2e914c1e101c1df3608500071304c","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        compute_rpcapi.NO_COMPUTES_WARNING \u003d False"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":600,"context_line":"        self.assertEqual(1, mock_log.debug.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_30d29f60","line":600,"range":{"start_line":600,"start_character":8,"end_line":600,"end_character":54},"updated":"2018-12-07 19:13:41.000000000","message":"Or just: mock_log.debug.assert_called_once() ... :)","commit_id":"f4253e095574b99f5313de2923f2e42e0cb75fed"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7178288e9638db56611dbf116cfd406c0377f40e","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        compute_rpcapi.NO_COMPUTES_WARNING \u003d False"},{"line_number":598,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":599,"context_line":"        compute_rpcapi.ComputeAPI()"},{"line_number":600,"context_line":"        self.assertEqual(1, mock_log.debug.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ec4f7365","line":600,"range":{"start_line":600,"start_character":8,"end_line":600,"end_character":54},"in_reply_to":"3f79a3b5_30d29f60","updated":"2018-12-07 21:59:54.000000000","message":":| ...","commit_id":"f4253e095574b99f5313de2923f2e42e0cb75fed"}]}