)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"6cc16781c3a8c2f7f2bab5ad0c50faf33fcaaf1b","unresolved":false,"context_lines":[{"line_number":21540,"context_line":""},{"line_number":21541,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_volume_snapshot_create\u0027)"},{"line_number":21542,"context_line":"    @mock.patch.object(host.Host, \u0027get_guest\u0027)"},{"line_number":21543,"context_line":"    def test_volume_snapshot_create_snapshot_info_failure(self,"},{"line_number":21544,"context_line":"                                                          mock_get,"},{"line_number":21545,"context_line":"                                                          mock_snapshot):"},{"line_number":21546,"context_line":"        instance \u003d objects.Instance(**self.inst)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4c280aec","line":21543,"range":{"start_line":21543,"start_character":36,"end_line":21543,"end_character":57},"updated":"2018-12-19 14:59:26.000000000","message":"no_snapshot_info seems better","commit_id":"1c37b6304e913d1b9217c7afcecc1e0575cb7de3"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b1554dc71e879e393f6230f9e029a54f3477a86","unresolved":false,"context_lines":[{"line_number":21540,"context_line":""},{"line_number":21541,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_volume_snapshot_create\u0027)"},{"line_number":21542,"context_line":"    @mock.patch.object(host.Host, \u0027get_guest\u0027)"},{"line_number":21543,"context_line":"    def test_volume_snapshot_create_snapshot_info_failure(self,"},{"line_number":21544,"context_line":"                                                          mock_get,"},{"line_number":21545,"context_line":"                                                          mock_snapshot):"},{"line_number":21546,"context_line":"        instance \u003d objects.Instance(**self.inst)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_85b829c2","line":21543,"range":{"start_line":21543,"start_character":36,"end_line":21543,"end_character":57},"in_reply_to":"3f79a3b5_4c280aec","updated":"2018-12-20 02:08:23.000000000","message":"Done","commit_id":"1c37b6304e913d1b9217c7afcecc1e0575cb7de3"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"fd9094c278f35255245d36e4d024c7b68464d7c0","unresolved":false,"context_lines":[{"line_number":2336,"context_line":"        :param volume_id: id of volume being snapshotted"},{"line_number":2337,"context_line":"        :param create_info: dict of information used to create snapshots"},{"line_number":2338,"context_line":"                     - snapshot_id : ID of snapshot"},{"line_number":2339,"context_line":"                     - type : qcow2 / \u003cother\u003e"},{"line_number":2340,"context_line":"                     - new_file : qcow2 file created by Cinder which"},{"line_number":2341,"context_line":"                     becomes the VM\u0027s active image after"},{"line_number":2342,"context_line":"                     the snapshot is complete"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5cb1bc2b","side":"PARENT","line":2339,"range":{"start_line":2339,"start_character":23,"end_line":2339,"end_character":45},"updated":"2018-12-18 07:16:32.000000000","message":"IMO, it should remain as it is.\nInstead, the following should be added.\n\n        :raises: InternalError if the type is not \u0027qcow2\u0027 or\n                 the snapshot_id is not included in the create_info.","commit_id":"61cd9ccc457b78b9d3a2a9076028ad494aa3fbb0"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"56922bb3fadc534faeb5a383254ca3dcb0c1e79b","unresolved":false,"context_lines":[{"line_number":2336,"context_line":"        :param volume_id: id of volume being snapshotted"},{"line_number":2337,"context_line":"        :param create_info: dict of information used to create snapshots"},{"line_number":2338,"context_line":"                     - snapshot_id : ID of snapshot"},{"line_number":2339,"context_line":"                     - type : qcow2 / \u003cother\u003e"},{"line_number":2340,"context_line":"                     - new_file : qcow2 file created by Cinder which"},{"line_number":2341,"context_line":"                     becomes the VM\u0027s active image after"},{"line_number":2342,"context_line":"                     the snapshot is complete"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cf77508d","side":"PARENT","line":2339,"range":{"start_line":2339,"start_character":23,"end_line":2339,"end_character":45},"in_reply_to":"3f79a3b5_5cb1bc2b","updated":"2018-12-18 08:11:12.000000000","message":"Thanks, will update.","commit_id":"61cd9ccc457b78b9d3a2a9076028ad494aa3fbb0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"12b16d50e161f5aa424ab35833720f29e5e35410","unresolved":false,"context_lines":[{"line_number":2340,"context_line":"                     - new_file : qcow2 file created by Cinder which"},{"line_number":2341,"context_line":"                     becomes the VM\u0027s active image after"},{"line_number":2342,"context_line":"                     the snapshot is complete"},{"line_number":2343,"context_line":"        :raises: InternalError if the type is not \u0027qcow2\u0027 or"},{"line_number":2344,"context_line":"                 the snapshot_id is not included in the create_info."},{"line_number":2345,"context_line":"        \"\"\""},{"line_number":2346,"context_line":""},{"line_number":2347,"context_line":"        LOG.debug(\"volume_snapshot_create: create_info: %(c_info)s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_56e7ea47","line":2344,"range":{"start_line":2343,"start_character":7,"end_line":2344,"end_character":68},"updated":"2019-03-19 03:53:49.000000000","message":"if this is an InternalError, can we catch and handle it?","commit_id":"d8ec5cfa2eae54e9b67f10ab3bcc521d4178c31b"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"87b28a9be1479337a9da3c7b9801076641a0bfd8","unresolved":false,"context_lines":[{"line_number":2340,"context_line":"                     - new_file : qcow2 file created by Cinder which"},{"line_number":2341,"context_line":"                     becomes the VM\u0027s active image after"},{"line_number":2342,"context_line":"                     the snapshot is complete"},{"line_number":2343,"context_line":"        :raises: InternalError if the type is not \u0027qcow2\u0027 or"},{"line_number":2344,"context_line":"                 the snapshot_id is not included in the create_info."},{"line_number":2345,"context_line":"        \"\"\""},{"line_number":2346,"context_line":""},{"line_number":2347,"context_line":"        LOG.debug(\"volume_snapshot_create: create_info: %(c_info)s\","}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_76bb06c4","line":2344,"range":{"start_line":2343,"start_character":7,"end_line":2344,"end_character":68},"in_reply_to":"5fc1f717_56e7ea47","updated":"2019-03-19 04:49:09.000000000","message":"This will process in L2355~L2357.","commit_id":"d8ec5cfa2eae54e9b67f10ab3bcc521d4178c31b"}]}