)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"280f67a686d0e39a5fd064f69d7d3f21e111a1ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Qiu Yu \u003cqiuyu@ebaysf.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-10 10:28:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move pack_action_start/finish helper to InstanceAction object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add these two helper function so that InstanceAction object no longer"},{"line_number":10,"context_line":"depends on compute/utils.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAUH%2F%2FPWM%3D","line":7,"updated":"2014-01-16 01:17:54.000000000","message":"This patch does not move them, since it doesn\u0027t remove it from compute/utils, so this line is incorrect.","commit_id":"b40d6343b9ae752aec0fb935354b14d193fb3b64"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"280f67a686d0e39a5fd064f69d7d3f21e111a1ad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Move pack_action_start/finish helper to InstanceAction object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add these two helper function so that InstanceAction object no longer"},{"line_number":10,"context_line":"depends on compute/utils.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The version of InstanceAction object doesn\u0027t change, since it\u0027s just an"},{"line_number":13,"context_line":"object internal refactoring. No object field or method has been changed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAUH%2F%2FPWI%3D","line":10,"updated":"2014-01-16 01:17:54.000000000","message":"This is also not right, since it still imports the file.","commit_id":"b40d6343b9ae752aec0fb935354b14d193fb3b64"}],"nova/objects/instance_action.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"80b53250234d546b2aa698f48c3ec0f144d7d7fc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: String attributes updated to support unicode"},{"line_number":25,"context_line":"    # Version 1.2: Replace action_start/action_finish class method with"},{"line_number":26,"context_line":"    #              start/finish method for InstanceAction object"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Bpk%3D","line":26,"updated":"2013-12-17 15:19:18.000000000","message":"Why?\n\nYou can\u0027t do this and only bump the minor version as this will be incompatible with older 1.x clients. This will also break icehouse compatibility with havana. You can add things, but you can\u0027t remove/break them.","commit_id":"2b828def0fd45a5b4ad9f7d0b62a59d4893405d5"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"b7a1cba774b6ea494d4987350a653fa8976303da","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: String attributes updated to support unicode"},{"line_number":25,"context_line":"    # Version 1.2: Replace action_start/action_finish class method with"},{"line_number":26,"context_line":"    #              start/finish method for InstanceAction object"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F8%2FEI%3D","line":26,"in_reply_to":"AAAATn%2F8%2FFI%3D","updated":"2013-12-18 02:42:22.000000000","message":"Sure. Thanks for clarification.\n\nWill re-work this patch for the InstanceAction model.","commit_id":"2b828def0fd45a5b4ad9f7d0b62a59d4893405d5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"32c689e2823da29ccf0446a6c756d0b7164174cf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: String attributes updated to support unicode"},{"line_number":25,"context_line":"    # Version 1.2: Replace action_start/action_finish class method with"},{"line_number":26,"context_line":"    #              start/finish method for InstanceAction object"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F8%2FFI%3D","line":26,"in_reply_to":"AAAATn%2F9Big%3D","updated":"2013-12-18 02:37:35.000000000","message":"It does have a version of 1.0, implied from the base class.\n\nUnless you have a really strong reason and a technical justification for why it won\u0027t matter, yes, you need to always keep backwards compatibility. If we were to backport something that started using the object over RPC to havana, but not the change that lost the compatibility, then things would be broken. We just have to be diligent about the rules here.","commit_id":"2b828def0fd45a5b4ad9f7d0b62a59d4893405d5"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"2023242a4f9d8fe8fb7c795a6ca8f136d82ec63e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # Version 1.0: Initial version"},{"line_number":24,"context_line":"    # Version 1.1: String attributes updated to support unicode"},{"line_number":25,"context_line":"    # Version 1.2: Replace action_start/action_finish class method with"},{"line_number":26,"context_line":"    #              start/finish method for InstanceAction object"},{"line_number":27,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9Big%3D","line":26,"in_reply_to":"AAAATn%2F9Bpk%3D","updated":"2013-12-17 15:38:00.000000000","message":"Sorry. I had a quick check, currently the only place referring to InstanceAction model is compute/api.py. I didn\u0027t realized it has already in Havana. Will restore in the next patchset.\n\nBTW, do I have to keep all 1.1 interface even it wasn\u0027t used anywhere? For example, InstanceActionEvent model it was totally not referenced and don\u0027t even have a version number.","commit_id":"2b828def0fd45a5b4ad9f7d0b62a59d4893405d5"}]}