)]}'
{"doc/source/cli/nova-api-metadata.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db3f5763d1e13622725022ce75222cfcbffba11","unresolved":false,"context_lines":[{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the `cells v2 layout`__."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. __: https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#nova-metadata-api-service"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Options"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffd0ebdf_cec6b417","line":28,"updated":"2019-01-04 22:04:58.000000000","message":"nit: rather than point at the latest, we could just define a ref and link to that here since these are part of the same docs build. See how :ref: is used elsewhere.","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"80ce6a0ec96c2f83c4a7c6856d20ad6a7a2dbfd4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the `cells v2 layout`__."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. __: https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#nova-metadata-api-service"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Options"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfdaf3ff_7d9f3c50","line":28,"in_reply_to":"ffd0ebdf_cec6b417","updated":"2019-01-14 07:43:45.000000000","message":"Done","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08cf77e533d247bc4daf679ad32b1a6564100fbc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":":program:`nova-api-metadata` is a server daemon that serves the Nova Metadata"},{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the :ref:`cells-v2-layout-metadata-api`."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_536820f4","line":25,"range":{"start_line":25,"start_character":46,"end_line":25,"end_character":53},"updated":"2019-01-14 15:02:12.000000000","message":"Either \". There are\" or \", so there are\".","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d93049c7fb728f2b96bd8ef1751fc5d6c0908622","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":":program:`nova-api-metadata` is a server daemon that serves the Nova Metadata"},{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the :ref:`cells-v2-layout-metadata-api`."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_a5734380","line":25,"range":{"start_line":25,"start_character":31,"end_line":25,"end_character":42},"updated":"2019-01-14 15:18:06.000000000","message":"No one probably knows what \"indirection API\" is, so we should probably re-word this. We could just say it routes internal communication through the nova-conductor, like nova-compute does, and has no direct access to the database.","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d93049c7fb728f2b96bd8ef1751fc5d6c0908622","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":":program:`nova-api-metadata` is a server daemon that serves the Nova Metadata"},{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the :ref:`cells-v2-layout-metadata-api`."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_250513c3","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":16},"updated":"2019-01-14 15:18:06.000000000","message":"daemon","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d93049c7fb728f2b96bd8ef1751fc5d6c0908622","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":":program:`nova-api-metadata` is a server daemon that serves the Nova Metadata"},{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the :ref:`cells-v2-layout-metadata-api`."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Options"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_25d3d33a","line":25,"range":{"start_line":25,"start_character":46,"end_line":25,"end_character":53},"in_reply_to":"bfdaf3ff_536820f4","updated":"2019-01-14 15:18:06.000000000","message":"Done","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08cf77e533d247bc4daf679ad32b1a6564100fbc","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":":program:`nova-api-metadata` is a server daemon that serves the Nova Metadata"},{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the :ref:`cells-v2-layout-metadata-api`."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Options"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_937d28b3","line":26,"range":{"start_line":26,"start_character":31,"end_line":26,"end_character":66},"updated":"2019-01-14 15:02:12.000000000","message":"This just renders as \"script in the Nova Metadata API service.\" which doesn\u0027t make a ton of sense. The \"cells v2 layout\" label you had before makes more sense, so use that label with the ref.","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d93049c7fb728f2b96bd8ef1751fc5d6c0908622","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":":program:`nova-api-metadata` is a server daemon that serves the Nova Metadata"},{"line_number":25,"context_line":"API. This script runs with the indirection API, there are some considerations"},{"line_number":26,"context_line":"about using this script in the :ref:`cells-v2-layout-metadata-api`."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Options"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_e5dceb47","line":26,"range":{"start_line":26,"start_character":31,"end_line":26,"end_character":66},"in_reply_to":"bfdaf3ff_937d28b3","updated":"2019-01-14 15:18:06.000000000","message":"Done","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"}],"doc/source/user/cellsv2-layout.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":291,"context_line":"\u003cconfiguration/opts.html#oslo_messaging_notifications.transport_url\u003e` for more"},{"line_number":292,"context_line":"details."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"Nova Metadata API service"},{"line_number":295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_276819b9","line":294,"updated":"2018-12-21 14:22:36.000000000","message":"nit: the global vs local discussion below is a bit too intermixed for my taste, meaning, it might be more clear to just have a sentence that says you can run it globally or local per cell, and then create two separate sub-sections for global and local configuration/issues/notes/conditions/etc. For example:\n\nStarting from the Stein release, the Nova metadata API service can be run either globally or per cell using the :oslo.config:option:`api.local_metadata_per_cell` configuration option.\n\n**Global**\n\nblah blah blah global stuff\n\n**Local per cell**\n\nblah blah blah per-cell stuff","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"20fac2cd4100c661325a0112084ca6af241d8a8b","unresolved":false,"context_lines":[{"line_number":291,"context_line":"\u003cconfiguration/opts.html#oslo_messaging_notifications.transport_url\u003e` for more"},{"line_number":292,"context_line":"details."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"Nova Metadata API service"},{"line_number":295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_080a9325","line":294,"in_reply_to":"3f79a3b5_276819b9","updated":"2018-12-24 02:07:36.000000000","message":"yeah, looks better.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":294,"context_line":"Nova Metadata API service"},{"line_number":295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"},{"line_number":298,"context_line":"service globally or per cell using ``[api]/local_metadata_per_cell``"},{"line_number":299,"context_line":"configuration. Running Nova metadata API per cell can avoid query API DB for"},{"line_number":300,"context_line":"instance information each time an instance query for its\u0027 metadata. If you"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_cc014c0a","line":297,"range":{"start_line":297,"start_character":0,"end_line":297,"end_character":10},"updated":"2018-12-21 14:22:36.000000000","message":"Starting from the","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"},{"line_number":298,"context_line":"service globally or per cell using ``[api]/local_metadata_per_cell``"},{"line_number":299,"context_line":"configuration. Running Nova metadata API per cell can avoid query API DB for"},{"line_number":300,"context_line":"instance information each time an instance query for its\u0027 metadata. If you"},{"line_number":301,"context_line":"have networks that span cells, you might need to still run Nova metadata API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_a70c2937","line":298,"range":{"start_line":298,"start_character":35,"end_line":298,"end_character":68},"updated":"2018-12-21 14:22:36.000000000","message":"Link to the config docs:\n\n:oslo.config:option:`api.local_metadata_per_cell`","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":294,"context_line":"Nova Metadata API service"},{"line_number":295,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"},{"line_number":298,"context_line":"service globally or per cell using ``[api]/local_metadata_per_cell``"},{"line_number":299,"context_line":"configuration. Running Nova metadata API per cell can avoid query API DB for"},{"line_number":300,"context_line":"instance information each time an instance query for its\u0027 metadata. If you"},{"line_number":301,"context_line":"have networks that span cells, you might need to still run Nova metadata API"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_67fb7113","line":298,"range":{"start_line":297,"start_character":26,"end_line":298,"end_character":34},"updated":"2018-12-21 14:22:36.000000000","message":"the Nova metadata API service can be run either globally or per cell using the","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"},{"line_number":298,"context_line":"service globally or per cell using ``[api]/local_metadata_per_cell``"},{"line_number":299,"context_line":"configuration. Running Nova metadata API per cell can avoid query API DB for"},{"line_number":300,"context_line":"instance information each time an instance query for its\u0027 metadata. If you"},{"line_number":301,"context_line":"have networks that span cells, you might need to still run Nova metadata API"},{"line_number":302,"context_line":"service global. On the other hand, if your networks are segmented along cell"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_07171d44","line":299,"range":{"start_line":299,"start_character":60,"end_line":299,"end_character":65},"updated":"2018-12-21 14:22:36.000000000","message":"querying the","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":297,"context_line":"Start from Stein release, user can choose whether to run the Nova metadata API"},{"line_number":298,"context_line":"service globally or per cell using ``[api]/local_metadata_per_cell``"},{"line_number":299,"context_line":"configuration. Running Nova metadata API per cell can avoid query API DB for"},{"line_number":300,"context_line":"instance information each time an instance query for its\u0027 metadata. If you"},{"line_number":301,"context_line":"have networks that span cells, you might need to still run Nova metadata API"},{"line_number":302,"context_line":"service global. On the other hand, if your networks are segmented along cell"},{"line_number":303,"context_line":"boundaries, then you can run Nova metadata API service per cell. When running"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_271a5969","line":300,"range":{"start_line":300,"start_character":21,"end_line":300,"end_character":66},"updated":"2018-12-21 14:22:36.000000000","message":"I think you could omit this sentence, it\u0027s implied.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":299,"context_line":"configuration. Running Nova metadata API per cell can avoid query API DB for"},{"line_number":300,"context_line":"instance information each time an instance query for its\u0027 metadata. If you"},{"line_number":301,"context_line":"have networks that span cells, you might need to still run Nova metadata API"},{"line_number":302,"context_line":"service global. On the other hand, if your networks are segmented along cell"},{"line_number":303,"context_line":"boundaries, then you can run Nova metadata API service per cell. When running"},{"line_number":304,"context_line":"global, it should be configured as an API-level service with access to the"},{"line_number":305,"context_line":"``[api_database]/connection`` information. If you choose to run it per cell,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_c734c5e2","line":302,"range":{"start_line":302,"start_character":8,"end_line":302,"end_character":14},"updated":"2018-12-21 14:22:36.000000000","message":"globally","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":302,"context_line":"service global. On the other hand, if your networks are segmented along cell"},{"line_number":303,"context_line":"boundaries, then you can run Nova metadata API service per cell. When running"},{"line_number":304,"context_line":"global, it should be configured as an API-level service with access to the"},{"line_number":305,"context_line":"``[api_database]/connection`` information. If you choose to run it per cell,"},{"line_number":306,"context_line":"you should also correctly config each neutron metadata-agent to point to the"},{"line_number":307,"context_line":"corresponding nova-metadata-api. The nova metadata API service must not be run"},{"line_number":308,"context_line":"as a standalone service (e.g. must not be run via the nova-api-metadata"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_872a4d76","line":305,"range":{"start_line":305,"start_character":2,"end_line":305,"end_character":27},"updated":"2018-12-21 14:22:36.000000000","message":"Let\u0027s turn this into a link as well.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":303,"context_line":"boundaries, then you can run Nova metadata API service per cell. When running"},{"line_number":304,"context_line":"global, it should be configured as an API-level service with access to the"},{"line_number":305,"context_line":"``[api_database]/connection`` information. If you choose to run it per cell,"},{"line_number":306,"context_line":"you should also correctly config each neutron metadata-agent to point to the"},{"line_number":307,"context_line":"corresponding nova-metadata-api. The nova metadata API service must not be run"},{"line_number":308,"context_line":"as a standalone service (e.g. must not be run via the nova-api-metadata"},{"line_number":309,"context_line":"script)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_47467558","line":306,"range":{"start_line":306,"start_character":26,"end_line":306,"end_character":32},"updated":"2018-12-21 14:22:36.000000000","message":"configure","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":304,"context_line":"global, it should be configured as an API-level service with access to the"},{"line_number":305,"context_line":"``[api_database]/connection`` information. If you choose to run it per cell,"},{"line_number":306,"context_line":"you should also correctly config each neutron metadata-agent to point to the"},{"line_number":307,"context_line":"corresponding nova-metadata-api. The nova metadata API service must not be run"},{"line_number":308,"context_line":"as a standalone service (e.g. must not be run via the nova-api-metadata"},{"line_number":309,"context_line":"script)."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"Consoleauth service and console proxies"},{"line_number":312,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f79a3b5_67493163","line":309,"range":{"start_line":307,"start_character":33,"end_line":309,"end_character":8},"updated":"2018-12-21 14:22:36.000000000","message":"I\u0027m not really sure why we have this in here in the first place, because it\u0027s how we run it in our CI jobs:\n\nhttp://logs.openstack.org/68/567268/42/check/tempest-full/12e0fc5/controller/logs/screen-n-api-meta.txt.gz","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"20fac2cd4100c661325a0112084ca6af241d8a8b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"global, it should be configured as an API-level service with access to the"},{"line_number":305,"context_line":"``[api_database]/connection`` information. If you choose to run it per cell,"},{"line_number":306,"context_line":"you should also correctly config each neutron metadata-agent to point to the"},{"line_number":307,"context_line":"corresponding nova-metadata-api. The nova metadata API service must not be run"},{"line_number":308,"context_line":"as a standalone service (e.g. must not be run via the nova-api-metadata"},{"line_number":309,"context_line":"script)."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"Consoleauth service and console proxies"},{"line_number":312,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f769fc5_5c0dac35","line":309,"range":{"start_line":307,"start_character":33,"end_line":309,"end_character":8},"in_reply_to":"3f79a3b5_67493163","updated":"2018-12-24 02:07:36.000000000","message":"I will try to find out.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":297,"context_line":"Starting from the Stein release, the Nova Metadata API service"},{"line_number":298,"context_line":"can be run either globally or per cell using the"},{"line_number":299,"context_line":":oslo.config:option:`api.local_metadata_per_cell` configuration option."},{"line_number":300,"context_line":"The nova metadata API service must not be run as a standalone service"},{"line_number":301,"context_line":"(e.g. must not be run via the nova-api-metadata script)."},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"**Global**"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_4882d8ca","line":301,"range":{"start_line":300,"start_character":0,"end_line":301,"end_character":56},"updated":"2019-01-03 16:10:32.000000000","message":"I\u0027m not sure about this - need to ask Dan, but this might be here because the nova-api-metadata script runs with the indirection API so it runs through conductor for hitting the database, and therefore is maybe meant for per-cell deployment, in which case this would be a distinction to make in the global vs local sections, i.e. don\u0027t run that script in global deployment, but do run it in local deployments.\n\nWhile we\u0027re making distinctions, we likely should update the docs on that script a bit:\n\nhttps://docs.openstack.org/nova/latest/cli/nova-api-metadata.html\n\nMaybe as a note and link back to this subsection for multi-cell considerations.","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":310,"context_line":"**Local per cell**"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_489e5808","line":313,"range":{"start_line":313,"start_character":13,"end_line":313,"end_character":15},"updated":"2019-01-03 16:10:32.000000000","message":"If","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":310,"context_line":"**Local per cell**"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_088850c4","line":313,"range":{"start_line":313,"start_character":21,"end_line":313,"end_character":28},"updated":"2019-01-03 16:10:32.000000000","message":"networks","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"**Local per cell**"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_436f19c5","line":313,"range":{"start_line":312,"start_character":35,"end_line":313,"end_character":11},"updated":"2019-01-03 16:10:32.000000000","message":"see my note in the release note about this wording - let\u0027s mention the non-functional benefit instead of the code change (performance and data isolation).","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Consoleauth service and console proxies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_c8aa4818","line":315,"range":{"start_line":315,"start_character":45,"end_line":315,"end_character":59},"updated":"2019-01-03 16:10:32.000000000","message":"Would be good to link to the neutron docs on the metadata-agent:\n\nhttps://docs.openstack.org/neutron/latest/configuration/metadata-agent.html?#DEFAULT.nova_metadata_host","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Consoleauth service and console proxies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_c891e8f3","line":315,"range":{"start_line":315,"start_character":12,"end_line":315,"end_character":21},"updated":"2019-01-03 16:10:32.000000000","message":"You can remove this word - why would someone incorrectly configure the metadata agent on purpose?","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"095379e9df0f006e31a1bdda85bed39f2195cce5","unresolved":false,"context_lines":[{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Consoleauth service and console proxies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_3b979293","line":315,"range":{"start_line":315,"start_character":12,"end_line":315,"end_character":21},"in_reply_to":"ffd0ebdf_c891e8f3","updated":"2019-01-04 08:40:43.000000000","message":":)","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"095379e9df0f006e31a1bdda85bed39f2195cce5","unresolved":false,"context_lines":[{"line_number":312,"context_line":"Running Nova metadata API per cell can avoid querying the API DB for instance"},{"line_number":313,"context_line":"information. if your network are segmented along cell boundaries, then you can"},{"line_number":314,"context_line":"run Nova metadata API service per cell. If you choose to run it per cell, you"},{"line_number":315,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":316,"context_line":"corresponding nova-metadata-api."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"Consoleauth service and console proxies"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffd0ebdf_9bf79ef6","line":315,"range":{"start_line":315,"start_character":45,"end_line":315,"end_character":59},"in_reply_to":"ffd0ebdf_c8aa4818","updated":"2019-01-04 08:40:43.000000000","message":"Done","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db3f5763d1e13622725022ce75222cfcbffba11","unresolved":false,"context_lines":[{"line_number":303,"context_line":"If you have networks that span cells, you might need to run Nova metadata API"},{"line_number":304,"context_line":"globally. When running globally, it should be configured as an API-level"},{"line_number":305,"context_line":"service with access to the :oslo.config:option:`api_database.connection`"},{"line_number":306,"context_line":"information. The nova metadata API service must not be run as a standalone"},{"line_number":307,"context_line":"service in this case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"**Local per cell**"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffd0ebdf_aed570bb","line":307,"range":{"start_line":306,"start_character":13,"end_line":307,"end_character":76},"updated":"2019-01-04 22:04:58.000000000","message":"TODO: confirm with Dan if this is what this was meant for.","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76b02a3f2c021c9c80374fdb96d5b8cbf1b792b4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"If you have networks that span cells, you might need to run Nova metadata API"},{"line_number":304,"context_line":"globally. When running globally, it should be configured as an API-level"},{"line_number":305,"context_line":"service with access to the :oslo.config:option:`api_database.connection`"},{"line_number":306,"context_line":"information. The nova metadata API service must not be run as a standalone"},{"line_number":307,"context_line":"service in this case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"**Local per cell**"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffd0ebdf_2902dab5","line":307,"range":{"start_line":306,"start_character":13,"end_line":307,"end_character":76},"in_reply_to":"ffd0ebdf_aed570bb","updated":"2019-01-04 22:23:55.000000000","message":"(4:17:59 PM) dansmith: mriedem: yeah, the standalone is per-cell, so if you arrange for it to have the right config and instances only hit it from within the cell, then it\u0027s fine, it just doesn\u0027t so the switching\n(4:18:03 PM) dansmith: (IIRC(","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db3f5763d1e13622725022ce75222cfcbffba11","unresolved":false,"context_lines":[{"line_number":312,"context_line":"isolation in a muli-cell deployment. If your networks are segmented along"},{"line_number":313,"context_line":"cell boundaries, then you can run Nova metadata API service per cell. If"},{"line_number":314,"context_line":"you choose to run it per cell, you should also configure each"},{"line_number":315,"context_line":"`Neutron metadata-agent`__ to point to the corresponding nova-metadata-api."},{"line_number":316,"context_line":"The nova metadata API service must be run as a standalone service in this"},{"line_number":317,"context_line":"case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffd0ebdf_4e8884c5","line":315,"range":{"start_line":315,"start_character":24,"end_line":315,"end_character":26},"updated":"2019-01-04 22:04:58.000000000","message":"nit: I\u0027m not sure an anonymous link should be used here.","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"80ce6a0ec96c2f83c4a7c6856d20ad6a7a2dbfd4","unresolved":false,"context_lines":[{"line_number":312,"context_line":"isolation in a muli-cell deployment. If your networks are segmented along"},{"line_number":313,"context_line":"cell boundaries, then you can run Nova metadata API service per cell. If"},{"line_number":314,"context_line":"you choose to run it per cell, you should also configure each"},{"line_number":315,"context_line":"`Neutron metadata-agent`__ to point to the corresponding nova-metadata-api."},{"line_number":316,"context_line":"The nova metadata API service must be run as a standalone service in this"},{"line_number":317,"context_line":"case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":318,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfdaf3ff_3dd774f0","line":315,"range":{"start_line":315,"start_character":24,"end_line":315,"end_character":26},"in_reply_to":"ffd0ebdf_4e8884c5","updated":"2019-01-14 07:43:45.000000000","message":"Done","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db3f5763d1e13622725022ce75222cfcbffba11","unresolved":false,"context_lines":[{"line_number":314,"context_line":"you choose to run it per cell, you should also configure each"},{"line_number":315,"context_line":"`Neutron metadata-agent`__ to point to the corresponding nova-metadata-api."},{"line_number":316,"context_line":"The nova metadata API service must be run as a standalone service in this"},{"line_number":317,"context_line":"case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":".. __: https://docs.openstack.org/neutron/latest/configuration/metadata-agent.html?#DEFAULT.nova_metadata_host"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffd0ebdf_eec298e9","line":317,"range":{"start_line":317,"start_character":15,"end_line":317,"end_character":18},"updated":"2019-01-04 22:04:58.000000000","message":"not? or must be?","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db3f5763d1e13622725022ce75222cfcbffba11","unresolved":false,"context_lines":[{"line_number":314,"context_line":"you choose to run it per cell, you should also configure each"},{"line_number":315,"context_line":"`Neutron metadata-agent`__ to point to the corresponding nova-metadata-api."},{"line_number":316,"context_line":"The nova metadata API service must be run as a standalone service in this"},{"line_number":317,"context_line":"case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":".. __: https://docs.openstack.org/neutron/latest/configuration/metadata-agent.html?#DEFAULT.nova_metadata_host"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ffd0ebdf_2e8f40cd","line":317,"range":{"start_line":317,"start_character":4,"end_line":317,"end_character":5},"updated":"2019-01-04 22:04:58.000000000","message":"space","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"80ce6a0ec96c2f83c4a7c6856d20ad6a7a2dbfd4","unresolved":false,"context_lines":[{"line_number":314,"context_line":"you choose to run it per cell, you should also configure each"},{"line_number":315,"context_line":"`Neutron metadata-agent`__ to point to the corresponding nova-metadata-api."},{"line_number":316,"context_line":"The nova metadata API service must be run as a standalone service in this"},{"line_number":317,"context_line":"case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":".. __: https://docs.openstack.org/neutron/latest/configuration/metadata-agent.html?#DEFAULT.nova_metadata_host"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfdaf3ff_5df9187e","line":317,"range":{"start_line":317,"start_character":15,"end_line":317,"end_character":18},"in_reply_to":"ffd0ebdf_eec298e9","updated":"2019-01-14 07:43:45.000000000","message":"Done","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"08cf77e533d247bc4daf679ad32b1a6564100fbc","unresolved":false,"context_lines":[{"line_number":306,"context_line":"globally. When running globally, it should be configured as an API-level"},{"line_number":307,"context_line":"service with access to the :oslo.config:option:`api_database.connection`"},{"line_number":308,"context_line":"information. The nova metadata API service must not be run as a standalone"},{"line_number":309,"context_line":"service in this case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"**Local per cell**"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_f33a74e5","line":309,"range":{"start_line":309,"start_character":20,"end_line":309,"end_character":21},"updated":"2019-01-14 15:02:12.000000000","message":"space","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d93049c7fb728f2b96bd8ef1751fc5d6c0908622","unresolved":false,"context_lines":[{"line_number":306,"context_line":"globally. When running globally, it should be configured as an API-level"},{"line_number":307,"context_line":"service with access to the :oslo.config:option:`api_database.connection`"},{"line_number":308,"context_line":"information. The nova metadata API service must not be run as a standalone"},{"line_number":309,"context_line":"service in this case(e.g. must not be run via the nova-api-metadata script)."},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"**Local per cell**"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bfdaf3ff_651b1b1b","line":309,"range":{"start_line":309,"start_character":20,"end_line":309,"end_character":21},"in_reply_to":"bfdaf3ff_f33a74e5","updated":"2019-01-14 15:18:06.000000000","message":"Done","commit_id":"2700f11825eaa5b1b7917664f90065bbe9fee29f"}],"nova/api/metadata/base.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a80c500c57d7be3b66782e0f247d33321cf22121","unresolved":false,"context_lines":[{"line_number":681,"context_line":"             \u0027security_groups\u0027, \u0027keypairs\u0027,"},{"line_number":682,"context_line":"             \u0027device_metadata\u0027]"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    if CONF.api.local_metadata_per_cell:"},{"line_number":685,"context_line":"        instance \u003d objects.Instance.get_by_uuid(ctxt, instance_id,"},{"line_number":686,"context_line":"                                                expected_attrs\u003dattrs)"},{"line_number":687,"context_line":"        return InstanceMetadata(instance, address)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7b0981d9","line":684,"updated":"2018-12-12 15:47:23.000000000","message":"Should also handle it here:\n\nhttps://github.com/openstack/nova/blob/ba163cd5fd3e6ea9a42f0b8082e8e096885f0c57/nova/api/metadata/password.py#L71","commit_id":"cc0385f510854c64aaecd2e4c36a61d459fb3fdc"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"3eed0e87d53cc63756e10568e7e3d61e69bb0ce7","unresolved":false,"context_lines":[{"line_number":681,"context_line":"             \u0027security_groups\u0027, \u0027keypairs\u0027,"},{"line_number":682,"context_line":"             \u0027device_metadata\u0027]"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    if CONF.api.local_metadata_per_cell:"},{"line_number":685,"context_line":"        instance \u003d objects.Instance.get_by_uuid(ctxt, instance_id,"},{"line_number":686,"context_line":"                                                expected_attrs\u003dattrs)"},{"line_number":687,"context_line":"        return InstanceMetadata(instance, address)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5920eeae","line":684,"in_reply_to":"3f79a3b5_7b0981d9","updated":"2018-12-18 07:03:30.000000000","message":"Done","commit_id":"cc0385f510854c64aaecd2e4c36a61d459fb3fdc"}],"nova/api/metadata/password.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            msg \u003d _(\"Request is too large.\")"},{"line_number":72,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if CONF.api.local_metadata_per_cell:"},{"line_number":75,"context_line":"            instance \u003d objects.Instance.get_by_uuid(ctxt, meta_data.uuid)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c7c84577","line":74,"updated":"2018-12-21 14:22:36.000000000","message":"There is no test coverage for this.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"20fac2cd4100c661325a0112084ca6af241d8a8b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            msg \u003d _(\"Request is too large.\")"},{"line_number":72,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if CONF.api.local_metadata_per_cell:"},{"line_number":75,"context_line":"            instance \u003d objects.Instance.get_by_uuid(ctxt, meta_data.uuid)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_1c3894d1","line":74,"in_reply_to":"3f79a3b5_c7c84577","updated":"2018-12-24 02:07:36.000000000","message":"Done","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if CONF.api.local_metadata_per_cell:"},{"line_number":75,"context_line":"            instance \u003d objects.Instance.get_by_uuid(ctxt, meta_data.uuid)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            im \u003d objects.InstanceMapping.get_by_instance_uuid("},{"line_number":79,"context_line":"                ctxt, meta_data.uuid)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_477d156e","line":76,"updated":"2018-12-21 14:22:36.000000000","message":"nit: drop the blank line","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"}],"nova/conf/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a80c500c57d7be3b66782e0f247d33321cf22121","unresolved":false,"context_lines":[{"line_number":196,"context_line":"of the metadata API when under heavy load. Higher values may increase memory"},{"line_number":197,"context_line":"usage, and result in longer times for host metadata changes to take effect."},{"line_number":198,"context_line":"\"\"\"),"},{"line_number":199,"context_line":"    cfg.BoolOpt(\"local_metadata_per_cell\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5bd28534","line":199,"updated":"2018-12-12 15:47:23.000000000","message":"Need to update the docs for this:\n\nhttps://docs.openstack.org/nova/latest/user/cellsv2-layout.html#nova-metadata-api-service\n\nI believe the blueprint whiteboard also points out some caveats discussed at the PTG about when you might want to run metadata-api globally depending on how neutron is setup, so that could be called out both here and in the docs.\n\nPlus we\u0027ll want a release note for this, and tests obviously.","commit_id":"cc0385f510854c64aaecd2e4c36a61d459fb3fdc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a80c500c57d7be3b66782e0f247d33321cf22121","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid hit API DB for instance information."},{"line_number":204,"context_line":"\"\"\"),"},{"line_number":205,"context_line":"]"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1bee4dff","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":16},"updated":"2018-12-12 15:47:23.000000000","message":"querying the","commit_id":"cc0385f510854c64aaecd2e4c36a61d459fb3fdc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    cfg.BoolOpt(\"local_metadata_per_cell\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid query API DB for instance information. Users should consider the"},{"line_number":204,"context_line":"use of this configuration depending on how neutron is setup, you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e78b0167","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":10},"updated":"2018-12-21 14:22:36.000000000","message":"Indicates","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid query API DB for instance information. Users should consider the"},{"line_number":204,"context_line":"use of this configuration depending on how neutron is setup, you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a7818948","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":18},"updated":"2018-12-21 14:22:36.000000000","message":"querying","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid query API DB for instance information. Users should consider the"},{"line_number":204,"context_line":"use of this configuration depending on how neutron is setup, you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_47e2f537","line":204,"range":{"start_line":204,"start_character":59,"end_line":204,"end_character":64},"updated":"2018-12-21 14:22:36.000000000","message":". If you","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid query API DB for instance information. Users should consider the"},{"line_number":204,"context_line":"use of this configuration depending on how neutron is setup, you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c7d5a549","line":205,"range":{"start_line":205,"start_character":72,"end_line":205,"end_character":76},"updated":"2018-12-21 14:22:36.000000000","message":". If your","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Indicating that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid query API DB for instance information. Users should consider the"},{"line_number":204,"context_line":"use of this configuration depending on how neutron is setup, you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_07e87d11","line":205,"range":{"start_line":205,"start_character":66,"end_line":205,"end_character":72},"updated":"2018-12-21 14:22:36.000000000","message":"globally","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_c76cc59f","line":208,"range":{"start_line":208,"start_character":42,"end_line":208,"end_character":56},"updated":"2018-12-21 14:22:36.000000000","message":"We should probably have a neutron docs change that mentions this as well and depends on the nova change, but I\u0027m not sure what the best doc would be for that information, but here are some possible places:\n\nhttps://docs.openstack.org/neutron/rocky/admin/config-ml2.html?highlight\u003dmetadata#metadata-agent\n\nhttps://docs.openstack.org/neutron/rocky/admin/intro-os-networking.html?highlight\u003dmetadata#metadata\n\nhttps://docs.openstack.org/neutron/rocky/configuration/metadata-agent.html?highlight\u003dmetadata#DEFAULT.nova_metadata_host\n\nMaybe ask slaweq, hongbin or mlavalle which would be best.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_87db2d79","line":208,"range":{"start_line":208,"start_character":22,"end_line":208,"end_character":28},"updated":"2018-12-21 14:22:36.000000000","message":"configure","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0666cf1a2a8497067437fa84f577b020148a3725","unresolved":false,"context_lines":[{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3e3a5fc1","line":208,"range":{"start_line":208,"start_character":42,"end_line":208,"end_character":56},"in_reply_to":"3f79a3b5_02514b65","updated":"2018-12-21 17:50:03.000000000","message":"The source of the file recommended be Slawek is: https://github.com/openstack/neutron/blob/master/doc/source/configuration/metadata-agent.rst. It is an auto-generated file from the config file: https://github.com/openstack/neutron/blob/master/neutron/conf/agent/metadata/config.py#L47.\n\nSo we need to update the help string for the config option. I also strongly recommend updating the deployment guides:\n\nhttps://github.com/openstack/neutron/blob/master/doc/source/admin/deploy-lb-provider.rst#compute-nodes, fifth bullet point\n\nhttps://github.com/openstack/neutron/blob/master/doc/source/admin/deploy-ovs-provider.rst#compute-nodes, sixth bullet point\n\nhttps://github.com/openstack/neutron/blob/master/doc/source/install/controller-install-obs.rst#configure-the-metadata-agent\n\nhttps://github.com/openstack/neutron/blob/master/doc/source/install/controller-install-rdo.rst#configure-the-metadata-agent\n\nhttps://github.com/openstack/neutron/blob/master/doc/source/install/controller-install-ubuntu.rst#configure-the-metadata-agent","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"20fac2cd4100c661325a0112084ca6af241d8a8b","unresolved":false,"context_lines":[{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_fc3fd8b2","line":208,"range":{"start_line":208,"start_character":42,"end_line":208,"end_character":56},"in_reply_to":"3f79a3b5_3e3a5fc1","updated":"2018-12-24 02:07:36.000000000","message":"Thanks all for the reply, I will do a patch in neutron","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b2a9af54df80bceee537e0154b69d601714ea8c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api global, if"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly config each neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_02514b65","line":208,"range":{"start_line":208,"start_character":42,"end_line":208,"end_character":56},"in_reply_to":"3f79a3b5_c76cc59f","updated":"2018-12-21 15:29:09.000000000","message":"IMO the best place to mention it would be here:\nhttps://docs.openstack.org/neutron/latest/configuration/metadata-agent.html?highlight\u003dmetadata#DEFAULT.nova_metadata_host\n\nas it describes config option and we can mention there directly that this should point to nova-metadata-api from corresponding cell.\n\nIn other places it is also describes in overall what metadata agent is, there is anything about connection to nova there so it might be confusing to place it there.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    cfg.BoolOpt(\"local_metadata_per_cell\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicates that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid querying API DB for instance information. Users should consider"},{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_a81ee46d","line":202,"range":{"start_line":202,"start_character":19,"end_line":202,"end_character":31},"updated":"2019-01-03 16:10:32.000000000","message":"nit: we are really inconsistent about what we call this thing. If you run the nova-api-metadata script, then the actual services table entry is called \"nova-metadata\", but we refer to the thing as nova-api-metadata and nova-metadata-api all over the docs.\n\nTo be consistent, if we\u0027re talking about the service, let\u0027s just say nova-metadata. If you want to mix \"API\" into the wording, then say \"the nova-metadata API service\".","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"095379e9df0f006e31a1bdda85bed39f2195cce5","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    cfg.BoolOpt(\"local_metadata_per_cell\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicates that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid querying API DB for instance information. Users should consider"},{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_7b7d1a6d","line":202,"range":{"start_line":202,"start_character":19,"end_line":202,"end_character":31},"in_reply_to":"ffd0ebdf_a81ee46d","updated":"2019-01-04 08:40:43.000000000","message":"Done","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    cfg.BoolOpt(\"local_metadata_per_cell\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicates that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid querying API DB for instance information. Users should consider"},{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_63749d9a","line":203,"range":{"start_line":202,"start_character":68,"end_line":203,"end_character":53},"updated":"2019-01-03 16:10:32.000000000","message":"same note as in the docs and reno","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"095379e9df0f006e31a1bdda85bed39f2195cce5","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    cfg.BoolOpt(\"local_metadata_per_cell\","},{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicates that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid querying API DB for instance information. Users should consider"},{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_db88c672","line":203,"range":{"start_line":202,"start_character":68,"end_line":203,"end_character":53},"in_reply_to":"ffd0ebdf_63749d9a","updated":"2019-01-04 08:40:43.000000000","message":"Done","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":202,"context_line":"Indicates that the metadata-api service has been deployed per-cell, so that"},{"line_number":203,"context_line":"we can avoid querying API DB for instance information. Users should consider"},{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_4813b867","line":205,"range":{"start_line":205,"start_character":48,"end_line":205,"end_character":65},"updated":"2019-01-03 16:10:32.000000000","message":"same nit","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_e8038c0e","line":207,"range":{"start_line":207,"start_character":41,"end_line":207,"end_character":58},"updated":"2019-01-03 16:10:32.000000000","message":"and here","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":204,"context_line":"the use of this configuration depending on how neutron is setup. If you have"},{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_280af425","line":207,"range":{"start_line":207,"start_character":0,"end_line":207,"end_character":17},"updated":"2019-01-03 16:10:32.000000000","message":"same","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":205,"context_line":"networks that span cells, you might need to run nova-metadata-api globally. If"},{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_83fe6103","line":208,"range":{"start_line":208,"start_character":12,"end_line":208,"end_character":21},"updated":"2019-01-03 16:10:32.000000000","message":"remove this word","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":206,"context_line":"your networks are segmented along cell boundaries, then you can run"},{"line_number":207,"context_line":"nova-metadata-api per cell. When running nova-metadata-api per cell, you"},{"line_number":208,"context_line":"should also correctly configure each Neutron metadata-agent to point to the"},{"line_number":209,"context_line":"corresponding nova-metadata-api."},{"line_number":210,"context_line":"\"\"\"),"},{"line_number":211,"context_line":"]"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffd0ebdf_a303650d","line":209,"range":{"start_line":209,"start_character":14,"end_line":209,"end_character":31},"updated":"2019-01-03 16:10:32.000000000","message":"same","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6db3f5763d1e13622725022ce75222cfcbffba11","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicates that the nova-metadata API service has been deployed per-cell, so"},{"line_number":203,"context_line":"that we can have better performance and data isolation in a muli-cell"},{"line_number":204,"context_line":"deployment. Users should consider the use of this configuration depending on"},{"line_number":205,"context_line":"how neutron is setup. If you have networks that span cells, you might need to"},{"line_number":206,"context_line":"run nova-metadata API service globally. If your networks are segmented along"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffd0ebdf_6eaea82f","line":203,"range":{"start_line":203,"start_character":60,"end_line":203,"end_character":64},"updated":"2019-01-04 22:04:58.000000000","message":"multi","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"80ce6a0ec96c2f83c4a7c6856d20ad6a7a2dbfd4","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                default\u003dFalse,"},{"line_number":201,"context_line":"                help\u003d\"\"\""},{"line_number":202,"context_line":"Indicates that the nova-metadata API service has been deployed per-cell, so"},{"line_number":203,"context_line":"that we can have better performance and data isolation in a muli-cell"},{"line_number":204,"context_line":"deployment. Users should consider the use of this configuration depending on"},{"line_number":205,"context_line":"how neutron is setup. If you have networks that span cells, you might need to"},{"line_number":206,"context_line":"run nova-metadata API service globally. If your networks are segmented along"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfdaf3ff_fd2facf3","line":203,"range":{"start_line":203,"start_character":60,"end_line":203,"end_character":64},"in_reply_to":"ffd0ebdf_6eaea82f","updated":"2019-01-14 07:43:45.000000000","message":"Done","commit_id":"2df1fbb5ac58a922fa8659ecf1779bc63ebce1c4"}],"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"        with mock.patch.object(base, \u0027InstanceMetadata\u0027) as imd:"},{"line_number":1632,"context_line":"            with mock.patch(\u0027nova.context.target_cell\u0027) as mock_tc:"},{"line_number":1633,"context_line":"                base.get_metadata_by_instance_id(\u0027foo\u0027, \u0027bar\u0027, ctxt\u003dctxt)"},{"line_number":1634,"context_line":"                mock_tc.assert_not_called()"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"        mock_get_im.assert_not_called()"},{"line_number":1637,"context_line":"        imd.assert_called_once_with(inst, \u0027bar\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a75d09e6","line":1634,"range":{"start_line":1634,"start_character":16,"end_line":1634,"end_character":43},"updated":"2018-12-21 14:22:36.000000000","message":"I\u0027m not sure this is right since target_cell is a context manager, so this assertion might always pass. It\u0027s probably good enough just to assert that mock_get_im isn\u0027t called.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"20fac2cd4100c661325a0112084ca6af241d8a8b","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"        with mock.patch.object(base, \u0027InstanceMetadata\u0027) as imd:"},{"line_number":1632,"context_line":"            with mock.patch(\u0027nova.context.target_cell\u0027) as mock_tc:"},{"line_number":1633,"context_line":"                base.get_metadata_by_instance_id(\u0027foo\u0027, \u0027bar\u0027, ctxt\u003dctxt)"},{"line_number":1634,"context_line":"                mock_tc.assert_not_called()"},{"line_number":1635,"context_line":""},{"line_number":1636,"context_line":"        mock_get_im.assert_not_called()"},{"line_number":1637,"context_line":"        imd.assert_called_once_with(inst, \u0027bar\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f769fc5_1c3df4ba","line":1634,"range":{"start_line":1634,"start_character":16,"end_line":1634,"end_character":43},"in_reply_to":"3f79a3b5_a75d09e6","updated":"2018-12-24 02:07:36.000000000","message":"Done","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"}],"releasenotes/notes/run-meta-api-per-cell-69d74cdd70528085.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid query"},{"line_number":6,"context_line":"    API DB for instance information each time an instance query for its\u0027"},{"line_number":7,"context_line":"    metadata. But it has some caveats, for example, If yo have networks that"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_2707b9c9","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":8},"updated":"2018-12-21 14:22:36.000000000","message":"Remember that release notes are read in aggregate, so when reading this in docs it won\u0027t have any context to the change that added it, so don\u0027t write it like a commit message, i.e. \"this\" or \"adds\". Instead, use something like, \"Added configuration option ...\". In other words, use the past-tense as that\u0027s generally how people read these.","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"63d053777fdba052c93b1f7c9472f4c5a01cd040","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid query"},{"line_number":6,"context_line":"    API DB for instance information each time an instance query for its\u0027"},{"line_number":7,"context_line":"    metadata. But it has some caveats, for example, If yo have networks that"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f769fc5_7c3668b7","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":8},"in_reply_to":"3f79a3b5_2707b9c9","updated":"2018-12-24 06:24:35.000000000","message":"Done","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid query"},{"line_number":6,"context_line":"    API DB for instance information each time an instance query for its\u0027"},{"line_number":7,"context_line":"    metadata. But it has some caveats, for example, If yo have networks that"},{"line_number":8,"context_line":"    span cells, you might need to still run Nova metadata API service global."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_67cff189","line":5,"updated":"2018-12-21 14:22:36.000000000","message":"same comments from the docs on wording here - honestly it might just be better to link to those docs from here for more details:\n\nhttps://docs.openstack.org/nova/latest/user/cellsv2-layout.html#nova-metadata-api-service","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9af53ef39bcb2124ed122663cb77e60bf7633624","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid query"},{"line_number":6,"context_line":"    API DB for instance information each time an instance query for its\u0027"},{"line_number":7,"context_line":"    metadata. But it has some caveats, for example, If yo have networks that"},{"line_number":8,"context_line":"    span cells, you might need to still run Nova metadata API service global."},{"line_number":9,"context_line":"    On the other hand, if your networks are segmented along cell boundaries,"},{"line_number":10,"context_line":"    then you can run Nova metadata API service per cell. If you choose to run"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_87100df7","line":7,"range":{"start_line":7,"start_character":52,"end_line":7,"end_character":57},"updated":"2018-12-21 14:22:36.000000000","message":"if you","commit_id":"3deac1c38aff763f4bc5d892f2167603040924ac"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid"},{"line_number":6,"context_line":"    querying API DB for instance. But it has some caveats, see the"},{"line_number":7,"context_line":"    `Metadata api service in cells v2 layout`_ for more details."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffd0ebdf_e3188d76","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":8},"updated":"2019-01-03 16:10:32.000000000","message":"users to run","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"095379e9df0f006e31a1bdda85bed39f2195cce5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid"},{"line_number":6,"context_line":"    querying API DB for instance. But it has some caveats, see the"},{"line_number":7,"context_line":"    `Metadata api service in cells v2 layout`_ for more details."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffd0ebdf_db7a0687","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":8},"in_reply_to":"ffd0ebdf_e3188d76","updated":"2019-01-04 08:40:43.000000000","message":"Done","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0aa85af7112a5cefb8a598fd481f9d84aad2bd47","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid"},{"line_number":6,"context_line":"    querying API DB for instance. But it has some caveats, see the"},{"line_number":7,"context_line":"    `Metadata api service in cells v2 layout`_ for more details."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _Metadata api service in cells v2 layout: https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#nova-metadata-api-service"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffd0ebdf_e3316dee","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":33},"updated":"2019-01-03 16:10:32.000000000","message":"nit: I know this is mentioned in the docs and the config option, but I\u0027m not sure it means much to an operator. It would probably be better to explain why this is useful, i.e. performance improvement and data isolation.","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"095379e9df0f006e31a1bdda85bed39f2195cce5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added configuration option ``[api]/local_metadata_per_cell`` to allow"},{"line_number":5,"context_line":"    user run Nova metadata API service per cell. Doing this can avoid"},{"line_number":6,"context_line":"    querying API DB for instance. But it has some caveats, see the"},{"line_number":7,"context_line":"    `Metadata api service in cells v2 layout`_ for more details."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    .. _Metadata api service in cells v2 layout: https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#nova-metadata-api-service"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ffd0ebdf_bb75c29a","line":6,"range":{"start_line":5,"start_character":49,"end_line":6,"end_character":33},"in_reply_to":"ffd0ebdf_e3316dee","updated":"2019-01-04 08:40:43.000000000","message":"Done","commit_id":"bb857a4b386b4ee29654b12ce849c727ba5ee680"}]}