)]}'
{"nova/api/openstack/compute/plugins/v3/extended_volumes.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"acbcfbe6e6c211dd89efcc76a3b4ae01d0b3c28b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                # the core API adding it in its \u0027detail\u0027 method."},{"line_number":129,"context_line":"                self._extend_server(context, server, db_instance)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _validate_volume_id(self, volume_id):"},{"line_number":132,"context_line":"        if not uuidutils.is_uuid_like(volume_id):"},{"line_number":133,"context_line":"            msg \u003d _(\"Bad volumeId format: volumeId is \""},{"line_number":134,"context_line":"                    \"not in proper format (%s)\") % volume_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F8oOk%3D","line":131,"updated":"2013-12-24 03:14:41.000000000","message":"Is this function no longer required now?","commit_id":"db015d2b9bae6c614e4fb51abaaccaebe84a6b8f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"421f85a78cc817209ffbab5e7f946e6f34807453","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                # the core API adding it in its \u0027detail\u0027 method."},{"line_number":129,"context_line":"                self._extend_server(context, server, db_instance)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def _validate_volume_id(self, volume_id):"},{"line_number":132,"context_line":"        if not uuidutils.is_uuid_like(volume_id):"},{"line_number":133,"context_line":"            msg \u003d _(\"Bad volumeId format: volumeId is \""},{"line_number":134,"context_line":"                    \"not in proper format (%s)\") % volume_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F8lg8%3D","line":131,"in_reply_to":"AAAATn%2F8oOk%3D","updated":"2013-12-25 00:20:37.000000000","message":"Nice catch, you are right.\nI will remove here in the next patch.","commit_id":"db015d2b9bae6c614e4fb51abaaccaebe84a6b8f"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"e9a9529a892c4d6468465c84dc6ab94c212ed8a0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        authorize_swap(context)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            old_volume_id \u003d body[\u0027swap_volume_attachment\u0027][\u0027old_volume_id\u0027]"},{"line_number":66,"context_line":"            new_volume_id \u003d body[\u0027swap_volume_attachment\u0027][\u0027new_volume_id\u0027]"},{"line_number":67,"context_line":"            old_volume \u003d self.volume_api.get(context, old_volume_id)"},{"line_number":68,"context_line":"            new_volume \u003d self.volume_api.get(context, new_volume_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAT3%2F%2F%2BAU%3D","line":65,"updated":"2013-12-26 05:49:12.000000000","message":"I think this and next line should be moved to before of above \u0027try\u0027.","commit_id":"04215b3bafb47d619ecdd8fae54f41eb4544a5b6"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0d8dcab58051c447c975fcee28a70cf0ed61e3a2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        authorize_swap(context)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            old_volume_id \u003d body[\u0027swap_volume_attachment\u0027][\u0027old_volume_id\u0027]"},{"line_number":66,"context_line":"            new_volume_id \u003d body[\u0027swap_volume_attachment\u0027][\u0027new_volume_id\u0027]"},{"line_number":67,"context_line":"            old_volume \u003d self.volume_api.get(context, old_volume_id)"},{"line_number":68,"context_line":"            new_volume \u003d self.volume_api.get(context, new_volume_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAT3%2F%2F9z0%3D","line":65,"in_reply_to":"AAAAT3%2F%2F%2BAU%3D","updated":"2013-12-26 06:32:23.000000000","message":"Nice catch, thanks.\nI will move them to the above.","commit_id":"04215b3bafb47d619ecdd8fae54f41eb4544a5b6"}],"nova/api/openstack/compute/schemas/v3/extended_volumes_schema.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a99b7f6f384de0e7dea1bbcf2fb4765e28f3f411","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                    \u0027pattern\u0027: \u0027(^/dev/x{0,1}[a-z]{0,1}d{0,1})([a-z]+)[0-9]*$\u0027"},{"line_number":53,"context_line":"                },"},{"line_number":54,"context_line":"            },"},{"line_number":55,"context_line":"            \u0027required\u0027: [\u0027volume_id\u0027],"},{"line_number":56,"context_line":"        },"},{"line_number":57,"context_line":"    },"},{"line_number":58,"context_line":"    \u0027required\u0027: [\u0027attach\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAT3%2F%2F35I%3D","line":55,"updated":"2013-12-29 01:21:17.000000000","message":"I forgot to put \"\u0027additionalProperties\u0027: False,\" here, sorry.","commit_id":"e279086a00897a517415afaa83bd9cfff18d5a15"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a99b7f6f384de0e7dea1bbcf2fb4765e28f3f411","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027required\u0027: [\u0027volume_id\u0027],"},{"line_number":56,"context_line":"        },"},{"line_number":57,"context_line":"    },"},{"line_number":58,"context_line":"    \u0027required\u0027: [\u0027attach\u0027],"},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAT3%2F%2F35E%3D","line":58,"updated":"2013-12-29 01:21:17.000000000","message":"ditto","commit_id":"e279086a00897a517415afaa83bd9cfff18d5a15"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a99b7f6f384de0e7dea1bbcf2fb4765e28f3f411","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    \u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027"},{"line_number":70,"context_line":"                },"},{"line_number":71,"context_line":"            },"},{"line_number":72,"context_line":"            \u0027required\u0027: [\u0027volume_id\u0027],"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    \u0027required\u0027: [\u0027detach\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAT3%2F%2F35A%3D","line":72,"updated":"2013-12-29 01:21:17.000000000","message":"ditto","commit_id":"e279086a00897a517415afaa83bd9cfff18d5a15"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a99b7f6f384de0e7dea1bbcf2fb4765e28f3f411","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            \u0027required\u0027: [\u0027volume_id\u0027],"},{"line_number":73,"context_line":"        },"},{"line_number":74,"context_line":"    },"},{"line_number":75,"context_line":"    \u0027required\u0027: [\u0027detach\u0027],"},{"line_number":76,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAT3%2F%2F348%3D","line":75,"updated":"2013-12-29 01:21:17.000000000","message":"ditto","commit_id":"e279086a00897a517415afaa83bd9cfff18d5a15"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f7ad9f3f18a28eb16594f6c68033e0d45ee75bad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 NEC Corporation.  All rights reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2FxsA%3D","line":1,"updated":"2014-01-01 11:39:34.000000000","message":"for new files do we want to add the vim header - over the last few weeks these have been removed","commit_id":"4cb494d7cec86f4d47d18237e722ae9b51acee4d"}],"nova/tests/api/openstack/compute/plugins/v3/test_extended_volumes.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f7ad9f3f18a28eb16594f6c68033e0d45ee75bad","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def test_swap_volume_with_bad_action(self):"},{"line_number":300,"context_line":"        self.stubs.Set(compute.api.API, \u0027swap_volume\u0027, fake_swap_volume)"},{"line_number":301,"context_line":"        body \u003d {\u0027swap_volume_attachment_bad_action\u0027: None}"},{"line_number":302,"context_line":"        self.assertRaises(exception.ValidationError, self._test_swap,"},{"line_number":303,"context_line":"                          body\u003dbody)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def test_swap_volume_with_invalid_body(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2Fxr8%3D","line":302,"updated":"2014-01-01 11:39:34.000000000","message":"should this not raise a HTTP exception?","commit_id":"4cb494d7cec86f4d47d18237e722ae9b51acee4d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"19358b4de56fbc280f2edc11b5f0d74f096fe4ed","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def test_swap_volume_with_bad_action(self):"},{"line_number":300,"context_line":"        self.stubs.Set(compute.api.API, \u0027swap_volume\u0027, fake_swap_volume)"},{"line_number":301,"context_line":"        body \u003d {\u0027swap_volume_attachment_bad_action\u0027: None}"},{"line_number":302,"context_line":"        self.assertRaises(exception.ValidationError, self._test_swap,"},{"line_number":303,"context_line":"                          body\u003dbody)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def test_swap_volume_with_invalid_body(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAT3%2F%2Fxro%3D","line":302,"in_reply_to":"AAAAT3%2F%2Fxr8%3D","updated":"2014-01-01 11:44:04.000000000","message":"you can ignore this. cyeoh explained it to me","commit_id":"4cb494d7cec86f4d47d18237e722ae9b51acee4d"}]}