)]}'
{"nova/tests/conf_fixture.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"c394e6b6d4fc0083733f4826ebc396a742700d5e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                              \u0027nova.tests.utils.dns_manager\u0027)"},{"line_number":56,"context_line":"        self.conf.set_default(\u0027instance_dns_manager\u0027,"},{"line_number":57,"context_line":"                              \u0027nova.tests.utils.dns_manager\u0027)"},{"line_number":58,"context_line":"        self.conf.set_default(\u0027lock_path\u0027, os.getenv(\u0027NOVA_LOCK_PATH\u0027))"},{"line_number":59,"context_line":"        self.conf.set_default(\u0027network_size\u0027, 8)"},{"line_number":60,"context_line":"        self.conf.set_default(\u0027num_networks\u0027, 2)"},{"line_number":61,"context_line":"        self.conf.set_default(\u0027rpc_backend\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F82NY%3D","line":58,"updated":"2013-12-19 16:02:59.000000000","message":"I would suggest not setting this at all and letting the lockutils code look up the env var.  Just in case we decide to change the variable name or something.\n\nIt looks like that has already been synced from Oslo: https://github.com/openstack/nova/blob/master/nova/openstack/common/lockutils.py#L44","commit_id":"7895294157dcc6f5945122984623f087a60a55ec"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"e2d0a2bd78eacf081b69ac6fc7f71e3d0a6caca0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                              \u0027nova.tests.utils.dns_manager\u0027)"},{"line_number":56,"context_line":"        self.conf.set_default(\u0027instance_dns_manager\u0027,"},{"line_number":57,"context_line":"                              \u0027nova.tests.utils.dns_manager\u0027)"},{"line_number":58,"context_line":"        self.conf.set_default(\u0027lock_path\u0027, os.getenv(\u0027NOVA_LOCK_PATH\u0027))"},{"line_number":59,"context_line":"        self.conf.set_default(\u0027network_size\u0027, 8)"},{"line_number":60,"context_line":"        self.conf.set_default(\u0027num_networks\u0027, 2)"},{"line_number":61,"context_line":"        self.conf.set_default(\u0027rpc_backend\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F82Go%3D","line":58,"in_reply_to":"AAAATn%2F82NY%3D","updated":"2013-12-19 16:21:58.000000000","message":"Makes sense. Thanks for pointing this out, Ben! Done.","commit_id":"7895294157dcc6f5945122984623f087a60a55ec"}]}