)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"037bfdf02ca0e259232aae6df114ca8292250faf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the service to start up."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To this end, we copy the approach in the aforementioned change and"},{"line_number":16,"context_line":"implement a translation function in os_vif_util for binding_failed which"},{"line_number":17,"context_line":"will make the plug_vifs code raise VirtualInterfacePlugException which"},{"line_number":18,"context_line":"is what the _init_instance code in ComputeManager is already handling."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a24d25c7","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":66},"updated":"2018-12-19 16:20:48.000000000","message":"unbound","commit_id":"80881918f676d218d076ca30a66214c312dd089f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd96558845e3f3411c1f9b03ea2ecac741d5dc53","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the service to start up."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To this end, we copy the approach in the aforementioned change and"},{"line_number":16,"context_line":"implement a translation function in os_vif_util for binding_failed which"},{"line_number":17,"context_line":"will make the plug_vifs code raise VirtualInterfacePlugException which"},{"line_number":18,"context_line":"is what the _init_instance code in ComputeManager is already handling."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_08ee7bb5","line":16,"range":{"start_line":16,"start_character":52,"end_line":16,"end_character":66},"in_reply_to":"3f79a3b5_a24d25c7","updated":"2018-12-19 16:28:09.000000000","message":"Done","commit_id":"80881918f676d218d076ca30a66214c312dd089f"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"037bfdf02ca0e259232aae6df114ca8292250faf","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            LOG.debug(e, instance\u003dinstance)"},{"line_number":965,"context_line":"        except exception.VirtualInterfacePlugException:"},{"line_number":966,"context_line":"            # NOTE(mriedem): If we get here, it could be because the vif_type"},{"line_number":967,"context_line":"            # in the cache is \"binding_failed\" or \"unbound\". This shouldn\u0027t"},{"line_number":968,"context_line":"            # have been saved but, from here, the only way to fix this is to"},{"line_number":969,"context_line":"            # try and bind the ports again, which would be expensive here on"},{"line_number":970,"context_line":"            # host startup. We could add a check to _heal_instance_info_cache"},{"line_number":971,"context_line":"            # to handle this, but probably only if the instance task_state is"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c27dc1c3","line":968,"range":{"start_line":967,"start_character":61,"end_line":968,"end_character":29},"updated":"2018-12-19 16:20:48.000000000","message":"This is debatable and I wouldn\u0027t include it here - if we don\u0027t save it, the info_cache (our state) is not the same as neutron\u0027s state, which could lead to weird side effects. Generally I think it\u0027s best if we try to always mirror the source of truth as much as possible (hence https://review.openstack.org/#/c/591607/). So how about we just add the \u0027unbound\u0027 here and drop the additional editorial?","commit_id":"80881918f676d218d076ca30a66214c312dd089f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd96558845e3f3411c1f9b03ea2ecac741d5dc53","unresolved":false,"context_lines":[{"line_number":964,"context_line":"            LOG.debug(e, instance\u003dinstance)"},{"line_number":965,"context_line":"        except exception.VirtualInterfacePlugException:"},{"line_number":966,"context_line":"            # NOTE(mriedem): If we get here, it could be because the vif_type"},{"line_number":967,"context_line":"            # in the cache is \"binding_failed\" or \"unbound\". This shouldn\u0027t"},{"line_number":968,"context_line":"            # have been saved but, from here, the only way to fix this is to"},{"line_number":969,"context_line":"            # try and bind the ports again, which would be expensive here on"},{"line_number":970,"context_line":"            # host startup. We could add a check to _heal_instance_info_cache"},{"line_number":971,"context_line":"            # to handle this, but probably only if the instance task_state is"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c8cac342","line":968,"range":{"start_line":967,"start_character":61,"end_line":968,"end_character":29},"in_reply_to":"3f79a3b5_c27dc1c3","updated":"2018-12-19 16:28:09.000000000","message":"Fair point. Done.","commit_id":"80881918f676d218d076ca30a66214c312dd089f"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"037bfdf02ca0e259232aae6df114ca8292250faf","unresolved":false,"context_lines":[{"line_number":499,"context_line":"def _nova_to_osvif_vif_unbound(vif):"},{"line_number":500,"context_line":"    \"\"\"Special handler for the \"unbound\" vif type."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    The \"unboung\" vif type indicates a port has not been hooked up to backend"},{"line_number":503,"context_line":"    network driver (OVS, linux bridge, ...). We raise NotImplementedError to"},{"line_number":504,"context_line":"    indicate to the caller that we cannot handle this type of vif rather than"},{"line_number":505,"context_line":"    the generic \"Unsupported VIF type\" error in nova_to_osvif_vif."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_624dcd92","line":502,"range":{"start_line":502,"start_character":9,"end_line":502,"end_character":16},"updated":"2018-12-19 16:20:48.000000000","message":"unbound","commit_id":"80881918f676d218d076ca30a66214c312dd089f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fd96558845e3f3411c1f9b03ea2ecac741d5dc53","unresolved":false,"context_lines":[{"line_number":499,"context_line":"def _nova_to_osvif_vif_unbound(vif):"},{"line_number":500,"context_line":"    \"\"\"Special handler for the \"unbound\" vif type."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    The \"unboung\" vif type indicates a port has not been hooked up to backend"},{"line_number":503,"context_line":"    network driver (OVS, linux bridge, ...). We raise NotImplementedError to"},{"line_number":504,"context_line":"    indicate to the caller that we cannot handle this type of vif rather than"},{"line_number":505,"context_line":"    the generic \"Unsupported VIF type\" error in nova_to_osvif_vif."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e8c77f3d","line":502,"range":{"start_line":502,"start_character":9,"end_line":502,"end_character":16},"in_reply_to":"3f79a3b5_624dcd92","updated":"2018-12-19 16:28:09.000000000","message":"Done","commit_id":"80881918f676d218d076ca30a66214c312dd089f"}]}