)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dead5b27aeaf95470e097c301d6901d9d15af349","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure rbd auth fallback uses matching credentials"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of Ocata, cinder config is preferred for rbd auth values with a"},{"line_number":10,"context_line":"fallback to nova values [1]. The fallback, however, results in the"},{"line_number":11,"context_line":"mismatched use of cinder auth_username with nova rbd_secret_uuid."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_fd615010","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":11},"updated":"2018-12-21 16:32:09.000000000","message":"Technically Pike:\n\nhttps://review.openstack.org/#/c/472266/\n\nUnless [1] should be b89efa3ef611a1932df0c2d6e6f30315b5111a57.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a78a347af6db8156c2741fbdf9bd39863a6441c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure rbd auth fallback uses matching credentials"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of Ocata, cinder config is preferred for rbd auth values with a"},{"line_number":10,"context_line":"fallback to nova values [1]. The fallback, however, results in the"},{"line_number":11,"context_line":"mismatched use of cinder auth_username with nova rbd_secret_uuid."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_41e3becb","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":11},"in_reply_to":"3f79a3b5_b839a6d0","updated":"2018-12-21 19:47:00.000000000","message":"Yeah the fallback was https://review.openstack.org/#/c/472687. I was just thinking about how the \"use cinder over nova conf\" was a different change, but either way I think I see what you\u0027re saying.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"43447b3f3569e8edbdb7805f0ec2820b59e6c955","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure rbd auth fallback uses matching credentials"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of Ocata, cinder config is preferred for rbd auth values with a"},{"line_number":10,"context_line":"fallback to nova values [1]. The fallback, however, results in the"},{"line_number":11,"context_line":"mismatched use of cinder auth_username with nova rbd_secret_uuid."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b839a6d0","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":11},"in_reply_to":"3f79a3b5_fd615010","updated":"2018-12-21 16:53:07.000000000","message":"That was cherry-picked to ocata though via https://review.openstack.org/#/c/472687","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"}],"nova/tests/unit/virt/libvirt/volume/test_net.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dead5b27aeaf95470e097c301d6901d9d15af349","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        secret_uuid wasn\u0027t set on the cinder side for the original connection"},{"line_number":151,"context_line":"        which is now persisted in the"},{"line_number":152,"context_line":"        nova.block_device_mappings.connection_info column and used here. In"},{"line_number":153,"context_line":"        this case we fallback to use the local config for secret_uuid."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        libvirt_driver \u003d net.LibvirtNetVolumeDriver(self.fake_host)"},{"line_number":156,"context_line":"        connection_info \u003d self.rbd_connection(self.vol)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bd1d1879","line":153,"range":{"start_line":153,"start_character":58,"end_line":153,"end_character":69},"updated":"2018-12-21 16:32:09.000000000","message":"and username.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"43447b3f3569e8edbdb7805f0ec2820b59e6c955","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        secret_uuid wasn\u0027t set on the cinder side for the original connection"},{"line_number":151,"context_line":"        which is now persisted in the"},{"line_number":152,"context_line":"        nova.block_device_mappings.connection_info column and used here. In"},{"line_number":153,"context_line":"        this case we fallback to use the local config for secret_uuid."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        libvirt_driver \u003d net.LibvirtNetVolumeDriver(self.fake_host)"},{"line_number":156,"context_line":"        connection_info \u003d self.rbd_connection(self.vol)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_386fd6c7","line":153,"range":{"start_line":153,"start_character":58,"end_line":153,"end_character":69},"in_reply_to":"3f79a3b5_bd1d1879","updated":"2018-12-21 16:53:07.000000000","message":"Good catch, let me fix that.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"620aeafbe8a354802b5953944ef17525c21f5f17","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        secret_uuid wasn\u0027t set on the cinder side for the original connection"},{"line_number":151,"context_line":"        which is now persisted in the"},{"line_number":152,"context_line":"        nova.block_device_mappings.connection_info column and used here. In"},{"line_number":153,"context_line":"        this case we fallback to use the local config for secret_uuid."},{"line_number":154,"context_line":"        \"\"\""},{"line_number":155,"context_line":"        libvirt_driver \u003d net.LibvirtNetVolumeDriver(self.fake_host)"},{"line_number":156,"context_line":"        connection_info \u003d self.rbd_connection(self.vol)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_273fb2b3","line":153,"range":{"start_line":153,"start_character":58,"end_line":153,"end_character":69},"updated":"2018-12-21 21:54:41.000000000","message":"and username","commit_id":"6fea14020bf7246bfcb2c7b2dcb71b680e9a0aa0"}],"nova/virt/libvirt/volume/net.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dead5b27aeaf95470e097c301d6901d9d15af349","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7dfc600d","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"updated":"2018-12-21 16:32:09.000000000","message":"This was explicitly checking secret_uuid. Could it be possible that cinder is configured with auth_enabled\u003dTrue, and a secret_uuid is provided by rbd_user is not? In other words, should it be a separate conditional block for rbd_user?","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a78a347af6db8156c2741fbdf9bd39863a6441c1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8132365a","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_187c5a1f","updated":"2018-12-21 19:47:00.000000000","message":"\u003e To be honest we\u0027re not really sure where auth_enabled gets set. If\n \u003e it were false, then it looks like the else uses the correct\n \u003e rbd_user and rbd_secret_uuid.\n\nIt comes from the connection_info generated during initialize_connection in the rbd cinder volume driver:\n\nhttps://github.com/openstack/cinder/blob/stable/ocata/cinder/volume/drivers/rbd.py#L1088\n\nAnd looking at that, auth_enabled should only be True if rbd_user is set, which is probably why I didn\u0027t add the fallback here. The rbd_secret_uuid came from cinder.conf which is why it was possible that it could have been misconfigured to have the rbd_user configured (which makes auth_enabled\u003dTrue) but not have the secret_uuid configured in cinder.conf, which was bug 1687581 and why we needed the fallback.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a78a347af6db8156c2741fbdf9bd39863a6441c1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a12972f0","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_58cf3289","updated":"2018-12-21 19:47:00.000000000","message":"\u003e I\u0027m not sure I understand this one. Can you clarify please?\n\nI meant is it possible that secret_uuid is not None (from cinder) but rbd_user is None (from cinder), thus meaning you\u0027d need separate conditionals to fallback to using local nova.conf for secret_uuid or rbd_user.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"ee3ec97c068c4a189d18f2635daed6f9f89b9e0e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_187c5a1f","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_58cf3289","updated":"2018-12-21 17:02:44.000000000","message":"To be honest we\u0027re not really sure where auth_enabled gets set. If it were false, then it looks like the else uses the correct rbd_user and rbd_secret_uuid.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8248d257415924af75b4ed14a3ccc7f6e9897f83","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a1509262","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_61659a49","updated":"2018-12-21 19:51:35.000000000","message":"Alternatively, add a comment with the new change on L74 below saying something to the effect of, even if rbd_user is configured in cinder, if we\u0027re using the secret_uuid from nova.conf we need to use the rbd_user from nova.conf as well.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"43c3079285b7e3f8de44fb5e32c1332fb041c6ec","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_848b2468","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_61659a49","updated":"2018-12-21 20:45:03.000000000","message":"Yes that is exactly the issue we are hitting. I wasn\u0027t sure if rbd_secret_uuid wasn\u0027t set but clearly it must not have been, seeing that we\u0027re hitting the else path within this auth_enabled block, and seeing that in connection_info secret_uuid is set to self.configuration.rbd_secret_uuid.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"43447b3f3569e8edbdb7805f0ec2820b59e6c955","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_58cf3289","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_7dfc600d","updated":"2018-12-21 16:53:07.000000000","message":"I\u0027m not sure I understand this one. Can you clarify please?","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"96c49e1ea66896e396002c2dcf69fb4f0b3191ad","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_61659a49","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_8132365a","updated":"2018-12-21 19:49:38.000000000","message":"Reading the new bug 1687581, it sounds like the issue was cinder rbd_user was configured so auth_enabled\u003dTrue above, but secret_uuid was not configured in cinder (bug 1687581) so nova used the fallback code here to use the nova.conf secret_uuid, but is using the rbd_user from the volume connection_info (cinder.conf).\n\nThe fix is that if we\u0027re using the nova.conf secret_uuid because it isn\u0027t coming from cinder, we need to also use the rbd_user from nova.conf because regardless of whether or not rbd_user is coming from cinder, we can\u0027t use it (we need to use the secret that matches the user).\n\nIs that correct? If so, that might be better explained in the commit message.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"43c3079285b7e3f8de44fb5e32c1332fb041c6ec","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # in Ocata, but if we have a guest connection from before that when"},{"line_number":67,"context_line":"            # secret_uuid wasn\u0027t configured in Cinder, we need to fallback to"},{"line_number":68,"context_line":"            # get it from local nova.conf."},{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_64904898","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":61},"in_reply_to":"3f79a3b5_a1509262","updated":"2018-12-21 20:45:03.000000000","message":"I\u0027ll update the commit message and add a comment to better explain the situation. Thanks very much for the review and suggestions.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dead5b27aeaf95470e097c301d6901d9d15af349","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"},{"line_number":73,"context_line":"                          \u0027secret_uuid value.\u0027)"},{"line_number":74,"context_line":"                conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":75,"context_line":"                conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":76,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5d2de4aa","line":73,"range":{"start_line":72,"start_character":16,"end_line":73,"end_character":47},"updated":"2018-12-21 16:32:09.000000000","message":"This should probably be updated to mention username.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"43447b3f3569e8edbdb7805f0ec2820b59e6c955","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if netdisk_properties[\u0027secret_uuid\u0027] is not None:"},{"line_number":70,"context_line":"                conf.auth_secret_uuid \u003d netdisk_properties[\u0027secret_uuid\u0027]"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"},{"line_number":73,"context_line":"                          \u0027secret_uuid value.\u0027)"},{"line_number":74,"context_line":"                conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":75,"context_line":"                conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"},{"line_number":76,"context_line":"            # secret_type is always hard-coded to \u0027ceph\u0027 in cinder"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5897329c","line":73,"range":{"start_line":72,"start_character":16,"end_line":73,"end_character":47},"in_reply_to":"3f79a3b5_5d2de4aa","updated":"2018-12-21 16:53:07.000000000","message":"Good point. I\u0027ll fix that.","commit_id":"619b81e81f99dad4601c4e0d567d7f138562856c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"620aeafbe8a354802b5953944ef17525c21f5f17","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                # If we\u0027re using the rbd_secret_uuid from nova.conf we need to"},{"line_number":73,"context_line":"                # use the rbd_user from nova.conf as well."},{"line_number":74,"context_line":"                LOG.debug(\u0027Falling back to Nova configuration for RBD auth \u0027"},{"line_number":75,"context_line":"                          \u0027secret_uuid value.\u0027)"},{"line_number":76,"context_line":"                conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":77,"context_line":"                conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_873486d8","line":74,"updated":"2018-12-21 21:54:41.000000000","message":"nit: this log message could have been updated to mention rbd_user as well.","commit_id":"6fea14020bf7246bfcb2c7b2dcb71b680e9a0aa0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"23fb35a6afb4cbdedf42dc8844d06a0cd4f52953","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        elif CONF.libvirt.rbd_secret_uuid:"},{"line_number":81,"context_line":"            # Anyone relying on falling back to nova config is probably having"},{"line_number":82,"context_line":"            # this work accidentally and we\u0027ll remove that support in the"},{"line_number":83,"context_line":"            # 17.0.0 Queens release."},{"line_number":84,"context_line":"            # NOTE(mriedem): We\u0027ll have to be extra careful about this in case"},{"line_number":85,"context_line":"            # the reason we got here is due to an old volume connection created"},{"line_number":86,"context_line":"            # before we started preferring the Cinder settings in Ocata."},{"line_number":87,"context_line":"            LOG.warning(\u0027Falling back to Nova configuration values for \u0027"},{"line_number":88,"context_line":"                        \u0027RBD authentication. Cinder should be configured \u0027"},{"line_number":89,"context_line":"                        \u0027for auth with Ceph volumes. This fallback will \u0027"},{"line_number":90,"context_line":"                        \u0027be dropped in the Nova 17.0.0 Queens release.\u0027)"},{"line_number":91,"context_line":"            # use the nova config values"},{"line_number":92,"context_line":"            conf.auth_username \u003d CONF.libvirt.rbd_user"},{"line_number":93,"context_line":"            conf.auth_secret_uuid \u003d CONF.libvirt.rbd_secret_uuid"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a79982ce","line":90,"range":{"start_line":83,"start_character":12,"end_line":90,"end_character":72},"updated":"2018-12-21 21:57:58.000000000","message":"We should update this queens mention as well, but I\u0027ll do that in a follow up.","commit_id":"47b7c4f3cc582bf463fd0c796df84736a0074f48"}]}