)]}'
{"doc/notification_samples/common_payloads/InstanceCreatePayload.json":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"da226810b58caca8244f6f1950248f06501e7a83","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            \"cert-id-1\","},{"line_number":22,"context_line":"            \"cert-id-2\""},{"line_number":23,"context_line":"        ],"},{"line_number":24,"context_line":"        \"instance_name\": \"instance-00000001\""},{"line_number":25,"context_line":"    },"},{"line_number":26,"context_line":"    \"nova_object.name\":\"InstanceCreatePayload\","},{"line_number":27,"context_line":"    \"nova_object.version\": \"1.11\""}],"source_content_type":"application/json","patch_set":3,"id":"bfdaf3ff_9de67d44","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":22},"updated":"2019-01-15 15:24:02.000000000","message":"Looks like the correct variable name to use since we want the notification fields to more or less try to match the REST API resource fields, and this would map to OS-EXT-SRV-ATTR:instance_name and given we don\u0027t want to propagate the weird legacy OS-EXT-SRV-ATTR prefix in the notifications (or new REST API microversions for that matter), this looks good.","commit_id":"94f9892a9fd99dcc3d803694e138c83145f9ac02"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5f2253c01e123a760405d2cd7db79b7896708785","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.trusted_image_certificates \u003d None"},{"line_number":252,"context_line":"        if instance.trusted_certs:"},{"line_number":253,"context_line":"            self.trusted_image_certificates \u003d instance.trusted_certs.ids"},{"line_number":254,"context_line":"        self.instance_name \u003d getattr(instance, \u0027name\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffd0ebdf_556ca807","line":254,"range":{"start_line":254,"start_character":29,"end_line":254,"end_character":54},"updated":"2019-01-04 01:21:57.000000000","message":"nit: It can be \u0027instance.name\u0027.","commit_id":"9626b4c2b738ef1340dc7c550e9e941a0cbf626c"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"326414acf3c3a5eb1193b4270f5bc7cca10abda1","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.trusted_image_certificates \u003d None"},{"line_number":252,"context_line":"        if instance.trusted_certs:"},{"line_number":253,"context_line":"            self.trusted_image_certificates \u003d instance.trusted_certs.ids"},{"line_number":254,"context_line":"        self.instance_name \u003d getattr(instance, \u0027name\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffd0ebdf_a75e07e4","line":254,"range":{"start_line":254,"start_character":29,"end_line":254,"end_character":54},"in_reply_to":"ffd0ebdf_556ca807","updated":"2019-01-04 02:04:32.000000000","message":"+1","commit_id":"9626b4c2b738ef1340dc7c550e9e941a0cbf626c"},{"author":{"_account_id":19159,"name":"Ifat Afek","email":"ifat.afek@nokia.com","username":"ifat_afek"},"change_message_id":"6a2f72d4a217c153bb2895a84a9f2912a97f387a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.trusted_image_certificates \u003d None"},{"line_number":252,"context_line":"        if instance.trusted_certs:"},{"line_number":253,"context_line":"            self.trusted_image_certificates \u003d instance.trusted_certs.ids"},{"line_number":254,"context_line":"        self.instance_name \u003d getattr(instance, \u0027name\u0027)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"@nova_base.NovaObjectRegistry.register_notification"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_343d68bb","line":254,"range":{"start_line":254,"start_character":29,"end_line":254,"end_character":54},"in_reply_to":"ffd0ebdf_a75e07e4","updated":"2019-01-07 15:32:45.000000000","message":"Done","commit_id":"9626b4c2b738ef1340dc7c550e9e941a0cbf626c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"da226810b58caca8244f6f1950248f06501e7a83","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        \u0027tags\u0027: fields.ListOfStringsField(),"},{"line_number":236,"context_line":"        \u0027trusted_image_certificates\u0027: fields.ListOfStringsField("},{"line_number":237,"context_line":"            nullable\u003dTrue),"},{"line_number":238,"context_line":"        \u0027instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":239,"context_line":"    }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def __init__(self, context, instance, fault, bdms):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_7d3159a2","line":238,"range":{"start_line":238,"start_character":44,"end_line":238,"end_character":57},"updated":"2019-01-15 15:24:02.000000000","message":"This is fine although I\u0027m not sure instance.name would ever return None.","commit_id":"94f9892a9fd99dcc3d803694e138c83145f9ac02"}],"releasenotes/notes/add-instance-name-to-instance-create-notification-4c2f5eca9e574178.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"da226810b58caca8244f6f1950248f06501e7a83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The field ``instance_name`` have been added to InstanceCreatePayload."},{"line_number":5,"context_line":"    Versioned notifications for instance create action will include this field."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfdaf3ff_1dddad41","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":72},"updated":"2019-01-15 15:24:02.000000000","message":"This is code-speak. Use the actual notification names:\n\n* instance.create.start\n* instance.create.end\n* instance.create.error","commit_id":"94f9892a9fd99dcc3d803694e138c83145f9ac02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"da226810b58caca8244f6f1950248f06501e7a83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The field ``instance_name`` have been added to InstanceCreatePayload."},{"line_number":5,"context_line":"    Versioned notifications for instance create action will include this field."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfdaf3ff_fd1c6914","line":4,"range":{"start_line":4,"start_character":32,"end_line":4,"end_character":36},"updated":"2019-01-15 15:24:02.000000000","message":"has","commit_id":"94f9892a9fd99dcc3d803694e138c83145f9ac02"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"da226810b58caca8244f6f1950248f06501e7a83","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The field ``instance_name`` have been added to InstanceCreatePayload."},{"line_number":5,"context_line":"    Versioned notifications for instance create action will include this field."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bfdaf3ff_dde64517","line":5,"updated":"2019-01-15 15:24:02.000000000","message":"This is a bit redundant if we just mention which notifications get the new field.","commit_id":"94f9892a9fd99dcc3d803694e138c83145f9ac02"}]}