)]}'
{"etc/nova/nova.conf.sample":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ab32713b904c0bacf6a2c2b61fe9614fa2d22543","unresolved":false,"context_lines":[{"line_number":2621,"context_line":""},{"line_number":2622,"context_line":"# Protocol of the admin Identity API endpoint(http or https)"},{"line_number":2623,"context_line":"# (string value)"},{"line_number":2624,"context_line":"#auth_protocol\u003dhttps"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"# Complete public Identity API endpoint (string value)"},{"line_number":2627,"context_line":"#auth_uri\u003d\u003cNone\u003e"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F8w4c%3D","line":2624,"updated":"2013-12-20 15:19:09.000000000","message":"This used to be http...","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"99f0aa06d1fa46e81f90d1458554bb7ade6244a3","unresolved":false,"context_lines":[{"line_number":2621,"context_line":""},{"line_number":2622,"context_line":"# Protocol of the admin Identity API endpoint(http or https)"},{"line_number":2623,"context_line":"# (string value)"},{"line_number":2624,"context_line":"#auth_protocol\u003dhttps"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"# Complete public Identity API endpoint (string value)"},{"line_number":2627,"context_line":"#auth_uri\u003d\u003cNone\u003e"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAT3%2F%2FvFM%3D","line":2624,"in_reply_to":"AAAAT3%2F%2F0vk%3D","updated":"2014-01-02 17:17:05.000000000","message":"Was this discussed on openstack-dev?\n\nThis isn\u0027t really related to the review,  but this seems  like a pretty important breaking change that people need to know about.  It\u0027s going to break a large number of deployments, I suspect.","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"cf9b16e45d98c7d4c3da81937662db136ae1fc43","unresolved":false,"context_lines":[{"line_number":2621,"context_line":""},{"line_number":2622,"context_line":"# Protocol of the admin Identity API endpoint(http or https)"},{"line_number":2623,"context_line":"# (string value)"},{"line_number":2624,"context_line":"#auth_protocol\u003dhttps"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"# Complete public Identity API endpoint (string value)"},{"line_number":2627,"context_line":"#auth_uri\u003d\u003cNone\u003e"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAT3%2F%2FvDo%3D","line":2624,"in_reply_to":"AAAAT3%2F%2FvFM%3D","updated":"2014-01-02 17:26:33.000000000","message":"Actually, it looks like https has been the default in keystoneclient since auth_token was merged into keystoneclient back in Nov 2012.  See commit 7920899af119d1697c333d202ca3272f167c19b0 in keystoneclient\n\nSo, this is just a nova behavior change because this commit is removing the nova imposed defaults.","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b8ca1dbd9bc88a9e98d4576907d2169a7c5defab","unresolved":false,"context_lines":[{"line_number":2621,"context_line":""},{"line_number":2622,"context_line":"# Protocol of the admin Identity API endpoint(http or https)"},{"line_number":2623,"context_line":"# (string value)"},{"line_number":2624,"context_line":"#auth_protocol\u003dhttps"},{"line_number":2625,"context_line":""},{"line_number":2626,"context_line":"# Complete public Identity API endpoint (string value)"},{"line_number":2627,"context_line":"#auth_uri\u003d\u003cNone\u003e"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAT3%2F%2F0vk%3D","line":2624,"in_reply_to":"AAAATn%2F8w4c%3D","updated":"2013-12-30 18:54:22.000000000","message":"This changed somewhat recently. Since this makes the system more secure by default it was deemed to be an acceptable change despite that it\u0027s not completely backwards compatible.","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ab32713b904c0bacf6a2c2b61fe9614fa2d22543","unresolved":false,"context_lines":[{"line_number":2628,"context_line":""},{"line_number":2629,"context_line":"# API version of the admin Identity API endpoint (string"},{"line_number":2630,"context_line":"# value)"},{"line_number":2631,"context_line":"#auth_version\u003d\u003cNone\u003e"},{"line_number":2632,"context_line":""},{"line_number":2633,"context_line":"# Do not handle authorization requests within the middleware,"},{"line_number":2634,"context_line":"# but delegate the authorization decision to downstream WSGI"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F8w40%3D","line":2631,"updated":"2013-12-20 15:19:09.000000000","message":"This used to default to v2.0, will we have issues if it doesn\u0027t now?","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b8ca1dbd9bc88a9e98d4576907d2169a7c5defab","unresolved":false,"context_lines":[{"line_number":2628,"context_line":""},{"line_number":2629,"context_line":"# API version of the admin Identity API endpoint (string"},{"line_number":2630,"context_line":"# value)"},{"line_number":2631,"context_line":"#auth_version\u003d\u003cNone\u003e"},{"line_number":2632,"context_line":""},{"line_number":2633,"context_line":"# Do not handle authorization requests within the middleware,"},{"line_number":2634,"context_line":"# but delegate the authorization decision to downstream WSGI"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAT3%2F%2F0vo%3D","line":2631,"in_reply_to":"AAAATn%2F8w40%3D","updated":"2013-12-30 18:54:22.000000000","message":"the auth_version is now calculated at runtime by default, and it will be v2.0 if the keystone server supports it.","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ab32713b904c0bacf6a2c2b61fe9614fa2d22543","unresolved":false,"context_lines":[{"line_number":2684,"context_line":""},{"line_number":2685,"context_line":"# Directory used to cache files related to PKI tokens (string"},{"line_number":2686,"context_line":"# value)"},{"line_number":2687,"context_line":"#signing_dir\u003d\u003cNone\u003e"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"# If defined, the memcache server(s) to use for caching (list"},{"line_number":2690,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F8w4k%3D","line":2687,"updated":"2013-12-20 15:19:09.000000000","message":"This used to default to /var/lib/nova/keystone-signing - problems if it doesn\u0027t now?  My main concern here is a regression to packagers/deployers that would now have to set these values explicitly.","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b8ca1dbd9bc88a9e98d4576907d2169a7c5defab","unresolved":false,"context_lines":[{"line_number":2684,"context_line":""},{"line_number":2685,"context_line":"# Directory used to cache files related to PKI tokens (string"},{"line_number":2686,"context_line":"# value)"},{"line_number":2687,"context_line":"#signing_dir\u003d\u003cNone\u003e"},{"line_number":2688,"context_line":""},{"line_number":2689,"context_line":"# If defined, the memcache server(s) to use for caching (list"},{"line_number":2690,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAT3%2F%2F0vM%3D","line":2687,"in_reply_to":"AAAATn%2F8w4k%3D","updated":"2013-12-30 18:54:22.000000000","message":"the new value will be a random directory in /tmp -- tempfile.mkdtemp(prefix\u003d\u0027keystone-signing-\u0027) .\n\nThis seems to me like something that packagers/deployers shouldn\u0027t have been relying on.\n\nThis is a sample config file and it\u0027s just documenting what config options are available and what the defaults are. This isn\u0027t actually changing the defaults. I guess packagers/deployers could have abused this and used it as a template, but I\u0027m not sure that OpenStack needs to support that.","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"}],"tools/config/generate_sample.sh":[{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"bd7d608d16818c004739dbac5c44066efa86442b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"FILES\u003d$(find $TARGETDIR -type f -name \"*.py\" ! -path \"*/tests/*\" \\"},{"line_number":78,"context_line":"        -exec grep -l \"Opt(\" {} + | sed -e \"s/^$BASEDIRESC\\///g\" | sort -u)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"EXTRA_MODULES_FILE\u003d\"`dirname $0`/oslo.config.generator.rc\""},{"line_number":81,"context_line":"if test -r \"$EXTRA_MODULES_FILE\""},{"line_number":82,"context_line":"then"},{"line_number":83,"context_line":"    source \"$EXTRA_MODULES_FILE\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F8%2BEU%3D","line":80,"updated":"2013-12-18 09:28:05.000000000","message":"This file is missing in your review. intentional?","commit_id":"bf6a6876c4258f8424683b79bed229cdce7e61b1"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"c175aaae3b09b7fb1ed8d518d4ac11a11fac6209","unresolved":false,"context_lines":[{"line_number":77,"context_line":"FILES\u003d$(find $TARGETDIR -type f -name \"*.py\" ! -path \"*/tests/*\" \\"},{"line_number":78,"context_line":"        -exec grep -l \"Opt(\" {} + | sed -e \"s/^$BASEDIRESC\\///g\" | sort -u)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"EXTRA_MODULES_FILE\u003d\"`dirname $0`/oslo.config.generator.rc\""},{"line_number":81,"context_line":"if test -r \"$EXTRA_MODULES_FILE\""},{"line_number":82,"context_line":"then"},{"line_number":83,"context_line":"    source \"$EXTRA_MODULES_FILE\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAATn%2F89qo%3D","line":80,"in_reply_to":"AAAATn%2F8%2BEU%3D","updated":"2013-12-18 10:55:18.000000000","message":"Oops, I\u0027ll add the missing file.","commit_id":"bf6a6876c4258f8424683b79bed229cdce7e61b1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e667d91e8625c42b75203d4d763cff2bde3aa35b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"FILES\u003d$(find $TARGETDIR -type f -name \"*.py\" ! -path \"*/tests/*\" \\"},{"line_number":78,"context_line":"        -exec grep -l \"Opt(\" {} + | sed -e \"s/^$BASEDIRESC\\///g\" | sort -u)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"EXTRA_MODULES_FILE\u003d\"`dirname $0`/oslo.config.generator.rc\""},{"line_number":81,"context_line":"if test -r \"$EXTRA_MODULES_FILE\""},{"line_number":82,"context_line":"then"},{"line_number":83,"context_line":"    source \"$EXTRA_MODULES_FILE\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAATn%2F87qk%3D","line":80,"updated":"2013-12-18 16:54:50.000000000","message":"I was wondering if this file should be named oslo.config.generator.rc or nova.config.generator.rc, but it\u0027s oslo, this is the ceilometer version of the same (which is why this code was added to oslo-incubator):\n\nhttps://github.com/openstack/ceilometer/blob/master/tools/config/oslo.config.generator.rc","commit_id":"6c8d2cd7120899564bfb27e833c46e10ad0e4d79"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b8ca1dbd9bc88a9e98d4576907d2169a7c5defab","unresolved":false,"context_lines":[{"line_number":95,"context_line":"# Hook to allow projects to append custom config file snippets"},{"line_number":96,"context_line":"CONCAT_FILES\u003d$(ls $BASEDIR/tools/config/*.conf.sample 2\u003e/dev/null)"},{"line_number":97,"context_line":"for CONCAT_FILE in $CONCAT_FILES; do"},{"line_number":98,"context_line":"    cat $CONCAT_FILE \u003e\u003e $OUTPUTFILE"},{"line_number":99,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAT3%2F%2F0tg%3D","line":98,"updated":"2013-12-30 18:54:22.000000000","message":"why not cat $CONCAT_FILES \u003e\u003e $OUTPUTFILE\n\nor even\n\n cat $(ls $BASEDIR/tools/config/*.conf.sample 2\u003e/dev/null) \u003e\u003e $OUTPUTFILE","commit_id":"dc8649574c00c9cf79e658ca6ce9bb7b239e8f4c"}],"tools/config/keystone_authtoken.conf.sample":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"d2c9adfb13358054378ba0072ee30e1af9671131","unresolved":false,"context_lines":[{"line_number":11,"context_line":"auth_port \u003d 35357"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Protocol of the admin Identity API endpoint"},{"line_number":14,"context_line":"auth_protocol \u003d http"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Keystone service account tenant name to validate user tokens"},{"line_number":17,"context_line":"admin_tenant_name \u003d %SERVICE_TENANT_NAME%"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F8sc0%3D","side":"PARENT","line":14,"updated":"2013-12-23 05:57:57.000000000","message":"now the new generated default value is \u0027https\u0027, but this seems not compatible with the default values in keystone.conf.sample","commit_id":"7d79f458d6935bd7939a7c7d3b15d114e85268f2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"d2c9adfb13358054378ba0072ee30e1af9671131","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# signing_dir is configurable, but the default behavior of the authtoken"},{"line_number":27,"context_line":"# middleware should be sufficient.  It will create a temporary directory"},{"line_number":28,"context_line":"# in the home directory for the user the nova process is running as."},{"line_number":29,"context_line":"#signing_dir \u003d /var/lib/nova/keystone-signing"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# API version of the admin Identity API endpoint"},{"line_number":32,"context_line":"# Workaround for https://bugs.launchpad.net/nova/+bug/1154809"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F8scY%3D","side":"PARENT","line":29,"updated":"2013-12-23 05:57:57.000000000","message":"Previously this value was not set either and was left as the default value. The default behavior of the keystone middleware should be enough.","commit_id":"7d79f458d6935bd7939a7c7d3b15d114e85268f2"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"d2c9adfb13358054378ba0072ee30e1af9671131","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# API version of the admin Identity API endpoint"},{"line_number":32,"context_line":"# Workaround for https://bugs.launchpad.net/nova/+bug/1154809"},{"line_number":33,"context_line":"auth_version \u003d v2.0"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F8scg%3D","side":"PARENT","line":33,"updated":"2013-12-23 05:57:57.000000000","message":"looks like we need to wait for cinderclient\u0027s fix for the bug 1154809 before we can remove this?","commit_id":"7d79f458d6935bd7939a7c7d3b15d114e85268f2"}],"tools/config/oslo.config.generator.rc":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e667d91e8625c42b75203d4d763cff2bde3aa35b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export OSLO_CONFIG_GENERATOR_EXTRA_MODULES\u003dkeystoneclient.middleware.auth_token"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAATn%2F87q0%3D","line":1,"updated":"2013-12-18 16:54:50.000000000","message":"Ceilometer version is here:\n\nhttps://github.com/openstack/ceilometer/blob/master/tools/config/oslo.config.generator.rc\n\nHowever, I don\u0027t see where OSLO_CONFIG_GENERATOR_EXTRA_MODULES is used in the code, should that be \"NOVA_CONFIG_GENERATOR_EXTRA_MODULES\"?","commit_id":"6c8d2cd7120899564bfb27e833c46e10ad0e4d79"}]}