)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2f28aa2098df30ec537232f4c33ba1f587b76d4e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rewrite InstanceAction object test cases using mock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change rewrite InstanceAction object test cases as a groundwork for"},{"line_number":10,"context_line":"other InstanceAction changes to come."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a part of: blueprint make-instance-action-use-objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FsKQ%3D","line":9,"updated":"2014-01-09 15:33:34.000000000","message":"s/rewrite/rewrites the/","commit_id":"dc91920886c3aa9527ce7d889688b6128a73bacf"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"1a50eb652db0c9dc409d2d104f8419a78736decf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rewrite InstanceAction object test cases using mock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change rewrite InstanceAction object test cases as a groundwork for"},{"line_number":10,"context_line":"other InstanceAction changes to come."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is a part of: blueprint make-instance-action-use-objects"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FqH0%3D","line":9,"in_reply_to":"AAAAUH%2F%2FsKQ%3D","updated":"2014-01-10 03:00:41.000000000","message":"Done","commit_id":"dc91920886c3aa9527ce7d889688b6128a73bacf"}],"nova/tests/objects/test_instance_action.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2f28aa2098df30ec537232f4c33ba1f587b76d4e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.tests.objects import test_objects"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOW \u003d timeutils.utcnow().replace(microsecond\u003d0)"},{"line_number":26,"context_line":"fake_action \u003d {"},{"line_number":27,"context_line":"    \u0027created_at\u0027: NOW,"},{"line_number":28,"context_line":"    \u0027deleted_at\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FsME%3D","line":25,"updated":"2014-01-09 15:33:34.000000000","message":"Is this related to the change?","commit_id":"dc91920886c3aa9527ce7d889688b6128a73bacf"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"1a50eb652db0c9dc409d2d104f8419a78736decf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.tests.objects import test_objects"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOW \u003d timeutils.utcnow().replace(microsecond\u003d0)"},{"line_number":26,"context_line":"fake_action \u003d {"},{"line_number":27,"context_line":"    \u0027created_at\u0027: NOW,"},{"line_number":28,"context_line":"    \u0027deleted_at\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FqHM%3D","line":25,"in_reply_to":"AAAAUH%2F%2FsME%3D","updated":"2014-01-10 03:00:41.000000000","message":"Yes, otherwise it would fail several cases with a mismatch error of\n\nMismatchError: !\u003d:\nreference \u003d datetime.datetime(2014, 1, 10, 1, 8, 37, 962559)\nactual    \u003d datetime.datetime(2014, 1, 10, 1, 8, 37)","commit_id":"dc91920886c3aa9527ce7d889688b6128a73bacf"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2f28aa2098df30ec537232f4c33ba1f587b76d4e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        with contextlib.nested("},{"line_number":129,"context_line":"            mock.patch.object(db, \u0027action_start\u0027, return_value\u003dfake_action),"},{"line_number":130,"context_line":"            mock.patch.object(db, \u0027action_finish\u0027, return_value\u003dfake_action)"},{"line_number":131,"context_line":"        ) as (mock_start, mock_finish):"},{"line_number":132,"context_line":"            action \u003d instance_action.InstanceAction.action_start("},{"line_number":133,"context_line":"                self.context, \u0027fake-uuid\u0027, \u0027fake-action\u0027)"},{"line_number":134,"context_line":"            action.finish(self.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FsKg%3D","line":131,"updated":"2014-01-09 15:33:34.000000000","message":"Can you use the decorator approach to avoid this nested context? It will reduce the indent level on a lot of things and be easier to read.\n\nAll the changed methods in this file would benefit from this change, but especially this one.","commit_id":"dc91920886c3aa9527ce7d889688b6128a73bacf"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"1a50eb652db0c9dc409d2d104f8419a78736decf","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        with contextlib.nested("},{"line_number":129,"context_line":"            mock.patch.object(db, \u0027action_start\u0027, return_value\u003dfake_action),"},{"line_number":130,"context_line":"            mock.patch.object(db, \u0027action_finish\u0027, return_value\u003dfake_action)"},{"line_number":131,"context_line":"        ) as (mock_start, mock_finish):"},{"line_number":132,"context_line":"            action \u003d instance_action.InstanceAction.action_start("},{"line_number":133,"context_line":"                self.context, \u0027fake-uuid\u0027, \u0027fake-action\u0027)"},{"line_number":134,"context_line":"            action.finish(self.context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FqCo%3D","line":131,"in_reply_to":"AAAAUH%2F%2FsKg%3D","updated":"2014-01-10 03:00:41.000000000","message":"Done. Rewrited the testcases to use decorator apprach for all changes in this file. Also updated dependent changes to use decorator approach.","commit_id":"dc91920886c3aa9527ce7d889688b6128a73bacf"}]}
