)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"574b4f4e47054f4680cdca9455516868a02b18a4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-18 14:25:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Some clean in manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F9b4%3D","line":7,"updated":"2013-12-26 09:29:37.000000000","message":"\"Some clean in compute/manage.py\" might be more accurate","commit_id":"07b41b4c95735c3046288ae569cc313a2fcd19c5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"81e6ed5f8908cbc8a66bcfe2a584ec3a7fea64e0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-18 14:25:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Some clean in manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F6f8%3D","line":7,"in_reply_to":"AAAAT3%2F%2F9b4%3D","updated":"2013-12-27 08:46:26.000000000","message":"Done","commit_id":"07b41b4c95735c3046288ae569cc313a2fcd19c5"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"3db004c951cdec824152b44a4c21fbfc2085abbb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F6Zc%3D","line":11,"updated":"2013-12-27 09:38:51.000000000","message":"Just curious, why do we need this change? Thanks.","commit_id":"3c2ccbb7e30c535b40148ecc686e2113d75b7277"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"610258ef8a5f01c34ec56158228b88087d30d2f5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F6XU%3D","line":11,"in_reply_to":"AAAAT3%2F%2F6YM%3D","updated":"2013-12-27 09:58:33.000000000","message":"I have no problem with your change. Let us wait some comments from Gary. ;-)","commit_id":"3c2ccbb7e30c535b40148ecc686e2113d75b7277"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5e6182d020db6848f2baf342bdba817313071cd8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F6YM%3D","line":11,"in_reply_to":"AAAAT3%2F%2F6ZE%3D","updated":"2013-12-27 09:50:24.000000000","message":"@Jay, according the comment of @garyk in https://review.openstack.org/#/c/61462/8/nova/compute/api.py\n\nYou are right,  but we have to began from something and because I\u0027m working on  manage.py I was thinking is good to do that. \n\nwhat do you think?","commit_id":"3c2ccbb7e30c535b40148ecc686e2113d75b7277"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"0b4c20c7f3ee4a2af7c067453a96b1319ac82779","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F6ZE%3D","line":11,"in_reply_to":"AAAAT3%2F%2F6Zc%3D","updated":"2013-12-27 09:42:09.000000000","message":"Notice the comments on  https://review.openstack.org/61462\n\nYou said we want to make the code clean, but I noticed that i nova, there are tons of places using LOG.warn()","commit_id":"3c2ccbb7e30c535b40148ecc686e2113d75b7277"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"f19b997815f1d3ede6563fbf7718055a0c0b2b0e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Some clean in compute/manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2F4Zk%3D","line":10,"updated":"2014-01-07 09:34:14.000000000","message":"Not sure about this - looking at the code change, do you mean to s/prototype/signature/ ?","commit_id":"1aca8c51edf13145d5452ab7d6f3f18f2bdd781b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3a71a2cb1dc47c5f0e9bc19930b830e661f78539","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Some clean in compute/manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2F4N0%3D","line":10,"in_reply_to":"AAAAUH%2F%2F4SU%3D","updated":"2014-01-07 10:11:35.000000000","message":"Ok thanks for that response. I can update the commit message it\u0027s trivial for jenkins.","commit_id":"1aca8c51edf13145d5452ab7d6f3f18f2bdd781b"},{"author":{"_account_id":9420,"name":"Matthew Gilliard","email":"matthew.gilliard@hp.com","username":"gilliard"},"change_message_id":"aec0f50ef25e29a55427591b4da181326cc0a8f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Some clean in compute/manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2F4SU%3D","line":10,"in_reply_to":"AAAAUH%2F%2F4U4%3D","updated":"2014-01-07 10:05:19.000000000","message":"Method \"prototype\" is used in C for forward declaration, and does not specify the body of the method - I don\u0027t think it\u0027s used at all in Python.  So I found this commit message a bit confusing - only a nit really.\n\nhttp://en.wikipedia.org/wiki/Function_prototype","commit_id":"1aca8c51edf13145d5452ab7d6f3f18f2bdd781b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"79cb0c7a01025a7e1278f76d408f468e51bfbbf8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Some clean in compute/manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message"},{"line_number":10,"context_line":" * About the prototype of the method notify"},{"line_number":11,"context_line":" * About using LOG.warning instead of LOG.warn"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3d58c9b6c53e77408ed846d76d68d9aa38528892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAUH%2F%2F4U4%3D","line":10,"in_reply_to":"AAAAUH%2F%2F4Zk%3D","updated":"2014-01-07 09:45:05.000000000","message":"What\u0027s the difference?","commit_id":"1aca8c51edf13145d5452ab7d6f3f18f2bdd781b"},{"author":{"_account_id":9046,"name":"Maithem","email":"munshedm@vmware.com","username":"Maithem"},"change_message_id":"72901a2ea40ae71c10372e5cdd15885c5c2fc132","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-20 16:44:33 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Some clean in compute/manage.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" * About using e.format_message."},{"line_number":10,"context_line":" * About the signature of the method notify."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"AAAAUH%2F%2B6lk%3D","line":7,"updated":"2014-01-20 19:36:06.000000000","message":"Typo: Some cleaning in ....","commit_id":"816c311b1d41ce0e6a45047081d0a28a9c5fccaa"}],"nova/compute/manager.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":903,"context_line":"            volume_status \u003d volume[\u0027status\u0027]"},{"line_number":904,"context_line":"            if volume_status not in [\u0027creating\u0027, \u0027downloading\u0027]:"},{"line_number":905,"context_line":"                if volume_status !\u003d \u0027available\u0027:"},{"line_number":906,"context_line":"                    LOG.warning(_(\"Volume id: %s finished being created but\""},{"line_number":907,"context_line":"                               \"was not set as \u0027available\u0027\"), vol_id)"},{"line_number":908,"context_line":"                # NOTE(harlowja): return how many attempts were tried"},{"line_number":909,"context_line":"                return attempts + 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1vE%3D","line":906,"updated":"2013-12-30 12:03:46.000000000","message":"Lost a blank space here","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"                  instance\u003dinstance)"},{"line_number":1222,"context_line":"        retries \u003d CONF.network_allocate_retries"},{"line_number":1223,"context_line":"        if retries \u003c 0:"},{"line_number":1224,"context_line":"            LOG.warning(_(\"Treating negative config value (%(retries)s) for \""},{"line_number":1225,"context_line":"                       \"\u0027network_allocate_retries\u0027 as 0.\"),"},{"line_number":1226,"context_line":"                     {\u0027retries\u0027: retries})"},{"line_number":1227,"context_line":"        attempts \u003d retries \u003e 1 and retries + 1 or 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1t0%3D","line":1224,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"                                    \u0027after %(attempts)d attempt(s)\u0027),"},{"line_number":1247,"context_line":"                                  log_info)"},{"line_number":1248,"context_line":"                    raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":1249,"context_line":"                LOG.warning(_(\u0027Instance failed network setup \u0027"},{"line_number":1250,"context_line":"                           \u0027(attempt %(attempt)d of %(attempts)d)\u0027),"},{"line_number":1251,"context_line":"                         log_info, instance\u003dinstance)"},{"line_number":1252,"context_line":"                time.sleep(retry_time)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1t4%3D","line":1249,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":1878,"context_line":"                                                     connector)"},{"line_number":1879,"context_line":"                self.volume_api.detach(context, bdm[\u0027volume_id\u0027])"},{"line_number":1880,"context_line":"            except exception.DiskNotFound as exc:"},{"line_number":1881,"context_line":"                LOG.warning(_(\u0027Ignoring DiskNotFound: %s\u0027) % exc,"},{"line_number":1882,"context_line":"                         instance\u003dinstance)"},{"line_number":1883,"context_line":"            except exception.VolumeNotFound as exc:"},{"line_number":1884,"context_line":"                LOG.warning(_(\u0027Ignoring VolumeNotFound: %s\u0027) % exc,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uA%3D","line":1881,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"                LOG.warning(_(\u0027Ignoring DiskNotFound: %s\u0027) % exc,"},{"line_number":1882,"context_line":"                         instance\u003dinstance)"},{"line_number":1883,"context_line":"            except exception.VolumeNotFound as exc:"},{"line_number":1884,"context_line":"                LOG.warning(_(\u0027Ignoring VolumeNotFound: %s\u0027) % exc,"},{"line_number":1885,"context_line":"                         instance\u003dinstance)"},{"line_number":1886,"context_line":""},{"line_number":1887,"context_line":"        if notify:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1t8%3D","line":1884,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":2302,"context_line":"        if instance[\u0027power_state\u0027] !\u003d power_state.RUNNING:"},{"line_number":2303,"context_line":"            state \u003d instance[\u0027power_state\u0027]"},{"line_number":2304,"context_line":"            running \u003d power_state.RUNNING"},{"line_number":2305,"context_line":"            LOG.warning(_(\u0027trying to reboot a non-running instance:\u0027"},{"line_number":2306,"context_line":"                       \u0027 (state: %(state)s expected: %(running)s)\u0027),"},{"line_number":2307,"context_line":"                     {\u0027state\u0027: state, \u0027running\u0027: running},"},{"line_number":2308,"context_line":"                     context\u003dcontext, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uE%3D","line":2305,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":2354,"context_line":"            instance.task_state \u003d None"},{"line_number":2355,"context_line":"            instance.save()"},{"line_number":2356,"context_line":"        except exception.InstanceNotFound:"},{"line_number":2357,"context_line":"            LOG.warning(_(\"Instance disappeared during reboot\"),"},{"line_number":2358,"context_line":"                     context\u003dcontext, instance\u003dinstance)"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"        self._notify_about_instance_usage(context, instance, \"reboot.end\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uI%3D","line":2357,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":2579,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"},{"line_number":2580,"context_line":"        expected_state \u003d power_state.RUNNING"},{"line_number":2581,"context_line":"        if current_power_state !\u003d expected_state:"},{"line_number":2582,"context_line":"            LOG.warning(_(\u0027trying to inject a file into a non-running (state: \u0027"},{"line_number":2583,"context_line":"                       \u0027%(current_state)s expected: %(expected_state)s)\u0027),"},{"line_number":2584,"context_line":"                     {\u0027current_state\u0027: current_power_state,"},{"line_number":2585,"context_line":"                      \u0027expected_state\u0027: expected_state},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uM%3D","line":2582,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":2603,"context_line":"        if not rescue_image_ref:"},{"line_number":2604,"context_line":"            # 2. As a last resort, use instance\u0027s current image"},{"line_number":2605,"context_line":"            LOG.warning(_(\u0027Unable to find a different image to use\u0027"},{"line_number":2606,"context_line":"                       \u0027 for rescue VM, using instance\\\u0027s current image\u0027))"},{"line_number":2607,"context_line":"            rescue_image_ref \u003d instance[\u0027image_ref\u0027]"},{"line_number":2608,"context_line":""},{"line_number":2609,"context_line":"        image_service, image_id \u003d glance.get_remote_image_service("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1u4%3D","line":2606,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align with \u0027Unable\u0027","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":3809,"context_line":"        try:"},{"line_number":3810,"context_line":"            if not self.driver.instance_exists(instance[\u0027name\u0027]):"},{"line_number":3811,"context_line":"                LOG.warning(_(\u0027Detaching volume from unknown instance\u0027),"},{"line_number":3812,"context_line":"                         context\u003dcontext, instance\u003dinstance)"},{"line_number":3813,"context_line":""},{"line_number":3814,"context_line":"            encryption \u003d encryptors.get_encryption_metadata("},{"line_number":3815,"context_line":"                context, self.volume_api, volume_id, connection_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1u0%3D","line":3812,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4488,"context_line":"                     migrations_info)"},{"line_number":4489,"context_line":""},{"line_number":4490,"context_line":"        def _set_migration_to_error(migration, reason, **kwargs):"},{"line_number":4491,"context_line":"            LOG.warning(_(\"Setting migration %(migration_id)s to error: \""},{"line_number":4492,"context_line":"                       \"%(reason)s\"),"},{"line_number":4493,"context_line":"                     {\u0027migration_id\u0027: migration[\u0027id\u0027], \u0027reason\u0027: reason},"},{"line_number":4494,"context_line":"                     **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uw%3D","line":4491,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4760,"context_line":"        num_db_instances \u003d len(db_instances)"},{"line_number":4761,"context_line":""},{"line_number":4762,"context_line":"        if num_vm_instances !\u003d num_db_instances:"},{"line_number":4763,"context_line":"            LOG.warning(_(\"Found %(num_db_instances)s in the database and \""},{"line_number":4764,"context_line":"                       \"%(num_vm_instances)s on the hypervisor.\"),"},{"line_number":4765,"context_line":"                     {\u0027num_db_instances\u0027: num_db_instances,"},{"line_number":4766,"context_line":"                      \u0027num_vm_instances\u0027: num_vm_instances})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1us%3D","line":4763,"updated":"2013-12-30 12:03:46.000000000","message":"Keep align","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4852,"context_line":"            # The only rational power state should be RUNNING"},{"line_number":4853,"context_line":"            if vm_power_state in (power_state.SHUTDOWN,"},{"line_number":4854,"context_line":"                                  power_state.CRASHED):"},{"line_number":4855,"context_line":"                LOG.warning(_(\"Instance shutdown by itself. Calling \""},{"line_number":4856,"context_line":"                           \"the stop API.\"), instance\u003ddb_instance)"},{"line_number":4857,"context_line":"                try:"},{"line_number":4858,"context_line":"                    # Note(maoy): here we call the API instead of"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uo%3D","line":4855,"updated":"2013-12-30 12:03:46.000000000","message":"ditto","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4868,"context_line":"                                    \"sync_power_state.\"),"},{"line_number":4869,"context_line":"                                  instance\u003ddb_instance)"},{"line_number":4870,"context_line":"            elif vm_power_state \u003d\u003d power_state.SUSPENDED:"},{"line_number":4871,"context_line":"                LOG.warning(_(\"Instance is suspended unexpectedly. Calling \""},{"line_number":4872,"context_line":"                           \"the stop API.\"), instance\u003ddb_instance)"},{"line_number":4873,"context_line":"                try:"},{"line_number":4874,"context_line":"                    self.compute_api.stop(context, db_instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uk%3D","line":4871,"updated":"2013-12-30 12:03:46.000000000","message":"ditto","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4884,"context_line":"                # we simply ignore the state discrepancy. In many cases,"},{"line_number":4885,"context_line":"                # the VM state will go back to running after the external"},{"line_number":4886,"context_line":"                # instrumentation is done. See bug 1097806 for details."},{"line_number":4887,"context_line":"                LOG.warning(_(\"Instance is paused unexpectedly. Ignore.\"),"},{"line_number":4888,"context_line":"                         instance\u003ddb_instance)"},{"line_number":4889,"context_line":"            elif vm_power_state \u003d\u003d power_state.NOSTATE:"},{"line_number":4890,"context_line":"                # Occasionally, depending on the status of the hypervisor,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1ug%3D","line":4887,"updated":"2013-12-30 12:03:46.000000000","message":"ditto","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4890,"context_line":"                # Occasionally, depending on the status of the hypervisor,"},{"line_number":4891,"context_line":"                # which could be restarting for example, an instance may"},{"line_number":4892,"context_line":"                # not be found.  Therefore just log the condition."},{"line_number":4893,"context_line":"                LOG.warning(_(\"Instance is unexpectedly not found. Ignore.\"),"},{"line_number":4894,"context_line":"                         instance\u003ddb_instance)"},{"line_number":4895,"context_line":"        elif vm_state \u003d\u003d vm_states.STOPPED:"},{"line_number":4896,"context_line":"            if vm_power_state not in (power_state.NOSTATE,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uc%3D","line":4893,"updated":"2013-12-30 12:03:46.000000000","message":"ditto","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":4896,"context_line":"            if vm_power_state not in (power_state.NOSTATE,"},{"line_number":4897,"context_line":"                                      power_state.SHUTDOWN,"},{"line_number":4898,"context_line":"                                      power_state.CRASHED):"},{"line_number":4899,"context_line":"                LOG.warning(_(\"Instance is not stopped. Calling \""},{"line_number":4900,"context_line":"                           \"the stop API.\"), instance\u003ddb_instance)"},{"line_number":4901,"context_line":"                try:"},{"line_number":4902,"context_line":"                    # NOTE(russellb) Force the stop, because normally the"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uY%3D","line":4899,"updated":"2013-12-30 12:03:46.000000000","message":"ditto","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6839283943b3b416995c084d0b6f48dd187cfd66","unresolved":false,"context_lines":[{"line_number":5034,"context_line":"                            # disable starting the instance"},{"line_number":5035,"context_line":"                            self.driver.set_bootable(instance, False)"},{"line_number":5036,"context_line":"                        except NotImplementedError:"},{"line_number":5037,"context_line":"                            LOG.warning(_(\"set_bootable is not implemented\""},{"line_number":5038,"context_line":"                                       \" for the current driver\"))"},{"line_number":5039,"context_line":"                        # and power it off"},{"line_number":5040,"context_line":"                        self.driver.power_off(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAT3%2F%2F1uQ%3D","line":5037,"updated":"2013-12-30 12:03:46.000000000","message":"ditto","commit_id":"167965136446a3bbe3ea30decb3bf041b9fa42a4"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"a3f44136f044c29c3d481c4f49e8ba4c8cb4501f","unresolved":false,"context_lines":[{"line_number":4489,"context_line":""},{"line_number":4490,"context_line":"        def _set_migration_to_error(migration, reason, **kwargs):"},{"line_number":4491,"context_line":"            LOG.warning(_(\"Setting migration %(migration_id)s to error: \""},{"line_number":4492,"context_line":"                       \"%(reason)s\"),"},{"line_number":4493,"context_line":"                     {\u0027migration_id\u0027: migration[\u0027id\u0027], \u0027reason\u0027: reason},"},{"line_number":4494,"context_line":"                     **kwargs)"},{"line_number":4495,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F1Ds%3D","line":4492,"updated":"2013-12-30 15:37:28.000000000","message":"Keep align","commit_id":"a0d0cff03e390e5086f7a024b6b3effc1e93c5b7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d92fd39dbbfc2eead21b8c16d3e6d0f90dbd6b9c","unresolved":false,"context_lines":[{"line_number":4489,"context_line":""},{"line_number":4490,"context_line":"        def _set_migration_to_error(migration, reason, **kwargs):"},{"line_number":4491,"context_line":"            LOG.warning(_(\"Setting migration %(migration_id)s to error: \""},{"line_number":4492,"context_line":"                       \"%(reason)s\"),"},{"line_number":4493,"context_line":"                     {\u0027migration_id\u0027: migration[\u0027id\u0027], \u0027reason\u0027: reason},"},{"line_number":4494,"context_line":"                     **kwargs)"},{"line_number":4495,"context_line":"            migration.status \u003d \u0027error\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAT3%2F%2F1Cw%3D","line":4492,"in_reply_to":"AAAAT3%2F%2F1Ds%3D","updated":"2013-12-30 15:39:27.000000000","message":"Done","commit_id":"a0d0cff03e390e5086f7a024b6b3effc1e93c5b7"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"353e6e9cfa03ee7626f10ad9024c3d21698a1dd9","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            \"\"\"Send a create.{start,error,end} notification.\"\"\""},{"line_number":942,"context_line":"            type_ \u003d \"create.%(status)s\" % dict(status\u003dstatus)"},{"line_number":943,"context_line":"            info \u003d extra_usage_info.copy()"},{"line_number":944,"context_line":"            if not msg:"},{"line_number":945,"context_line":"                msg \u003d \"\""},{"line_number":946,"context_line":"            info[\u0027message\u0027] \u003d unicode(msg)"},{"line_number":947,"context_line":"            self._notify_about_instance_usage(context, instance, type_,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Fw6A%3D","side":"PARENT","line":944,"updated":"2014-01-08 18:36:54.000000000","message":"What if people pass in None as msg? I guess they don\u0027t else some unit tests would have failed, but just curious.","commit_id":"beca18af16ab02784c5ecc27ea269e5e7b83d2e6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0b0089c6a6c0d93a52146ef35822bd47268864a6","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            \"\"\"Send a create.{start,error,end} notification.\"\"\""},{"line_number":942,"context_line":"            type_ \u003d \"create.%(status)s\" % dict(status\u003dstatus)"},{"line_number":943,"context_line":"            info \u003d extra_usage_info.copy()"},{"line_number":944,"context_line":"            if not msg:"},{"line_number":945,"context_line":"                msg \u003d \"\""},{"line_number":946,"context_line":"            info[\u0027message\u0027] \u003d unicode(msg)"},{"line_number":947,"context_line":"            self._notify_about_instance_usage(context, instance, type_,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Fw2c%3D","side":"PARENT","line":944,"in_reply_to":"AAAAUH%2F%2Fw6A%3D","updated":"2014-01-08 18:49:16.000000000","message":"Interesting point, to be honest I have not thought about it.","commit_id":"beca18af16ab02784c5ecc27ea269e5e7b83d2e6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0b0089c6a6c0d93a52146ef35822bd47268864a6","unresolved":false,"context_lines":[{"line_number":943,"context_line":"            info \u003d extra_usage_info.copy()"},{"line_number":944,"context_line":"            if not msg:"},{"line_number":945,"context_line":"                msg \u003d \"\""},{"line_number":946,"context_line":"            info[\u0027message\u0027] \u003d unicode(msg)"},{"line_number":947,"context_line":"            self._notify_about_instance_usage(context, instance, type_,"},{"line_number":948,"context_line":"                    extra_usage_info\u003dinfo, **kwargs)"},{"line_number":949,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2Fw2E%3D","side":"PARENT","line":946,"updated":"2014-01-08 18:49:16.000000000","message":"The message will be converted in: u\u0027None\u0027, It\u0027s probably not what we are expecting.","commit_id":"beca18af16ab02784c5ecc27ea269e5e7b83d2e6"},{"author":{"_account_id":4573,"name":"yunhong-jiang","email":"yunhong.jiang@intel.com","username":"yunhong-jiang"},"change_message_id":"29b3529eb2cd117da88ab660d3f525dc4c640ede","unresolved":false,"context_lines":[{"line_number":5085,"context_line":"                            self.driver.set_bootable(instance, False)"},{"line_number":5086,"context_line":"                        except NotImplementedError:"},{"line_number":5087,"context_line":"                            LOG.warning(_(\"set_bootable is not implemented\""},{"line_number":5088,"context_line":"                                          \" for the current driver\"))"},{"line_number":5089,"context_line":"                        # and power it off"},{"line_number":5090,"context_line":"                        self.driver.power_off(instance)"},{"line_number":5091,"context_line":"                    except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FazU%3D","line":5088,"updated":"2014-01-13 22:53:47.000000000","message":"Would it be better to place  the white space at end, instead of begin?","commit_id":"04c190e74b7457cabfd8805fa5735dc81208f985"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"29b850d91866221573209adb4e87de863370b4a1","unresolved":false,"context_lines":[{"line_number":5085,"context_line":"                            self.driver.set_bootable(instance, False)"},{"line_number":5086,"context_line":"                        except NotImplementedError:"},{"line_number":5087,"context_line":"                            LOG.warning(_(\"set_bootable is not implemented\""},{"line_number":5088,"context_line":"                                          \" for the current driver\"))"},{"line_number":5089,"context_line":"                        # and power it off"},{"line_number":5090,"context_line":"                        self.driver.power_off(instance)"},{"line_number":5091,"context_line":"                    except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FZbA%3D","line":5088,"in_reply_to":"AAAAUH%2F%2FazU%3D","updated":"2014-01-14 07:22:09.000000000","message":"Probably better yes, i\u0027m working on a new patchset. thanks.","commit_id":"04c190e74b7457cabfd8805fa5735dc81208f985"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"454e1094b21a441d1c65de45ba576acc282cf5ee","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"                  instance\u003dinstance)"},{"line_number":1223,"context_line":"        retries \u003d CONF.network_allocate_retries"},{"line_number":1224,"context_line":"        if retries \u003c 0:"},{"line_number":1225,"context_line":"            LOG.warning(_(\"Treating negative config value (%(retries)s) for \""},{"line_number":1226,"context_line":"                          \"\u0027network_allocate_retries\u0027 as 0.\"),"},{"line_number":1227,"context_line":"                        {\u0027retries\u0027: retries})"},{"line_number":1228,"context_line":"        attempts \u003d retries \u003e 1 and retries + 1 or 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8ZM%3D","line":1225,"updated":"2014-01-20 15:05:12.000000000","message":"for one parameter you do not need to pass a dict","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"54b7a2221209ab717e242f41bbd9390fae0389e9","unresolved":false,"context_lines":[{"line_number":1222,"context_line":"                  instance\u003dinstance)"},{"line_number":1223,"context_line":"        retries \u003d CONF.network_allocate_retries"},{"line_number":1224,"context_line":"        if retries \u003c 0:"},{"line_number":1225,"context_line":"            LOG.warning(_(\"Treating negative config value (%(retries)s) for \""},{"line_number":1226,"context_line":"                          \"\u0027network_allocate_retries\u0027 as 0.\"),"},{"line_number":1227,"context_line":"                        {\u0027retries\u0027: retries})"},{"line_number":1228,"context_line":"        attempts \u003d retries \u003e 1 and retries + 1 or 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8Tw%3D","line":1225,"in_reply_to":"AAAAUH%2F%2B8ZM%3D","updated":"2014-01-20 15:40:30.000000000","message":"Done","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"454e1094b21a441d1c65de45ba576acc282cf5ee","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"                                                     connector)"},{"line_number":1907,"context_line":"                self.volume_api.detach(context, bdm[\u0027volume_id\u0027])"},{"line_number":1908,"context_line":"            except exception.DiskNotFound as exc:"},{"line_number":1909,"context_line":"                LOG.warning(_(\u0027Ignoring DiskNotFound: %s\u0027) % exc,"},{"line_number":1910,"context_line":"                            instance\u003dinstance)"},{"line_number":1911,"context_line":"            except exception.VolumeNotFound as exc:"},{"line_number":1912,"context_line":"                LOG.warning(_(\u0027Ignoring VolumeNotFound: %s\u0027) % exc,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8ZA%3D","line":1909,"updated":"2014-01-20 15:05:12.000000000","message":"can you please use a , instead of the %","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"54b7a2221209ab717e242f41bbd9390fae0389e9","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"                                                     connector)"},{"line_number":1907,"context_line":"                self.volume_api.detach(context, bdm[\u0027volume_id\u0027])"},{"line_number":1908,"context_line":"            except exception.DiskNotFound as exc:"},{"line_number":1909,"context_line":"                LOG.warning(_(\u0027Ignoring DiskNotFound: %s\u0027) % exc,"},{"line_number":1910,"context_line":"                            instance\u003dinstance)"},{"line_number":1911,"context_line":"            except exception.VolumeNotFound as exc:"},{"line_number":1912,"context_line":"                LOG.warning(_(\u0027Ignoring VolumeNotFound: %s\u0027) % exc,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8TI%3D","line":1909,"in_reply_to":"AAAAUH%2F%2B8ZA%3D","updated":"2014-01-20 15:40:30.000000000","message":"Done","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"454e1094b21a441d1c65de45ba576acc282cf5ee","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"                LOG.warning(_(\u0027Ignoring DiskNotFound: %s\u0027) % exc,"},{"line_number":1910,"context_line":"                            instance\u003dinstance)"},{"line_number":1911,"context_line":"            except exception.VolumeNotFound as exc:"},{"line_number":1912,"context_line":"                LOG.warning(_(\u0027Ignoring VolumeNotFound: %s\u0027) % exc,"},{"line_number":1913,"context_line":"                            instance\u003dinstance)"},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"        if notify:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8Y4%3D","line":1912,"updated":"2014-01-20 15:05:12.000000000","message":"ditto","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"54b7a2221209ab717e242f41bbd9390fae0389e9","unresolved":false,"context_lines":[{"line_number":1909,"context_line":"                LOG.warning(_(\u0027Ignoring DiskNotFound: %s\u0027) % exc,"},{"line_number":1910,"context_line":"                            instance\u003dinstance)"},{"line_number":1911,"context_line":"            except exception.VolumeNotFound as exc:"},{"line_number":1912,"context_line":"                LOG.warning(_(\u0027Ignoring VolumeNotFound: %s\u0027) % exc,"},{"line_number":1913,"context_line":"                            instance\u003dinstance)"},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"        if notify:"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8TE%3D","line":1912,"in_reply_to":"AAAAUH%2F%2B8Y4%3D","updated":"2014-01-20 15:40:30.000000000","message":"Done","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"454e1094b21a441d1c65de45ba576acc282cf5ee","unresolved":false,"context_lines":[{"line_number":1973,"context_line":"                self._cleanup_volumes(context, instance_uuid, bdms)"},{"line_number":1974,"context_line":"            except Exception as exc:"},{"line_number":1975,"context_line":"                err_str \u003d _(\"Ignoring volume cleanup failure due to %s\")"},{"line_number":1976,"context_line":"                LOG.warning(err_str % exc, instance\u003dinstance)"},{"line_number":1977,"context_line":"            # if a delete task succeed, always update vm state and task"},{"line_number":1978,"context_line":"            # state without expecting task state to be DELETING"},{"line_number":1979,"context_line":"            instance.vm_state \u003d vm_states.DELETED"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8Ys%3D","line":1976,"updated":"2014-01-20 15:05:12.000000000","message":"ditto","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"54b7a2221209ab717e242f41bbd9390fae0389e9","unresolved":false,"context_lines":[{"line_number":1973,"context_line":"                self._cleanup_volumes(context, instance_uuid, bdms)"},{"line_number":1974,"context_line":"            except Exception as exc:"},{"line_number":1975,"context_line":"                err_str \u003d _(\"Ignoring volume cleanup failure due to %s\")"},{"line_number":1976,"context_line":"                LOG.warning(err_str % exc, instance\u003dinstance)"},{"line_number":1977,"context_line":"            # if a delete task succeed, always update vm state and task"},{"line_number":1978,"context_line":"            # state without expecting task state to be DELETING"},{"line_number":1979,"context_line":"            instance.vm_state \u003d vm_states.DELETED"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8S4%3D","line":1976,"in_reply_to":"AAAAUH%2F%2B8Ys%3D","updated":"2014-01-20 15:40:30.000000000","message":"Done","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"454e1094b21a441d1c65de45ba576acc282cf5ee","unresolved":false,"context_lines":[{"line_number":5107,"context_line":"                                      \"instance: %s\"),"},{"line_number":5108,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":5109,"context_line":"                else:"},{"line_number":5110,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027 \""},{"line_number":5111,"context_line":"                                      \"for CONF.running_deleted_ \""},{"line_number":5112,"context_line":"                                      \"instance_action\"), action,"},{"line_number":5113,"context_line":"                                    instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8Yk%3D","line":5110,"updated":"2014-01-20 15:05:12.000000000","message":"should this not be % instead of the ,\n\ni looks like it is the format of a LOG message and not an exception","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"54b7a2221209ab717e242f41bbd9390fae0389e9","unresolved":false,"context_lines":[{"line_number":5107,"context_line":"                                      \"instance: %s\"),"},{"line_number":5108,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":5109,"context_line":"                else:"},{"line_number":5110,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027 \""},{"line_number":5111,"context_line":"                                      \"for CONF.running_deleted_ \""},{"line_number":5112,"context_line":"                                      \"instance_action\"), action,"},{"line_number":5113,"context_line":"                                    instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F%2B8SI%3D","line":5110,"in_reply_to":"AAAAUH%2F%2B8Yk%3D","updated":"2014-01-20 15:40:30.000000000","message":"good catch!","commit_id":"172c52f0382881cc2e4d320cbcf3ca984a631107"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"a47c1f26cfffdc4340c6da091d11730434341204","unresolved":false,"context_lines":[{"line_number":5107,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":5108,"context_line":"                else:"},{"line_number":5109,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027 \""},{"line_number":5110,"context_line":"                                      \"for CONF.running_deleted_ \""},{"line_number":5111,"context_line":"                                      \"instance_action\") % action)"},{"line_number":5112,"context_line":""},{"line_number":5113,"context_line":"    def _running_deleted_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B8Go%3D","line":5110,"updated":"2014-01-20 15:42:35.000000000","message":"I made a wrong space at the end of the line there...","commit_id":"33585256e119e0cd24ef37f7313a161df3d14ac8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"78b78539628d37f0c041893488af39580f694326","unresolved":false,"context_lines":[{"line_number":5107,"context_line":"                                    unicode(e), instance\u003dinstance)"},{"line_number":5108,"context_line":"                else:"},{"line_number":5109,"context_line":"                    raise Exception(_(\"Unrecognized value \u0027%s\u0027 \""},{"line_number":5110,"context_line":"                                      \"for CONF.running_deleted_ \""},{"line_number":5111,"context_line":"                                      \"instance_action\") % action)"},{"line_number":5112,"context_line":""},{"line_number":5113,"context_line":"    def _running_deleted_instances(self, context):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B8FA%3D","line":5110,"in_reply_to":"AAAAUH%2F%2B8Go%3D","updated":"2014-01-20 15:44:29.000000000","message":"ok","commit_id":"33585256e119e0cd24ef37f7313a161df3d14ac8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":94,"context_line":"               help\u003d\u0027Name of network to use to set access IPs for instances\u0027),"},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027defer_iptables_apply\u0027,"},{"line_number":96,"context_line":"                default\u003dFalse,"},{"line_number":97,"context_line":"                help\u003d\u0027Whether to batch up the application of IPTables rules \u0027"},{"line_number":98,"context_line":"                     \u0027during a host restart and apply all at the end of the \u0027"},{"line_number":99,"context_line":"                     \u0027init phase\u0027),"},{"line_number":100,"context_line":"    cfg.StrOpt(\u0027instances_path\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2Fbk8%3D","line":97,"updated":"2014-02-13 09:11:13.000000000","message":"not really sure why we need this change","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":922,"context_line":"            volume_status \u003d volume[\u0027status\u0027]"},{"line_number":923,"context_line":"            if volume_status not in [\u0027creating\u0027, \u0027downloading\u0027]:"},{"line_number":924,"context_line":"                if volume_status !\u003d \u0027available\u0027:"},{"line_number":925,"context_line":"                    LOG.warning(_(\"Volume id: %s finished being created but \""},{"line_number":926,"context_line":"                                  \"was not set as \u0027available\u0027\"), vol_id)"},{"line_number":927,"context_line":"                # NOTE(harlowja): return how many attempts were tried"},{"line_number":928,"context_line":"                return attempts + 1"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FbjQ%3D","line":925,"updated":"2014-02-13 09:11:13.000000000","message":"maybe you can do all of the warn \u003d\u003e warning in a separate patch set","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":979,"context_line":""},{"line_number":980,"context_line":"        except exception.RescheduledException as e:"},{"line_number":981,"context_line":"            # Instance build encountered an error, and has been rescheduled."},{"line_number":982,"context_line":"            notify(\"error\", msg\u003de)  # notify that build failed"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"        except exception.BuildAbortException as e:"},{"line_number":985,"context_line":"            # Instance build aborted due to a non-failure"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FbkA%3D","line":982,"updated":"2014-02-13 09:11:13.000000000","message":"i think that you should use e.format_message()","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":984,"context_line":"        except exception.BuildAbortException as e:"},{"line_number":985,"context_line":"            # Instance build aborted due to a non-failure"},{"line_number":986,"context_line":"            LOG.info(e)"},{"line_number":987,"context_line":"            notify(\"end\", msg\u003de)  # notify that build is done"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"        except Exception as e:"},{"line_number":990,"context_line":"            # Instance build encountered a non-recoverable error:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2Fbj8%3D","line":987,"updated":"2014-02-13 09:11:13.000000000","message":"ditto","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            # Instance build encountered a non-recoverable error:"},{"line_number":991,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":992,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":993,"context_line":"                notify(\"error\", msg\u003de)  # notify that build failed"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    def _prebuild_instance(self, context, instance):"},{"line_number":996,"context_line":"        self._check_instance_exists(context, instance)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2Fbj0%3D","line":993,"updated":"2014-02-13 09:11:13.000000000","message":"ditto","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":1814,"context_line":"                            block_device_mapping)"},{"line_number":1815,"context_line":"                except Exception:"},{"line_number":1816,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":1817,"context_line":"                    msg \u003d _(\u0027Could not clean up failed build, \u0027"},{"line_number":1818,"context_line":"                            \u0027not rescheduling\u0027)"},{"line_number":1819,"context_line":"                    raise exception.BuildAbortException("},{"line_number":1820,"context_line":"                            instance_uuid\u003dinstance.uuid, reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FbjA%3D","line":1817,"updated":"2014-02-13 09:11:13.000000000","message":"not sure why we need this change","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":1837,"context_line":"                    block_device_mapping)"},{"line_number":1838,"context_line":"        except Exception:"},{"line_number":1839,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1840,"context_line":"                msg \u003d _(\u0027Failed to cleanup volumes for failed build, \u0027"},{"line_number":1841,"context_line":"                        \u0027not rescheduling\u0027)"},{"line_number":1842,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":1843,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2Fbi8%3D","line":1840,"updated":"2014-02-13 09:11:13.000000000","message":"ditto","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"                # shared storage, but not accessible and vice versa"},{"line_number":2224,"context_line":"                if on_shared_storage !\u003d self.driver.instance_on_disk(instance):"},{"line_number":2225,"context_line":"                    raise exception.InvalidSharedStorage("},{"line_number":2226,"context_line":"                            _(\"Invalid state of instance files on shared \""},{"line_number":2227,"context_line":"                              \"storage\"))"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"                if on_shared_storage:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FbiY%3D","line":2226,"updated":"2014-02-13 09:11:13.000000000","message":"not sure why we need this change","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":2227,"context_line":"                              \"storage\"))"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"                if on_shared_storage:"},{"line_number":2230,"context_line":"                    LOG.info(_(\u0027disk on shared storage, recreating using \u0027"},{"line_number":2231,"context_line":"                               \u0027existing disk\u0027))"},{"line_number":2232,"context_line":"                else:"},{"line_number":2233,"context_line":"                    image_ref \u003d orig_image_ref \u003d instance.image_ref"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FbiQ%3D","line":2230,"updated":"2014-02-13 09:11:13.000000000","message":"ditto","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1a8bfbd09615921ad7dd6f20f8f21b7611a30042","unresolved":false,"context_lines":[{"line_number":2231,"context_line":"                               \u0027existing disk\u0027))"},{"line_number":2232,"context_line":"                else:"},{"line_number":2233,"context_line":"                    image_ref \u003d orig_image_ref \u003d instance.image_ref"},{"line_number":2234,"context_line":"                    LOG.info(_(\"disk not on shared storagerebuilding from: \""},{"line_number":2235,"context_line":"                               \"\u0027%s\u0027\") % str(image_ref))"},{"line_number":2236,"context_line":""},{"line_number":2237,"context_line":"                # NOTE(mriedem): On a recreate (evacuate), we need to update"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FbiM%3D","line":2234,"updated":"2014-02-13 09:11:13.000000000","message":"ditto","commit_id":"32cbd96896432dbb0b30d55990f117d479ecdd67"}]}