)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be4c1272f92ca6fd88ff03800577a3df07d142a1","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            instance_type)"},{"line_number":812,"context_line":"        result \u003d self.network_api.create_resource_requests("},{"line_number":813,"context_line":"            context, requested_networks, pci_request_info)"},{"line_number":814,"context_line":"        network_metadata, port_resource_requests \u003d result"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        base_options \u003d {"},{"line_number":817,"context_line":"            \u0027reservation_id\u0027: reservation_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_d7f7c2d2","line":814,"range":{"start_line":814,"start_character":26,"end_line":814,"end_character":48},"updated":"2019-01-28 15:16:16.000000000","message":"OK so as of this change, this variable is unused. It gets used later here:\n\nhttps://review.openstack.org/#/c/567268/46/nova/compute/api.py","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c905331ab2cf5c3e7ed76e0a1275498061d0b2ab","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            instance_type)"},{"line_number":812,"context_line":"        result \u003d self.network_api.create_resource_requests("},{"line_number":813,"context_line":"            context, requested_networks, pci_request_info)"},{"line_number":814,"context_line":"        network_metadata, port_resource_requests \u003d result"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":"        base_options \u003d {"},{"line_number":817,"context_line":"            \u0027reservation_id\u0027: reservation_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_fe609103","line":814,"range":{"start_line":814,"start_character":26,"end_line":814,"end_character":48},"in_reply_to":"9fdfeff1_d7f7c2d2","updated":"2019-01-29 16:20:07.000000000","message":"Yes it is unused in this patch but will be used later. Originally the patch that used this variable was right after this patch that introduced it. But the necessary reject patches made this connection a lot more stretched.","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be4c1272f92ca6fd88ff03800577a3df07d142a1","unresolved":false,"context_lines":[{"line_number":1892,"context_line":""},{"line_number":1893,"context_line":"        # NOTE(gibi): Get the port resource_request which may or may not be"},{"line_number":1894,"context_line":"        # set depending on neutron configuration, e.g. if QoS rules are"},{"line_number":1895,"context_line":"        # applied to the port/network and the resource_request API extension is"},{"line_number":1896,"context_line":"        # enabled."},{"line_number":1897,"context_line":"        resource_request \u003d port.get(\u0027resource_request\u0027, None)"},{"line_number":1898,"context_line":"        return vnic_type, trusted, network_id, resource_request"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_77c37639","line":1895,"range":{"start_line":1895,"start_character":46,"end_line":1895,"end_character":62},"updated":"2019-01-28 15:16:16.000000000","message":"nit: \"port-resource-request\"\n\nhttps://review.openstack.org/#/c/584903/10/neutron_lib/api/definitions/base.py@110","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c905331ab2cf5c3e7ed76e0a1275498061d0b2ab","unresolved":false,"context_lines":[{"line_number":1892,"context_line":""},{"line_number":1893,"context_line":"        # NOTE(gibi): Get the port resource_request which may or may not be"},{"line_number":1894,"context_line":"        # set depending on neutron configuration, e.g. if QoS rules are"},{"line_number":1895,"context_line":"        # applied to the port/network and the resource_request API extension is"},{"line_number":1896,"context_line":"        # enabled."},{"line_number":1897,"context_line":"        resource_request \u003d port.get(\u0027resource_request\u0027, None)"},{"line_number":1898,"context_line":"        return vnic_type, trusted, network_id, resource_request"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_a1050e13","line":1895,"range":{"start_line":1895,"start_character":46,"end_line":1895,"end_character":62},"in_reply_to":"9fdfeff1_77c37639","updated":"2019-01-29 16:20:07.000000000","message":"Done in a fup.","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be4c1272f92ca6fd88ff03800577a3df07d142a1","unresolved":false,"context_lines":[{"line_number":1938,"context_line":"                    context, neutron, network_id)"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"                if resource_request:"},{"line_number":1941,"context_line":"                    # NOTE(gibi): explicitly orphan the RequestGroup as we"},{"line_number":1942,"context_line":"                    # never intended to save it to the DB."},{"line_number":1943,"context_line":"                    resource_requests.append("},{"line_number":1944,"context_line":"                        objects.RequestGroup.from_port_request("},{"line_number":1945,"context_line":"                            context\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_f7e446e2","line":1942,"range":{"start_line":1941,"start_character":20,"end_line":1942,"end_character":58},"updated":"2019-01-28 15:16:16.000000000","message":"nit: this could live closer to the context\u003dNone for context\n\nor\n\nre-word as \"explicitly orphan the RequestGroup by setting context\u003dNone as we never intended to save it to the DB\"","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c905331ab2cf5c3e7ed76e0a1275498061d0b2ab","unresolved":false,"context_lines":[{"line_number":1938,"context_line":"                    context, neutron, network_id)"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"                if resource_request:"},{"line_number":1941,"context_line":"                    # NOTE(gibi): explicitly orphan the RequestGroup as we"},{"line_number":1942,"context_line":"                    # never intended to save it to the DB."},{"line_number":1943,"context_line":"                    resource_requests.append("},{"line_number":1944,"context_line":"                        objects.RequestGroup.from_port_request("},{"line_number":1945,"context_line":"                            context\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_4106a21e","line":1942,"range":{"start_line":1941,"start_character":20,"end_line":1942,"end_character":58},"in_reply_to":"9fdfeff1_f7e446e2","updated":"2019-01-29 16:20:07.000000000","message":"Done in a fup","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1b781d13eed7affe97b93afb3466d8efedf9937d","unresolved":false,"context_lines":[{"line_number":3061,"context_line":"        self._test_get_port_vnic_info(mock_get_client, None,"},{"line_number":3062,"context_line":"                                      model.VNIC_TYPE_NORMAL)"},{"line_number":3063,"context_line":""},{"line_number":3064,"context_line":"    @mock.patch.object(neutronapi, \u0027get_client\u0027, return_value\u003dmock.Mock())"},{"line_number":3065,"context_line":"    def test_get_port_vnic_info_requested_resources(self, mock_get_client):"},{"line_number":3066,"context_line":"        self._test_get_port_vnic_info("},{"line_number":3067,"context_line":"            mock_get_client, None, model.VNIC_TYPE_NORMAL,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_d0c6d668","line":3064,"range":{"start_line":3064,"start_character":47,"end_line":3064,"end_character":73},"updated":"2019-01-29 13:58:17.000000000","message":"note that this is default return value for a mock, so not necessary. I see it\u0027s just copy/paste though, so no worries.","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c905331ab2cf5c3e7ed76e0a1275498061d0b2ab","unresolved":false,"context_lines":[{"line_number":3061,"context_line":"        self._test_get_port_vnic_info(mock_get_client, None,"},{"line_number":3062,"context_line":"                                      model.VNIC_TYPE_NORMAL)"},{"line_number":3063,"context_line":""},{"line_number":3064,"context_line":"    @mock.patch.object(neutronapi, \u0027get_client\u0027, return_value\u003dmock.Mock())"},{"line_number":3065,"context_line":"    def test_get_port_vnic_info_requested_resources(self, mock_get_client):"},{"line_number":3066,"context_line":"        self._test_get_port_vnic_info("},{"line_number":3067,"context_line":"            mock_get_client, None, model.VNIC_TYPE_NORMAL,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_3a593c34","line":3064,"range":{"start_line":3064,"start_character":47,"end_line":3064,"end_character":73},"in_reply_to":"9fdfeff1_d0c6d668","updated":"2019-01-29 16:20:07.000000000","message":"good point, bad copy paste :). Fixed in a fup.","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"be4c1272f92ca6fd88ff03800577a3df07d142a1","unresolved":false,"context_lines":[{"line_number":5216,"context_line":"    @mock.patch.object(neutronapi, \u0027get_client\u0027)"},{"line_number":5217,"context_line":"    def test_create_resource_requests(self, getclient,"},{"line_number":5218,"context_line":"            mock_get_port_vnic_info, mock_get_physnet_tunneled_info,"},{"line_number":5219,"context_line":"            mock_request_spec):"},{"line_number":5220,"context_line":"        requested_networks \u003d objects.NetworkRequestList("},{"line_number":5221,"context_line":"            objects \u003d ["},{"line_number":5222,"context_line":"                objects.NetworkRequest(port_id\u003duuids.portid_1),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_1738ea3a","line":5219,"range":{"start_line":5219,"start_character":12,"end_line":5219,"end_character":29},"updated":"2019-01-28 15:16:16.000000000","message":"nit: rename to mock_request_group or mock_from_port_request\n\nWhen I was first looking at this variable below I wondered what a request spec had to do with this test.","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1b781d13eed7affe97b93afb3466d8efedf9937d","unresolved":false,"context_lines":[{"line_number":5216,"context_line":"    @mock.patch.object(neutronapi, \u0027get_client\u0027)"},{"line_number":5217,"context_line":"    def test_create_resource_requests(self, getclient,"},{"line_number":5218,"context_line":"            mock_get_port_vnic_info, mock_get_physnet_tunneled_info,"},{"line_number":5219,"context_line":"            mock_request_spec):"},{"line_number":5220,"context_line":"        requested_networks \u003d objects.NetworkRequestList("},{"line_number":5221,"context_line":"            objects \u003d ["},{"line_number":5222,"context_line":"                objects.NetworkRequest(port_id\u003duuids.portid_1),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_3093a25d","line":5219,"range":{"start_line":5219,"start_character":12,"end_line":5219,"end_character":29},"in_reply_to":"9fdfeff1_1738ea3a","updated":"2019-01-29 13:58:17.000000000","message":"+1 to Matt\u0027s suggestion (if respin)","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c905331ab2cf5c3e7ed76e0a1275498061d0b2ab","unresolved":false,"context_lines":[{"line_number":5216,"context_line":"    @mock.patch.object(neutronapi, \u0027get_client\u0027)"},{"line_number":5217,"context_line":"    def test_create_resource_requests(self, getclient,"},{"line_number":5218,"context_line":"            mock_get_port_vnic_info, mock_get_physnet_tunneled_info,"},{"line_number":5219,"context_line":"            mock_request_spec):"},{"line_number":5220,"context_line":"        requested_networks \u003d objects.NetworkRequestList("},{"line_number":5221,"context_line":"            objects \u003d ["},{"line_number":5222,"context_line":"                objects.NetworkRequest(port_id\u003duuids.portid_1),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_8129ea8a","line":5219,"range":{"start_line":5219,"start_character":12,"end_line":5219,"end_character":29},"in_reply_to":"9fdfeff1_1738ea3a","updated":"2019-01-29 16:20:07.000000000","message":"Done in a fup","commit_id":"9ba910bb539b0172bab899852692a49d30645a14"}]}