)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17bb8693f7fbf27b35d07aadcc7866a5783494a1","unresolved":false,"context_lines":[{"line_number":5493,"context_line":"            networks\u003d[{\u0027port\u0027: self.neutron.port_1[\u0027id\u0027]}])"},{"line_number":5494,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":5495,"context_line":""},{"line_number":5496,"context_line":"        # We need to simulate that the above server has a port that has"},{"line_number":5497,"context_line":"        # resource request, we cannot boot with such a port but legacy servers"},{"line_number":5498,"context_line":"        # can exists with such a port."},{"line_number":5499,"context_line":"        bound_port \u003d self.neutron._ports[self.neutron.port_1[\u0027id\u0027]]"},{"line_number":5500,"context_line":"        fake_resource_request \u003d self.neutron.port_with_resource_request["},{"line_number":5501,"context_line":"            \u0027resource_request\u0027]"},{"line_number":5502,"context_line":"        bound_port[\u0027resource_request\u0027] \u003d fake_resource_request"},{"line_number":5503,"context_line":""},{"line_number":5504,"context_line":"        ex \u003d self.assertRaises("},{"line_number":5505,"context_line":"            client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_0bbbe371","line":5502,"range":{"start_line":5496,"start_character":8,"end_line":5502,"end_character":62},"updated":"2019-01-28 18:06:15.000000000","message":"nit: since this keeps getting copied you could move it into a helper method.","commit_id":"3730bd079104ad14f6992ad55cf8643911c916ab"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bcf302094976077fa4775b45cace9226cabec6e4","unresolved":false,"context_lines":[{"line_number":5493,"context_line":"            networks\u003d[{\u0027port\u0027: self.neutron.port_1[\u0027id\u0027]}])"},{"line_number":5494,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":5495,"context_line":""},{"line_number":5496,"context_line":"        # We need to simulate that the above server has a port that has"},{"line_number":5497,"context_line":"        # resource request, we cannot boot with such a port but legacy servers"},{"line_number":5498,"context_line":"        # can exists with such a port."},{"line_number":5499,"context_line":"        bound_port \u003d self.neutron._ports[self.neutron.port_1[\u0027id\u0027]]"},{"line_number":5500,"context_line":"        fake_resource_request \u003d self.neutron.port_with_resource_request["},{"line_number":5501,"context_line":"            \u0027resource_request\u0027]"},{"line_number":5502,"context_line":"        bound_port[\u0027resource_request\u0027] \u003d fake_resource_request"},{"line_number":5503,"context_line":""},{"line_number":5504,"context_line":"        ex \u003d self.assertRaises("},{"line_number":5505,"context_line":"            client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_80e9c9b7","line":5502,"range":{"start_line":5496,"start_character":8,"end_line":5502,"end_character":62},"in_reply_to":"9fdfeff1_0bbbe371","updated":"2019-01-30 16:00:29.000000000","message":"I agree. See my proposal in the previous patch","commit_id":"3730bd079104ad14f6992ad55cf8643911c916ab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c23d73446ef0ee2e36e65c449854339bfdf5903","unresolved":false,"context_lines":[{"line_number":5493,"context_line":"            networks\u003d[{\u0027port\u0027: self.neutron.port_1[\u0027id\u0027]}])"},{"line_number":5494,"context_line":"        self._wait_for_state_change(self.admin_api, server, \u0027ACTIVE\u0027)"},{"line_number":5495,"context_line":""},{"line_number":5496,"context_line":"        # We need to simulate that the above server has a port that has"},{"line_number":5497,"context_line":"        # resource request, we cannot boot with such a port but legacy servers"},{"line_number":5498,"context_line":"        # can exists with such a port."},{"line_number":5499,"context_line":"        bound_port \u003d self.neutron._ports[self.neutron.port_1[\u0027id\u0027]]"},{"line_number":5500,"context_line":"        fake_resource_request \u003d self.neutron.port_with_resource_request["},{"line_number":5501,"context_line":"            \u0027resource_request\u0027]"},{"line_number":5502,"context_line":"        bound_port[\u0027resource_request\u0027] \u003d fake_resource_request"},{"line_number":5503,"context_line":""},{"line_number":5504,"context_line":"        ex \u003d self.assertRaises("},{"line_number":5505,"context_line":"            client.OpenStackApiException,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_c4723c4a","line":5502,"range":{"start_line":5496,"start_character":8,"end_line":5502,"end_character":62},"in_reply_to":"9fdfeff1_80e9c9b7","updated":"2019-02-04 17:51:32.000000000","message":"Done","commit_id":"3730bd079104ad14f6992ad55cf8643911c916ab"}],"nova/tests/unit/api/openstack/compute/test_migrate_server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17bb8693f7fbf27b35d07aadcc7866a5783494a1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            args_map\u003dargs_map, method_translations\u003dmethod_translations,"},{"line_number":107,"context_line":"            exception_args\u003dexception_arg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_migrate_with_port_resource_request_old_microversion(self):"},{"line_number":110,"context_line":"        self.mock_list_port.return_value \u003d {\u0027ports\u0027: ["},{"line_number":111,"context_line":"            {\u0027resource_request\u0027: {"},{"line_number":112,"context_line":"                \"resources\": {\u0027CUSTOM_FOO\u0027: 1}}}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_ab617707","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":64},"updated":"2019-01-28 18:06:15.000000000","message":"Not sure we need this or the unit test below when we have the functional tests.","commit_id":"3730bd079104ad14f6992ad55cf8643911c916ab"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c23d73446ef0ee2e36e65c449854339bfdf5903","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            args_map\u003dargs_map, method_translations\u003dmethod_translations,"},{"line_number":107,"context_line":"            exception_args\u003dexception_arg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_migrate_with_port_resource_request_old_microversion(self):"},{"line_number":110,"context_line":"        self.mock_list_port.return_value \u003d {\u0027ports\u0027: ["},{"line_number":111,"context_line":"            {\u0027resource_request\u0027: {"},{"line_number":112,"context_line":"                \"resources\": {\u0027CUSTOM_FOO\u0027: 1}}}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_64db5021","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":64},"in_reply_to":"9fdfeff1_40f8c179","updated":"2019-02-04 17:51:32.000000000","message":"Done","commit_id":"3730bd079104ad14f6992ad55cf8643911c916ab"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bcf302094976077fa4775b45cace9226cabec6e4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            args_map\u003dargs_map, method_translations\u003dmethod_translations,"},{"line_number":107,"context_line":"            exception_args\u003dexception_arg)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_migrate_with_port_resource_request_old_microversion(self):"},{"line_number":110,"context_line":"        self.mock_list_port.return_value \u003d {\u0027ports\u0027: ["},{"line_number":111,"context_line":"            {\u0027resource_request\u0027: {"},{"line_number":112,"context_line":"                \"resources\": {\u0027CUSTOM_FOO\u0027: 1}}}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_40f8c179","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":64},"in_reply_to":"9fdfeff1_ab617707","updated":"2019-01-30 16:00:29.000000000","message":"I agree. Let\u0027s drop this and keep the functional test as that is a tiny bit broader.","commit_id":"3730bd079104ad14f6992ad55cf8643911c916ab"}]}
