)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d24c8f769dff5c999b3825fb28edf4ecb938099e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reject evacuate with port having resource request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova does not consider the resource request of a Neutron port as of now."},{"line_number":10,"context_line":"So this patch makes sure that server evacuate request is rejected if it"},{"line_number":11,"context_line":"involves a port that has resource request. When the feature is ready on"},{"line_number":12,"context_line":"the nova side this limitation will be lifted."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fdfeff1_a63d2ec5","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":45},"updated":"2019-01-28 18:13:58.000000000","message":"Evacuate is rebuild on another host and we go through the scheduler.\n\nHave we talked through rebuild support for these types of ports? We only go through the scheduler if the image changes on rebuild. If the ports aren\u0027t changing between create and rebuild we\u0027re probably OK, and we\u0027ve already talked through the need to have neutron reject requests to change QoS policies on bound ports (either by adding/removing the QoS policy to the port or it\u0027s network). Is someone working on that?","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1118dc1d8f15075dca39019aa0df3ea70e0bcb7d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reject evacuate with port having resource request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova does not consider the resource request of a Neutron port as of now."},{"line_number":10,"context_line":"So this patch makes sure that server evacuate request is rejected if it"},{"line_number":11,"context_line":"involves a port that has resource request. When the feature is ready on"},{"line_number":12,"context_line":"the nova side this limitation will be lifted."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fdfeff1_8010e9a9","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":45},"in_reply_to":"9fdfeff1_a63d2ec5","updated":"2019-01-30 16:03:57.000000000","message":"I assume that rebuild (not evacuate) does not need any special handling from bandwidth perspective. \n\nBence Romsics (rubasov) has a TODO on his list to reject QoS policy change on bound ports from neutron.","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a14734adfdff49add813b5024532cb610e452392","unresolved":false,"context_lines":[{"line_number":5557,"context_line":""},{"line_number":5558,"context_line":"        ex \u003d self.assertRaises("},{"line_number":5559,"context_line":"            client.OpenStackApiException,"},{"line_number":5560,"context_line":"            self.api.post_server_action, server[\u0027id\u0027], {\u0027evacuate\u0027: {}})"},{"line_number":5561,"context_line":""},{"line_number":5562,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":5563,"context_line":"        self.assertIn("}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_0b176353","line":5560,"range":{"start_line":5560,"start_character":54,"end_line":5560,"end_character":71},"updated":"2019-01-28 18:11:46.000000000","message":"Are you using the latest microversion? Because otherwise onSharedStorage is required.\n\nOh right ProviderUsageBaseTestCase uses the latest microversion by default.","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1118dc1d8f15075dca39019aa0df3ea70e0bcb7d","unresolved":false,"context_lines":[{"line_number":5557,"context_line":""},{"line_number":5558,"context_line":"        ex \u003d self.assertRaises("},{"line_number":5559,"context_line":"            client.OpenStackApiException,"},{"line_number":5560,"context_line":"            self.api.post_server_action, server[\u0027id\u0027], {\u0027evacuate\u0027: {}})"},{"line_number":5561,"context_line":""},{"line_number":5562,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":5563,"context_line":"        self.assertIn("}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_8037894d","line":5560,"range":{"start_line":5560,"start_character":54,"end_line":5560,"end_character":71},"in_reply_to":"9fdfeff1_0b176353","updated":"2019-01-30 16:03:57.000000000","message":"yes. :)","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"}],"nova/tests/unit/api/openstack/compute/test_evacuate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a14734adfdff49add813b5024532cb610e452392","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            self.assertIsNone(res)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def test_evacuate_with_port_resource_request_old_microversion(self):"},{"line_number":248,"context_line":"        self.mock_list_port.return_value \u003d {\u0027ports\u0027: ["},{"line_number":249,"context_line":"            {\u0027resource_request\u0027: {"},{"line_number":250,"context_line":"                \"resources\": {\u0027CUSTOM_FOO\u0027: 1}}}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_c6115254","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":65},"updated":"2019-01-28 18:11:46.000000000","message":"This is redundant with the functional test but that\u0027s just a nit since this is pretty simple.","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"570451e3f56985635b087273ce993b58f75416ff","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            self.assertIsNone(res)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def test_evacuate_with_port_resource_request_old_microversion(self):"},{"line_number":248,"context_line":"        self.mock_list_port.return_value \u003d {\u0027ports\u0027: ["},{"line_number":249,"context_line":"            {\u0027resource_request\u0027: {"},{"line_number":250,"context_line":"                \"resources\": {\u0027CUSTOM_FOO\u0027: 1}}}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_84651448","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":65},"in_reply_to":"9fdfeff1_40268117","updated":"2019-02-04 17:56:19.000000000","message":"Done","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1118dc1d8f15075dca39019aa0df3ea70e0bcb7d","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        else:"},{"line_number":245,"context_line":"            self.assertIsNone(res)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def test_evacuate_with_port_resource_request_old_microversion(self):"},{"line_number":248,"context_line":"        self.mock_list_port.return_value \u003d {\u0027ports\u0027: ["},{"line_number":249,"context_line":"            {\u0027resource_request\u0027: {"},{"line_number":250,"context_line":"                \"resources\": {\u0027CUSTOM_FOO\u0027: 1}}}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_40268117","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":65},"in_reply_to":"9fdfeff1_c6115254","updated":"2019-01-30 16:03:57.000000000","message":"I would keep the functional test and drop the unit test.","commit_id":"b164aaac1f036455205d2457abc3ae75769bf42f"}]}